Re: [PR] [fix](spill) fix wrong disk usage of spill [doris]

2024-05-28 Thread via GitHub
yiguolei merged PR #35423: URL: https://github.com/apache/doris/pull/35423 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

Re: [PR] [fix](spill) fix wrong disk usage of spill [doris]

2024-05-28 Thread via GitHub
github-actions[bot] commented on PR #35423: URL: https://github.com/apache/doris/pull/35423#issuecomment-2134785396 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [fix](spill) fix wrong disk usage of spill [doris]

2024-05-28 Thread via GitHub
github-actions[bot] commented on PR #35423: URL: https://github.com/apache/doris/pull/35423#issuecomment-2134785338 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix](spill) fix wrong disk usage of spill [doris]

2024-05-28 Thread via GitHub
doris-robot commented on PR #35423: URL: https://github.com/apache/doris/pull/35423#issuecomment-2134674732 ClickBench: Total hot run time: 30.81 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix](spill) fix wrong disk usage of spill [doris]

2024-05-28 Thread via GitHub
doris-robot commented on PR #35423: URL: https://github.com/apache/doris/pull/35423#issuecomment-2134663956 TPC-DS: Total hot run time: 171880 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](spill) fix wrong disk usage of spill [doris]

2024-05-28 Thread via GitHub
doris-robot commented on PR #35423: URL: https://github.com/apache/doris/pull/35423#issuecomment-2134643257 TPC-H: Total hot run time: 41659 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](spill) fix wrong disk usage of spill [doris]

2024-05-28 Thread via GitHub
jacktengg commented on PR #35423: URL: https://github.com/apache/doris/pull/35423#issuecomment-2134498877 run performance -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [fix](spill) fix wrong disk usage of spill [doris]

2024-05-27 Thread via GitHub
doris-robot commented on PR #35423: URL: https://github.com/apache/doris/pull/35423#issuecomment-2134304512 TeamCity be ut coverage result: Function Coverage: 35.75% (9009/25199) Line Coverage: 27.36% (74567/272575) Region Coverage: 26.57% (38562/145124) Branch Coverage: 23.4

Re: [PR] [fix](spill) fix wrong disk usage of spill [doris]

2024-05-27 Thread via GitHub
github-actions[bot] commented on PR #35423: URL: https://github.com/apache/doris/pull/35423#issuecomment-2134247610 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](spill) fix wrong disk usage of spill [doris]

2024-05-27 Thread via GitHub
github-actions[bot] commented on PR #35423: URL: https://github.com/apache/doris/pull/35423#issuecomment-2134246384 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](spill) fix wrong disk usage of spill [doris]

2024-05-27 Thread via GitHub
jacktengg commented on PR #35423: URL: https://github.com/apache/doris/pull/35423#issuecomment-2134241636 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [fix](spill) fix wrong disk usage of spill [doris]

2024-05-27 Thread via GitHub
jacktengg commented on PR #35423: URL: https://github.com/apache/doris/pull/35423#issuecomment-2133685180 run performance -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [fix](spill) fix wrong disk usage of spill [doris]

2024-05-27 Thread via GitHub
doris-robot commented on PR #35423: URL: https://github.com/apache/doris/pull/35423#issuecomment-2132844990 TeamCity be ut coverage result: Function Coverage: 35.74% (9009/25206) Line Coverage: 27.36% (74560/272474) Region Coverage: 26.59% (38573/145085) Branch Coverage: 23.4

Re: [PR] [fix](spill) fix wrong disk usage of spill [doris]

2024-05-26 Thread via GitHub
github-actions[bot] commented on PR #35423: URL: https://github.com/apache/doris/pull/35423#issuecomment-2132723931 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](spill) fix wrong disk usage of spill [doris]

2024-05-26 Thread via GitHub
github-actions[bot] commented on PR #35423: URL: https://github.com/apache/doris/pull/35423#issuecomment-2132723486 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](spill) fix wrong disk usage of spill [doris]

2024-05-26 Thread via GitHub
jacktengg commented on PR #35423: URL: https://github.com/apache/doris/pull/35423#issuecomment-2132716971 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [fix](spill) fix wrong disk usage of spill [doris]

2024-05-26 Thread via GitHub
doris-robot commented on PR #35423: URL: https://github.com/apache/doris/pull/35423#issuecomment-2132677781 TeamCity be ut coverage result: Function Coverage: 35.73% (9007/25206) Line Coverage: 27.36% (74558/272478) Region Coverage: 26.58% (38570/145085) Branch Coverage: 23.4

Re: [PR] [fix](spill) fix wrong disk usage of spill [doris]

2024-05-26 Thread via GitHub
yiguolei commented on code in PR #35423: URL: https://github.com/apache/doris/pull/35423#discussion_r1615461238 ## be/src/vec/spill/spill_writer.h: ## @@ -44,7 +44,7 @@ class SpillWriter { int64_t get_id() const { return stream_id_; } -size_t get_written_bytes() con

Re: [PR] [fix](spill) fix wrong disk usage of spill [doris]

2024-05-26 Thread via GitHub
yiguolei commented on code in PR #35423: URL: https://github.com/apache/doris/pull/35423#discussion_r1615461049 ## be/src/vec/spill/spill_stream.h: ## @@ -51,7 +51,7 @@ class SpillStream { const std::string& get_spill_dir() const { return spill_dir_; } -size_t get_w

Re: [PR] [fix](spill) fix wrong disk usage of spill [doris]

2024-05-26 Thread via GitHub
github-actions[bot] commented on PR #35423: URL: https://github.com/apache/doris/pull/35423#issuecomment-2132604354 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](spill) fix wrong disk usage of spill [doris]

2024-05-26 Thread via GitHub
github-actions[bot] commented on PR #35423: URL: https://github.com/apache/doris/pull/35423#issuecomment-2132604273 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](spill) fix wrong disk usage of spill [doris]

2024-05-26 Thread via GitHub
jacktengg commented on PR #35423: URL: https://github.com/apache/doris/pull/35423#issuecomment-2132600080 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [fix](spill) fix wrong disk usage of spill [doris]

2024-05-26 Thread via GitHub
doris-robot commented on PR #35423: URL: https://github.com/apache/doris/pull/35423#issuecomment-2132599783 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

[PR] [fix](spill) fix wrong disk usage of spill [doris]

2024-05-26 Thread via GitHub
jacktengg opened a new pull request, #35423: URL: https://github.com/apache/doris/pull/35423 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailt