Re: [PR] [fix](sleep) sleep with character const make be crash [doris]

2024-07-14 Thread via GitHub
lide-reed merged PR #37681: URL: https://github.com/apache/doris/pull/37681 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

Re: [PR] [fix](sleep) sleep with character const make be crash [doris]

2024-07-14 Thread via GitHub
cambyzju commented on code in PR #37681: URL: https://github.com/apache/doris/pull/37681#discussion_r1677263687 ## be/src/vec/functions/function_utility.cpp: ## @@ -62,31 +62,26 @@ class FunctionSleep : public IFunction { size_t get_number_of_arguments() const override { re

Re: [PR] [fix](sleep) sleep with character const make be crash [doris]

2024-07-14 Thread via GitHub
github-actions[bot] commented on PR #37681: URL: https://github.com/apache/doris/pull/37681#issuecomment-2227574768 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix](sleep) sleep with character const make be crash [doris]

2024-07-12 Thread via GitHub
zclllyybb commented on code in PR #37681: URL: https://github.com/apache/doris/pull/37681#discussion_r1676769328 ## be/src/vec/functions/function_utility.cpp: ## @@ -62,31 +62,26 @@ class FunctionSleep : public IFunction { size_t get_number_of_arguments() const override { r

Re: [PR] [fix](sleep) sleep with character const make be crash [doris]

2024-07-12 Thread via GitHub
doris-robot commented on PR #37681: URL: https://github.com/apache/doris/pull/37681#issuecomment-2225150127 ClickBench: Total hot run time: 31.19 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix](sleep) sleep with character const make be crash [doris]

2024-07-12 Thread via GitHub
doris-robot commented on PR #37681: URL: https://github.com/apache/doris/pull/37681#issuecomment-2225140533 TPC-DS: Total hot run time: 175411 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](sleep) sleep with character const make be crash [doris]

2024-07-12 Thread via GitHub
doris-robot commented on PR #37681: URL: https://github.com/apache/doris/pull/37681#issuecomment-2225120401 TPC-H: Total hot run time: 40099 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](sleep) sleep with character const make be crash [doris]

2024-07-12 Thread via GitHub
github-actions[bot] commented on PR #37681: URL: https://github.com/apache/doris/pull/37681#issuecomment-2225052713 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](sleep) sleep with character const make be crash [doris]

2024-07-12 Thread via GitHub
cambyzju commented on PR #37681: URL: https://github.com/apache/doris/pull/37681#issuecomment-2225043377 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [fix](sleep) sleep with character const make be crash [doris]

2024-07-12 Thread via GitHub
cambyzju commented on code in PR #37681: URL: https://github.com/apache/doris/pull/37681#discussion_r1675475352 ## be/src/vec/functions/function_utility.cpp: ## @@ -74,19 +74,12 @@ class FunctionSleep : public IFunction { Review Comment: done -- This is an automated me

Re: [PR] [fix](sleep) sleep with character const make be crash [doris]

2024-07-11 Thread via GitHub
zhiqiang- commented on code in PR #37681: URL: https://github.com/apache/doris/pull/37681#discussion_r1675093842 ## be/src/vec/functions/function_utility.cpp: ## @@ -74,19 +74,12 @@ class FunctionSleep : public IFunction { Review Comment: Could you please add some comm

Re: [PR] [fix](sleep) sleep with character const make be crash [doris]

2024-07-11 Thread via GitHub
zhiqiang- commented on code in PR #37681: URL: https://github.com/apache/doris/pull/37681#discussion_r1675093842 ## be/src/vec/functions/function_utility.cpp: ## @@ -74,19 +74,12 @@ class FunctionSleep : public IFunction { Review Comment: Could you please add some comm

Re: [PR] [fix](sleep) sleep with character const make be crash [doris]

2024-07-11 Thread via GitHub
zhiqiang- commented on code in PR #37681: URL: https://github.com/apache/doris/pull/37681#discussion_r1675093842 ## be/src/vec/functions/function_utility.cpp: ## @@ -74,19 +74,12 @@ class FunctionSleep : public IFunction { Review Comment: Could you please add some comm

Re: [PR] [fix](sleep) sleep with character const make be crash [doris]

2024-07-11 Thread via GitHub
github-actions[bot] commented on PR #37681: URL: https://github.com/apache/doris/pull/37681#issuecomment-2224254272 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [fix](sleep) sleep with character const make be crash [doris]

2024-07-11 Thread via GitHub
github-actions[bot] commented on PR #37681: URL: https://github.com/apache/doris/pull/37681#issuecomment-2224254250 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix](sleep) sleep with character const make be crash [doris]

2024-07-11 Thread via GitHub
doris-robot commented on PR #37681: URL: https://github.com/apache/doris/pull/37681#issuecomment-950906 ClickBench: Total hot run time: 30.69 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix](sleep) sleep with character const make be crash [doris]

2024-07-11 Thread via GitHub
doris-robot commented on PR #37681: URL: https://github.com/apache/doris/pull/37681#issuecomment-937931 TPC-DS: Total hot run time: 175035 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](sleep) sleep with character const make be crash [doris]

2024-07-11 Thread via GitHub
doris-robot commented on PR #37681: URL: https://github.com/apache/doris/pull/37681#issuecomment-911545 TPC-H: Total hot run time: 39949 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](sleep) sleep with character const make be crash [doris]

2024-07-11 Thread via GitHub
github-actions[bot] commented on PR #37681: URL: https://github.com/apache/doris/pull/37681#issuecomment-873453 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](sleep) sleep with character const make be crash [doris]

2024-07-11 Thread via GitHub
cambyzju commented on PR #37681: URL: https://github.com/apache/doris/pull/37681#issuecomment-872179 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [fix](sleep) sleep with character const make be crash [doris]

2024-07-11 Thread via GitHub
doris-robot commented on PR #37681: URL: https://github.com/apache/doris/pull/37681#issuecomment-859887 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

[PR] [fix](sleep) sleep with character const make be crash [doris]

2024-07-11 Thread via GitHub
cambyzju opened a new pull request, #37681: URL: https://github.com/apache/doris/pull/37681 ## Proposed changes Issue Number: close https://github.com/apache/doris/issues/37327 -- This is an automated message from the Apache Git Service. To respond to the message, pl