Re: [PR] [fix](new_json_reader)fix core for new_json_reader [doris]

2025-01-01 Thread via GitHub
eldenmoon merged PR #45905: URL: https://github.com/apache/doris/pull/45905 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

Re: [PR] [fix](new_json_reader)fix core for new_json_reader [doris]

2025-01-01 Thread via GitHub
github-actions[bot] commented on PR #45905: URL: https://github.com/apache/doris/pull/45905#issuecomment-2567242180 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix](new_json_reader)fix core for new_json_reader [doris]

2024-12-29 Thread via GitHub
doris-robot commented on PR #45905: URL: https://github.com/apache/doris/pull/45905#issuecomment-2565134367 ClickBench: Total hot run time: 31.58 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix](new_json_reader)fix core for new_json_reader [doris]

2024-12-29 Thread via GitHub
doris-robot commented on PR #45905: URL: https://github.com/apache/doris/pull/45905#issuecomment-2565130337 TPC-DS: Total hot run time: 197643 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](new_json_reader)fix core for new_json_reader [doris]

2024-12-29 Thread via GitHub
doris-robot commented on PR #45905: URL: https://github.com/apache/doris/pull/45905#issuecomment-2565121168 TPC-H: Total hot run time: 32298 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](new_json_reader)fix core for new_json_reader [doris]

2024-12-29 Thread via GitHub
doris-robot commented on PR #45905: URL: https://github.com/apache/doris/pull/45905#issuecomment-2565121015 TeamCity be ut coverage result: Function Coverage: 38.90% (10120/26016) Line Coverage: 29.90% (85528/286093) Region Coverage: 29.02% (43709/150612) Branch Coverage: 25.

Re: [PR] [fix](new_json_reader)fix core for new_json_reader [doris]

2024-12-29 Thread via GitHub
amorynan commented on PR #45905: URL: https://github.com/apache/doris/pull/45905#issuecomment-2565089356 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [fix](new_json_reader)fix core for new_json_reader [doris]

2024-12-29 Thread via GitHub
amorynan commented on code in PR #45905: URL: https://github.com/apache/doris/pull/45905#discussion_r1899316282 ## be/src/vec/exec/format/json/new_json_reader.cpp: ## @@ -1818,6 +1816,10 @@ Status NewJsonReader::_simdjson_write_data_to_column(simdjson::ondemand::value& } e

Re: [PR] [fix](new_json_reader)fix core for new_json_reader [doris]

2024-12-29 Thread via GitHub
github-actions[bot] commented on PR #45905: URL: https://github.com/apache/doris/pull/45905#issuecomment-2564972266 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [fix](new_json_reader)fix core for new_json_reader [doris]

2024-12-29 Thread via GitHub
xiaokang commented on code in PR #45905: URL: https://github.com/apache/doris/pull/45905#discussion_r1899215050 ## be/src/vec/exec/format/json/new_json_reader.cpp: ## @@ -1818,6 +1816,10 @@ Status NewJsonReader::_simdjson_write_data_to_column(simdjson::ondemand::value& } e

Re: [PR] [fix](new_json_reader)fix core for new_json_reader [doris]

2024-12-27 Thread via GitHub
doris-robot commented on PR #45905: URL: https://github.com/apache/doris/pull/45905#issuecomment-2563481563 ClickBench: Total hot run time: 30.77 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix](new_json_reader)fix core for new_json_reader [doris]

2024-12-27 Thread via GitHub
doris-robot commented on PR #45905: URL: https://github.com/apache/doris/pull/45905#issuecomment-2563477050 TPC-DS: Total hot run time: 197527 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](new_json_reader)fix core for new_json_reader [doris]

2024-12-27 Thread via GitHub
doris-robot commented on PR #45905: URL: https://github.com/apache/doris/pull/45905#issuecomment-2563466706 TPC-H: Total hot run time: 32669 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](new_json_reader)fix core for new_json_reader [doris]

2024-12-27 Thread via GitHub
doris-robot commented on PR #45905: URL: https://github.com/apache/doris/pull/45905#issuecomment-2563465713 TeamCity be ut coverage result: Function Coverage: 38.89% (10121/26022) Line Coverage: 29.89% (85525/286103) Region Coverage: 29.03% (43712/150563) Branch Coverage: 25.

Re: [PR] [fix](new_json_reader)fix core for new_json_reader [doris]

2024-12-26 Thread via GitHub
amorynan commented on PR #45905: URL: https://github.com/apache/doris/pull/45905#issuecomment-2563429451 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [fix](new_json_reader)fix core for new_json_reader [doris]

2024-12-24 Thread via GitHub
hello-stephen commented on PR #45905: URL: https://github.com/apache/doris/pull/45905#issuecomment-2561568184 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+pro

[PR] [fix](new_json_reader)fix core for new_json_reader [doris]

2024-12-24 Thread via GitHub
amorynan opened a new pull request, #45905: URL: https://github.com/apache/doris/pull/45905 ### What problem does this PR solve? fix coredump with new_json_reader if we read invalid data will core ![image](https://github.com/user-attachments/assets/74b6c0ee-8d3b-419c-9899-12a80d844b8d)