Re: [PR] [fix](move-memtable) pass num total streams to load stream [doris]

2023-11-01 Thread via GitHub
github-actions[bot] commented on code in PR #26198: URL: https://github.com/apache/doris/pull/26198#discussion_r1379612675 ## be/test/vec/exec/load_stream_stub_pool_test.cpp: ## @@ -36,9 +36,9 @@ TEST_F(LoadStreamStubPoolTest, test) { PUniqueId load_id; load_id.set_hi(

Re: [PR] [fix](move-memtable) pass num total streams to load stream [doris]

2023-11-01 Thread via GitHub
github-actions[bot] commented on PR #26198: URL: https://github.com/apache/doris/pull/26198#issuecomment-1789998652 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](move-memtable) pass num total streams to load stream [doris]

2023-11-01 Thread via GitHub
kaijchen commented on PR #26198: URL: https://github.com/apache/doris/pull/26198#issuecomment-1789992136 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [fix](move-memtable) pass num total streams to load stream [doris]

2023-11-01 Thread via GitHub
github-actions[bot] commented on PR #26198: URL: https://github.com/apache/doris/pull/26198#issuecomment-1789975922 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](move-memtable) pass num total streams to load stream [doris]

2023-11-01 Thread via GitHub
kaijchen commented on PR #26198: URL: https://github.com/apache/doris/pull/26198#issuecomment-1789969762 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [fix](move-memtable) pass num total streams to load stream [doris]

2023-11-01 Thread via GitHub
github-actions[bot] commented on PR #26198: URL: https://github.com/apache/doris/pull/26198#issuecomment-1789967370 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](move-memtable) pass num total streams to load stream [doris]

2023-11-01 Thread via GitHub
kaijchen commented on PR #26198: URL: https://github.com/apache/doris/pull/26198#issuecomment-1789964632 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [fix](move-memtable) pass num total streams to load stream [doris]

2023-11-01 Thread via GitHub
github-actions[bot] commented on PR #26198: URL: https://github.com/apache/doris/pull/26198#issuecomment-1789963389 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](move-memtable) pass num total streams to load stream [doris]

2023-11-01 Thread via GitHub
github-actions[bot] commented on PR #26198: URL: https://github.com/apache/doris/pull/26198#issuecomment-1789956725 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](move-memtable) pass num total streams to load stream [doris]

2023-11-01 Thread via GitHub
github-actions[bot] commented on PR #26198: URL: https://github.com/apache/doris/pull/26198#issuecomment-1789945288 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](move-memtable) pass num total streams to load stream [doris]

2023-11-01 Thread via GitHub
doris-robot commented on PR #26198: URL: https://github.com/apache/doris/pull/26198#issuecomment-1788546047 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.65 seconds stream load tsv: 572 seconds loaded 74807831229 Bytes,

Re: [PR] [fix](move-memtable) pass num total streams to load stream [doris]

2023-11-01 Thread via GitHub
github-actions[bot] commented on PR #26198: URL: https://github.com/apache/doris/pull/26198#issuecomment-1788516956 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](move-memtable) pass num total streams to load stream [doris]

2023-11-01 Thread via GitHub
kaijchen commented on PR #26198: URL: https://github.com/apache/doris/pull/26198#issuecomment-1788509663 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [fix](move-memtable) pass num total streams to load stream [doris]

2023-10-31 Thread via GitHub
doris-robot commented on PR #26198: URL: https://github.com/apache/doris/pull/26198#issuecomment-1788503209 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 47 seconds stream load tsv: 559 seconds loaded 74807831229 Bytes, abo

Re: [PR] [fix](move-memtable) pass num total streams to load stream [doris]

2023-10-31 Thread via GitHub
dataroaring commented on code in PR #26198: URL: https://github.com/apache/doris/pull/26198#discussion_r1378450616 ## be/src/runtime/load_stream.cpp: ## @@ -258,19 +259,21 @@ Status LoadStream::init(const POpenStreamSinkRequest* request) { Status LoadStream::close(int64_t src_

Re: [PR] [fix](move-memtable) pass num total streams to load stream [doris]

2023-10-31 Thread via GitHub
github-actions[bot] commented on PR #26198: URL: https://github.com/apache/doris/pull/26198#issuecomment-1788482840 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](move-memtable) pass num total streams to load stream [doris]

2023-10-31 Thread via GitHub
github-actions[bot] commented on PR #26198: URL: https://github.com/apache/doris/pull/26198#issuecomment-1788437147 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[PR] [fix](move-memtable) pass num total streams to load stream [doris]

2023-10-31 Thread via GitHub
kaijchen opened a new pull request, #26198: URL: https://github.com/apache/doris/pull/26198 ## Proposed changes Some sinks may close load before other sinks open the stream, fix it by passing num total streams to downstream BE. ## Further comments If this is a relatively

Re: [PR] [fix](move-memtable) pass num total streams to load stream [doris]

2023-10-31 Thread via GitHub
kaijchen commented on PR #26198: URL: https://github.com/apache/doris/pull/26198#issuecomment-1788428937 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns