Re: [PR] [fix](move-memtable) fix use-after-free in load stream stub [doris]

2023-10-19 Thread via GitHub
dataroaring merged PR #25618: URL: https://github.com/apache/doris/pull/25618 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.

Re: [PR] [fix](move-memtable) fix use-after-free in load stream stub [doris]

2023-10-19 Thread via GitHub
github-actions[bot] commented on PR #25618: URL: https://github.com/apache/doris/pull/25618#issuecomment-1770213811 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix](move-memtable) fix use-after-free in load stream stub [doris]

2023-10-19 Thread via GitHub
github-actions[bot] commented on PR #25618: URL: https://github.com/apache/doris/pull/25618#issuecomment-1770213867 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [fix](move-memtable) fix use-after-free in load stream stub [doris]

2023-10-18 Thread via GitHub
doris-robot commented on PR #25618: URL: https://github.com/apache/doris/pull/25618#issuecomment-1770126111 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.93 seconds stream load tsv: 559 seconds loaded 74807831229 Bytes,

Re: [PR] [fix](move-memtable) fix use-after-free in load stream stub [doris]

2023-10-18 Thread via GitHub
doris-robot commented on PR #25618: URL: https://github.com/apache/doris/pull/25618#issuecomment-1770117846 TeamCity be ut coverage result: Function Coverage: 37.01% (8281/22375) Line Coverage: 29.07% (66418/228471) Region Coverage: 27.73% (34491/124392) Branch Coverage: 24.3

Re: [PR] [fix](move-memtable) fix use-after-free in load stream stub [doris]

2023-10-18 Thread via GitHub
kaijchen commented on PR #25618: URL: https://github.com/apache/doris/pull/25618#issuecomment-1770069864 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [fix](move-memtable) fix use-after-free in load stream stub [doris]

2023-10-18 Thread via GitHub
github-actions[bot] commented on code in PR #25618: URL: https://github.com/apache/doris/pull/25618#discussion_r1364905067 ## be/src/vec/sink/load_stream_stub.h: ## @@ -85,17 +85,33 @@ class LoadStreamStub { private: class LoadStreamReplyHandler : public brpc::StreamInputH

Re: [PR] [fix](move-memtable) fix use-after-free in load stream stub [doris]

2023-10-18 Thread via GitHub
kaijchen commented on PR #25618: URL: https://github.com/apache/doris/pull/25618#issuecomment-1769974265 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[PR] [fix](move-memtable) fix use-after-free in load stream stub [doris]

2023-10-18 Thread via GitHub
kaijchen opened a new pull request, #25618: URL: https://github.com/apache/doris/pull/25618 ## Proposed changes Fix use-after-free in load stream stub handler `on_closed()`. ## Further comments If this is a relatively large or complex change, kick off the discussion at [