Re: [PR] [fix](merge-on-write) schema change may cause mow duplicate key [doris]

2024-04-12 Thread via GitHub
zhannngchen merged PR #33536: URL: https://github.com/apache/doris/pull/33536 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.

Re: [PR] [fix](merge-on-write) schema change may cause mow duplicate key [doris]

2024-04-12 Thread via GitHub
github-actions[bot] commented on PR #33536: URL: https://github.com/apache/doris/pull/33536#issuecomment-2053029123 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix](merge-on-write) schema change may cause mow duplicate key [doris]

2024-04-12 Thread via GitHub
doris-robot commented on PR #33536: URL: https://github.com/apache/doris/pull/33536#issuecomment-2051747108 TeamCity be ut coverage result: Function Coverage: 35.60% (8905/25017) Line Coverage: 27.32% (73124/267684) Region Coverage: 26.45% (37830/143007) Branch Coverage: 23.2

Re: [PR] [fix](merge-on-write) schema change may cause mow duplicate key [doris]

2024-04-12 Thread via GitHub
github-actions[bot] commented on PR #33536: URL: https://github.com/apache/doris/pull/33536#issuecomment-2051710536 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](merge-on-write) schema change may cause mow duplicate key [doris]

2024-04-12 Thread via GitHub
zhannngchen commented on PR #33536: URL: https://github.com/apache/doris/pull/33536#issuecomment-2051701592 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [fix](merge-on-write) schema change may cause mow duplicate key [doris]

2024-04-12 Thread via GitHub
doris-robot commented on PR #33536: URL: https://github.com/apache/doris/pull/33536#issuecomment-2051600947 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit 921c9e5d78a8f2c14e1b72a81d8e0613b718c41e with default session variables Stream

Re: [PR] [fix](merge-on-write) schema change may cause mow duplicate key [doris]

2024-04-12 Thread via GitHub
doris-robot commented on PR #33536: URL: https://github.com/apache/doris/pull/33536#issuecomment-2051596395 ClickBench: Total hot run time: 30.48 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix](merge-on-write) schema change may cause mow duplicate key [doris]

2024-04-12 Thread via GitHub
doris-robot commented on PR #33536: URL: https://github.com/apache/doris/pull/33536#issuecomment-2051588802 TPC-DS: Total hot run time: 182934 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](merge-on-write) schema change may cause mow duplicate key [doris]

2024-04-12 Thread via GitHub
doris-robot commented on PR #33536: URL: https://github.com/apache/doris/pull/33536#issuecomment-2051572048 TPC-H: Total hot run time: 38733 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](merge-on-write) schema change may cause mow duplicate key [doris]

2024-04-12 Thread via GitHub
doris-robot commented on PR #33536: URL: https://github.com/apache/doris/pull/33536#issuecomment-2051565270 TeamCity be ut coverage result: Function Coverage: 35.58% (8902/25017) Line Coverage: 27.31% (73096/267678) Region Coverage: 26.44% (37803/142984) Branch Coverage: 23.1

Re: [PR] [fix](merge-on-write) schema change may cause mow duplicate key [doris]

2024-04-12 Thread via GitHub
zhannngchen commented on PR #33536: URL: https://github.com/apache/doris/pull/33536#issuecomment-2051542647 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [fix](merge-on-write) schema change may cause mow duplicate key [doris]

2024-04-12 Thread via GitHub
github-actions[bot] commented on PR #33536: URL: https://github.com/apache/doris/pull/33536#issuecomment-2051378799 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](merge-on-write) schema change may cause mow duplicate key [doris]

2024-04-12 Thread via GitHub
doris-robot commented on PR #33536: URL: https://github.com/apache/doris/pull/33536#issuecomment-2051133141 TeamCity be ut coverage result: Function Coverage: 35.59% (8902/25012) Line Coverage: 27.31% (73091/267649) Region Coverage: 26.43% (37794/142978) Branch Coverage: 23.1

Re: [PR] [fix](merge-on-write) schema change may cause mow duplicate key [doris]

2024-04-11 Thread via GitHub
github-actions[bot] commented on PR #33536: URL: https://github.com/apache/doris/pull/33536#issuecomment-2051019585 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](merge-on-write) schema change may cause mow duplicate key [doris]

2024-04-11 Thread via GitHub
zhannngchen commented on PR #33536: URL: https://github.com/apache/doris/pull/33536#issuecomment-2051014864 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [fix](merge-on-write) schema change may cause mow duplicate key [doris]

2024-04-11 Thread via GitHub
zhannngchen commented on PR #33536: URL: https://github.com/apache/doris/pull/33536#issuecomment-2050926206 run p1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [PR] [fix](merge-on-write) schema change may cause mow duplicate key [doris]

2024-04-11 Thread via GitHub
zhannngchen commented on PR #33536: URL: https://github.com/apache/doris/pull/33536#issuecomment-2050925542 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [PR] [fix](merge-on-write) schema change may cause mow duplicate key [doris]

2024-04-11 Thread via GitHub
luwei16 commented on PR #33536: URL: https://github.com/apache/doris/pull/33536#issuecomment-2049343639 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] [fix](merge-on-write) schema change may cause mow duplicate key [doris]

2024-04-11 Thread via GitHub
github-actions[bot] commented on PR #33536: URL: https://github.com/apache/doris/pull/33536#issuecomment-2049245756 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix](merge-on-write) schema change may cause mow duplicate key [doris]

2024-04-11 Thread via GitHub
github-actions[bot] commented on PR #33536: URL: https://github.com/apache/doris/pull/33536#issuecomment-2049245830 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [fix](merge-on-write) schema change may cause mow duplicate key [doris]

2024-04-11 Thread via GitHub
doris-robot commented on PR #33536: URL: https://github.com/apache/doris/pull/33536#issuecomment-2049239821 TeamCity be ut coverage result: Function Coverage: 35.58% (8903/25020) Line Coverage: 27.31% (73121/267781) Region Coverage: 26.42% (37821/143136) Branch Coverage: 23.2

Re: [PR] [fix](merge-on-write) schema change may cause mow duplicate key [doris]

2024-04-11 Thread via GitHub
zhannngchen commented on PR #33536: URL: https://github.com/apache/doris/pull/33536#issuecomment-2049207614 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [fix](merge-on-write) schema change may cause mow duplicate key [doris]

2024-04-11 Thread via GitHub
github-actions[bot] commented on PR #33536: URL: https://github.com/apache/doris/pull/33536#issuecomment-2049206276 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](merge-on-write) schema change may cause mow duplicate key [doris]

2024-04-11 Thread via GitHub
doris-robot commented on PR #33536: URL: https://github.com/apache/doris/pull/33536#issuecomment-2049197354 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

[PR] [fix](merge-on-write) schema change may cause mow duplicate key [doris]

2024-04-11 Thread via GitHub
zhannngchen opened a new pull request, #33536: URL: https://github.com/apache/doris/pull/33536 ## Proposed changes Issue Number: close #xxx #29386 fixed an issue that may cause duplicate key, but it breaks some schema change cases. Then #29733 reverted some change of #29386,