Re: [PR] [fix](insert) make group commit wal_manager exit elegantly [doris]

2023-10-14 Thread via GitHub
yiguolei merged PR #25250: URL: https://github.com/apache/doris/pull/25250 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

Re: [PR] [fix](insert) make group commit wal_manager exit elegantly [doris]

2023-10-13 Thread via GitHub
doris-robot commented on PR #25250: URL: https://github.com/apache/doris/pull/25250#issuecomment-1762549867 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.08 seconds stream load tsv: 552 seconds loaded 74807831229 Bytes,

Re: [PR] [fix](insert) make group commit wal_manager exit elegantly [doris]

2023-10-13 Thread via GitHub
doris-robot commented on PR #25250: URL: https://github.com/apache/doris/pull/25250#issuecomment-1762547861 TeamCity be ut coverage result: Function Coverage: 36.64% (8227/22454) Line Coverage: 28.77% (65923/229118) Region Coverage: 27.48% (34191/124410) Branch Coverage: 24.1

Re: [PR] [fix](insert) make group commit wal_manager exit elegantly [doris]

2023-10-13 Thread via GitHub
github-actions[bot] commented on code in PR #25250: URL: https://github.com/apache/doris/pull/25250#discussion_r1359102785 ## be/test/vec/exec/vwal_scanner_test.cpp: ## @@ -0,0 +1,267 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor licen

Re: [PR] [fix](insert) make group commit wal_manager exit elegantly [doris]

2023-10-13 Thread via GitHub
hust-hhb commented on PR #25250: URL: https://github.com/apache/doris/pull/25250#issuecomment-1762541826 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [fix](insert) make group commit wal_manager exit elegantly [doris]

2023-10-12 Thread via GitHub
doris-robot commented on PR #25250: URL: https://github.com/apache/doris/pull/25250#issuecomment-1759486652 TeamCity be ut coverage result: Function Coverage: 36.66% (8226/22438) Line Coverage: 28.71% (65890/229525) Region Coverage: 27.39% (34162/124712) Branch Coverage: 24.1

Re: [PR] [fix](insert) make group commit wal_manager exit elegantly [doris]

2023-10-12 Thread via GitHub
doris-robot commented on PR #25250: URL: https://github.com/apache/doris/pull/25250#issuecomment-1759468077 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.91 seconds stream load tsv: 549 seconds loaded 74807831229 Bytes,

Re: [PR] [fix](insert) make group commit wal_manager exit elegantly [doris]

2023-10-12 Thread via GitHub
zhiqiang- commented on PR #25250: URL: https://github.com/apache/doris/pull/25250#issuecomment-1759416233 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] [fix](insert) make group commit wal_manager exit elegantly [doris]

2023-10-11 Thread via GitHub
github-actions[bot] commented on PR #25250: URL: https://github.com/apache/doris/pull/25250#issuecomment-1757529364 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix](insert) make group commit wal_manager exit elegantly [doris]

2023-10-10 Thread via GitHub
doris-robot commented on PR #25250: URL: https://github.com/apache/doris/pull/25250#issuecomment-1755943561 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.5 seconds stream load tsv: 557 seconds loaded 74807831229 Bytes, a

Re: [PR] [fix](insert) make group commit wal_manager exit elegantly [doris]

2023-10-10 Thread via GitHub
doris-robot commented on PR #25250: URL: https://github.com/apache/doris/pull/25250#issuecomment-1755927570 TeamCity be ut coverage result: Function Coverage: 36.68% (8232/22444) Line Coverage: 28.70% (65795/229222) Region Coverage: 27.65% (34134/123441) Branch Coverage: 24.2

Re: [PR] [fix](insert) make group commit wal_manager exit elegantly [doris]

2023-10-10 Thread via GitHub
github-actions[bot] commented on code in PR #25250: URL: https://github.com/apache/doris/pull/25250#discussion_r1353027920 ## be/test/vec/exec/vwal_scanner_test.cpp: ## @@ -0,0 +1,267 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor licen

Re: [PR] [fix](insert) make group commit wal_manager exit elegantly [doris]

2023-10-10 Thread via GitHub
hust-hhb commented on PR #25250: URL: https://github.com/apache/doris/pull/25250#issuecomment-1755889346 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [fix](insert) make group commit wal_manager exit elegantly [doris]

2023-10-10 Thread via GitHub
doris-robot commented on PR #25250: URL: https://github.com/apache/doris/pull/25250#issuecomment-1755232090 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.03 seconds stream load tsv: 558 seconds loaded 74807831229 Bytes,

Re: [PR] [fix](insert) make group commit wal_manager exit elegantly [doris]

2023-10-10 Thread via GitHub
github-actions[bot] commented on PR #25250: URL: https://github.com/apache/doris/pull/25250#issuecomment-1755142764 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](insert) make group commit wal_manager exit elegantly [doris]

2023-10-10 Thread via GitHub
github-actions[bot] commented on PR #25250: URL: https://github.com/apache/doris/pull/25250#issuecomment-1755127667 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[PR] [fix](insert) make group commit wal_manager exit elegantly [doris]

2023-10-10 Thread via GitHub
hust-hhb opened a new pull request, #25250: URL: https://github.com/apache/doris/pull/25250 ## Proposed changes now be exit will hang because of wal_manager relay thread dosen't exit, this pr fix it. Issue Number: close #xxx ## Further comments If this is a re

Re: [PR] [fix](insert) make group commit wal_manager exit elegantly [doris]

2023-10-10 Thread via GitHub
hust-hhb commented on PR #25250: URL: https://github.com/apache/doris/pull/25250#issuecomment-1755119946 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns