Re: [PR] [fix](function) stddev with DecimalV2 type will result in an error (#… [doris]

2024-12-04 Thread via GitHub
Mryange closed pull request #39073: [fix](function) stddev with DecimalV2 type will result in an error (#… URL: https://github.com/apache/doris/pull/39073 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] [fix](function) stddev with DecimalV2 type will result in an error (#… [doris]

2024-08-08 Thread via GitHub
yiguolei merged PR #39072: URL: https://github.com/apache/doris/pull/39072 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

Re: [PR] [fix](function) stddev with DecimalV2 type will result in an error (#… [doris]

2024-08-07 Thread via GitHub
doris-robot commented on PR #39073: URL: https://github.com/apache/doris/pull/39073#issuecomment-2274896312 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit 7b06e6bf77b8052fc0bdc4d86436f394cb5466a6 with default session variables Stream

Re: [PR] [fix](function) stddev with DecimalV2 type will result in an error (#… [doris]

2024-08-07 Thread via GitHub
doris-robot commented on PR #39073: URL: https://github.com/apache/doris/pull/39073#issuecomment-2274893821 ClickBench: Total hot run time: 30.61 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix](function) stddev with DecimalV2 type will result in an error (#… [doris]

2024-08-07 Thread via GitHub
doris-robot commented on PR #39073: URL: https://github.com/apache/doris/pull/39073#issuecomment-2274892257 TeamCity be ut coverage result: Function Coverage: 37.76% (8102/21456) Line Coverage: 29.39% (66351/225796) Region Coverage: 28.89% (34240/118508) Branch Coverage: 24.7

Re: [PR] [fix](function) stddev with DecimalV2 type will result in an error (#… [doris]

2024-08-07 Thread via GitHub
doris-robot commented on PR #39073: URL: https://github.com/apache/doris/pull/39073#issuecomment-2274889893 TPC-DS: Total hot run time: 204608 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](function) stddev with DecimalV2 type will result in an error (#… [doris]

2024-08-07 Thread via GitHub
doris-robot commented on PR #39073: URL: https://github.com/apache/doris/pull/39073#issuecomment-2274880506 TPC-H: Total hot run time: 50205 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](function) stddev with DecimalV2 type will result in an error (#… [doris]

2024-08-07 Thread via GitHub
doris-robot commented on PR #39072: URL: https://github.com/apache/doris/pull/39072#issuecomment-2274877163 TeamCity be ut coverage result: Function Coverage: 36.38% (9259/25450) Line Coverage: 27.85% (75645/271593) Region Coverage: 26.73% (38948/145718) Branch Coverage: 23.4

Re: [PR] [fix](function) stddev with DecimalV2 type will result in an error (#… [doris]

2024-08-07 Thread via GitHub
github-actions[bot] commented on PR #39073: URL: https://github.com/apache/doris/pull/39073#issuecomment-2274871939 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](function) stddev with DecimalV2 type will result in an error (#… [doris]

2024-08-07 Thread via GitHub
doris-robot commented on PR #39073: URL: https://github.com/apache/doris/pull/39073#issuecomment-2274865315 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

Re: [PR] [fix](function) stddev with DecimalV2 type will result in an error (#… [doris]

2024-08-07 Thread via GitHub
Mryange commented on PR #39073: URL: https://github.com/apache/doris/pull/39073#issuecomment-2274865391 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[PR] [fix](function) stddev with DecimalV2 type will result in an error (#… [doris]

2024-08-07 Thread via GitHub
Mryange opened a new pull request, #39073: URL: https://github.com/apache/doris/pull/39073 …38731) https://github.com/apache/doris/pull/38731 The stddev function has a separate implementation for the DecimalV2 type, but there are issues with the implementation. Given that there is almo

Re: [PR] [fix](function) stddev with DecimalV2 type will result in an error (#… [doris]

2024-08-07 Thread via GitHub
github-actions[bot] commented on PR #39072: URL: https://github.com/apache/doris/pull/39072#issuecomment-2274862555 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](function) stddev with DecimalV2 type will result in an error (#… [doris]

2024-08-07 Thread via GitHub
Mryange commented on PR #39072: URL: https://github.com/apache/doris/pull/39072#issuecomment-2274858883 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [fix](function) stddev with DecimalV2 type will result in an error (#… [doris]

2024-08-07 Thread via GitHub
doris-robot commented on PR #39072: URL: https://github.com/apache/doris/pull/39072#issuecomment-2274857516 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

[PR] [fix](function) stddev with DecimalV2 type will result in an error (#… [doris]

2024-08-07 Thread via GitHub
Mryange opened a new pull request, #39072: URL: https://github.com/apache/doris/pull/39072 …38731) https://github.com/apache/doris/pull/38731 The stddev function has a separate implementation for the DecimalV2 type, but there are issues with the implementation. Given that there is

Re: [PR] [fix](function) stddev with DecimalV2 type will result in an error [doris]

2024-08-07 Thread via GitHub
HappenLee merged PR #38731: URL: https://github.com/apache/doris/pull/38731 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

Re: [PR] [fix](function) stddev with DecimalV2 type will result in an error [doris]

2024-08-05 Thread via GitHub
github-actions[bot] commented on PR #38731: URL: https://github.com/apache/doris/pull/38731#issuecomment-2270255207 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix](function) stddev with DecimalV2 type will result in an error [doris]

2024-08-05 Thread via GitHub
github-actions[bot] commented on PR #38731: URL: https://github.com/apache/doris/pull/38731#issuecomment-2268712823 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [fix](function) stddev with DecimalV2 type will result in an error [doris]

2024-08-05 Thread via GitHub
github-actions[bot] commented on PR #38731: URL: https://github.com/apache/doris/pull/38731#issuecomment-2268712745 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix](function) stddev with DecimalV2 type will result in an error [doris]

2024-08-02 Thread via GitHub
doris-robot commented on PR #38731: URL: https://github.com/apache/doris/pull/38731#issuecomment-2264782077 ClickBench: Total hot run time: 30.46 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix](function) stddev with DecimalV2 type will result in an error [doris]

2024-08-02 Thread via GitHub
doris-robot commented on PR #38731: URL: https://github.com/apache/doris/pull/38731#issuecomment-2264773283 TPC-DS: Total hot run time: 169775 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](function) stddev with DecimalV2 type will result in an error [doris]

2024-08-02 Thread via GitHub
doris-robot commented on PR #38731: URL: https://github.com/apache/doris/pull/38731#issuecomment-2264755208 TPC-H: Total hot run time: 42089 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](function) stddev with DecimalV2 type will result in an error [doris]

2024-08-01 Thread via GitHub
github-actions[bot] commented on code in PR #38731: URL: https://github.com/apache/doris/pull/38731#discussion_r1701370098 ## be/src/vec/aggregate_functions/aggregate_function_stddev.h: ## @@ -20,20 +20,16 @@ #include #include -#include #include Review Comment: warn

Re: [PR] [fix](function) stddev with DecimalV2 type will result in an error [doris]

2024-08-01 Thread via GitHub
Mryange commented on PR #38731: URL: https://github.com/apache/doris/pull/38731#issuecomment-2264675424 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [fix](function) stddev with DecimalV2 type will result in an error [doris]

2024-08-01 Thread via GitHub
doris-robot commented on PR #38731: URL: https://github.com/apache/doris/pull/38731#issuecomment-2263060053 ClickBench: Total hot run time: 29.97 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix](function) stddev with DecimalV2 type will result in an error [doris]

2024-08-01 Thread via GitHub
doris-robot commented on PR #38731: URL: https://github.com/apache/doris/pull/38731#issuecomment-2263045293 TPC-DS: Total hot run time: 167788 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](function) stddev with DecimalV2 type will result in an error [doris]

2024-08-01 Thread via GitHub
doris-robot commented on PR #38731: URL: https://github.com/apache/doris/pull/38731#issuecomment-2263019044 TPC-H: Total hot run time: 41717 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](function) stddev with DecimalV2 type will result in an error [doris]

2024-08-01 Thread via GitHub
github-actions[bot] commented on PR #38731: URL: https://github.com/apache/doris/pull/38731#issuecomment-2262970678 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](function) stddev with DecimalV2 type will result in an error [doris]

2024-08-01 Thread via GitHub
Mryange commented on PR #38731: URL: https://github.com/apache/doris/pull/38731#issuecomment-2262957237 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[PR] [fix](function) stddev with DecimalV2 type will result in an error [doris]

2024-08-01 Thread via GitHub
Mryange opened a new pull request, #38731: URL: https://github.com/apache/doris/pull/38731 ## Proposed changes The stddev function has a separate implementation for the DecimalV2 type, but there are issues with the implementation. Given that there is almost no existing data for Decim

Re: [PR] [fix](function) stddev with DecimalV2 type will result in an error [doris]

2024-08-01 Thread via GitHub
doris-robot commented on PR #38731: URL: https://github.com/apache/doris/pull/38731#issuecomment-2262957050 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y