Re: [PR] [fix](fs) Use full path as file cache key [doris]

2025-02-02 Thread via GitHub
github-actions[bot] closed pull request #38808: [fix](fs) Use full path as file cache key URL: https://github.com/apache/doris/pull/38808 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [fix](fs) Use full path as file cache key [doris]

2025-02-01 Thread via GitHub
github-actions[bot] commented on PR #38808: URL: https://github.com/apache/doris/pull/38808#issuecomment-2629172079 We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable

Re: [PR] [fix](fs) Use full path as file cache key [doris]

2024-08-05 Thread via GitHub
gavinchou commented on code in PR #38808: URL: https://github.com/apache/doris/pull/38808#discussion_r1703666746 ## be/src/io/cache/block_file_cache.cpp: ## Review Comment: Add UT to cover all newly added branches, make sure nothing is missed. -- This is an automated me

Re: [PR] [fix](fs) Use full path as file cache key [doris]

2024-08-02 Thread via GitHub
doris-robot commented on PR #38808: URL: https://github.com/apache/doris/pull/38808#issuecomment-2265580503 ClickBench: Total hot run time: 29.81 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix](fs) Use full path as file cache key [doris]

2024-08-02 Thread via GitHub
doris-robot commented on PR #38808: URL: https://github.com/apache/doris/pull/38808#issuecomment-2265570418 TPC-DS: Total hot run time: 169601 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](fs) Use full path as file cache key [doris]

2024-08-02 Thread via GitHub
doris-robot commented on PR #38808: URL: https://github.com/apache/doris/pull/38808#issuecomment-2265540222 TPC-H: Total hot run time: 41923 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](fs) Use full path as file cache key [doris]

2024-08-02 Thread via GitHub
platoneko commented on PR #38808: URL: https://github.com/apache/doris/pull/38808#issuecomment-2265491251 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [fix](fs) Use full path as file cache key [doris]

2024-08-02 Thread via GitHub
github-actions[bot] commented on PR #38808: URL: https://github.com/apache/doris/pull/38808#issuecomment-2265456461 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[PR] [fix](fs) Use full path as file cache key [doris]

2024-08-02 Thread via GitHub
platoneko opened a new pull request, #38808: URL: https://github.com/apache/doris/pull/38808 ## Proposed changes In path v1, the segment file path is "data/${shard_id}/${tablet_id}/${rowset_id}/${seg_id}.dat", which means that segment files of different rowsets can have the same file

Re: [PR] [fix](fs) Use full path as file cache key [doris]

2024-08-02 Thread via GitHub
doris-robot commented on PR #38808: URL: https://github.com/apache/doris/pull/38808#issuecomment-2265443183 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y