Re: [PR] [fix](cloud) shorten cache lock held time and add metrics [doris]

2025-02-02 Thread via GitHub
gavinchou merged PR #47472: URL: https://github.com/apache/doris/pull/47472 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

Re: [PR] [fix](cloud) shorten cache lock held time and add metrics [doris]

2025-02-01 Thread via GitHub
freemandealer commented on code in PR #47472: URL: https://github.com/apache/doris/pull/47472#discussion_r1938262670 ## be/src/common/config.cpp: ## @@ -1060,7 +1060,8 @@ DEFINE_Bool(enable_ttl_cache_evict_using_lru, "true"); DEFINE_mBool(enbale_dump_error_file, "false"); // l

Re: [PR] [fix](cloud) shorten cache lock held time and add metrics [doris]

2025-01-30 Thread via GitHub
gavinchou commented on code in PR #47472: URL: https://github.com/apache/doris/pull/47472#discussion_r1935804080 ## be/src/common/config.cpp: ## @@ -1060,7 +1060,8 @@ DEFINE_Bool(enable_ttl_cache_evict_using_lru, "true"); DEFINE_mBool(enbale_dump_error_file, "false"); // limit

Re: [PR] [fix](cloud) shorten cache lock held time and add metrics [doris]

2025-01-30 Thread via GitHub
gavinchou commented on code in PR #47472: URL: https://github.com/apache/doris/pull/47472#discussion_r1935791062 ## be/src/io/cache/file_block.cpp: ## @@ -59,6 +59,10 @@ FileBlock::State FileBlock::state() const { return _download_state; } +FileBlock::State FileBlock::st

Re: [PR] [fix](cloud) shorten cache lock held time and add metrics [doris]

2025-01-28 Thread via GitHub
github-actions[bot] commented on PR #47472: URL: https://github.com/apache/doris/pull/47472#issuecomment-2620389047 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [fix](cloud) shorten cache lock held time and add metrics [doris]

2025-01-28 Thread via GitHub
github-actions[bot] commented on PR #47472: URL: https://github.com/apache/doris/pull/47472#issuecomment-2620389020 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix](cloud) shorten cache lock held time and add metrics [doris]

2025-01-28 Thread via GitHub
dataroaring closed pull request #47472: [fix](cloud) shorten cache lock held time and add metrics URL: https://github.com/apache/doris/pull/47472 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [fix](cloud) shorten cache lock held time and add metrics [doris]

2025-01-27 Thread via GitHub
doris-robot commented on PR #47472: URL: https://github.com/apache/doris/pull/47472#issuecomment-2616084014 TeamCity be ut coverage result: Function Coverage: 42.07% (10972/26083) Line Coverage: 32.33% (92733/286812) Region Coverage: 31.49% (47563/151027) Branch Coverage: 27.

Re: [PR] [fix](cloud) shorten cache lock held time and add metrics [doris]

2025-01-27 Thread via GitHub
doris-robot commented on PR #47472: URL: https://github.com/apache/doris/pull/47472#issuecomment-2616024658 TPC-DS: Total hot run time: 192068 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](cloud) shorten cache lock held time and add metrics [doris]

2025-01-27 Thread via GitHub
doris-robot commented on PR #47472: URL: https://github.com/apache/doris/pull/47472#issuecomment-2616038963 ClickBench: Total hot run time: 30.08 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix](cloud) shorten cache lock held time and add metrics [doris]

2025-01-27 Thread via GitHub
doris-robot commented on PR #47472: URL: https://github.com/apache/doris/pull/47472#issuecomment-2615991667 TPC-H: Total hot run time: 32396 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](cloud) shorten cache lock held time and add metrics [doris]

2025-01-27 Thread via GitHub
Thearas commented on PR #47472: URL: https://github.com/apache/doris/pull/47472#issuecomment-2615725212 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

Re: [PR] [fix](cloud) shorten cache lock held time and add metrics [doris]

2025-01-27 Thread via GitHub
freemandealer commented on PR #47472: URL: https://github.com/apache/doris/pull/47472#issuecomment-2615725315 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[PR] [fix](cloud) shorten cache lock held time and add metrics [doris]

2025-01-27 Thread via GitHub
freemandealer opened a new pull request, #47472: URL: https://github.com/apache/doris/pull/47472 when update bvar metrics, we held block lock in the critical context of cache lock, make the later lock held too long and affect other cache logic. we use unsafe method to update the bvar to boo