yiguolei merged PR #48398:
URL: https://github.com/apache/doris/pull/48398
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apa
hello-stephen commented on PR #48398:
URL: https://github.com/apache/doris/pull/48398#issuecomment-2696334941
# BE UT Coverage Report
Increment line coverage `55.36% (31/56)` :tada:
[Increment coverage
report](http://coverage.selectdb-in.cc/coverage/b6660e2c0a9dcd45d3b363487806
doris-robot commented on PR #48398:
URL: https://github.com/apache/doris/pull/48398#issuecomment-2696235413
ClickBench: Total hot run time: 30.89 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #48398:
URL: https://github.com/apache/doris/pull/48398#issuecomment-2696227785
TPC-DS: Total hot run time: 191205 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #48398:
URL: https://github.com/apache/doris/pull/48398#issuecomment-2696209896
TPC-H: Total hot run time: 31526 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
xinyiZzz commented on PR #48398:
URL: https://github.com/apache/doris/pull/48398#issuecomment-2696087368
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
github-actions[bot] commented on PR #48398:
URL: https://github.com/apache/doris/pull/48398#issuecomment-2695956861
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
hello-stephen commented on PR #48398:
URL: https://github.com/apache/doris/pull/48398#issuecomment-2694598020
# BE UT Coverage Report
Increment line coverage `55.36% (31/56)` :tada:
[Increment coverage
report](http://coverage.selectdb-in.cc/coverage/9c2580fc33bf011549b1853b3f80c227
doris-robot commented on PR #48398:
URL: https://github.com/apache/doris/pull/48398#issuecomment-2694576215
ClickBench: Total hot run time: 30.69 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #48398:
URL: https://github.com/apache/doris/pull/48398#issuecomment-2694556418
TPC-DS: Total hot run time: 191345 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #48398:
URL: https://github.com/apache/doris/pull/48398#issuecomment-2694523437
TPC-H: Total hot run time: 31745 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
xinyiZzz commented on PR #48398:
URL: https://github.com/apache/doris/pull/48398#issuecomment-2694206609
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
xinyiZzz closed pull request #48398: [fix](arrow) Fix UT
`DataTypeSerDeArrowTest` of Date type
URL: https://github.com/apache/doris/pull/48398
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
xinyiZzz commented on code in PR #48398:
URL: https://github.com/apache/doris/pull/48398#discussion_r1977088192
##
be/test/vec/data_types/serde/data_type_serde_arrow_test.cpp:
##
@@ -300,19 +302,18 @@ void serialize_and_deserialize_arrow_test() {
} break;
case
xinyiZzz commented on code in PR #48398:
URL: https://github.com/apache/doris/pull/48398#discussion_r1977016585
##
be/test/vec/data_types/serde/data_type_serde_arrow_test.cpp:
##
@@ -86,13 +86,15 @@ void serialize_and_deserialize_arrow_test() {
{"k7", FieldType:
xinyiZzz commented on code in PR #48398:
URL: https://github.com/apache/doris/pull/48398#discussion_r1976894555
##
be/src/runtime/types.h:
##
Review Comment:
https://github.com/apache/doris/pull/48529
--
This is an automated message from the Apache Git Service.
To respo
xinyiZzz commented on code in PR #48398:
URL: https://github.com/apache/doris/pull/48398#discussion_r1976856890
##
be/src/runtime/types.h:
##
@@ -69,11 +70,11 @@ struct TypeDescriptor {
// explicit TypeDescriptor(PrimitiveType type) :
TypeDescriptor(PrimitiveType typ
xinyiZzz commented on code in PR #48398:
URL: https://github.com/apache/doris/pull/48398#discussion_r1976853809
##
be/src/vec/data_types/serde/data_type_date64_serde.cpp:
##
@@ -245,20 +252,28 @@ void DataTypeDate64SerDe::read_column_from_arrow(IColumn&
column, const arrow::A
xinyiZzz commented on code in PR #48398:
URL: https://github.com/apache/doris/pull/48398#discussion_r1976832925
##
be/test/vec/data_types/serde/data_type_serde_arrow_test.cpp:
##
@@ -300,19 +302,18 @@ void serialize_and_deserialize_arrow_test() {
} break;
case
zclllyybb commented on code in PR #48398:
URL: https://github.com/apache/doris/pull/48398#discussion_r1976667430
##
be/test/vec/data_types/serde/data_type_serde_arrow_test.cpp:
##
@@ -86,13 +86,15 @@ void serialize_and_deserialize_arrow_test() {
{"k7", FieldType
github-actions[bot] commented on PR #48398:
URL: https://github.com/apache/doris/pull/48398#issuecomment-2689864439
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
doris-robot commented on PR #48398:
URL: https://github.com/apache/doris/pull/48398#issuecomment-2689639542
TPC-H: Total hot run time: 31778 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
doris-robot commented on PR #48398:
URL: https://github.com/apache/doris/pull/48398#issuecomment-2689666584
# BE UT Coverage Report
Increment line coverage `55.36% (31/56)` :tada:
[Increment coverage
report](http://coverage.selectdb-in.cc/coverage/86ea5eec5c1c499021fe06a4ac6ebad822
doris-robot commented on PR #48398:
URL: https://github.com/apache/doris/pull/48398#issuecomment-2689650643
TPC-DS: Total hot run time: 189965 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #48398:
URL: https://github.com/apache/doris/pull/48398#issuecomment-2689655654
ClickBench: Total hot run time: 31.01 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
xinyiZzz commented on PR #48398:
URL: https://github.com/apache/doris/pull/48398#issuecomment-2689601711
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
doris-robot commented on PR #48398:
URL: https://github.com/apache/doris/pull/48398#issuecomment-2688872101
ClickBench: Total hot run time: 30.83 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #48398:
URL: https://github.com/apache/doris/pull/48398#issuecomment-2688859454
TPC-DS: Total hot run time: 191133 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #48398:
URL: https://github.com/apache/doris/pull/48398#issuecomment-2688831858
TPC-H: Total hot run time: 32087 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
xinyiZzz commented on PR #48398:
URL: https://github.com/apache/doris/pull/48398#issuecomment-2688703987
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
doris-robot commented on PR #48398:
URL: https://github.com/apache/doris/pull/48398#issuecomment-2687376465
TPC-DS: Total hot run time: 190922 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #48398:
URL: https://github.com/apache/doris/pull/48398#issuecomment-2687389953
ClickBench: Total hot run time: 30.99 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #48398:
URL: https://github.com/apache/doris/pull/48398#issuecomment-2687347924
TPC-H: Total hot run time: 32099 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
xinyiZzz commented on PR #48398:
URL: https://github.com/apache/doris/pull/48398#issuecomment-2687164090
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
xinyiZzz commented on PR #48398:
URL: https://github.com/apache/doris/pull/48398#issuecomment-2687123310
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
doris-robot commented on PR #48398:
URL: https://github.com/apache/doris/pull/48398#issuecomment-2687085658
ClickBench: Total hot run time: 30.63 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #48398:
URL: https://github.com/apache/doris/pull/48398#issuecomment-2687077429
TPC-DS: Total hot run time: 190206 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #48398:
URL: https://github.com/apache/doris/pull/48398#issuecomment-2687060011
TPC-H: Total hot run time: 31775 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
xinyiZzz commented on code in PR #48398:
URL: https://github.com/apache/doris/pull/48398#discussion_r1972745366
##
be/src/vec/data_types/data_type_time_v2.h:
##
@@ -123,7 +123,9 @@ class DataTypeDateTimeV2 final : public
DataTypeNumberBase {
DataTypeDateTimeV2(const DataTy
xinyiZzz commented on code in PR #48398:
URL: https://github.com/apache/doris/pull/48398#discussion_r1972743306
##
be/src/runtime/types.h:
##
@@ -68,15 +69,7 @@ struct TypeDescriptor {
TypeDescriptor() : type(INVALID_TYPE), len(-1), precision(-1), scale(-1) {}
// exp
xinyiZzz commented on PR #48398:
URL: https://github.com/apache/doris/pull/48398#issuecomment-2687005700
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
doris-robot commented on PR #48398:
URL: https://github.com/apache/doris/pull/48398#issuecomment-2686978245
ClickBench: Total hot run time: 31.13 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #48398:
URL: https://github.com/apache/doris/pull/48398#issuecomment-2686971212
TPC-DS: Total hot run time: 191055 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #48398:
URL: https://github.com/apache/doris/pull/48398#issuecomment-2686957219
TPC-H: Total hot run time: 31920 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
xinyiZzz commented on PR #48398:
URL: https://github.com/apache/doris/pull/48398#issuecomment-2686788081
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
xinyiZzz commented on code in PR #48398:
URL: https://github.com/apache/doris/pull/48398#discussion_r1972745366
##
be/src/vec/data_types/data_type_time_v2.h:
##
@@ -123,7 +123,9 @@ class DataTypeDateTimeV2 final : public
DataTypeNumberBase {
DataTypeDateTimeV2(const DataTy
xinyiZzz commented on code in PR #48398:
URL: https://github.com/apache/doris/pull/48398#discussion_r1972743306
##
be/src/runtime/types.h:
##
@@ -68,15 +69,7 @@ struct TypeDescriptor {
TypeDescriptor() : type(INVALID_TYPE), len(-1), precision(-1), scale(-1) {}
// exp
doris-robot commented on PR #48398:
URL: https://github.com/apache/doris/pull/48398#issuecomment-2685331423
ClickBench: Total hot run time: 31.9 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
C
doris-robot commented on PR #48398:
URL: https://github.com/apache/doris/pull/48398#issuecomment-2685314647
TPC-DS: Total hot run time: 184095 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #48398:
URL: https://github.com/apache/doris/pull/48398#issuecomment-2685267635
TPC-H: Total hot run time: 31913 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
yiguolei commented on code in PR #48398:
URL: https://github.com/apache/doris/pull/48398#discussion_r1971637192
##
be/src/vec/data_types/data_type_time_v2.h:
##
@@ -123,7 +123,9 @@ class DataTypeDateTimeV2 final : public
DataTypeNumberBase {
DataTypeDateTimeV2(const DataTy
yiguolei commented on code in PR #48398:
URL: https://github.com/apache/doris/pull/48398#discussion_r1971635162
##
be/src/runtime/types.h:
##
@@ -68,15 +69,7 @@ struct TypeDescriptor {
TypeDescriptor() : type(INVALID_TYPE), len(-1), precision(-1), scale(-1) {}
// exp
xinyiZzz commented on PR #48398:
URL: https://github.com/apache/doris/pull/48398#issuecomment-2684940955
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
Thearas commented on PR #48398:
URL: https://github.com/apache/doris/pull/48398#issuecomment-2684939884
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y
xinyiZzz opened a new pull request, #48398:
URL: https://github.com/apache/doris/pull/48398
### What problem does this PR solve?
1. Fix `TYPE_DATETIME`, `TYPE_DATETIMEV2`, `TYPE_DATE`, `TYPE_DATEV2`
deserialize from Arrow data to Doris data type.
2. Delete unused code.
### C
55 matches
Mail list logo
