Re: [PR] [feature-wip](Cloud) Add property storage vault for OlapTable [doris]

2024-03-12 Thread via GitHub
doris-robot commented on PR #31628: URL: https://github.com/apache/doris/pull/31628#issuecomment-1991065822 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit c851ce8263db2a5b7696ee173eaab768d8fd1f02 with default session variables Stream

Re: [PR] [feature-wip](Cloud) Add property storage vault for OlapTable [doris]

2024-03-12 Thread via GitHub
doris-robot commented on PR #31628: URL: https://github.com/apache/doris/pull/31628#issuecomment-1991060684 ClickBench: Total hot run time: 30.15 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [feature-wip](Cloud) Add property storage vault for OlapTable [doris]

2024-03-12 Thread via GitHub
doris-robot commented on PR #31628: URL: https://github.com/apache/doris/pull/31628#issuecomment-1991051923 TPC-DS: Total hot run time: 186782 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [feature-wip](Cloud) Add property storage vault for OlapTable [doris]

2024-03-12 Thread via GitHub
doris-robot commented on PR #31628: URL: https://github.com/apache/doris/pull/31628#issuecomment-1991031567 TPC-H: Total hot run time: 36553 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [feature-wip](Cloud) Add property storage vault for OlapTable [doris]

2024-03-12 Thread via GitHub
doris-robot commented on PR #31628: URL: https://github.com/apache/doris/pull/31628#issuecomment-1990974753 TeamCity be ut coverage result: Function Coverage: 34.97% (8556/24465) Line Coverage: 26.81% (69531/259305) Region Coverage: 26.07% (36087/138436) Branch Coverage: 23.0

Re: [PR] [feature-wip](Cloud) Add property storage vault for OlapTable [doris]

2024-03-12 Thread via GitHub
github-actions[bot] commented on PR #31628: URL: https://github.com/apache/doris/pull/31628#issuecomment-1990950700 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [feature-wip](Cloud) Add property storage vault for OlapTable [doris]

2024-03-12 Thread via GitHub
github-actions[bot] commented on PR #31628: URL: https://github.com/apache/doris/pull/31628#issuecomment-1990950663 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [feature-wip](Cloud) Add property storage vault for OlapTable [doris]

2024-03-12 Thread via GitHub
ByteYue commented on PR #31628: URL: https://github.com/apache/doris/pull/31628#issuecomment-1990945588 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [feature-wip](Cloud) Add property storage vault for OlapTable [doris]

2024-03-12 Thread via GitHub
doris-robot commented on PR #31628: URL: https://github.com/apache/doris/pull/31628#issuecomment-1990939037 TPC-DS: Total hot run time: 186991 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [feature-wip](Cloud) Add property storage vault for OlapTable [doris]

2024-03-12 Thread via GitHub
doris-robot commented on PR #31628: URL: https://github.com/apache/doris/pull/31628#issuecomment-1990923837 TPC-H: Total hot run time: 36920 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [feature-wip](Cloud) Add property storage vault for OlapTable [doris]

2024-03-11 Thread via GitHub
ByteYue commented on PR #31628: URL: https://github.com/apache/doris/pull/31628#issuecomment-1990754825 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [feature-wip](Cloud) Add property storage vault for OlapTable [doris]

2024-03-11 Thread via GitHub
gavinchou commented on code in PR #31628: URL: https://github.com/apache/doris/pull/31628#discussion_r1520854955 ## be/src/cloud/cloud_storage_engine.cpp: ## @@ -189,51 +193,93 @@ Status CloudStorageEngine::start_bg_threads() { return Status::OK(); } -void CloudStorageEn

Re: [PR] [feature-wip](Cloud) Add property storage vault for OlapTable [doris]

2024-03-08 Thread via GitHub
github-actions[bot] commented on PR #31628: URL: https://github.com/apache/doris/pull/31628#issuecomment-1985259445 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [feature-wip](Cloud) Add property storage vault for OlapTable [doris]

2024-03-07 Thread via GitHub
platoneko commented on code in PR #31628: URL: https://github.com/apache/doris/pull/31628#discussion_r1515730452 ## be/src/olap/delta_writer_context.h: ## @@ -43,6 +43,7 @@ struct WriteRequest { std::shared_ptr table_schema_param = nullptr; bool is_high_priority = fals

Re: [PR] [feature-wip](Cloud) Add property storage vault for OlapTable [doris]

2024-03-07 Thread via GitHub
platoneko commented on code in PR #31628: URL: https://github.com/apache/doris/pull/31628#discussion_r1515730452 ## be/src/olap/delta_writer_context.h: ## @@ -43,6 +43,7 @@ struct WriteRequest { std::shared_ptr table_schema_param = nullptr; bool is_high_priority = fals

Re: [PR] [feature-wip](Cloud) Add property storage vault for OlapTable [doris]

2024-03-04 Thread via GitHub
github-actions[bot] commented on PR #31628: URL: https://github.com/apache/doris/pull/31628#issuecomment-1978159550 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [feature-wip](Cloud) Add property storage vault for OlapTable [doris]

2024-03-04 Thread via GitHub
ByteYue commented on code in PR #31628: URL: https://github.com/apache/doris/pull/31628#discussion_r1512244177 ## fe/fe-core/src/main/java/org/apache/doris/cloud/datasource/CloudInternalCatalog.java: ## @@ -145,11 +148,19 @@ protected Partition createPartitionWithIndices(long db

Re: [PR] [feature-wip](Cloud) Add property storage vault for OlapTable [doris]

2024-03-04 Thread via GitHub
gavinchou commented on code in PR #31628: URL: https://github.com/apache/doris/pull/31628#discussion_r1512190108 ## fe/fe-core/src/main/java/org/apache/doris/common/util/PropertyAnalyzer.java: ## @@ -984,6 +987,15 @@ public static String analyzeStoragePolicy(Map properties) {

Re: [PR] [feature-wip](Cloud) Add property storage vault for OlapTable [doris]

2024-03-04 Thread via GitHub
github-actions[bot] commented on PR #31628: URL: https://github.com/apache/doris/pull/31628#issuecomment-1976552953 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [feature-wip](Cloud) Add property storage vault for OlapTable [doris]

2024-03-04 Thread via GitHub
github-actions[bot] commented on PR #31628: URL: https://github.com/apache/doris/pull/31628#issuecomment-1976054276 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [feature-wip](Cloud) Add property storage vault for OlapTable [doris]

2024-03-04 Thread via GitHub
github-actions[bot] commented on PR #31628: URL: https://github.com/apache/doris/pull/31628#issuecomment-1976033155 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [feature-wip](Cloud) Add property storage vault for OlapTable [doris]

2024-03-01 Thread via GitHub
github-actions[bot] commented on PR #31628: URL: https://github.com/apache/doris/pull/31628#issuecomment-1972864814 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [feature-wip](Cloud) Add property storage vault for OlapTable [doris]

2024-03-01 Thread via GitHub
github-actions[bot] commented on PR #31628: URL: https://github.com/apache/doris/pull/31628#issuecomment-1972838803 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [feature-wip](Cloud) Add property storage vault for OlapTable [doris]

2024-02-29 Thread via GitHub
github-actions[bot] commented on PR #31628: URL: https://github.com/apache/doris/pull/31628#issuecomment-1971484675 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[PR] [feature-wip](Cloud) Add property storage vault for OlapTable [doris]

2024-02-29 Thread via GitHub
ByteYue opened a new pull request, #31628: URL: https://github.com/apache/doris/pull/31628 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:

Re: [PR] [feature-wip](Cloud) Add property storage vault for OlapTable [doris]

2024-02-29 Thread via GitHub
doris-robot commented on PR #31628: URL: https://github.com/apache/doris/pull/31628#issuecomment-1971465591 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y