Re: [PR] [feature](pred) Support xor function [doris]

2024-05-05 Thread via GitHub
HappenLee merged PR #33634: URL: https://github.com/apache/doris/pull/33634 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

Re: [PR] [feature](pred) Support xor function [doris]

2024-05-05 Thread via GitHub
github-actions[bot] commented on PR #33634: URL: https://github.com/apache/doris/pull/33634#issuecomment-2094663147 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [feature](pred) Support xor function [doris]

2024-04-24 Thread via GitHub
Mryange commented on PR #33634: URL: https://github.com/apache/doris/pull/33634#issuecomment-2076424121 run feut -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

Re: [PR] [feature](pred) Support xor function [doris]

2024-04-24 Thread via GitHub
Mryange commented on PR #33634: URL: https://github.com/apache/doris/pull/33634#issuecomment-2076423971 run cloud_p1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [feature](pred) Support xor function [doris]

2024-04-24 Thread via GitHub
doris-robot commented on PR #33634: URL: https://github.com/apache/doris/pull/33634#issuecomment-2076334781 TeamCity be ut coverage result: Function Coverage: 35.18% (8915/25339) Line Coverage: 26.96% (73290/271856) Region Coverage: 26.13% (37857/144877) Branch Coverage: 22.9

Re: [PR] [feature](pred) Support xor function [doris]

2024-04-24 Thread via GitHub
Mryange commented on PR #33634: URL: https://github.com/apache/doris/pull/33634#issuecomment-2076303496 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [feature](pred) Support xor function [doris]

2024-04-24 Thread via GitHub
github-actions[bot] commented on PR #33634: URL: https://github.com/apache/doris/pull/33634#issuecomment-2076300941 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [feature](pred) Support xor function [doris]

2024-04-24 Thread via GitHub
github-actions[bot] commented on PR #33634: URL: https://github.com/apache/doris/pull/33634#issuecomment-2076297286 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [feature](pred) Support xor function [doris]

2024-04-24 Thread via GitHub
Mryange commented on PR #33634: URL: https://github.com/apache/doris/pull/33634#issuecomment-2076295178 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [feature](pred) Support xor function [doris]

2024-04-16 Thread via GitHub
Mryange commented on code in PR #33634: URL: https://github.com/apache/doris/pull/33634#discussion_r1568183371 ## regression-test/suites/correctness_p0/test_xor_pred.groovy: ## @@ -0,0 +1,42 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributo

Re: [PR] [feature](pred) Support xor function [doris]

2024-04-16 Thread via GitHub
zhiqiang- commented on code in PR #33634: URL: https://github.com/apache/doris/pull/33634#discussion_r1568177359 ## regression-test/suites/correctness_p0/test_xor_pred.groovy: ## @@ -0,0 +1,42 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more cont

Re: [PR] [feature](pred) Support xor function [doris]

2024-04-16 Thread via GitHub
tang350476527 commented on PR #33634: URL: https://github.com/apache/doris/pull/33634#issuecomment-2060287978 谢谢您的来信,您的邮件已收到! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [feature](pred) Support xor function [doris]

2024-04-16 Thread via GitHub
zhiqiang- commented on code in PR #33634: URL: https://github.com/apache/doris/pull/33634#discussion_r1568173821 ## regression-test/suites/correctness_p0/test_xor_pred.groovy: ## @@ -0,0 +1,42 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more cont

Re: [PR] [feature](pred) Support xor function [doris]

2024-04-16 Thread via GitHub
Mryange commented on code in PR #33634: URL: https://github.com/apache/doris/pull/33634#discussion_r1568173726 ## regression-test/suites/correctness_p0/test_xor_pred.groovy: ## @@ -0,0 +1,42 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributo

Re: [PR] [feature](pred) Support xor function [doris]

2024-04-16 Thread via GitHub
Mryange commented on code in PR #33634: URL: https://github.com/apache/doris/pull/33634#discussion_r1568173180 ## regression-test/suites/correctness_p0/test_xor_pred.groovy: ## @@ -0,0 +1,42 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributo

Re: [PR] [feature](pred) Support xor function [doris]

2024-04-16 Thread via GitHub
zhiqiang- commented on code in PR #33634: URL: https://github.com/apache/doris/pull/33634#discussion_r1568171633 ## regression-test/suites/correctness_p0/test_xor_pred.groovy: ## @@ -0,0 +1,42 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more cont

Re: [PR] [feature](pred) Support xor function [doris]

2024-04-16 Thread via GitHub
Mryange commented on code in PR #33634: URL: https://github.com/apache/doris/pull/33634#discussion_r1568168659 ## regression-test/suites/correctness_p0/test_xor_pred.groovy: ## @@ -0,0 +1,42 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributo

Re: [PR] [feature](pred) Support xor function [doris]

2024-04-16 Thread via GitHub
Mryange commented on code in PR #33634: URL: https://github.com/apache/doris/pull/33634#discussion_r1568165372 ## regression-test/suites/correctness_p0/test_xor_pred.groovy: ## @@ -0,0 +1,42 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributo

Re: [PR] [feature](pred) Support xor function [doris]

2024-04-16 Thread via GitHub
zhiqiang- commented on code in PR #33634: URL: https://github.com/apache/doris/pull/33634#discussion_r1568164576 ## regression-test/suites/correctness_p0/test_xor_pred.groovy: ## @@ -0,0 +1,42 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more cont

Re: [PR] [feature](pred) Support xor function [doris]

2024-04-16 Thread via GitHub
yiguolei commented on code in PR #33634: URL: https://github.com/apache/doris/pull/33634#discussion_r1568162163 ## regression-test/suites/correctness_p0/test_xor_pred.groovy: ## @@ -0,0 +1,42 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contribut

Re: [PR] [feature](pred) Support xor function [doris]

2024-04-14 Thread via GitHub
github-actions[bot] commented on PR #33634: URL: https://github.com/apache/doris/pull/33634#issuecomment-2054498616 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [feature](pred) Support xor function [doris]

2024-04-14 Thread via GitHub
github-actions[bot] commented on PR #33634: URL: https://github.com/apache/doris/pull/33634#issuecomment-2054498389 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [feature](pred) Support xor function [doris]

2024-04-14 Thread via GitHub
Mryange commented on PR #33634: URL: https://github.com/apache/doris/pull/33634#issuecomment-2054239222 run p1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [PR] [feature](pred) Support xor function [doris]

2024-04-14 Thread via GitHub
doris-robot commented on PR #33634: URL: https://github.com/apache/doris/pull/33634#issuecomment-2054110327 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit 9755436eeb8d453fbb72048d0b0ccb5eef697176 with default session variables Stream

Re: [PR] [feature](pred) Support xor function [doris]

2024-04-14 Thread via GitHub
doris-robot commented on PR #33634: URL: https://github.com/apache/doris/pull/33634#issuecomment-2054109516 ClickBench: Total hot run time: 30.62 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [feature](pred) Support xor function [doris]

2024-04-14 Thread via GitHub
doris-robot commented on PR #33634: URL: https://github.com/apache/doris/pull/33634#issuecomment-2054107891 TPC-DS: Total hot run time: 183344 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [feature](pred) Support xor function [doris]

2024-04-14 Thread via GitHub
doris-robot commented on PR #33634: URL: https://github.com/apache/doris/pull/33634#issuecomment-2054104854 TPC-H: Total hot run time: 38511 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [feature](pred) Support xor function [doris]

2024-04-14 Thread via GitHub
doris-robot commented on PR #33634: URL: https://github.com/apache/doris/pull/33634#issuecomment-2054102013 TeamCity be ut coverage result: Function Coverage: 35.58% (8904/25022) Line Coverage: 27.31% (73129/267760) Region Coverage: 26.44% (37820/143031) Branch Coverage: 23.1

Re: [PR] [feature](pred) Support xor function [doris]

2024-04-14 Thread via GitHub
github-actions[bot] commented on PR #33634: URL: https://github.com/apache/doris/pull/33634#issuecomment-2054095331 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [feature](pred) Support xor function [doris]

2024-04-14 Thread via GitHub
Mryange commented on PR #33634: URL: https://github.com/apache/doris/pull/33634#issuecomment-2054093885 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [feature](pred) Support xor function [doris]

2024-04-14 Thread via GitHub
doris-robot commented on PR #33634: URL: https://github.com/apache/doris/pull/33634#issuecomment-2054079940 TeamCity be ut coverage result: Function Coverage: 35.58% (8904/25022) Line Coverage: 27.30% (73100/267756) Region Coverage: 26.44% (37824/143031) Branch Coverage: 23.1

Re: [PR] [feature](pred) Support xor function [doris]

2024-04-14 Thread via GitHub
github-actions[bot] commented on PR #33634: URL: https://github.com/apache/doris/pull/33634#issuecomment-2054072321 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [feature](pred) Support xor function [doris]

2024-04-14 Thread via GitHub
Mryange commented on PR #33634: URL: https://github.com/apache/doris/pull/33634#issuecomment-2054070955 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [feature](pred) Support xor function [doris]

2024-04-14 Thread via GitHub
HappenLee commented on code in PR #33634: URL: https://github.com/apache/doris/pull/33634#discussion_r1564634000 ## be/src/vec/functions/functions_logical.h: ## @@ -94,6 +94,18 @@ struct OrImpl { static inline constexpr bool special_implementation_for_nulls() { return true

Re: [PR] [feature](pred) Support xor function [doris]

2024-04-14 Thread via GitHub
doris-robot commented on PR #33634: URL: https://github.com/apache/doris/pull/33634#issuecomment-2054008308 TeamCity be ut coverage result: Function Coverage: 35.58% (8904/25023) Line Coverage: 27.31% (73121/267754) Region Coverage: 26.44% (37814/143032) Branch Coverage: 23.1

Re: [PR] [feature](pred) Support xor function [doris]

2024-04-14 Thread via GitHub
github-actions[bot] commented on PR #33634: URL: https://github.com/apache/doris/pull/33634#issuecomment-2054000809 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [feature](pred) Support xor function [doris]

2024-04-14 Thread via GitHub
Mryange commented on PR #33634: URL: https://github.com/apache/doris/pull/33634#issuecomment-2053999513 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [feature](pred) Support xor function [doris]

2024-04-14 Thread via GitHub
doris-robot commented on PR #33634: URL: https://github.com/apache/doris/pull/33634#issuecomment-2053999486 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

[PR] [feature](pred) Support xor function [doris]

2024-04-14 Thread via GitHub
Mryange opened a new pull request, #33634: URL: https://github.com/apache/doris/pull/33634 ## Proposed changes ``` mysql [test]>select true xor false,true xor true; +--+-+ | (TRUE XOR FALSE) | (TRUE XOR TRUE) | +--+---