Re: [PR] [feature](datatype) add BE config to allow zero date [doris]

2024-05-22 Thread via GitHub
dataroaring merged PR #34961: URL: https://github.com/apache/doris/pull/34961 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.

Re: [PR] [feature](datatype) add BE config to allow zero date [doris]

2024-05-20 Thread via GitHub
github-actions[bot] commented on PR #34961: URL: https://github.com/apache/doris/pull/34961#issuecomment-2121831931 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [feature](datatype) add BE config to allow zero date [doris]

2024-05-20 Thread via GitHub
doris-robot commented on PR #34961: URL: https://github.com/apache/doris/pull/34961#issuecomment-2120185689 TeamCity be ut coverage result: Function Coverage: 35.70% (9014/25250) Line Coverage: 27.35% (74544/272527) Region Coverage: 26.61% (38562/144923) Branch Coverage: 23.4

Re: [PR] [feature](datatype) add BE config to allow zero date [doris]

2024-05-20 Thread via GitHub
dataroaring commented on PR #34961: URL: https://github.com/apache/doris/pull/34961#issuecomment-2120021855 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [feature](datatype) add BE config to allow zero date [doris]

2024-05-18 Thread via GitHub
doris-robot commented on PR #34961: URL: https://github.com/apache/doris/pull/34961#issuecomment-2118684650 TeamCity be ut coverage result: Function Coverage: 35.71% (9009/25228) Line Coverage: 27.37% (74523/272254) Region Coverage: 26.63% (38556/144805) Branch Coverage: 23.4

Re: [PR] [feature](datatype) add BE config to allow zero date [doris]

2024-05-17 Thread via GitHub
dataroaring commented on PR #34961: URL: https://github.com/apache/doris/pull/34961#issuecomment-2118660868 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [feature](datatype) add BE config to allow zero date [doris]

2024-05-17 Thread via GitHub
liaoxin01 commented on PR #34961: URL: https://github.com/apache/doris/pull/34961#issuecomment-2117619749 Please add a regression test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] [feature](datatype) add BE config to allow zero date [doris]

2024-05-16 Thread via GitHub
doris-robot commented on PR #34961: URL: https://github.com/apache/doris/pull/34961#issuecomment-2114895268 TeamCity be ut coverage result: Function Coverage: 35.71% (9005/25219) Line Coverage: 27.37% (74499/272154) Region Coverage: 26.62% (38517/144718) Branch Coverage: 23.4

Re: [PR] [feature](datatype) add BE config to allow zero date [doris]

2024-05-16 Thread via GitHub
kaijchen commented on PR #34961: URL: https://github.com/apache/doris/pull/34961#issuecomment-2114734861 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [feature](datatype) add BE config to allow zero date [doris]

2024-05-16 Thread via GitHub
github-actions[bot] commented on PR #34961: URL: https://github.com/apache/doris/pull/34961#issuecomment-2114732126 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [feature](datatype) add BE config to allow zero date [doris]

2024-05-16 Thread via GitHub
github-actions[bot] commented on PR #34961: URL: https://github.com/apache/doris/pull/34961#issuecomment-2114732043 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [feature](datatype) add BE config to allow zero date [doris]

2024-05-16 Thread via GitHub
github-actions[bot] commented on code in PR #34961: URL: https://github.com/apache/doris/pull/34961#discussion_r1602939107 ## be/src/vec/runtime/vdatetime_value.cpp: ## @@ -1976,18 +1976,20 @@ void DateV2Value::format_datetime(uint32_t* date_val, bool* carry_bits) const // YYY

Re: [PR] [feature](datatype) add BE config to allow zero date [doris]

2024-05-16 Thread via GitHub
kaijchen commented on PR #34961: URL: https://github.com/apache/doris/pull/34961#issuecomment-2114626231 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [feature](datatype) add BE config to allow zero date [doris]

2024-05-16 Thread via GitHub
doris-robot commented on PR #34961: URL: https://github.com/apache/doris/pull/34961#issuecomment-2114621679 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

[PR] [feature](datatype) add BE config to allow zero date [doris]

2024-05-16 Thread via GitHub
kaijchen opened a new pull request, #34961: URL: https://github.com/apache/doris/pull/34961 ## Proposed changes Add a BE config `allow_zero_date`, which defaults to `false`. If set to `false`, `-00-00` will be converted to `NULL` (old behavior). If set to `true`, `-00