dolfinus commented on PR #50126:
URL: https://github.com/apache/doris/pull/50126#issuecomment-2921679237
May I propose an alternative? This PR can be splitted to a set of smaller
ones:
* replace `UUID.generateRandomUUID()` to UUIDGenerator class, returning
UUIDv4, so behavior remains the
hello-stephen commented on PR #50126:
URL: https://github.com/apache/doris/pull/50126#issuecomment-2895638479
# BE Regression && UT Coverage Report
Increment line coverage `100.00% (39/39)` :tada:
[Increment coverage
report](http://coverage.selectdb-in.cc/coverage/50126_d9d06497489
hello-stephen commented on PR #50126:
URL: https://github.com/apache/doris/pull/50126#issuecomment-2895263165
# BE UT Coverage Report
Increment line coverage `100.00% (37/37)` :tada:
[Increment coverage
report](http://coverage.selectdb-in.cc/coverage/d9d06497489f5075723c6767c77fa93
doris-robot commented on PR #50126:
URL: https://github.com/apache/doris/pull/50126#issuecomment-2893829282
ClickBench: Total hot run time: 28.88 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
felixwluo commented on PR #50126:
URL: https://github.com/apache/doris/pull/50126#issuecomment-2894399485
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
doris-robot commented on PR #50126:
URL: https://github.com/apache/doris/pull/50126#issuecomment-2893813981
TPC-DS: Total hot run time: 182862 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #50126:
URL: https://github.com/apache/doris/pull/50126#issuecomment-2893780579
TPC-H: Total hot run time: 33550 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
dolfinus commented on code in PR #50126:
URL: https://github.com/apache/doris/pull/50126#discussion_r2097373744
##
fe/fe-core/src/main/java/org/apache/doris/common/UUIDv7Generator.java:
##
@@ -0,0 +1,132 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or mo
felixwluo commented on PR #50126:
URL: https://github.com/apache/doris/pull/50126#issuecomment-2893437057
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
dolfinus commented on code in PR #50126:
URL: https://github.com/apache/doris/pull/50126#discussion_r2076028582
##
fe/fe-core/src/main/java/org/apache/doris/common/UUIDv7Generator.java:
##
@@ -0,0 +1,124 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or mo
dolfinus commented on code in PR #50126:
URL: https://github.com/apache/doris/pull/50126#discussion_r2076028582
##
fe/fe-core/src/main/java/org/apache/doris/common/UUIDv7Generator.java:
##
@@ -0,0 +1,124 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or mo
dolfinus commented on code in PR #50126:
URL: https://github.com/apache/doris/pull/50126#discussion_r2076019934
##
be/src/util/uuid_generator.h:
##
@@ -17,18 +17,102 @@
#pragma once
+#include
#include
#include
#include
+#include
+#include
#include
+#include
n
hello-stephen commented on PR #50126:
URL: https://github.com/apache/doris/pull/50126#issuecomment-2855363570
# BE Regression && UT Coverage Report
Increment line coverage `100.00% (39/39)` :tada:
[Increment coverage
report](http://coverage.selectdb-in.cc/coverage/50126_b1ade9a70ce
doris-robot commented on PR #50126:
URL: https://github.com/apache/doris/pull/50126#issuecomment-2854809438
# BE UT Coverage Report
Increment line coverage `100.00% (37/37)` :tada:
[Increment coverage
report](http://coverage.selectdb-in.cc/coverage/b1ade9a70cee067ab4b6a61fd834d69eb
doris-robot commented on PR #50126:
URL: https://github.com/apache/doris/pull/50126#issuecomment-2854566483
ClickBench: Total hot run time: 28.38 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #50126:
URL: https://github.com/apache/doris/pull/50126#issuecomment-2854548492
TPC-DS: Total hot run time: 185711 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #50126:
URL: https://github.com/apache/doris/pull/50126#issuecomment-2854503780
TPC-H: Total hot run time: 33582 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
felixwluo commented on PR #50126:
URL: https://github.com/apache/doris/pull/50126#issuecomment-2854258195
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
doris-robot commented on PR #50126:
URL: https://github.com/apache/doris/pull/50126#issuecomment-2854091918
ClickBench: Total hot run time: 29.16 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #50126:
URL: https://github.com/apache/doris/pull/50126#issuecomment-2854080131
TPC-DS: Total hot run time: 184942 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #50126:
URL: https://github.com/apache/doris/pull/50126#issuecomment-2854048458
TPC-H: Total hot run time: 33838 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
924060929 commented on code in PR #50126:
URL: https://github.com/apache/doris/pull/50126#discussion_r2075051669
##
fe/fe-core/src/main/java/org/apache/doris/common/UUIDv7Generator.java:
##
@@ -0,0 +1,106 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or m
924060929 commented on code in PR #50126:
URL: https://github.com/apache/doris/pull/50126#discussion_r2075035573
##
fe/fe-core/src/main/java/org/apache/doris/common/UUIDv7Generator.java:
##
@@ -0,0 +1,106 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or m
924060929 commented on code in PR #50126:
URL: https://github.com/apache/doris/pull/50126#discussion_r2075035573
##
fe/fe-core/src/main/java/org/apache/doris/common/UUIDv7Generator.java:
##
@@ -0,0 +1,106 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or m
924060929 commented on code in PR #50126:
URL: https://github.com/apache/doris/pull/50126#discussion_r2075035573
##
fe/fe-core/src/main/java/org/apache/doris/common/UUIDv7Generator.java:
##
@@ -0,0 +1,106 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or m
felixwluo commented on PR #50126:
URL: https://github.com/apache/doris/pull/50126#issuecomment-2853735281
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
hello-stephen commented on PR #50126:
URL: https://github.com/apache/doris/pull/50126#issuecomment-2833687910
# BE Regression P0 && UT Coverage Report
Increment line coverage `100.00% (31/31)` :tada:
[Increment coverage
report](http://coverage.selectdb-in.cc/coverage/50126_71a0f2d9
doris-robot commented on PR #50126:
URL: https://github.com/apache/doris/pull/50126#issuecomment-2833605478
# BE UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage
report](http://coverage.selectdb-in.cc/coverage/71a0f2d9b0ecf13c66d12288018a8138a9127cc3_71a0f2
dolfinus commented on code in PR #50126:
URL: https://github.com/apache/doris/pull/50126#discussion_r2062691368
##
be/src/util/uuid_generator.h:
##
@@ -17,18 +17,92 @@
#pragma once
+#include
#include
#include
#include
+#include
+#include
#include
+#include
na
doris-robot commented on PR #50126:
URL: https://github.com/apache/doris/pull/50126#issuecomment-2833576768
ClickBench: Total hot run time: 29.48 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #50126:
URL: https://github.com/apache/doris/pull/50126#issuecomment-2833574748
TPC-DS: Total hot run time: 192318 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #50126:
URL: https://github.com/apache/doris/pull/50126#issuecomment-2833569804
TPC-H: Total hot run time: 34017 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
dolfinus commented on code in PR #50126:
URL: https://github.com/apache/doris/pull/50126#discussion_r2062668353
##
be/test/util/uuid_generator_test.cpp:
##
@@ -0,0 +1,170 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
Awesome, thank you!
felixwluo commented on code in PR #50126:
URL: https://github.com/apache/doris/pull/50126#discussion_r2062667568
##
be/test/util/uuid_generator_test.cpp:
##
@@ -0,0 +1,170 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
@dolfinus Added fe ut
doris-robot commented on PR #50126:
URL: https://github.com/apache/doris/pull/50126#issuecomment-2833513267
TPC-H: Total hot run time: 34056 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
felixwluo commented on PR #50126:
URL: https://github.com/apache/doris/pull/50126#issuecomment-2833527438
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
doris-robot commented on PR #50126:
URL: https://github.com/apache/doris/pull/50126#issuecomment-2833518084
TPC-DS: Total hot run time: 192131 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #50126:
URL: https://github.com/apache/doris/pull/50126#issuecomment-2833520030
ClickBench: Total hot run time: 29.94 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
felixwluo commented on code in PR #50126:
URL: https://github.com/apache/doris/pull/50126#discussion_r2062635993
##
be/test/util/uuid_generator_test.cpp:
##
@@ -0,0 +1,170 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
OK
--
This is an
dolfinus commented on code in PR #50126:
URL: https://github.com/apache/doris/pull/50126#discussion_r2062632745
##
be/test/util/uuid_generator_test.cpp:
##
@@ -0,0 +1,170 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
Could you please add t
felixwluo commented on PR #50126:
URL: https://github.com/apache/doris/pull/50126#issuecomment-2833464991
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
felixwluo commented on PR #50126:
URL: https://github.com/apache/doris/pull/50126#issuecomment-2833464227
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
dolfinus commented on code in PR #50126:
URL: https://github.com/apache/doris/pull/50126#discussion_r2062603957
##
be/src/util/uuid_generator.h:
##
@@ -17,18 +17,74 @@
#pragma once
+#include
#include
#include
#include
+#include
+#include
#include
+#include
na
dolfinus commented on PR #50126:
URL: https://github.com/apache/doris/pull/50126#issuecomment-2833414310
BTW, doesn't new classes need any tests? E.g. that every time UUID is
generated it is monotonically increasing, and that random part is always new,
not static.
--
This is an automated
dolfinus commented on code in PR #50126:
URL: https://github.com/apache/doris/pull/50126#discussion_r2062602744
##
be/src/util/uuid_generator.h:
##
@@ -17,18 +17,89 @@
#pragma once
+#include
#include
#include
#include
+#include
+#include
#include
+#include
na
dolfinus commented on code in PR #50126:
URL: https://github.com/apache/doris/pull/50126#discussion_r2055476682
##
be/src/util/uuid_generator.h:
##
@@ -17,18 +17,74 @@
#pragma once
+#include
#include
#include
#include
+#include
+#include
#include
+#include
na
HappenLee commented on code in PR #50126:
URL: https://github.com/apache/doris/pull/50126#discussion_r2055467437
##
be/src/util/uuid_generator.h:
##
@@ -17,18 +17,74 @@
#pragma once
+#include
#include
#include
#include
+#include
+#include
#include
+#include
n
hello-stephen commented on PR #50126:
URL: https://github.com/apache/doris/pull/50126#issuecomment-2822149051
# BE Regression P0 && UT Coverage Report
Increment line coverage `100.00% (30/30)` :tada:
[Increment coverage
report](http://coverage.selectdb-in.cc/coverage/50126_4190be14
doris-robot commented on PR #50126:
URL: https://github.com/apache/doris/pull/50126#issuecomment-2821637042
# BE UT Coverage Report
Increment line coverage `100.00% (28/28)` :tada:
[Increment coverage
report](http://coverage.selectdb-in.cc/coverage/4190be14312634b95ba1cbb4edcf1af8a
doris-robot commented on PR #50126:
URL: https://github.com/apache/doris/pull/50126#issuecomment-2821429314
ClickBench: Total hot run time: 29.77 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #50126:
URL: https://github.com/apache/doris/pull/50126#issuecomment-2821412886
TPC-DS: Total hot run time: 191996 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #50126:
URL: https://github.com/apache/doris/pull/50126#issuecomment-2821376025
TPC-H: Total hot run time: 33816 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
github-actions[bot] commented on PR #50126:
URL: https://github.com/apache/doris/pull/50126#issuecomment-2821092381
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
felixwluo commented on PR #50126:
URL: https://github.com/apache/doris/pull/50126#issuecomment-2821083199
> LTGM, but there are 2 open comments about class description, please take a
look.
Thanks. done
--
This is an automated message from the Apache Git Service.
To respond to the m
felixwluo commented on PR #50126:
URL: https://github.com/apache/doris/pull/50126#issuecomment-2821081807
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
dolfinus commented on PR #50126:
URL: https://github.com/apache/doris/pull/50126#issuecomment-2818393358
LTGM, but there are 2 open commends about class description, please take a
look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
felixwluo commented on code in PR #50126:
URL: https://github.com/apache/doris/pull/50126#discussion_r2050729861
##
fe/fe-core/src/main/java/org/apache/doris/common/UUIDv7Generator.java:
##
@@ -0,0 +1,64 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or mo
dolfinus commented on code in PR #50126:
URL: https://github.com/apache/doris/pull/50126#discussion_r205022
##
be/src/util/uuid_generator.h:
##
@@ -17,18 +17,85 @@
#pragma once
+#include
#include
#include
#include
+#include
+#include
#include
+#include
na
felixwluo commented on code in PR #50126:
URL: https://github.com/apache/doris/pull/50126#discussion_r2050331527
##
fe/fe-core/src/main/java/org/apache/doris/common/UUIDv7Generator.java:
##
@@ -0,0 +1,64 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or mo
dolfinus commented on code in PR #50126:
URL: https://github.com/apache/doris/pull/50126#discussion_r205022
##
be/src/util/uuid_generator.h:
##
@@ -17,18 +17,85 @@
#pragma once
+#include
#include
#include
#include
+#include
+#include
#include
+#include
na
dolfinus commented on code in PR #50126:
URL: https://github.com/apache/doris/pull/50126#discussion_r2050332119
##
fe/fe-core/src/main/java/org/apache/doris/common/UUIDv7Generator.java:
##
@@ -0,0 +1,64 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or mor
felixwluo commented on code in PR #50126:
URL: https://github.com/apache/doris/pull/50126#discussion_r2050322668
##
fe/fe-core/src/main/java/org/apache/doris/common/UUIDv7Generator.java:
##
@@ -0,0 +1,64 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or mo
dolfinus commented on code in PR #50126:
URL: https://github.com/apache/doris/pull/50126#discussion_r205022
##
be/src/util/uuid_generator.h:
##
@@ -17,18 +17,85 @@
#pragma once
+#include
#include
#include
#include
+#include
+#include
#include
+#include
na
dolfinus commented on code in PR #50126:
URL: https://github.com/apache/doris/pull/50126#discussion_r2050301615
##
fe/fe-core/src/main/java/org/apache/doris/common/UUIDv7Generator.java:
##
@@ -0,0 +1,64 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or mor
dolfinus commented on code in PR #50126:
URL: https://github.com/apache/doris/pull/50126#discussion_r2050278029
##
be/src/util/uuid_generator.h:
##
@@ -17,18 +17,74 @@
#pragma once
+#include
#include
#include
#include
+#include
+#include
#include
+#include
na
felixwluo commented on code in PR #50126:
URL: https://github.com/apache/doris/pull/50126#discussion_r2049010343
##
be/src/util/uuid_generator.h:
##
@@ -17,18 +17,74 @@
#pragma once
+#include
#include
#include
#include
+#include
+#include
#include
+#include
n
doris-robot commented on PR #50126:
URL: https://github.com/apache/doris/pull/50126#issuecomment-2812309659
# BE UT Coverage Report
Increment line coverage `100.00% (27/27)` :tada:
[Increment coverage
report](http://coverage.selectdb-in.cc/coverage/d1bbab6490cdcfa72f93888dd8cd2ea9c
dolfinus commented on code in PR #50126:
URL: https://github.com/apache/doris/pull/50126#discussion_r2048489465
##
be/src/util/uuid_generator.h:
##
@@ -17,18 +17,74 @@
#pragma once
+#include
#include
#include
#include
+#include
+#include
#include
+#include
na
doris-robot commented on PR #50126:
URL: https://github.com/apache/doris/pull/50126#issuecomment-2812121050
ClickBench: Total hot run time: 29.31 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #50126:
URL: https://github.com/apache/doris/pull/50126#issuecomment-2812110166
TPC-DS: Total hot run time: 193903 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #50126:
URL: https://github.com/apache/doris/pull/50126#issuecomment-2812084336
TPC-H: Total hot run time: 33772 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
felixwluo commented on PR #50126:
URL: https://github.com/apache/doris/pull/50126#issuecomment-2811854523
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
72 matches
Mail list logo
