Re: [PR] [enhancement](function) change some function nullable mode [doris]

2024-02-09 Thread via GitHub
doris-robot commented on PR #30991: URL: https://github.com/apache/doris/pull/30991#issuecomment-1935623578 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit 47c7e3f5fa770df25fe6bb60c1ca796d9127c9a9 with default session variables Stream

Re: [PR] [enhancement](function) change some function nullable mode [doris]

2024-02-09 Thread via GitHub
doris-robot commented on PR #30991: URL: https://github.com/apache/doris/pull/30991#issuecomment-1935619377 ClickBench: Total hot run time: 30.67 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [enhancement](function) change some function nullable mode [doris]

2024-02-09 Thread via GitHub
doris-robot commented on PR #30991: URL: https://github.com/apache/doris/pull/30991#issuecomment-1935611634 TPC-DS: Total hot run time: 180505 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [enhancement](function) change some function nullable mode [doris]

2024-02-09 Thread via GitHub
doris-robot commented on PR #30991: URL: https://github.com/apache/doris/pull/30991#issuecomment-1935595836 TeamCity be ut coverage result: Function Coverage: 35.85% (8560/23875) Line Coverage: 27.78% (69461/250079) Region Coverage: 26.91% (36036/133915) Branch Coverage: 23.6

Re: [PR] [enhancement](function) change some function nullable mode [doris]

2024-02-09 Thread via GitHub
doris-robot commented on PR #30991: URL: https://github.com/apache/doris/pull/30991#issuecomment-1935596530 TPC-H: Total hot run time: 41145 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [enhancement](function) change some function nullable mode [doris]

2024-02-09 Thread via GitHub
github-actions[bot] commented on PR #30991: URL: https://github.com/apache/doris/pull/30991#issuecomment-1935559809 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [enhancement](function) change some function nullable mode [doris]

2024-02-09 Thread via GitHub
koarz commented on PR #30991: URL: https://github.com/apache/doris/pull/30991#issuecomment-1935553649 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [PR] [enhancement](function) change some function nullable mode [doris]

2024-02-08 Thread via GitHub
doris-robot commented on PR #30991: URL: https://github.com/apache/doris/pull/30991#issuecomment-1934643126 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit 4f881f65da74d8047b009fb7b0525a34526109f9 with default session variables Stream

Re: [PR] [enhancement](function) change some function nullable mode [doris]

2024-02-08 Thread via GitHub
doris-robot commented on PR #30991: URL: https://github.com/apache/doris/pull/30991#issuecomment-1934638549 ClickBench: Total hot run time: 31.6 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools C

Re: [PR] [enhancement](function) change some function nullable mode [doris]

2024-02-08 Thread via GitHub
doris-robot commented on PR #30991: URL: https://github.com/apache/doris/pull/30991#issuecomment-1934630345 TPC-DS: Total hot run time: 180932 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [enhancement](function) change some function nullable mode [doris]

2024-02-08 Thread via GitHub
doris-robot commented on PR #30991: URL: https://github.com/apache/doris/pull/30991#issuecomment-1934626768 TeamCity be ut coverage result: Function Coverage: 35.84% (8560/23881) Line Coverage: 27.77% (69467/250140) Region Coverage: 26.90% (36035/133942) Branch Coverage: 23.6

Re: [PR] [enhancement](function) change some function nullable mode [doris]

2024-02-08 Thread via GitHub
doris-robot commented on PR #30991: URL: https://github.com/apache/doris/pull/30991#issuecomment-1934612742 TPC-H: Total hot run time: 41638 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [enhancement](function) change some function nullable mode [doris]

2024-02-08 Thread via GitHub
koarz commented on PR #30991: URL: https://github.com/apache/doris/pull/30991#issuecomment-1934561606 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [PR] [enhancement](function) change some function nullable mode [doris]

2024-02-08 Thread via GitHub
zclllyybb commented on code in PR #30991: URL: https://github.com/apache/doris/pull/30991#discussion_r1483299619 ## be/src/agent/be_exec_version_manager.h: ## @@ -65,6 +65,7 @@ class BeExecVersionManager { *d. unix_timestamp function support timestamp with float for dateti

Re: [PR] [enhancement](function) change some function nullable mode [doris]

2024-02-08 Thread via GitHub
doris-robot commented on PR #30991: URL: https://github.com/apache/doris/pull/30991#issuecomment-1934423774 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit 60e81e94379af7d292ae65da66593242adf9e7f4 with default session variables Stream

Re: [PR] [enhancement](function) change some function nullable mode [doris]

2024-02-08 Thread via GitHub
doris-robot commented on PR #30991: URL: https://github.com/apache/doris/pull/30991#issuecomment-1934417567 ClickBench: Total hot run time: 30.22 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [enhancement](function) change some function nullable mode [doris]

2024-02-08 Thread via GitHub
doris-robot commented on PR #30991: URL: https://github.com/apache/doris/pull/30991#issuecomment-1934405989 TPC-DS: Total hot run time: 180865 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [enhancement](function) change some function nullable mode [doris]

2024-02-08 Thread via GitHub
doris-robot commented on PR #30991: URL: https://github.com/apache/doris/pull/30991#issuecomment-1934391117 TeamCity be ut coverage result: Function Coverage: 35.84% (8559/23881) Line Coverage: 27.78% (69478/250140) Region Coverage: 26.91% (36044/133942) Branch Coverage: 23.6

Re: [PR] [enhancement](function) change some function nullable mode [doris]

2024-02-08 Thread via GitHub
doris-robot commented on PR #30991: URL: https://github.com/apache/doris/pull/30991#issuecomment-1934383266 TPC-H: Total hot run time: 41420 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [enhancement](function) change some function nullable mode [doris]

2024-02-08 Thread via GitHub
koarz commented on PR #30991: URL: https://github.com/apache/doris/pull/30991#issuecomment-1934287102 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [enhancement](function) change some function nullable mode [doris]

2024-02-08 Thread via GitHub
koarz commented on PR #30991: URL: https://github.com/apache/doris/pull/30991#issuecomment-1934279989 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [PR] [enhancement](function) change some function nullable mode [doris]

2024-02-08 Thread via GitHub
koarz commented on PR #30991: URL: https://github.com/apache/doris/pull/30991#issuecomment-1934273109 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [PR] [enhancement](function) change some function nullable mode [doris]

2024-02-08 Thread via GitHub
doris-robot commented on PR #30991: URL: https://github.com/apache/doris/pull/30991#issuecomment-1934244660 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit 2fb8693e3748879ca5d37f98b7146d69ccce050a with default session variables Stream

Re: [PR] [enhancement](function) change some function nullable mode [doris]

2024-02-08 Thread via GitHub
doris-robot commented on PR #30991: URL: https://github.com/apache/doris/pull/30991#issuecomment-1934238599 ClickBench: Total hot run time: 31.35 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [enhancement](function) change some function nullable mode [doris]

2024-02-08 Thread via GitHub
doris-robot commented on PR #30991: URL: https://github.com/apache/doris/pull/30991#issuecomment-1934227043 TPC-DS: Total hot run time: 179995 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [enhancement](function) change some function nullable mode [doris]

2024-02-08 Thread via GitHub
doris-robot commented on PR #30991: URL: https://github.com/apache/doris/pull/30991#issuecomment-1934203257 TPC-H: Total hot run time: 41452 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [enhancement](function) change some function nullable mode [doris]

2024-02-08 Thread via GitHub
koarz commented on PR #30991: URL: https://github.com/apache/doris/pull/30991#issuecomment-1934139312 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [PR] [enhancement](function) change some function nullable mode [doris]

2024-02-08 Thread via GitHub
koarz commented on PR #30991: URL: https://github.com/apache/doris/pull/30991#issuecomment-1934105632 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [PR] [enhancement](function) change some function nullable mode [doris]

2024-02-07 Thread via GitHub
github-actions[bot] commented on code in PR #30991: URL: https://github.com/apache/doris/pull/30991#discussion_r1482486267 ## be/src/vec/functions/function_string.cpp: ## @@ -756,7 +879,89 @@ struct ToBase64Impl { } }; -struct FromBase64Impl { +class FunctionFromBase64 :

Re: [PR] [enhancement](function) change some function nullable mode [doris]

2024-02-07 Thread via GitHub
koarz commented on PR #30991: URL: https://github.com/apache/doris/pull/30991#issuecomment-1933457915 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [PR] [enhancement](function) change some function nullable mode [doris]

2024-02-07 Thread via GitHub
doris-robot commented on PR #30991: URL: https://github.com/apache/doris/pull/30991#issuecomment-1933455730 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

[PR] [enhancement](function) change some function nullable mode [doris]

2024-02-07 Thread via GitHub
koarz opened a new pull request, #30991: URL: https://github.com/apache/doris/pull/30991 ## Proposed changes Issue Number: close #27435 change some function nullable mode, and change function unhex ,to_base64, from_base64,will return empty string when input empty strin