Re: [PR] [enhancement](cloud) add table version to cloud [doris]

2024-04-07 Thread via GitHub
gavinchou commented on code in PR #32738: URL: https://github.com/apache/doris/pull/32738#discussion_r1554843782 ## fe/fe-core/src/main/java/org/apache/doris/cloud/datasource/CloudInternalCatalog.java: ## @@ -657,7 +663,7 @@ private void dropCloudPartition(long dbId, long tableI

Re: [PR] [enhancement](cloud) add table version to cloud [doris]

2024-03-28 Thread via GitHub
xy720 commented on code in PR #32738: URL: https://github.com/apache/doris/pull/32738#discussion_r1542943461 ## fe/fe-core/src/main/java/org/apache/doris/cloud/qe/SnapshotProxy.java: ## @@ -0,0 +1,92 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more c

Re: [PR] [enhancement](cloud) add table version to cloud [doris]

2024-03-27 Thread via GitHub
gavinchou commented on code in PR #32738: URL: https://github.com/apache/doris/pull/32738#discussion_r1542288556 ## fe/fe-core/src/main/java/org/apache/doris/common/profile/SummaryProfile.java: ## @@ -115,6 +118,8 @@ public class SummaryProfile { builder.put(GET_PARTITI

Re: [PR] [enhancement](cloud) add table version to cloud [doris]

2024-03-27 Thread via GitHub
xy720 merged PR #32738: URL: https://github.com/apache/doris/pull/32738 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache

Re: [PR] [enhancement](cloud) add table version to cloud [doris]

2024-03-27 Thread via GitHub
xy720 commented on code in PR #32738: URL: https://github.com/apache/doris/pull/32738#discussion_r1542276210 ## fe/fe-core/src/main/java/org/apache/doris/cloud/qe/SnapshotProxy.java: ## @@ -0,0 +1,92 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more c

Re: [PR] [enhancement](cloud) add table version to cloud [doris]

2024-03-27 Thread via GitHub
xy720 commented on code in PR #32738: URL: https://github.com/apache/doris/pull/32738#discussion_r1542275426 ## cloud/test/recycler_test.cpp: ## @@ -309,6 +309,21 @@ static int create_version_kv(TxnKv* txn_kv, int64_t table_id, int64_t partition_ return 0; } +static int

Re: [PR] [enhancement](cloud) add table version to cloud [doris]

2024-03-27 Thread via GitHub
w41ter commented on code in PR #32738: URL: https://github.com/apache/doris/pull/32738#discussion_r1542269744 ## fe/fe-core/src/main/java/org/apache/doris/cloud/qe/SnapshotProxy.java: ## @@ -0,0 +1,92 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

Re: [PR] [enhancement](cloud) add table version to cloud [doris]

2024-03-27 Thread via GitHub
github-actions[bot] commented on PR #32738: URL: https://github.com/apache/doris/pull/32738#issuecomment-2024329490 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [enhancement](cloud) add table version to cloud [doris]

2024-03-27 Thread via GitHub
xy720 commented on PR #32738: URL: https://github.com/apache/doris/pull/32738#issuecomment-2022240093 run cloud_p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [PR] [enhancement](cloud) add table version to cloud [doris]

2024-03-27 Thread via GitHub
github-actions[bot] commented on PR #32738: URL: https://github.com/apache/doris/pull/32738#issuecomment-2022179605 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [enhancement](cloud) add table version to cloud [doris]

2024-03-27 Thread via GitHub
doris-robot commented on PR #32738: URL: https://github.com/apache/doris/pull/32738#issuecomment-2022128701 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit 6500edf590df7ea38526cd0cb97ce34890710b66 with default session variables Stream

Re: [PR] [enhancement](cloud) add table version to cloud [doris]

2024-03-27 Thread via GitHub
doris-robot commented on PR #32738: URL: https://github.com/apache/doris/pull/32738#issuecomment-2022118645 TPC-DS: Total hot run time: 181855 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [enhancement](cloud) add table version to cloud [doris]

2024-03-27 Thread via GitHub
doris-robot commented on PR #32738: URL: https://github.com/apache/doris/pull/32738#issuecomment-2022104665 TPC-H: Total hot run time: 38040 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [enhancement](cloud) add table version to cloud [doris]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #32738: URL: https://github.com/apache/doris/pull/32738#issuecomment-2022050515 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [enhancement](cloud) add table version to cloud [doris]

2024-03-26 Thread via GitHub
xy720 commented on PR #32738: URL: https://github.com/apache/doris/pull/32738#issuecomment-2022045829 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [PR] [enhancement](cloud) add table version to cloud [doris]

2024-03-26 Thread via GitHub
xy720 commented on PR #32738: URL: https://github.com/apache/doris/pull/32738#issuecomment-2021847861 run cloud_p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [PR] [enhancement](cloud) add table version to cloud [doris]

2024-03-26 Thread via GitHub
doris-robot commented on PR #32738: URL: https://github.com/apache/doris/pull/32738#issuecomment-2021572182 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit a2ec83e9f3dfd1c67652f65b91e5770c861da439 with default session variables Stream

Re: [PR] [enhancement](cloud) add table version to cloud [doris]

2024-03-26 Thread via GitHub
doris-robot commented on PR #32738: URL: https://github.com/apache/doris/pull/32738#issuecomment-2021562836 TPC-DS: Total hot run time: 181778 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [enhancement](cloud) add table version to cloud [doris]

2024-03-26 Thread via GitHub
doris-robot commented on PR #32738: URL: https://github.com/apache/doris/pull/32738#issuecomment-2021549233 TPC-H: Total hot run time: 37932 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [enhancement](cloud) add table version to cloud [doris]

2024-03-26 Thread via GitHub
xy720 commented on PR #32738: URL: https://github.com/apache/doris/pull/32738#issuecomment-2021493957 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [PR] [enhancement](cloud) add table version to cloud [doris]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #32738: URL: https://github.com/apache/doris/pull/32738#issuecomment-2021467768 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [enhancement](cloud) add table version to cloud [doris]

2024-03-26 Thread via GitHub
platoneko commented on code in PR #32738: URL: https://github.com/apache/doris/pull/32738#discussion_r1538715168 ## cloud/src/meta-service/meta_service_partition.cpp: ## @@ -166,9 +166,9 @@ void MetaServiceImpl::commit_index(::google::protobuf::RpcController* controller }

Re: [PR] [enhancement](cloud) add table version to cloud [doris]

2024-03-26 Thread via GitHub
doris-robot commented on PR #32738: URL: https://github.com/apache/doris/pull/32738#issuecomment-2019739771 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit 8a3ea4470aa9b2b057881af6c86095772911608c with default session variables Stream

Re: [PR] [enhancement](cloud) add table version to cloud [doris]

2024-03-26 Thread via GitHub
doris-robot commented on PR #32738: URL: https://github.com/apache/doris/pull/32738#issuecomment-2019712251 TPC-DS: Total hot run time: 181406 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [enhancement](cloud) add table version to cloud [doris]

2024-03-26 Thread via GitHub
doris-robot commented on PR #32738: URL: https://github.com/apache/doris/pull/32738#issuecomment-2019608717 TPC-H: Total hot run time: 37923 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [enhancement](cloud) add table version to cloud [doris]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #32738: URL: https://github.com/apache/doris/pull/32738#issuecomment-2019528356 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [enhancement](cloud) add table version to cloud [doris]

2024-03-25 Thread via GitHub
xy720 commented on PR #32738: URL: https://github.com/apache/doris/pull/32738#issuecomment-2019522625 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [PR] [enhancement](cloud) add table version to cloud [doris]

2024-03-25 Thread via GitHub
github-actions[bot] commented on PR #32738: URL: https://github.com/apache/doris/pull/32738#issuecomment-2019443229 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [enhancement](cloud) add table version to cloud [doris]

2024-03-25 Thread via GitHub
xy720 commented on PR #32738: URL: https://github.com/apache/doris/pull/32738#issuecomment-2019437884 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [PR] [enhancement](cloud) add table version to cloud [doris]

2024-03-25 Thread via GitHub
github-actions[bot] commented on PR #32738: URL: https://github.com/apache/doris/pull/32738#issuecomment-2019359689 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [enhancement](cloud) add table version to cloud [doris]

2024-03-25 Thread via GitHub
xy720 commented on code in PR #32738: URL: https://github.com/apache/doris/pull/32738#discussion_r1538567698 ## fe/fe-core/src/main/java/org/apache/doris/catalog/OlapTable.java: ## @@ -2666,11 +2671,45 @@ public void updateVisibleVersionAndTime(long visibleVersion, long visible

Re: [PR] [enhancement](cloud) add table version to cloud [doris]

2024-03-25 Thread via GitHub
xy720 commented on PR #32738: URL: https://github.com/apache/doris/pull/32738#issuecomment-2019358230 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [PR] [enhancement](cloud) add table version to cloud [doris]

2024-03-25 Thread via GitHub
gavinchou commented on code in PR #32738: URL: https://github.com/apache/doris/pull/32738#discussion_r1537104327 ## fe/fe-core/src/main/java/org/apache/doris/catalog/OlapTable.java: ## @@ -2666,11 +2671,45 @@ public void updateVisibleVersionAndTime(long visibleVersion, long vis

Re: [PR] [enhancement](cloud) add table version to cloud [doris]

2024-03-24 Thread via GitHub
doris-robot commented on PR #32738: URL: https://github.com/apache/doris/pull/32738#issuecomment-2017288265 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit b118fc6fe94fce746ef05315860abbb0d9eca766 with default session variables Stream

Re: [PR] [enhancement](cloud) add table version to cloud [doris]

2024-03-24 Thread via GitHub
doris-robot commented on PR #32738: URL: https://github.com/apache/doris/pull/32738#issuecomment-2017285094 TPC-DS: Total hot run time: 185760 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [enhancement](cloud) add table version to cloud [doris]

2024-03-24 Thread via GitHub
doris-robot commented on PR #32738: URL: https://github.com/apache/doris/pull/32738#issuecomment-2017275007 TPC-H: Total hot run time: 38518 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [enhancement](cloud) add table version to cloud [doris]

2024-03-24 Thread via GitHub
xy720 commented on PR #32738: URL: https://github.com/apache/doris/pull/32738#issuecomment-2017237945 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [PR] [enhancement](cloud) add table version to cloud [doris]

2024-03-24 Thread via GitHub
github-actions[bot] commented on PR #32738: URL: https://github.com/apache/doris/pull/32738#issuecomment-2017189066 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [enhancement](cloud) add table version to cloud [doris]

2024-03-24 Thread via GitHub
github-actions[bot] commented on PR #32738: URL: https://github.com/apache/doris/pull/32738#issuecomment-2016969691 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [enhancement](cloud) add table version to cloud [doris]

2024-03-24 Thread via GitHub
doris-robot commented on PR #32738: URL: https://github.com/apache/doris/pull/32738#issuecomment-2016968273 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

[PR] [enhancement](cloud) add table version to cloud [doris]

2024-03-24 Thread via GitHub
xy720 opened a new pull request, #32738: URL: https://github.com/apache/doris/pull/32738 ## Proposed changes Add table version to cloud. In Fe: Get: If Fe is cloud mode, get table version from meta service. Update: Op drop/replace temp partition, commit transaction.