Re: [PR] [enhance](io) Set segment file size to rowset meta [doris]

2024-03-13 Thread via GitHub
dataroaring merged PR #31853: URL: https://github.com/apache/doris/pull/31853 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.

Re: [PR] [enhance](io) Set segment file size to rowset meta [doris]

2024-03-13 Thread via GitHub
github-actions[bot] commented on PR #31853: URL: https://github.com/apache/doris/pull/31853#issuecomment-1996327162 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [enhance](io) Set segment file size to rowset meta [doris]

2024-03-13 Thread via GitHub
doris-robot commented on PR #31853: URL: https://github.com/apache/doris/pull/31853#issuecomment-1993960938 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit c6a80d63b84a5f923fde7987aafcfa5c3248b993 with default session variables Stream

Re: [PR] [enhance](io) Set segment file size to rowset meta [doris]

2024-03-13 Thread via GitHub
doris-robot commented on PR #31853: URL: https://github.com/apache/doris/pull/31853#issuecomment-1993955569 ClickBench: Total hot run time: 30.12 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [enhance](io) Set segment file size to rowset meta [doris]

2024-03-13 Thread via GitHub
doris-robot commented on PR #31853: URL: https://github.com/apache/doris/pull/31853#issuecomment-1993925924 TPC-DS: Total hot run time: 187572 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [enhance](io) Set segment file size to rowset meta [doris]

2024-03-13 Thread via GitHub
doris-robot commented on PR #31853: URL: https://github.com/apache/doris/pull/31853#issuecomment-1993905972 TeamCity be ut coverage result: Function Coverage: 35.00% (8573/24492) Line Coverage: 26.75% (69449/259620) Region Coverage: 26.02% (36068/138605) Branch Coverage: 22.9

Re: [PR] [enhance](io) Set segment file size to rowset meta [doris]

2024-03-13 Thread via GitHub
doris-robot commented on PR #31853: URL: https://github.com/apache/doris/pull/31853#issuecomment-1993896254 TPC-H: Total hot run time: 36800 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [enhance](io) Set segment file size to rowset meta [doris]

2024-03-13 Thread via GitHub
platoneko commented on PR #31853: URL: https://github.com/apache/doris/pull/31853#issuecomment-1993801944 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [enhance](io) Set segment file size to rowset meta [doris]

2024-03-13 Thread via GitHub
platoneko commented on PR #31853: URL: https://github.com/apache/doris/pull/31853#issuecomment-1993768869 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [enhance](io) Set segment file size to rowset meta [doris]

2024-03-07 Thread via GitHub
doris-robot commented on PR #31853: URL: https://github.com/apache/doris/pull/31853#issuecomment-1985216075 TeamCity be ut coverage result: Function Coverage: 35.37% (8553/24183) Line Coverage: 27.14% (69497/256104) Region Coverage: 26.36% (36079/136849) Branch Coverage: 23.2

Re: [PR] [enhance](io) Set segment file size to rowset meta [doris]

2024-03-07 Thread via GitHub
platoneko commented on PR #31853: URL: https://github.com/apache/doris/pull/31853#issuecomment-1985128911 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [enhance](io) Set segment file size to rowset meta [doris]

2024-03-07 Thread via GitHub
platoneko commented on PR #31853: URL: https://github.com/apache/doris/pull/31853#issuecomment-1985118860 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [enhance](io) Set segment file size to rowset meta [doris]

2024-03-07 Thread via GitHub
platoneko commented on PR #31853: URL: https://github.com/apache/doris/pull/31853#issuecomment-1985097193 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [enhance](io) Set segment file size to rowset meta [doris]

2024-03-06 Thread via GitHub
doris-robot commented on PR #31853: URL: https://github.com/apache/doris/pull/31853#issuecomment-1980902317 TeamCity be ut coverage result: Function Coverage: 35.40% (8557/24169) Line Coverage: 27.15% (69463/255855) Region Coverage: 26.38% (36043/136648) Branch Coverage: 23.2

Re: [PR] [enhance](io) Set segment file size to rowset meta [doris]

2024-03-06 Thread via GitHub
platoneko commented on PR #31853: URL: https://github.com/apache/doris/pull/31853#issuecomment-1980767003 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [enhance](io) Set segment file size to rowset meta [doris]

2024-03-06 Thread via GitHub
github-actions[bot] commented on PR #31853: URL: https://github.com/apache/doris/pull/31853#issuecomment-1980475093 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [enhance](io) Set segment file size to rowset meta [doris]

2024-03-06 Thread via GitHub
gavinchou commented on code in PR #31853: URL: https://github.com/apache/doris/pull/31853#discussion_r1514051381 ## be/src/olap/rowset/beta_rowset_writer.cpp: ## @@ -664,6 +739,13 @@ Status BaseBetaRowsetWriter::_build_rowset_meta(RowsetMeta* rowset_meta, bool ch // TODO w

Re: [PR] [enhance](io) Set segment file size to rowset meta [doris]

2024-03-06 Thread via GitHub
platoneko commented on PR #31853: URL: https://github.com/apache/doris/pull/31853#issuecomment-1980290828 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [enhance](io) Set segment file size to rowset meta [doris]

2024-03-06 Thread via GitHub
platoneko commented on PR #31853: URL: https://github.com/apache/doris/pull/31853#issuecomment-1980285293 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [enhance](io) Set segment file size to rowset meta [doris]

2024-03-05 Thread via GitHub
doris-robot commented on PR #31853: URL: https://github.com/apache/doris/pull/31853#issuecomment-1980284542 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

[PR] [enhance](io) Set segment file size to rowset meta [doris]

2024-03-05 Thread via GitHub
platoneko opened a new pull request, #31853: URL: https://github.com/apache/doris/pull/31853 ## Proposed changes Set segment file size to rowset meta, to avoid the IO of fetching file meta info ## Further comments If this is a relatively large or complex change, kick off