Re: [PR] [bugfix]json_length() BE crash fix [doris]

2024-03-19 Thread via GitHub
xiaokang commented on PR #32145: URL: https://github.com/apache/doris/pull/32145#issuecomment-2006858282 @rohitrs1983 I've picked it to branch-2.0 as #32484 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] [bugfix]json_length() BE crash fix [doris]

2024-03-14 Thread via GitHub
cambyzju commented on PR #32145: URL: https://github.com/apache/doris/pull/32145#issuecomment-1998869606 @rohitrs1983 could you also fix this problem on branch-2.0 ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [bugfix]json_length() BE crash fix [doris]

2024-03-14 Thread via GitHub
yiguolei merged PR #32145: URL: https://github.com/apache/doris/pull/32145 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

Re: [PR] [bugfix]json_length() BE crash fix [doris]

2024-03-13 Thread via GitHub
doris-robot commented on PR #32145: URL: https://github.com/apache/doris/pull/32145#issuecomment-1994100890 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit 3c62ebe28fffd4eb4f1d8d634be9700c01c0995d with default session variables Stream

Re: [PR] [bugfix]json_length() BE crash fix [doris]

2024-03-13 Thread via GitHub
doris-robot commented on PR #32145: URL: https://github.com/apache/doris/pull/32145#issuecomment-1994095470 ClickBench: Total hot run time: 29.33 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [bugfix]json_length() BE crash fix [doris]

2024-03-13 Thread via GitHub
doris-robot commented on PR #32145: URL: https://github.com/apache/doris/pull/32145#issuecomment-1994085826 TPC-DS: Total hot run time: 186750 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [bugfix]json_length() BE crash fix [doris]

2024-03-13 Thread via GitHub
doris-robot commented on PR #32145: URL: https://github.com/apache/doris/pull/32145#issuecomment-1994085123 TeamCity be ut coverage result: Function Coverage: 35.01% (8576/24499) Line Coverage: 26.76% (69475/259623) Region Coverage: 26.03% (36081/138609) Branch Coverage: 22.9

Re: [PR] [bugfix]json_length() BE crash fix [doris]

2024-03-13 Thread via GitHub
doris-robot commented on PR #32145: URL: https://github.com/apache/doris/pull/32145#issuecomment-1994062509 TPC-H: Total hot run time: 36970 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [bugfix]json_length() BE crash fix [doris]

2024-03-13 Thread via GitHub
yiguolei commented on PR #32145: URL: https://github.com/apache/doris/pull/32145#issuecomment-1994020618 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [bugfix]json_length() BE crash fix [doris]

2024-03-12 Thread via GitHub
github-actions[bot] commented on PR #32145: URL: https://github.com/apache/doris/pull/32145#issuecomment-1993664767 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [bugfix]json_length() BE crash fix [doris]

2024-03-12 Thread via GitHub
github-actions[bot] commented on PR #32145: URL: https://github.com/apache/doris/pull/32145#issuecomment-1993664803 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [bugfix]json_length() BE crash fix [doris]

2024-03-12 Thread via GitHub
rohitrs1983 commented on code in PR #32145: URL: https://github.com/apache/doris/pull/32145#discussion_r1522199340 ## be/src/vec/functions/function_jsonb.cpp: ## @@ -1097,10 +1097,15 @@ struct JsonbLengthUtil { } } auto jsonb_value = js

Re: [PR] [bugfix]json_length() BE crash fix [doris]

2024-03-12 Thread via GitHub
yiguolei commented on code in PR #32145: URL: https://github.com/apache/doris/pull/32145#discussion_r1521497768 ## be/src/vec/functions/function_jsonb.cpp: ## @@ -1097,10 +1097,15 @@ struct JsonbLengthUtil { } } auto jsonb_value = jsonb

Re: [PR] [bugfix]json_length() BE crash fix [doris]

2024-03-12 Thread via GitHub
doris-robot commented on PR #32145: URL: https://github.com/apache/doris/pull/32145#issuecomment-1991611672 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

[PR] [bugfix]json_length() BE crash fix [doris]

2024-03-12 Thread via GitHub
rohitrs1983 opened a new pull request, #32145: URL: https://github.com/apache/doris/pull/32145 ## Proposed changes Issue Number: close #32124 ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](