Re: [PR] [Refactor](Rf) refactor the code of runtime filter [doris]

2024-01-25 Thread via GitHub
HappenLee merged PR #30268: URL: https://github.com/apache/doris/pull/30268 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

Re: [PR] [Refactor](Rf) refactor the code of runtime filter [doris]

2024-01-25 Thread via GitHub
github-actions[bot] commented on PR #30268: URL: https://github.com/apache/doris/pull/30268#issuecomment-1911293307 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [Refactor](Rf) refactor the code of runtime filter [doris]

2024-01-25 Thread via GitHub
doris-robot commented on PR #30268: URL: https://github.com/apache/doris/pull/30268#issuecomment-1909968794 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit dc007e4025818f6a68257f2d763d6841fbc7d55d with default session variables Stream

Re: [PR] [Refactor](Rf) refactor the code of runtime filter [doris]

2024-01-25 Thread via GitHub
doris-robot commented on PR #30268: URL: https://github.com/apache/doris/pull/30268#issuecomment-1909963212 ClickBench: Total hot run time: 29.79 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [Refactor](Rf) refactor the code of runtime filter [doris]

2024-01-25 Thread via GitHub
doris-robot commented on PR #30268: URL: https://github.com/apache/doris/pull/30268#issuecomment-1909953846 TPC-DS: Total hot run time: 186440 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Refactor](Rf) refactor the code of runtime filter [doris]

2024-01-25 Thread via GitHub
doris-robot commented on PR #30268: URL: https://github.com/apache/doris/pull/30268#issuecomment-1909932611 TPC-H: Total hot run time: 38831 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [Refactor](Rf) refactor the code of runtime filter [doris]

2024-01-25 Thread via GitHub
github-actions[bot] commented on PR #30268: URL: https://github.com/apache/doris/pull/30268#issuecomment-1909855976 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [Refactor](Rf) refactor the code of runtime filter [doris]

2024-01-25 Thread via GitHub
github-actions[bot] commented on PR #30268: URL: https://github.com/apache/doris/pull/30268#issuecomment-1909853642 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [Refactor](Rf) refactor the code of runtime filter [doris]

2024-01-25 Thread via GitHub
github-actions[bot] commented on code in PR #30268: URL: https://github.com/apache/doris/pull/30268#discussion_r1466157679 ## be/src/runtime/runtime_filter_mgr.cpp: ## @@ -54,21 +54,15 @@ struct AsyncRPCContext { RuntimeFilterMgr::RuntimeFilterMgr(const UniqueId& query_id, Run

Re: [PR] [Refactor](Rf) refactor the code of runtime filter [doris]

2024-01-25 Thread via GitHub
HappenLee commented on PR #30268: URL: https://github.com/apache/doris/pull/30268#issuecomment-1909842282 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [Refactor](Rf) refactor the code of runtime filter [doris]

2024-01-25 Thread via GitHub
github-actions[bot] commented on PR #30268: URL: https://github.com/apache/doris/pull/30268#issuecomment-1909656364 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [Refactor](Rf) refactor the code of runtime filter [doris]

2024-01-25 Thread via GitHub
github-actions[bot] commented on PR #30268: URL: https://github.com/apache/doris/pull/30268#issuecomment-1909656311 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [Refactor](Rf) refactor the code of runtime filter [doris]

2024-01-24 Thread via GitHub
yiguolei commented on code in PR #30268: URL: https://github.com/apache/doris/pull/30268#discussion_r1465903091 ## be/src/runtime/fragment_mgr.cpp: ## @@ -786,7 +786,7 @@ Status FragmentMgr::exec_plan_fragment(const TExecPlanFragmentParams& params, std::shared_ptr handler;

Re: [PR] [Refactor](Rf) refactor the code of runtime filter [doris]

2024-01-23 Thread via GitHub
BiteThet commented on code in PR #30268: URL: https://github.com/apache/doris/pull/30268#discussion_r1464249926 ## be/src/runtime/fragment_mgr.cpp: ## @@ -786,7 +786,7 @@ Status FragmentMgr::exec_plan_fragment(const TExecPlanFragmentParams& params, std::shared_ptr hand

Re: [PR] [Refactor](Rf) refactor the code of runtime filter [doris]

2024-01-23 Thread via GitHub
doris-robot commented on PR #30268: URL: https://github.com/apache/doris/pull/30268#issuecomment-1905957696 TeamCity be ut coverage result: Function Coverage: 36.77% (8667/23573) Line Coverage: 28.72% (70712/246199) Region Coverage: 27.61% (36451/132006) Branch Coverage: 24.3

Re: [PR] [Refactor](Rf) refactor the code of runtime filter [doris]

2024-01-23 Thread via GitHub
doris-robot commented on PR #30268: URL: https://github.com/apache/doris/pull/30268#issuecomment-1905955182 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit dc007e4025818f6a68257f2d763d6841fbc7d55d with default session variables Stream

Re: [PR] [Refactor](Rf) refactor the code of runtime filter [doris]

2024-01-23 Thread via GitHub
doris-robot commented on PR #30268: URL: https://github.com/apache/doris/pull/30268#issuecomment-1905949400 ClickBench: Total hot run time: 30.13 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [Refactor](Rf) refactor the code of runtime filter [doris]

2024-01-23 Thread via GitHub
doris-robot commented on PR #30268: URL: https://github.com/apache/doris/pull/30268#issuecomment-1905937140 TPC-DS: Total hot run time: 186937 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Refactor](Rf) refactor the code of runtime filter [doris]

2024-01-23 Thread via GitHub
doris-robot commented on PR #30268: URL: https://github.com/apache/doris/pull/30268#issuecomment-1905898464 TPC-H: Total hot run time: 38797 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [Refactor](Rf) refactor the code of runtime filter [doris]

2024-01-23 Thread via GitHub
github-actions[bot] commented on PR #30268: URL: https://github.com/apache/doris/pull/30268#issuecomment-1905838264 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [Refactor](Rf) refactor the code of runtime filter [doris]

2024-01-23 Thread via GitHub
HappenLee commented on PR #30268: URL: https://github.com/apache/doris/pull/30268#issuecomment-1905825810 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [Refactor](Rf) refactor the code of runtime filter [doris]

2024-01-23 Thread via GitHub
doris-robot commented on PR #30268: URL: https://github.com/apache/doris/pull/30268#issuecomment-1905609829 TeamCity be ut coverage result: Function Coverage: 36.71% (8665/23605) Line Coverage: 28.72% (70728/246230) Region Coverage: 27.61% (36455/132038) Branch Coverage: 24.3

Re: [PR] [Refactor](Rf) refactor the code of runtime filter [doris]

2024-01-23 Thread via GitHub
github-actions[bot] commented on PR #30268: URL: https://github.com/apache/doris/pull/30268#issuecomment-1905563526 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [Refactor](Rf) refactor the code of runtime filter [doris]

2024-01-23 Thread via GitHub
HappenLee commented on PR #30268: URL: https://github.com/apache/doris/pull/30268#issuecomment-1905547653 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[PR] [Refactor](Rf) refactor the code of runtime filter [doris]

2024-01-23 Thread via GitHub
HappenLee opened a new pull request, #30268: URL: https://github.com/apache/doris/pull/30268 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailt