eldenmoon merged PR #33890:
URL: https://github.com/apache/doris/pull/33890
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.ap
github-actions[bot] commented on PR #33890:
URL: https://github.com/apache/doris/pull/33890#issuecomment-2105510993
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
xiaokang commented on code in PR #33890:
URL: https://github.com/apache/doris/pull/33890#discussion_r1597340669
##
be/src/vec/columns/column_object.cpp:
##
@@ -808,6 +876,33 @@ const ColumnObject::Subcolumn*
ColumnObject::get_subcolumn(const PathInData& key
return &node->d
github-actions[bot] commented on PR #33890:
URL: https://github.com/apache/doris/pull/33890#issuecomment-2100380604
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
eldenmoon commented on PR #33890:
URL: https://github.com/apache/doris/pull/33890#issuecomment-2100370390
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
doris-robot commented on PR #33890:
URL: https://github.com/apache/doris/pull/33890#issuecomment-2097388369
TPC-DS: Total hot run time: 186465 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
eldenmoon commented on PR #33890:
URL: https://github.com/apache/doris/pull/33890#issuecomment-2097259183
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
eldenmoon commented on code in PR #33890:
URL: https://github.com/apache/doris/pull/33890#discussion_r1591724105
##
be/src/vec/common/schema_util.cpp:
##
@@ -114,31 +114,8 @@ bool is_conversion_required_between_integers(const
IDataType& lhs, const IDataTy
WhichDataType whi
doris-robot commented on PR #33890:
URL: https://github.com/apache/doris/pull/33890#issuecomment-2095229443
TPC-DS: Total hot run time: 186136 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
github-actions[bot] commented on code in PR #33890:
URL: https://github.com/apache/doris/pull/33890#discussion_r1590514076
##
be/src/vec/columns/column_object.cpp:
##
@@ -207,8 +266,10 @@ class FieldVisitorToScalarType : public
StaticVisitor {
type_indexes.insert(TypeI
eldenmoon commented on PR #33890:
URL: https://github.com/apache/doris/pull/33890#issuecomment-2095159411
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
eldenmoon commented on code in PR #33890:
URL: https://github.com/apache/doris/pull/33890#discussion_r1590508484
##
be/src/vec/columns/column_object.cpp:
##
@@ -308,18 +399,29 @@ void ColumnObject::Subcolumn::insert(Field field,
FieldInfo info) {
value_dim = 0;
eldenmoon commented on code in PR #33890:
URL: https://github.com/apache/doris/pull/33890#discussion_r1590508250
##
be/src/vec/columns/column_object.cpp:
##
@@ -148,6 +151,84 @@ class FieldVisitorToNumberOfDimensions : public
StaticVisitor {
}
};
+// Visitor that allows
xiaokang commented on code in PR #33890:
URL: https://github.com/apache/doris/pull/33890#discussion_r1590200381
##
be/src/vec/columns/column_object.cpp:
##
@@ -148,6 +151,84 @@ class FieldVisitorToNumberOfDimensions : public
StaticVisitor {
}
};
+// Visitor that allows
xiaokang commented on code in PR #33890:
URL: https://github.com/apache/doris/pull/33890#discussion_r1590199297
##
be/src/vec/common/schema_util.cpp:
##
@@ -114,31 +114,8 @@ bool is_conversion_required_between_integers(const
IDataType& lhs, const IDataTy
WhichDataType whic
eldenmoon commented on PR #33890:
URL: https://github.com/apache/doris/pull/33890#issuecomment-2073868440
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
doris-robot commented on PR #33890:
URL: https://github.com/apache/doris/pull/33890#issuecomment-2069161068
ClickBench: Total hot run time: 30.09 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #33890:
URL: https://github.com/apache/doris/pull/33890#issuecomment-2069150521
TPC-DS: Total hot run time: 185062 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #33890:
URL: https://github.com/apache/doris/pull/33890#issuecomment-2069127833
TPC-H: Total hot run time: 38584 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
eldenmoon commented on PR #33890:
URL: https://github.com/apache/doris/pull/33890#issuecomment-2068970975
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
doris-robot commented on PR #33890:
URL: https://github.com/apache/doris/pull/33890#issuecomment-2068620404
ClickBench: Total hot run time: 30.78 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #33890:
URL: https://github.com/apache/doris/pull/33890#issuecomment-2068612449
TPC-DS: Total hot run time: 185387 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #33890:
URL: https://github.com/apache/doris/pull/33890#issuecomment-2068596037
TPC-H: Total hot run time: 38735 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
eldenmoon commented on PR #33890:
URL: https://github.com/apache/doris/pull/33890#issuecomment-2068551354
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
doris-robot commented on PR #33890:
URL: https://github.com/apache/doris/pull/33890#issuecomment-2068501096
ClickBench: Total hot run time: 30.4 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
C
doris-robot commented on PR #33890:
URL: https://github.com/apache/doris/pull/33890#issuecomment-2068496177
TPC-DS: Total hot run time: 185295 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #33890:
URL: https://github.com/apache/doris/pull/33890#issuecomment-2068486171
TPC-H: Total hot run time: 38587 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
eldenmoon commented on PR #33890:
URL: https://github.com/apache/doris/pull/33890#issuecomment-2068420143
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
github-actions[bot] commented on PR #33890:
URL: https://github.com/apache/doris/pull/33890#issuecomment-2068040436
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
doris-robot commented on PR #33890:
URL: https://github.com/apache/doris/pull/33890#issuecomment-2066221655
TPC-H: Total hot run time: 38846 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
github-actions[bot] commented on code in PR #33890:
URL: https://github.com/apache/doris/pull/33890#discussion_r1572029446
##
be/src/vec/columns/column_object.cpp:
##
@@ -148,6 +151,84 @@ class FieldVisitorToNumberOfDimensions : public
StaticVisitor {
}
};
+// Visitor t
eldenmoon commented on PR #33890:
URL: https://github.com/apache/doris/pull/33890#issuecomment-2066070135
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
doris-robot commented on PR #33890:
URL: https://github.com/apache/doris/pull/33890#issuecomment-2066069695
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y
33 matches
Mail list logo
