Re: [PR] [Opt](expr) Opt decimal comparsion expr. [doris]

2023-12-18 Thread via GitHub
yiguolei merged PR #28551: URL: https://github.com/apache/doris/pull/28551 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

Re: [PR] [Opt](expr) Opt decimal comparsion expr. [doris]

2023-12-18 Thread via GitHub
github-actions[bot] commented on PR #28551: URL: https://github.com/apache/doris/pull/28551#issuecomment-1860022955 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [Opt](expr) Opt decimal comparsion expr. [doris]

2023-12-17 Thread via GitHub
doris-robot commented on PR #28551: URL: https://github.com/apache/doris/pull/28551#issuecomment-1859697553 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 44.96 seconds stream load tsv: 577 seconds loaded 74807831229 Bytes,

Re: [PR] [Opt](expr) Opt decimal comparsion expr. [doris]

2023-12-17 Thread via GitHub
doris-robot commented on PR #28551: URL: https://github.com/apache/doris/pull/28551#issuecomment-1859690328 TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Tpch sf100 test result on commit 9f0228d9e42ff8876fb9b602ba3719b7651ac0c4, data reload: false run tpc

Re: [PR] [Opt](expr) Opt decimal comparsion expr. [doris]

2023-12-17 Thread via GitHub
yiguolei commented on PR #28551: URL: https://github.com/apache/doris/pull/28551#issuecomment-1859645251 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [Opt](expr) Opt decimal comparsion expr. [doris]

2023-12-17 Thread via GitHub
doris-robot commented on PR #28551: URL: https://github.com/apache/doris/pull/28551#issuecomment-1859603301 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 44.63 seconds stream load tsv: 594 seconds loaded 74807831229 Bytes,

Re: [PR] [Opt](expr) Opt decimal comparsion expr. [doris]

2023-12-17 Thread via GitHub
doris-robot commented on PR #28551: URL: https://github.com/apache/doris/pull/28551#issuecomment-1859599717 TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Tpch sf100 test result on commit 3c7bf32810dcdfdac488994348112ec7f1b18909, data reload: false run tpc

Re: [PR] [Opt](expr) Opt decimal comparsion expr. [doris]

2023-12-17 Thread via GitHub
github-actions[bot] commented on PR #28551: URL: https://github.com/apache/doris/pull/28551#issuecomment-1859596773 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [Opt](expr) Opt decimal comparsion expr. [doris]

2023-12-17 Thread via GitHub
github-actions[bot] commented on PR #28551: URL: https://github.com/apache/doris/pull/28551#issuecomment-1859596743 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [Opt](expr) Opt decimal comparsion expr. [doris]

2023-12-17 Thread via GitHub
github-actions[bot] commented on PR #28551: URL: https://github.com/apache/doris/pull/28551#issuecomment-1859582245 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [Opt](expr) Opt decimal comparsion expr. [doris]

2023-12-17 Thread via GitHub
kaka11chen commented on PR #28551: URL: https://github.com/apache/doris/pull/28551#issuecomment-1859576534 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] [Opt](expr) Opt decimal comparsion expr. [doris]

2023-12-17 Thread via GitHub
morningman merged PR #28496: URL: https://github.com/apache/doris/pull/28496 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.a

Re: [PR] [Opt](expr) Opt decimal comparsion expr. [doris]

2023-12-15 Thread via GitHub
github-actions[bot] commented on PR #28496: URL: https://github.com/apache/doris/pull/28496#issuecomment-1857782535 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [Opt](expr) Opt decimal comparsion expr. [doris]

2023-12-15 Thread via GitHub
github-actions[bot] commented on code in PR #28496: URL: https://github.com/apache/doris/pull/28496#discussion_r1427895559 ## be/src/vec/core/decimal_comparison.h: ## @@ -217,6 +215,7 @@ class DecimalComparison { LOG(FATAL) << "Wrong column in Decimal compar

[PR] [Opt](expr) Opt decimal comparsion expr. [doris]

2023-12-15 Thread via GitHub
kaka11chen opened a new pull request, #28496: URL: https://github.com/apache/doris/pull/28496 ## Proposed changes TPCH 19: 7.6 s to 6.47 s. ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...