Re: [PR] [Improve](datatype) change check_column to check data type [doris]

2023-10-23 Thread via GitHub
eldenmoon merged PR #25466: URL: https://github.com/apache/doris/pull/25466 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

Re: [PR] [Improve](datatype) change check_column to check data type [doris]

2023-10-23 Thread via GitHub
github-actions[bot] commented on PR #25466: URL: https://github.com/apache/doris/pull/25466#issuecomment-1774887721 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [Improve](datatype) change check_column to check data type [doris]

2023-10-19 Thread via GitHub
amorynan commented on PR #25466: URL: https://github.com/apache/doris/pull/25466#issuecomment-1772134818 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

Re: [PR] [Improve](datatype) change check_column to check data type [doris]

2023-10-19 Thread via GitHub
doris-robot commented on PR #25466: URL: https://github.com/apache/doris/pull/25466#issuecomment-1772064040 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.26 seconds stream load tsv: 575 seconds loaded 74807831229 Bytes,

Re: [PR] [Improve](datatype) change check_column to check data type [doris]

2023-10-19 Thread via GitHub
doris-robot commented on PR #25466: URL: https://github.com/apache/doris/pull/25466#issuecomment-1772059553 TeamCity be ut coverage result: Function Coverage: 36.97% (8283/22405) Line Coverage: 29.07% (66458/228622) Region Coverage: 27.73% (34506/124430) Branch Coverage: 24.3

Re: [PR] [Improve](datatype) change check_column to check data type [doris]

2023-10-19 Thread via GitHub
amorynan commented on PR #25466: URL: https://github.com/apache/doris/pull/25466#issuecomment-1772041284 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [Improve](datatype) change check_column to check data type [doris]

2023-10-19 Thread via GitHub
github-actions[bot] commented on PR #25466: URL: https://github.com/apache/doris/pull/25466#issuecomment-1772007047 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [Improve](datatype) change check_column to check data type [doris]

2023-10-18 Thread via GitHub
amorynan commented on PR #25466: URL: https://github.com/apache/doris/pull/25466#issuecomment-1768086342 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

Re: [PR] [Improve](datatype) change check_column to check data type [doris]

2023-10-16 Thread via GitHub
doris-robot commented on PR #25466: URL: https://github.com/apache/doris/pull/25466#issuecomment-1764701531 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.68 seconds stream load tsv: 553 seconds loaded 74807831229 Bytes,

Re: [PR] [Improve](datatype) change check_column to check data type [doris]

2023-10-16 Thread via GitHub
doris-robot commented on PR #25466: URL: https://github.com/apache/doris/pull/25466#issuecomment-1764658871 TeamCity be ut coverage result: Function Coverage: 37.02% (8283/22377) Line Coverage: 29.05% (66435/228689) Region Coverage: 27.73% (34465/124271) Branch Coverage: 24.3

Re: [PR] [Improve](datatype) change check_column to check data type [doris]

2023-10-16 Thread via GitHub
github-actions[bot] commented on PR #25466: URL: https://github.com/apache/doris/pull/25466#issuecomment-1764528684 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [Improve](datatype) change check_column to check data type [doris]

2023-10-16 Thread via GitHub
amorynan commented on PR #25466: URL: https://github.com/apache/doris/pull/25466#issuecomment-1764491351 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [Improve](datatype) change check_column to check data type [doris]

2023-10-16 Thread via GitHub
doris-robot commented on PR #25466: URL: https://github.com/apache/doris/pull/25466#issuecomment-1764113480 TeamCity be ut coverage result: Function Coverage: 36.69% (8228/22423) Line Coverage: 28.85% (65964/228626) Region Coverage: 27.55% (34209/124158) Branch Coverage: 24.2

Re: [PR] [Improve](datatype) change check_column to check data type [doris]

2023-10-16 Thread via GitHub
doris-robot commented on PR #25466: URL: https://github.com/apache/doris/pull/25466#issuecomment-1764110359 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.33 seconds stream load tsv: 550 seconds loaded 74807831229 Bytes,

Re: [PR] [Improve](datatype) change check_column to check data type [doris]

2023-10-16 Thread via GitHub
github-actions[bot] commented on PR #25466: URL: https://github.com/apache/doris/pull/25466#issuecomment-1764042218 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [Improve](datatype) change check_column to check data type [doris]

2023-10-16 Thread via GitHub
amorynan commented on PR #25466: URL: https://github.com/apache/doris/pull/25466#issuecomment-1764027480 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [Improve](datatype) change check_column to check data type [doris]

2023-10-16 Thread via GitHub
github-actions[bot] commented on PR #25466: URL: https://github.com/apache/doris/pull/25466#issuecomment-1764007091 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [Improve](datatype) change check_column to check data type [doris]

2023-10-16 Thread via GitHub
github-actions[bot] commented on PR #25466: URL: https://github.com/apache/doris/pull/25466#issuecomment-1764006945 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [Improve](datatype) change check_column to check data type [doris]

2023-10-16 Thread via GitHub
doris-robot commented on PR #25466: URL: https://github.com/apache/doris/pull/25466#issuecomment-1763895216 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.38 seconds stream load tsv: 572 seconds loaded 74807831229 Bytes,

Re: [PR] [Improve](datatype) change check_column to check data type [doris]

2023-10-16 Thread via GitHub
github-actions[bot] commented on PR #25466: URL: https://github.com/apache/doris/pull/25466#issuecomment-1763857035 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [Improve](datatype) change check_column to check data type [doris]

2023-10-15 Thread via GitHub
amorynan commented on PR #25466: URL: https://github.com/apache/doris/pull/25466#issuecomment-1763847438 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[PR] [Improve](datatype) change check_column to check data type [doris]

2023-10-15 Thread via GitHub
amorynan opened a new pull request, #25466: URL: https://github.com/apache/doris/pull/25466 ## Proposed changes Issue Number: close #xxx In functions exec we always use check_column to predict current branch , but it's wrong way to do this, because if we has two datatype but use sa