Re: [PR] [Feature-WIP](pipeline) Trace pipeline scheduling [doris]

2024-02-21 Thread via GitHub
github-actions[bot] commented on code in PR #31027: URL: https://github.com/apache/doris/pull/31027#discussion_r1497149297 ## be/src/util/thrift_util.h: ## @@ -17,26 +17,24 @@ #pragma once -#include -#include +#include Review Comment: warning: 'gen_cpp/DataSinks_type

Re: [PR] [Feature-WIP](pipeline) Trace pipeline scheduling [doris]

2024-02-21 Thread via GitHub
github-actions[bot] commented on code in PR #31027: URL: https://github.com/apache/doris/pull/31027#discussion_r1497134845 ## be/src/util/thrift_util.h: ## @@ -17,26 +17,24 @@ #pragma once -#include -#include +#include Review Comment: warning: 'gen_cpp/Types_types.h'

Re: [PR] [Feature-WIP](pipeline) Trace pipeline scheduling [doris]

2024-02-21 Thread via GitHub
zclllyybb commented on PR #31027: URL: https://github.com/apache/doris/pull/31027#issuecomment-1956181898 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [Feature-WIP](pipeline) Trace pipeline scheduling [doris]

2024-02-21 Thread via GitHub
zclllyybb commented on PR #31027: URL: https://github.com/apache/doris/pull/31027#issuecomment-1956164293 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [Feature-WIP](pipeline) Trace pipeline scheduling [doris]

2024-02-21 Thread via GitHub
zclllyybb commented on PR #31027: URL: https://github.com/apache/doris/pull/31027#issuecomment-1956160975 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [Feature-WIP](pipeline) Trace pipeline scheduling [doris]

2024-02-20 Thread via GitHub
github-actions[bot] commented on PR #31027: URL: https://github.com/apache/doris/pull/31027#issuecomment-1955988086 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [Feature-WIP](pipeline) Trace pipeline scheduling [doris]

2024-02-20 Thread via GitHub
github-actions[bot] commented on PR #31027: URL: https://github.com/apache/doris/pull/31027#issuecomment-1955988046 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [Feature-WIP](pipeline) Trace pipeline scheduling [doris]

2024-02-20 Thread via GitHub
github-actions[bot] commented on code in PR #31027: URL: https://github.com/apache/doris/pull/31027#discussion_r1496821671 ## be/src/pipeline/pipeline_tracing.h: ## @@ -0,0 +1,82 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license ag

Re: [PR] [Feature-WIP](pipeline) Trace pipeline scheduling [doris]

2024-02-20 Thread via GitHub
zclllyybb commented on PR #31027: URL: https://github.com/apache/doris/pull/31027#issuecomment-1955788259 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [Feature-WIP](pipeline) Trace pipeline scheduling [doris]

2024-02-20 Thread via GitHub
zclllyybb commented on PR #31027: URL: https://github.com/apache/doris/pull/31027#issuecomment-1955746702 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [Feature-WIP](pipeline) Trace pipeline scheduling [doris]

2024-02-20 Thread via GitHub
doris-robot commented on PR #31027: URL: https://github.com/apache/doris/pull/31027#issuecomment-1954804966 TeamCity be ut coverage result: Function Coverage: 35.74% (8558/23942) Line Coverage: 27.70% (69409/250587) Region Coverage: 26.81% (36014/134306) Branch Coverage: 23.6

Re: [PR] [Feature-WIP](pipeline) Trace pipeline scheduling [doris]

2024-02-20 Thread via GitHub
github-actions[bot] commented on code in PR #31027: URL: https://github.com/apache/doris/pull/31027#discussion_r1496180989 ## be/src/util/thrift_util.h: ## @@ -17,26 +17,23 @@ #pragma once -#include -#include +#include Review Comment: warning: 'gen_cpp/Types_types.h'

Re: [PR] [Feature-WIP](pipeline) Trace pipeline scheduling [doris]

2024-02-20 Thread via GitHub
zclllyybb commented on PR #31027: URL: https://github.com/apache/doris/pull/31027#issuecomment-1954632913 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [Feature-WIP](pipeline) Trace pipeline scheduling [doris]

2024-02-20 Thread via GitHub
zclllyybb commented on code in PR #31027: URL: https://github.com/apache/doris/pull/31027#discussion_r1496133730 ## be/src/exec/data_sink.cpp: ## @@ -54,6 +54,24 @@ std::shared_ptr DataSink::get_query_statistics_ptr() { return _query_statistics; } +static bool _has_inve

Re: [PR] [Feature-WIP](pipeline) Trace pipeline scheduling [doris]

2024-02-16 Thread via GitHub
github-actions[bot] commented on code in PR #31027: URL: https://github.com/apache/doris/pull/31027#discussion_r1492767621 ## be/src/pipeline/pipeline_fragment_context.h: ## @@ -19,13 +19,11 @@ #include Review Comment: warning: 'gen_cpp/Types_types.h' file not found [cla

Re: [PR] [Feature-WIP](pipeline) Trace pipeline scheduling [doris]

2024-02-14 Thread via GitHub
github-actions[bot] commented on code in PR #31027: URL: https://github.com/apache/doris/pull/31027#discussion_r1489513482 ## be/src/io/fs/file_system.h: ## @@ -19,8 +19,8 @@ #include Review Comment: warning: 'butil/macros.h' file not found [clang-diagnostic-error] ``