Re: [PR] [FIX]fix is_ip_address_in_range func with const param [doris]

2024-05-07 Thread via GitHub
HappenLee merged PR #34266: URL: https://github.com/apache/doris/pull/34266 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

Re: [PR] [FIX]fix is_ip_address_in_range func with const param [doris]

2024-05-05 Thread via GitHub
github-actions[bot] commented on PR #34266: URL: https://github.com/apache/doris/pull/34266#issuecomment-2095123015 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [FIX]fix is_ip_address_in_range func with const param [doris]

2024-05-05 Thread via GitHub
github-actions[bot] commented on PR #34266: URL: https://github.com/apache/doris/pull/34266#issuecomment-2095122990 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [FIX]fix is_ip_address_in_range func with const param [doris]

2024-05-04 Thread via GitHub
doris-robot commented on PR #34266: URL: https://github.com/apache/doris/pull/34266#issuecomment-2094636088 TPC-DS: Total hot run time: 186972 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [FIX]fix is_ip_address_in_range func with const param [doris]

2024-05-04 Thread via GitHub
doris-robot commented on PR #34266: URL: https://github.com/apache/doris/pull/34266#issuecomment-2094615665 TeamCity be ut coverage result: Function Coverage: 35.71% (8975/25133) Line Coverage: 27.33% (74091/271123) Region Coverage: 26.53% (38301/144350) Branch Coverage: 23.2

Re: [PR] [FIX]fix is_ip_address_in_range func with const param [doris]

2024-05-04 Thread via GitHub
sjyango commented on PR #34266: URL: https://github.com/apache/doris/pull/34266#issuecomment-2094576681 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [FIX]fix is_ip_address_in_range func with const param [doris]

2024-05-04 Thread via GitHub
github-actions[bot] commented on PR #34266: URL: https://github.com/apache/doris/pull/34266#issuecomment-2094576621 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [FIX]fix is_ip_address_in_range func with const param [doris]

2024-05-04 Thread via GitHub
github-actions[bot] commented on PR #34266: URL: https://github.com/apache/doris/pull/34266#issuecomment-2094576501 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [FIX]fix is_ip_address_in_range func with const param [doris]

2024-04-29 Thread via GitHub
zclllyybb commented on code in PR #34266: URL: https://github.com/apache/doris/pull/34266#discussion_r1582668269 ## regression-test/suites/query_p0/sql_functions/ip_functions/test_is_ip_address_in_range_function.groovy: ## Review Comment: don't add regression for this but b

Re: [PR] [FIX]fix is_ip_address_in_range func with const param [doris]

2024-04-28 Thread via GitHub
doris-robot commented on PR #34266: URL: https://github.com/apache/doris/pull/34266#issuecomment-2081559723 TPC-DS: Total hot run time: 188352 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [FIX]fix is_ip_address_in_range func with const param [doris]

2024-04-28 Thread via GitHub
github-actions[bot] commented on PR #34266: URL: https://github.com/apache/doris/pull/34266#issuecomment-2081541736 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [FIX]fix is_ip_address_in_range func with const param [doris]

2024-04-28 Thread via GitHub
sjyango commented on PR #34266: URL: https://github.com/apache/doris/pull/34266#issuecomment-2081541677 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [FIX]fix is_ip_address_in_range func with const param [doris]

2024-04-28 Thread via GitHub
github-actions[bot] commented on PR #34266: URL: https://github.com/apache/doris/pull/34266#issuecomment-2081541302 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [FIX]fix is_ip_address_in_range func with const param [doris]

2024-04-28 Thread via GitHub
doris-robot commented on PR #34266: URL: https://github.com/apache/doris/pull/34266#issuecomment-2081540125 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

[PR] [FIX]fix is_ip_address_in_range func with const param [doris]

2024-04-28 Thread via GitHub
sjyango opened a new pull request, #34266: URL: https://github.com/apache/doris/pull/34266 ## Proposed changes Issue Number: close #xxx - before this pr: ```shell mysql> select id, is_ip_address_in_range(addr, '192.168.100.0/24') from test_is_ip_address_in_range_funct