Re: [PR] [Enhancement] add information_schema.table_options(#32572) [doris-website]

2024-08-02 Thread via GitHub
Vallishp commented on PR #661: URL: https://github.com/apache/doris-website/pull/661#issuecomment-2266377629 closing this, raise another PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] [Enhancement] add information_schema.table_options(#32572) [doris-website]

2024-08-02 Thread via GitHub
Vallishp closed pull request #661: [Enhancement] add information_schema.table_options(#32572) URL: https://github.com/apache/doris-website/pull/661 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] [Enhancement] add information_schema.table_options(#32572) [doris]

2024-05-27 Thread via GitHub
yiguolei merged PR #34384: URL: https://github.com/apache/doris/pull/34384 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

Re: [PR] [Enhancement] add information_schema.table_options(#32572) [doris]

2024-05-27 Thread via GitHub
github-actions[bot] commented on PR #34384: URL: https://github.com/apache/doris/pull/34384#issuecomment-2134256141 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [Enhancement] add information_schema.table_options(#32572) [doris]

2024-05-27 Thread via GitHub
doris-robot commented on PR #34384: URL: https://github.com/apache/doris/pull/34384#issuecomment-2133760929 ClickBench: Total hot run time: 30.32 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [Enhancement] add information_schema.table_options(#32572) [doris]

2024-05-27 Thread via GitHub
doris-robot commented on PR #34384: URL: https://github.com/apache/doris/pull/34384#issuecomment-2133757698 TeamCity be ut coverage result: Function Coverage: 35.76% (9009/25196) Line Coverage: 27.36% (74566/272546) Region Coverage: 26.58% (38577/145145) Branch Coverage: 23.4

Re: [PR] [Enhancement] add information_schema.table_options(#32572) [doris]

2024-05-27 Thread via GitHub
doris-robot commented on PR #34384: URL: https://github.com/apache/doris/pull/34384#issuecomment-2133745290 TPC-DS: Total hot run time: 172383 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Enhancement] add information_schema.table_options(#32572) [doris]

2024-05-27 Thread via GitHub
doris-robot commented on PR #34384: URL: https://github.com/apache/doris/pull/34384#issuecomment-2133720693 TPC-H: Total hot run time: 40198 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [Enhancement] add information_schema.table_options(#32572) [doris]

2024-05-27 Thread via GitHub
Vallishp commented on PR #34384: URL: https://github.com/apache/doris/pull/34384#issuecomment-2133597975 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [Enhancement] add information_schema.table_options(#32572) [doris]

2024-05-27 Thread via GitHub
xinyiZzz commented on PR #34384: URL: https://github.com/apache/doris/pull/34384#issuecomment-2132985274 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [Enhancement] add information_schema.table_options(#32572) [doris]

2024-05-27 Thread via GitHub
xinyiZzz commented on PR #34384: URL: https://github.com/apache/doris/pull/34384#issuecomment-2132983908 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [Enhancement] add information_schema.table_options(#32572) [doris]

2024-05-27 Thread via GitHub
github-actions[bot] commented on PR #34384: URL: https://github.com/apache/doris/pull/34384#issuecomment-2132980690 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [Enhancement] add information_schema.table_options(#32572) [doris]

2024-05-25 Thread via GitHub
Vallishp commented on code in PR #34384: URL: https://github.com/apache/doris/pull/34384#discussion_r1614713794 ## be/src/exec/schema_scanner/schema_table_options_scanner.cpp: ## @@ -0,0 +1,134 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contrib

Re: [PR] [Enhancement] add information_schema.table_options(#32572) [doris]

2024-05-17 Thread via GitHub
gavinchou commented on code in PR #34384: URL: https://github.com/apache/doris/pull/34384#discussion_r1604470422 ## be/src/exec/schema_scanner/schema_table_options_scanner.cpp: ## @@ -0,0 +1,134 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contri

Re: [PR] [Enhancement] add information_schema.table_options(#32572) [doris]

2024-05-17 Thread via GitHub
gavinchou commented on code in PR #34384: URL: https://github.com/apache/doris/pull/34384#discussion_r1604463773 ## fe/fe-core/src/main/java/org/apache/doris/tablefunction/MetadataGenerator.java: ## @@ -873,4 +892,75 @@ private static TFetchSchemaTableDataResult routineInfoMeta

Re: [PR] [Enhancement] add information_schema.table_options(#32572) [doris]

2024-05-17 Thread via GitHub
gavinchou commented on code in PR #34384: URL: https://github.com/apache/doris/pull/34384#discussion_r1604462412 ## fe/fe-core/src/main/java/org/apache/doris/tablefunction/MetadataGenerator.java: ## @@ -873,4 +892,75 @@ private static TFetchSchemaTableDataResult routineInfoMeta

Re: [PR] [Enhancement] add information_schema.table_options(#32572) [doris]

2024-05-15 Thread via GitHub
Vallishp commented on PR #34384: URL: https://github.com/apache/doris/pull/34384#issuecomment-2113978675 > Please add the document in doris-website and link 2 prs. https://github.com/apache/doris-website/pull/661 handled all, pls help to review again -- This is an automated m

[PR] [Enhancement] add information_schema.table_options(#32572) [doris-website]

2024-05-15 Thread via GitHub
Vallishp opened a new pull request, #661: URL: https://github.com/apache/doris-website/pull/661 add document for information_schema.table_options table. code PR https://github.com/apache/doris/pull/34384 -- This is an automated message from the Apache Git Service. To respond to the mess

Re: [PR] [Enhancement] add information_schema.table_options(#32572) [doris]

2024-05-15 Thread via GitHub
doris-robot commented on PR #34384: URL: https://github.com/apache/doris/pull/34384#issuecomment-2112651487 TeamCity be ut coverage result: Function Coverage: 35.70% (8997/25204) Line Coverage: 27.37% (74455/272023) Region Coverage: 26.60% (38484/144654) Branch Coverage: 23.4

Re: [PR] [Enhancement] add information_schema.table_options(#32572) [doris]

2024-05-15 Thread via GitHub
doris-robot commented on PR #34384: URL: https://github.com/apache/doris/pull/34384#issuecomment-2112593614 ClickBench: Total hot run time: 30.53 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [Enhancement] add information_schema.table_options(#32572) [doris]

2024-05-15 Thread via GitHub
doris-robot commented on PR #34384: URL: https://github.com/apache/doris/pull/34384#issuecomment-2112577199 TPC-DS: Total hot run time: 187821 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Enhancement] add information_schema.table_options(#32572) [doris]

2024-05-15 Thread via GitHub
doris-robot commented on PR #34384: URL: https://github.com/apache/doris/pull/34384#issuecomment-2112541080 TPC-H: Total hot run time: 40387 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [Enhancement] add information_schema.table_options(#32572) [doris]

2024-05-15 Thread via GitHub
Vallishp commented on PR #34384: URL: https://github.com/apache/doris/pull/34384#issuecomment-2112391543 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [Enhancement] add information_schema.table_options(#32572) [doris]

2024-05-07 Thread via GitHub
Vallishp commented on code in PR #34384: URL: https://github.com/apache/doris/pull/34384#discussion_r1592822440 ## be/src/exec/schema_scanner/schema_table_options_scanner.cpp: ## @@ -0,0 +1,132 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contrib

Re: [PR] [Enhancement] add information_schema.table_options(#32572) [doris]

2024-05-07 Thread via GitHub
Vallishp commented on PR #34384: URL: https://github.com/apache/doris/pull/34384#issuecomment-2098928985 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [Enhancement] add information_schema.table_options(#32572) [doris]

2024-05-07 Thread via GitHub
github-actions[bot] commented on code in PR #34384: URL: https://github.com/apache/doris/pull/34384#discussion_r1592807658 ## be/src/exec/schema_scanner/schema_table_options_scanner.cpp: ## @@ -0,0 +1,134 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or m

Re: [PR] [Enhancement] add information_schema.table_options(#32572) [doris]

2024-05-07 Thread via GitHub
gavinchou commented on code in PR #34384: URL: https://github.com/apache/doris/pull/34384#discussion_r1591743514 ## be/src/exec/schema_scanner/schema_table_options_scanner.cpp: ## @@ -0,0 +1,132 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contri

Re: [PR] [Enhancement] add information_schema.table_options(#32572) [doris]

2024-05-06 Thread via GitHub
dataroaring commented on PR #34384: URL: https://github.com/apache/doris/pull/34384#issuecomment-2097316002 > > great job. BTW, should we put properties in json format? > > Ok. can you please give me example for any column we print in json format as reference? thanks properties

Re: [PR] [Enhancement] add information_schema.table_options(#32572) [doris]

2024-05-06 Thread via GitHub
Vallishp commented on PR #34384: URL: https://github.com/apache/doris/pull/34384#issuecomment-2096276939 > great job. BTW, should we put properties in json format? Ok. can you please give me example for any column we print in json format as reference? thanks -- This is an automate

Re: [PR] [Enhancement] add information_schema.table_options(#32572) [doris]

2024-05-06 Thread via GitHub
Vallishp commented on PR #34384: URL: https://github.com/apache/doris/pull/34384#issuecomment-2096229963 > DISTRIBUTE_KEY, TABLE_MODEL(agg unique, dup) DISTRIBUTE_KEY already have added. TABLE_MODEL(agg unique, dup) i will add this. Actually, we should show all messages in c

Re: [PR] [Enhancement] add information_schema.table_options(#32572) [doris]

2024-05-06 Thread via GitHub
Vallishp commented on PR #34384: URL: https://github.com/apache/doris/pull/34384#issuecomment-2096192982 > What is the meaning of TABLE_SCHEMA? databases to which table belongs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [Enhancement] add information_schema.table_options(#32572) [doris]

2024-05-06 Thread via GitHub
dataroaring commented on PR #34384: URL: https://github.com/apache/doris/pull/34384#issuecomment-2096105612 Please add the document in doris-website and link 2 prs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] [Enhancement] add information_schema.table_options(#32572) [doris]

2024-05-06 Thread via GitHub
dataroaring commented on PR #34384: URL: https://github.com/apache/doris/pull/34384#issuecomment-2096102496 Actually, we should show all messages in create table. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [Enhancement] add information_schema.table_options(#32572) [doris]

2024-05-06 Thread via GitHub
dataroaring commented on PR #34384: URL: https://github.com/apache/doris/pull/34384#issuecomment-2096101176 DISTRIBUTE_KEY, TABLE_MODEL(agg unique, dup) should also in the table. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [Enhancement] add information_schema.table_options(#32572) [doris]

2024-05-06 Thread via GitHub
dataroaring commented on PR #34384: URL: https://github.com/apache/doris/pull/34384#issuecomment-2096080838 great job. BTW, should we put properties in json format? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] [Enhancement] add information_schema.table_options(#32572) [doris]

2024-05-06 Thread via GitHub
dataroaring commented on PR #34384: URL: https://github.com/apache/doris/pull/34384#issuecomment-2096070533 What is the meaning of TABLE_SCHEMA? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] [Enhancement] add information_schema.table_options(#32572) [doris]

2024-05-03 Thread via GitHub
doris-robot commented on PR #34384: URL: https://github.com/apache/doris/pull/34384#issuecomment-2092749450 TPC-DS: Total hot run time: 185086 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Enhancement] add information_schema.table_options(#32572) [doris]

2024-05-03 Thread via GitHub
doris-robot commented on PR #34384: URL: https://github.com/apache/doris/pull/34384#issuecomment-2092733211 TPC-H: Total hot run time: 41778 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [Enhancement] add information_schema.table_options(#32572) [doris]

2024-05-03 Thread via GitHub
doris-robot commented on PR #34384: URL: https://github.com/apache/doris/pull/34384#issuecomment-2092719167 TeamCity be ut coverage result: Function Coverage: 35.65% (8961/25135) Line Coverage: 27.27% (73925/271098) Region Coverage: 26.47% (38201/144332) Branch Coverage: 23.2

Re: [PR] [Enhancement] add information_schema.table_options(#32572) [doris]

2024-05-03 Thread via GitHub
Vallishp commented on PR #34384: URL: https://github.com/apache/doris/pull/34384#issuecomment-2092673969 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [Enhancement] add information_schema.table_options(#32572) [doris]

2024-05-03 Thread via GitHub
doris-robot commented on PR #34384: URL: https://github.com/apache/doris/pull/34384#issuecomment-2092521492 TPC-DS: Total hot run time: 187819 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Enhancement] add information_schema.table_options(#32572) [doris]

2024-05-03 Thread via GitHub
doris-robot commented on PR #34384: URL: https://github.com/apache/doris/pull/34384#issuecomment-2092492712 TeamCity be ut coverage result: Function Coverage: 35.66% (8962/25135) Line Coverage: 27.27% (73926/271098) Region Coverage: 26.46% (38192/144332) Branch Coverage: 23.2

Re: [PR] [Enhancement] add information_schema.table_options(#32572) [doris]

2024-05-03 Thread via GitHub
Vallishp commented on PR #34384: URL: https://github.com/apache/doris/pull/34384#issuecomment-2092455525 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [Enhancement] add information_schema.table_options(#32572) [doris]

2024-05-02 Thread via GitHub
doris-robot commented on PR #34384: URL: https://github.com/apache/doris/pull/34384#issuecomment-2091209500 TPC-DS: Total hot run time: 188033 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Enhancement] add information_schema.table_options(#32572) [doris]

2024-05-02 Thread via GitHub
doris-robot commented on PR #34384: URL: https://github.com/apache/doris/pull/34384#issuecomment-2091177877 TeamCity be ut coverage result: Function Coverage: 35.65% (8960/25135) Line Coverage: 27.26% (73913/271098) Region Coverage: 26.46% (38186/144332) Branch Coverage: 23.2

Re: [PR] [Enhancement] add information_schema.table_options(#32572) [doris]

2024-05-02 Thread via GitHub
Vallishp commented on PR #34384: URL: https://github.com/apache/doris/pull/34384#issuecomment-2091141602 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [Enhancement] add information_schema.table_options(#32572) [doris]

2024-05-02 Thread via GitHub
doris-robot commented on PR #34384: URL: https://github.com/apache/doris/pull/34384#issuecomment-2090759704 TeamCity be ut coverage result: Function Coverage: 35.65% (8961/25135) Line Coverage: 27.27% (73916/271098) Region Coverage: 26.46% (38189/144332) Branch Coverage: 23.2

Re: [PR] [Enhancement] add information_schema.table_options(#32572) [doris]

2024-05-02 Thread via GitHub
doris-robot commented on PR #34384: URL: https://github.com/apache/doris/pull/34384#issuecomment-2090755203 TPC-DS: Total hot run time: 185670 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Enhancement] add information_schema.table_options(#32572) [doris]

2024-05-02 Thread via GitHub
Vallishp commented on PR #34384: URL: https://github.com/apache/doris/pull/34384#issuecomment-2090510437 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [Enhancement] add information_schema.table_options(#32572) [doris]

2024-05-02 Thread via GitHub
github-actions[bot] commented on code in PR #34384: URL: https://github.com/apache/doris/pull/34384#discussion_r1587611846 ## be/src/exec/schema_scanner/schema_table_options_scanner.cpp: ## @@ -0,0 +1,134 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or m

Re: [PR] [Enhancement] add information_schema.table_options(#32572) [doris]

2024-05-02 Thread via GitHub
doris-robot commented on PR #34384: URL: https://github.com/apache/doris/pull/34384#issuecomment-2090455074 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

[PR] [Enhancement] add information_schema.table_options(#32572) [doris]

2024-05-02 Thread via GitHub
Vallishp opened a new pull request, #34384: URL: https://github.com/apache/doris/pull/34384 ## Proposed changes Issue Number: close #32572 Support table_options in information_schema. UT result: mysql> select * from information_schema.table_options where table_schema="tes