Kosthi closed pull request #48956: [Enhancement] Support STGeomFromKML function
URL: https://github.com/apache/doris/pull/48956
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
zclllyybb commented on code in PR #48956:
URL: https://github.com/apache/doris/pull/48956#discussion_r2009196815
##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/visitor/ScalarFunctionVisitor.java:
##
@@ -917,7 +920,7 @@ default R visitChar(Char charFunc, C
zclllyybb commented on code in PR #48956:
URL: https://github.com/apache/doris/pull/48956#discussion_r2009197028
##
regression-test/suites/nereids_p0/sql_functions/spatial_functions/test_gis_function.groovy:
##
Review Comment:
we also need some more cases with data in the c
zclllyybb commented on code in PR #48956:
URL: https://github.com/apache/doris/pull/48956#discussion_r2009197877
##
be/src/geo/kml_parse_ctx.h:
##
@@ -0,0 +1,126 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See th
Kosthi commented on PR #48956:
URL: https://github.com/apache/doris/pull/48956#issuecomment-2727898694
I've been a bit busy, but I'll try to improve it this week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
HappenLee commented on code in PR #48956:
URL: https://github.com/apache/doris/pull/48956#discussion_r1997672942
##
be/src/vec/functions/functions_geo.cpp:
##
@@ -904,6 +906,74 @@ struct StAsBinary {
}
};
+struct StGeomFromKML {
+static constexpr auto NEED_CONTEXT =
HappenLee commented on code in PR #48956:
URL: https://github.com/apache/doris/pull/48956#discussion_r1997673081
##
be/src/vec/functions/functions_geo.cpp:
##
@@ -904,6 +906,74 @@ struct StAsBinary {
}
};
+struct StGeomFromKML {
+static constexpr auto NEED_CONTEXT =
HappenLee commented on code in PR #48956:
URL: https://github.com/apache/doris/pull/48956#discussion_r1997673343
##
be/src/geo/kml_parse.h:
##
@@ -0,0 +1,46 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOT
HappenLee commented on code in PR #48956:
URL: https://github.com/apache/doris/pull/48956#discussion_r1997673343
##
be/src/geo/kml_parse.h:
##
@@ -0,0 +1,46 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOT
HappenLee commented on PR #48956:
URL: https://github.com/apache/doris/pull/48956#issuecomment-2726572072
please add a doc to desc how the function work, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
dataroaring commented on PR #48956:
URL: https://github.com/apache/doris/pull/48956#issuecomment-2716989158
Could you add some unit tests and consider abnormal input especially.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
Kosthi commented on PR #48956:
URL: https://github.com/apache/doris/pull/48956#issuecomment-2717005569
> Could you add some unit tests and consider abnormal input especially.
Okay, for example, something like
"24.7,56.7", lacks a matching tag ?
--
This is an automated message from
Kosthi opened a new pull request, #48956:
URL: https://github.com/apache/doris/pull/48956
### What problem does this PR solve?
Issue Number: close #48203
Problem Summary:
Support for the STGeomFromKML function and test.
### Release note
None
### Check
Thearas commented on PR #48956:
URL: https://github.com/apache/doris/pull/48956#issuecomment-2716876291
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y
14 matches
Mail list logo
