[GitHub] [doris] xinyiZzz commented on pull request #11040: fix_arena_push_size

xinyiZzz commented on PR #11040: URL: https://github.com/apache/doris/pull/11040#issuecomment-1200422888 > > 如果 ChunkAllocator 中的 chunk 支持不定长内存的话，那预期存在内存浪费问题， > > 按之前的逻辑，申请1624k会实际申请2048k，free时放回2048k的free list中，在之后满足1024k到2048k的内存申请 > > chunk支持不定长内存的话，第一次申请1624k，free时放回1024k的free list

[GitHub] [doris] xinyiZzz commented on pull request #11040: fix_arena_push_size

xinyiZzz commented on PR #11040: URL: https://github.com/apache/doris/pull/11040#issuecomment-1190267181 如果 ChunkAllocator 中的 chunk 支持不定长内存的话，那预期存在内存浪费问题， 按之前的逻辑，申请1624k会实际申请2048k，free时放回2048k的free list中，在之后满足1024k到2048k的内存申请 chunk支持不定长内存的话，第一次申请1624k，free时放回1024k的free list中，在后

[GitHub] [doris] xinyiZzz commented on pull request #11040: fix_arena_push_size

xinyiZzz commented on PR #11040: URL: https://github.com/apache/doris/pull/11040#issuecomment-1190122477 refer this diff --git a/be/src/runtime/memory/chunk_allocator.cpp b/be/src/runtime/memory/chunk_allocator.cpp index 6db98ecc9..e69b4c2e8 100644 --- a/be/src/runtime/memory/ch

[GitHub] [doris] xinyiZzz commented on pull request #11040: fix_arena_push_size

xinyiZzz commented on PR #11040: URL: https://github.com/apache/doris/pull/11040#issuecomment-1190119739 @muyizi ChunkAllocator中的chunk大小必须是2^n ，`ChunkAllocator::allocate`不能申请1025，见接口注释，申请1025应该用`ChunkAllocator::allocate_align` 应该在`ChunkAllocator::allocate`中加一个 DCKECK或return error检