Re: [PR] [env](compile)open compile check in function string [doris]

2024-10-26 Thread via GitHub
github-actions[bot] commented on PR #42474: URL: https://github.com/apache/doris/pull/42474#issuecomment-2439879472 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [env](compile)open compile check in function string [doris]

2024-10-26 Thread via GitHub
Mryange commented on PR #42474: URL: https://github.com/apache/doris/pull/42474#issuecomment-2439878667 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] NPE can occur in the Response Path if MetricRepo is not initialized yet [doris]

2024-10-26 Thread via GitHub
rijeshkp commented on PR #42505: URL: https://github.com/apache/doris/pull/42505#issuecomment-2439872463 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [enhancement](jni)append exception check for jni code. [doris]

2024-10-26 Thread via GitHub
hubgeter commented on code in PR #42507: URL: https://github.com/apache/doris/pull/42507#discussion_r1817990527 ## be/src/util/jvm_metrics.cpp: ## @@ -90,9 +92,12 @@ JvmMetrics::JvmMetrics(MetricRegistry* registry, JNIEnv* env) { break; } try { -

Re: [PR] [enhancement](jni)append exception check for jni code. [doris]

2024-10-26 Thread via GitHub
github-actions[bot] commented on code in PR #42507: URL: https://github.com/apache/doris/pull/42507#discussion_r1817990380 ## be/src/util/jvm_metrics.cpp: ## @@ -182,193 +189,257 @@ void JvmMetrics::update() { } } -void JvmStats::init(JNIEnv* ENV) { -env = ENV; -

Re: [PR] [enhancement](jni)append exception check for jni code. [doris]

2024-10-26 Thread via GitHub
hubgeter commented on code in PR #42507: URL: https://github.com/apache/doris/pull/42507#discussion_r1817989956 ## be/src/util/jvm_metrics.cpp: ## @@ -182,193 +188,260 @@ void JvmMetrics::update() { } } -void JvmStats::init(JNIEnv* ENV) { -env = ENV; -_management

Re: [PR] [enhancement](jni)append exception check for jni code. [doris]

2024-10-26 Thread via GitHub
hubgeter commented on PR #42507: URL: https://github.com/apache/doris/pull/42507#issuecomment-2439869738 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [I] [Feature] Implement `DataTypeObjectSerDe::read_column_from_arrow` [doris]

2024-10-26 Thread via GitHub
wyxxxcat commented on issue #42406: URL: https://github.com/apache/doris/issues/42406#issuecomment-2439866043 Can you give me a reproducible statement? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [I] [Feature] Implement `DataTypeObjectSerDe::read_column_from_arrow` [doris]

2024-10-26 Thread via GitHub
wyxxxcat commented on issue #42406: URL: https://github.com/apache/doris/issues/42406#issuecomment-2439863327 can you give me some example to reproduce? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

(doris-website) branch asf-site updated (4045b0c435 -> bcec70be16)

2024-10-26 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/doris-website.git discard 4045b0c435 Automated deployment with doris branch @ 5976cf0977d620cfbf5e5200acf0288309449edb new bc

Re: [PR] [enhancement](jni)append exception check for jni code. [doris]

2024-10-26 Thread via GitHub
morningman commented on code in PR #42507: URL: https://github.com/apache/doris/pull/42507#discussion_r1817974809 ## be/src/util/jvm_metrics.cpp: ## @@ -90,9 +92,12 @@ JvmMetrics::JvmMetrics(MetricRegistry* registry, JNIEnv* env) { break; } try {

Re: [PR] [enhancement](jni)append exception check for jni code. [doris]

2024-10-26 Thread via GitHub
github-actions[bot] commented on code in PR #42507: URL: https://github.com/apache/doris/pull/42507#discussion_r1817773962 ## be/src/util/jvm_metrics.cpp: ## @@ -182,193 +188,260 @@ void JvmMetrics::update() { } } -void JvmStats::init(JNIEnv* ENV) { -env = ENV; -

[PR] [fix](regression) fix unstable regression case: test_cte_filter_pushdown [doris]

2024-10-26 Thread via GitHub
englefly opened a new pull request, #42510: URL: https://github.com/apache/doris/pull/42510 ## Proposed changes Issue Number: close #xxx -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] [fix](regression) fix unstable regression case: test_cte_filter_pushdown [doris]

2024-10-26 Thread via GitHub
doris-robot commented on PR #42510: URL: https://github.com/apache/doris/pull/42510#issuecomment-2439819038 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

Re: [PR] [fix](regression) fix unstable regression case: test_cte_filter_pushdown [doris]

2024-10-26 Thread via GitHub
englefly commented on PR #42510: URL: https://github.com/apache/doris/pull/42510#issuecomment-2439819062 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [fix](regression)update test_cte_filter_pushdown.out [doris]

2024-10-26 Thread via GitHub
englefly closed pull request #42509: [fix](regression)update test_cte_filter_pushdown.out URL: https://github.com/apache/doris/pull/42509 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [Improve](columns) update columns and ut [doris]

2024-10-26 Thread via GitHub
github-actions[bot] commented on code in PR #42269: URL: https://github.com/apache/doris/pull/42269#discussion_r1817969502 ## be/test/vec/columns/common_column_test.h: ## @@ -0,0 +1,766 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor lic

Re: [PR] [fix](bloomFilter)fix data type supported behavior same in FE and BE [doris]

2024-10-26 Thread via GitHub
amorynan commented on PR #42416: URL: https://github.com/apache/doris/pull/42416#issuecomment-2439811974 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

Re: [PR] [Featrue](default value) Add UUID default value [doris]

2024-10-26 Thread via GitHub
github-actions[bot] commented on PR #34211: URL: https://github.com/apache/doris/pull/34211#issuecomment-2439775711 We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable

Re: [PR] [enhancement](threadname) change thread name, whose length is restricted to 15 characters on linux platform [doris]

2024-10-26 Thread via GitHub
github-actions[bot] commented on PR #33792: URL: https://github.com/apache/doris/pull/33792#issuecomment-2439775728 We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable

Re: [PR] [Enhancement](Show Transaction) fix show transaction issue [doris]

2024-10-26 Thread via GitHub
github-actions[bot] commented on PR #34172: URL: https://github.com/apache/doris/pull/34172#issuecomment-2439775718 We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable

Re: [PR] [Feature](insert-overwrite) Support create partition for auto partition table when insert overwrite [doris]

2024-10-26 Thread via GitHub
HappenLee commented on code in PR #38628: URL: https://github.com/apache/doris/pull/38628#discussion_r1817923714 ## be/src/vec/sink/vrow_distribution.cpp: ## @@ -456,15 +507,19 @@ Status VRowDistribution::generate_rows_distribution( } Status st = Status::OK(); -i

Re: [PR] [Feature](insert-overwrite) Support create partition for auto partition table when insert overwrite [doris]

2024-10-26 Thread via GitHub
HappenLee commented on code in PR #38628: URL: https://github.com/apache/doris/pull/38628#discussion_r1817919177 ## be/src/vec/sink/vrow_distribution.cpp: ## @@ -456,15 +507,19 @@ Status VRowDistribution::generate_rows_distribution( } Status st = Status::OK(); -i

Re: [PR] [feature](function)support url domain functions [doris]

2024-10-26 Thread via GitHub
HappenLee commented on code in PR #42488: URL: https://github.com/apache/doris/pull/42488#discussion_r1817873031 ## be/src/vec/functions/url/domain.h: ## @@ -144,4 +145,138 @@ struct ExtractDomain { } }; +struct ExtractTopLevelDomain { +static size_t get_reserve_leng

Re: [PR] [env](compile)open compile check in some function [doris]

2024-10-26 Thread via GitHub
doris-robot commented on PR #42452: URL: https://github.com/apache/doris/pull/42452#issuecomment-2439675013 TeamCity be ut coverage result: Function Coverage: 37.47% (9717/25934) Line Coverage: 28.75% (80628/280462) Region Coverage: 28.16% (41678/147992) Branch Coverage: 24.7

Re: [PR] [Improve](columns) update columns and ut [doris]

2024-10-26 Thread via GitHub
github-actions[bot] commented on code in PR #42269: URL: https://github.com/apache/doris/pull/42269#discussion_r1817894691 ## be/test/vec/columns/common_column_test.cpp: ## @@ -0,0 +1,153 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor l

Re: [PR] [enhancement](jni)append exception check for jni code. [doris]

2024-10-26 Thread via GitHub
doris-robot commented on PR #42507: URL: https://github.com/apache/doris/pull/42507#issuecomment-2439564281 TPC-DS: Total hot run time: 191880 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

[PR] [fix](regression)update test_cte_filter_pushdown.out [doris]

2024-10-26 Thread via GitHub
englefly opened a new pull request, #42509: URL: https://github.com/apache/doris/pull/42509 ## Proposed changes Issue Number: close #xxx -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] [fix](regression)update test_cte_filter_pushdown.out [doris]

2024-10-26 Thread via GitHub
englefly commented on PR #42509: URL: https://github.com/apache/doris/pull/42509#issuecomment-2439621743 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [fix](regression)update test_cte_filter_pushdown.out [doris]

2024-10-26 Thread via GitHub
doris-robot commented on PR #42509: URL: https://github.com/apache/doris/pull/42509#issuecomment-2439621715 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

Re: [PR] [refactor](Coordinator) refactor coordinator [doris]

2024-10-26 Thread via GitHub
924060929 commented on PR #41730: URL: https://github.com/apache/doris/pull/41730#issuecomment-2439644350 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [env](compile)open compile check in some function [doris]

2024-10-26 Thread via GitHub
github-actions[bot] commented on PR #42452: URL: https://github.com/apache/doris/pull/42452#issuecomment-2439635063 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [env](compile)open compile check in some function [doris]

2024-10-26 Thread via GitHub
HappenLee commented on PR #42452: URL: https://github.com/apache/doris/pull/42452#issuecomment-2439633320 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [feature](function)support url domain functions [doris]

2024-10-26 Thread via GitHub
HappenLee commented on code in PR #42488: URL: https://github.com/apache/doris/pull/42488#discussion_r1817872772 ## be/src/vec/functions/url/domain.h: ## @@ -144,4 +145,138 @@ struct ExtractDomain { } }; +struct ExtractTopLevelDomain { +static size_t get_reserve_leng

Re: [PR] [feature](function)support url domain functions [doris]

2024-10-26 Thread via GitHub
HappenLee commented on code in PR #42488: URL: https://github.com/apache/doris/pull/42488#discussion_r1817872772 ## be/src/vec/functions/url/domain.h: ## @@ -144,4 +145,138 @@ struct ExtractDomain { } }; +struct ExtractTopLevelDomain { +static size_t get_reserve_leng

Re: [PR] [feature](function)support url domain functions [doris]

2024-10-26 Thread via GitHub
HappenLee commented on code in PR #42488: URL: https://github.com/apache/doris/pull/42488#discussion_r1816470102 ## be/src/vec/functions/url/domain.h: ## @@ -144,4 +145,138 @@ struct ExtractDomain { } }; +struct ExtractTopLevelDomain { +static size_t get_reserve_leng

Re: [PR] [feature](function)support url domain functions [doris]

2024-10-26 Thread via GitHub
HappenLee commented on code in PR #42488: URL: https://github.com/apache/doris/pull/42488#discussion_r1817873603 ## be/src/vec/functions/url/domain.h: ## @@ -144,4 +145,138 @@ struct ExtractDomain { } }; +struct ExtractTopLevelDomain { +static size_t get_reserve_leng

Re: [PR] [fix](test) fix move memtable injection test may cause other case stuck #40356 [doris]

2024-10-26 Thread via GitHub
liaoxin01 merged PR #42508: URL: https://github.com/apache/doris/pull/42508 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

(doris) branch branch-2.1 updated: [fix](test) fix move memtable injection test may cause other case stuck #40356 (#42508)

2024-10-26 Thread liaoxin
This is an automated email from the ASF dual-hosted git repository. liaoxin pushed a commit to branch branch-2.1 in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/branch-2.1 by this push: new 2bb29d7f365 [fix](test) fix move memtabl

Re: [PR] [fix](test) fix move memtable injection test may cause other case stuck #40356 [doris]

2024-10-26 Thread via GitHub
doris-robot commented on PR #42508: URL: https://github.com/apache/doris/pull/42508#issuecomment-2439564417 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

Re: [PR] [fix](test) fix move memtable injection test may cause other case stuck #40356 [doris]

2024-10-26 Thread via GitHub
doris-robot commented on PR #42508: URL: https://github.com/apache/doris/pull/42508#issuecomment-2439590741 TeamCity be ut coverage result: Function Coverage: 36.02% (9368/26005) Line Coverage: 27.60% (76983/278964) Region Coverage: 26.37% (39529/149900) Branch Coverage: 23.1

Re: [PR] [fix](test) fix move memtable injection test may cause other case stuck #40356 [doris]

2024-10-26 Thread via GitHub
liaoxin01 commented on PR #42508: URL: https://github.com/apache/doris/pull/42508#issuecomment-2439573990 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] [feature](function)support url domain functions [doris]

2024-10-26 Thread via GitHub
HappenLee commented on code in PR #42488: URL: https://github.com/apache/doris/pull/42488#discussion_r1817848401 ## be/src/vec/functions/url/find_symbols.h: ## @@ -0,0 +1,484 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreem

Re: [PR] [fix](test) fix move memtable injection test may cause other case stuck #40356 [doris]

2024-10-26 Thread via GitHub
github-actions[bot] commented on PR #42508: URL: https://github.com/apache/doris/pull/42508#issuecomment-2439576460 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](test) fix move memtable injection test may cause other case stuck #40356 [doris]

2024-10-26 Thread via GitHub
github-actions[bot] commented on PR #42508: URL: https://github.com/apache/doris/pull/42508#issuecomment-2439575791 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](test) fix move memtable injection test may cause other case stuck #40356 [doris]

2024-10-26 Thread via GitHub
github-actions[bot] commented on PR #42508: URL: https://github.com/apache/doris/pull/42508#issuecomment-2439575658 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](test) fix move memtable injection test may cause other case stuck #40356 [doris]

2024-10-26 Thread via GitHub
liaoxin01 commented on PR #42508: URL: https://github.com/apache/doris/pull/42508#issuecomment-2439574628 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [fix](test) fix move memtable injection test may cause other case stuck #40356 [doris]

2024-10-26 Thread via GitHub
liaoxin01 commented on PR #42508: URL: https://github.com/apache/doris/pull/42508#issuecomment-2439573772 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [fix](test) fix move memtable injection test may cause other case stuck #40356 [doris]

2024-10-26 Thread via GitHub
github-actions[bot] commented on PR #42508: URL: https://github.com/apache/doris/pull/42508#issuecomment-2439569083 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [enhancement](jni)append exception check for jni code. [doris]

2024-10-26 Thread via GitHub
doris-robot commented on PR #42507: URL: https://github.com/apache/doris/pull/42507#issuecomment-2439557021 TPC-H: Total hot run time: 41624 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](test) fix move memtable injection test may cause other case stuck #40356 [doris]

2024-10-26 Thread via GitHub
github-actions[bot] commented on PR #42508: URL: https://github.com/apache/doris/pull/42508#issuecomment-2439569581 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [enhancement](jni)append exception check for jni code. [doris]

2024-10-26 Thread via GitHub
doris-robot commented on PR #42507: URL: https://github.com/apache/doris/pull/42507#issuecomment-2439568711 ClickBench: Total hot run time: 32.92 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix](test) fix move memtable injection test may cause other case stuck #40356 [doris]

2024-10-26 Thread via GitHub
liaoxin01 commented on PR #42508: URL: https://github.com/apache/doris/pull/42508#issuecomment-2439566397 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [fix](test) fix move memtable injection test may cause other case stuck #40356 [doris]

2024-10-26 Thread via GitHub
liaoxin01 commented on PR #42508: URL: https://github.com/apache/doris/pull/42508#issuecomment-2439564402 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[PR] [fix](test) fix move memtable injection test may cause other case stuck #40356 [doris]

2024-10-26 Thread via GitHub
liaoxin01 opened a new pull request, #42508: URL: https://github.com/apache/doris/pull/42508 cherry pick from #40356 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [enhancement](jni)append exception check for jni code. [doris]

2024-10-26 Thread via GitHub
doris-robot commented on PR #42507: URL: https://github.com/apache/doris/pull/42507#issuecomment-2439557691 TeamCity be ut coverage result: Function Coverage: 37.46% (9714/25934) Line Coverage: 28.73% (80581/280507) Region Coverage: 28.04% (41652/148564) Branch Coverage: 24.6

(doris-website) branch master updated: (doc)[doris streamloader] update doris streamloader installation link (#1229)

2024-10-26 Thread liaoxin
This is an automated email from the ASF dual-hosted git repository. liaoxin pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris-website.git The following commit(s) were added to refs/heads/master by this push: new 5976cf0977 (doc)[doris streamloader] upd

Re: [PR] (doc)[doris streamloader] update doris streamloader installation link [doris-website]

2024-10-26 Thread via GitHub
liaoxin01 merged PR #1229: URL: https://github.com/apache/doris-website/pull/1229 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@do

Re: [PR] [enhancement](jni)append exception check for jni code. [doris]

2024-10-26 Thread via GitHub
doris-robot commented on PR #42507: URL: https://github.com/apache/doris/pull/42507#issuecomment-2439489107 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

[PR] [enhancement](jni)append exception check for jni code. [doris]

2024-10-26 Thread via GitHub
hubgeter opened a new pull request, #42507: URL: https://github.com/apache/doris/pull/42507 ## Proposed changes Because in jni, we need to manually check for exceptions thrown, and if we do not handle the exception, the program will continue to execute, which is not like the try catch lo

Re: [PR] [enhancement](jni)append exception check for jni code. [doris]

2024-10-26 Thread via GitHub
hubgeter commented on PR #42507: URL: https://github.com/apache/doris/pull/42507#issuecomment-2439489153 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [fix] query blocked by exchange reach limit [doris]

2024-10-26 Thread via GitHub
mrhhsg commented on PR #42371: URL: https://github.com/apache/doris/pull/42371#issuecomment-2439315608 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub