Re: [PR] [Improvement](executor)add remote scan thread pool [doris]

2024-02-24 Thread via GitHub
wangbo commented on PR #31376: URL: https://github.com/apache/doris/pull/31376#issuecomment-1962848077 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] [Improvement](executor)add remote scan thread pool [doris]

2024-02-24 Thread via GitHub
github-actions[bot] commented on code in PR #31376: URL: https://github.com/apache/doris/pull/31376#discussion_r1501765685 ## be/src/runtime/task_group/task_group.cpp: ## @@ -266,8 +273,167 @@ Status TaskGroupInfo::parse_topic_info(const TWorkloadGroupInfo& workload_group_

Re: [PR] [Improvement](executor)add remote scan thread pool [doris]

2024-02-24 Thread via GitHub
wangbo commented on PR #31376: URL: https://github.com/apache/doris/pull/31376#issuecomment-1962846972 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] [Improvement](executor)add remote scan thread pool [doris]

2024-02-24 Thread via GitHub
wangbo commented on code in PR #31376: URL: https://github.com/apache/doris/pull/31376#discussion_r1501763845 ## be/src/runtime/task_group/task_group.cpp: ## @@ -266,8 +273,167 @@ Status TaskGroupInfo::parse_topic_info(const TWorkloadGroupInfo& workload_group_ task_gro

Re: [PR] [Improvement](executor)add remote scan thread pool [doris]

2024-02-24 Thread via GitHub
doris-robot commented on PR #31376: URL: https://github.com/apache/doris/pull/31376#issuecomment-1962842067 TeamCity be ut coverage result: Function Coverage: 35.70% (8548/23943) Line Coverage: 27.52% (69365/252021) Region Coverage: 26.68% (35981/134868) Branch Coverage: 23.4

Re: [PR] [bugfix](wg) should set task group down after thread pool stopped [doris]

2024-02-24 Thread via GitHub
doris-robot commented on PR #31377: URL: https://github.com/apache/doris/pull/31377#issuecomment-1962840080 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit da8ace96beaac5aaab3e798ad4f1e8005824ee80 with default session variables Stream

Re: [PR] [bugfix](wg) should set task group down after thread pool stopped [doris]

2024-02-24 Thread via GitHub
doris-robot commented on PR #31377: URL: https://github.com/apache/doris/pull/31377#issuecomment-1962839253 ClickBench: Total hot run time: 30.22 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [bugfix](wg) should set task group down after thread pool stopped [doris]

2024-02-24 Thread via GitHub
doris-robot commented on PR #31377: URL: https://github.com/apache/doris/pull/31377#issuecomment-1962838045 TPC-DS: Total hot run time: 175886 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [bugfix](wg) should set task group down after thread pool stopped [doris]

2024-02-24 Thread via GitHub
github-actions[bot] commented on PR #31377: URL: https://github.com/apache/doris/pull/31377#issuecomment-1962837560 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [bugfix](wg) should set task group down after thread pool stopped [doris]

2024-02-24 Thread via GitHub
github-actions[bot] commented on PR #31377: URL: https://github.com/apache/doris/pull/31377#issuecomment-1962837552 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [refactor-wip](FS) Use golang-like generator to replace FS's list interface [doris]

2024-02-24 Thread via GitHub
doris-robot commented on PR #31214: URL: https://github.com/apache/doris/pull/31214#issuecomment-1962836281 TeamCity be ut coverage result: Function Coverage: 35.72% (8558/23959) Line Coverage: 27.53% (69413/252181) Region Coverage: 26.69% (36053/135069) Branch Coverage: 23.4

Re: [PR] [bugfix](wg) should set task group down after thread pool stopped [doris]

2024-02-24 Thread via GitHub
doris-robot commented on PR #31377: URL: https://github.com/apache/doris/pull/31377#issuecomment-1962835803 TPC-H: Total hot run time: 41015 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [bugfix](wg) should set task group down after thread pool stopped [doris]

2024-02-24 Thread via GitHub
doris-robot commented on PR #31377: URL: https://github.com/apache/doris/pull/31377#issuecomment-1962834901 TeamCity be ut coverage result: Function Coverage: 35.71% (8547/23937) Line Coverage: 27.52% (69357/251985) Region Coverage: 26.68% (35969/134838) Branch Coverage: 23.4

Re: [PR] [Improvement](executor)add remote scan thread pool [doris]

2024-02-24 Thread via GitHub
yiguolei commented on code in PR #31376: URL: https://github.com/apache/doris/pull/31376#discussion_r1501756222 ## be/src/runtime/task_group/task_group.cpp: ## @@ -266,8 +273,167 @@ Status TaskGroupInfo::parse_topic_info(const TWorkloadGroupInfo& workload_group_ task_g

Re: [PR] [Improvement](executor)add remote scan thread pool [doris]

2024-02-24 Thread via GitHub
yiguolei commented on code in PR #31376: URL: https://github.com/apache/doris/pull/31376#discussion_r1501755957 ## be/src/runtime/task_group/task_group.h: ## @@ -121,6 +129,15 @@ class TaskGroup : public std::enable_shared_from_this { int64_t gc_memory(int64_t need_free_

Re: [PR] [Improvement](executor)add remote scan thread pool [doris]

2024-02-24 Thread via GitHub
yiguolei commented on code in PR #31376: URL: https://github.com/apache/doris/pull/31376#discussion_r1501755687 ## be/src/runtime/task_group/task_group.cpp: ## @@ -266,8 +273,167 @@ Status TaskGroupInfo::parse_topic_info(const TWorkloadGroupInfo& workload_group_ task_g

Re: [PR] [refactor-wip](FS) Use golang-like generator to replace FS's list interface [doris]

2024-02-24 Thread via GitHub
ByteYue commented on PR #31214: URL: https://github.com/apache/doris/pull/31214#issuecomment-1962832430 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [refactor-wip](FS) Use golang-like generator to replace FS's list interface [doris]

2024-02-24 Thread via GitHub
github-actions[bot] commented on code in PR #31214: URL: https://github.com/apache/doris/pull/31214#discussion_r1501754329 ## be/src/io/fs/file_writer.h: ## @@ -54,7 +54,13 @@ class FileWriter { // Normal close. Wait for all data to persist before returning. virtual St

Re: [PR] [bugfix](wg) should set task group down after thread pool stopped [doris]

2024-02-24 Thread via GitHub
github-actions[bot] commented on PR #31377: URL: https://github.com/apache/doris/pull/31377#issuecomment-1962830699 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [Improvement](executor)add remote scan thread pool [doris]

2024-02-24 Thread via GitHub
yiguolei commented on code in PR #31376: URL: https://github.com/apache/doris/pull/31376#discussion_r1501753544 ## gensrc/thrift/FrontendService.thrift: ## @@ -412,7 +412,7 @@ struct TQueryStatistics { struct TReportWorkloadRuntimeStatusParams { 1: optional i64 backend_i

Re: [PR] test regression [doris]

2024-02-24 Thread via GitHub
feiniaofeiafei commented on PR #31374: URL: https://github.com/apache/doris/pull/31374#issuecomment-1962828721 run pipelinex_p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] [bugfix](wg) should set task group down after thread pool stopped [doris]

2024-02-24 Thread via GitHub
yiguolei commented on PR #31377: URL: https://github.com/apache/doris/pull/31377#issuecomment-1962828630 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] test regression [doris]

2024-02-24 Thread via GitHub
feiniaofeiafei commented on PR #31374: URL: https://github.com/apache/doris/pull/31374#issuecomment-1962828629 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [refactor-wip](FS) Use golang-like generator to replace FS's list interface [doris]

2024-02-24 Thread via GitHub
ByteYue commented on PR #31214: URL: https://github.com/apache/doris/pull/31214#issuecomment-1962828615 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [bugfix](wg) should set task group down after thread pool stopped [doris]

2024-02-24 Thread via GitHub
doris-robot commented on PR #31377: URL: https://github.com/apache/doris/pull/31377#issuecomment-1962828605 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

[PR] [bugfix](wg) should set task group down after thread pool stopped [doris]

2024-02-24 Thread via GitHub
yiguolei opened a new pull request, #31377: URL: https://github.com/apache/doris/pull/31377 ## Proposed changes If the first delete workload group thread hang and the publish topic thread will timeout. And it will publish again. And another thread will try to delete wg again. And the

Re: [PR] [Improvement](executor)add remote scan thread pool [doris]

2024-02-24 Thread via GitHub
github-actions[bot] commented on code in PR #31376: URL: https://github.com/apache/doris/pull/31376#discussion_r1501751586 ## be/src/runtime/task_group/task_group.cpp: ## @@ -266,8 +273,167 @@ Status TaskGroupInfo::parse_topic_info(const TWorkloadGroupInfo& workload_group_

Re: [PR] [Improvement](executor)add remote scan thread pool [doris]

2024-02-24 Thread via GitHub
wangbo commented on PR #31376: URL: https://github.com/apache/doris/pull/31376#issuecomment-1962824367 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] [Improvement](executor)add remote scan thread pool [doris]

2024-02-24 Thread via GitHub
doris-robot commented on PR #31376: URL: https://github.com/apache/doris/pull/31376#issuecomment-1962824344 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

[PR] [Improvement](executor)add remote scan thread pool [doris]

2024-02-24 Thread via GitHub
wangbo opened a new pull request, #31376: URL: https://github.com/apache/doris/pull/31376 ## Proposed changes add remote scan thread pool for workload group. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

(doris) branch master updated: [refactor](wg) enable wg by default and init normal wg in constructor (#31373)

2024-02-24 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 28a0217d9d4 [refactor](wg) enable wg by default

Re: [PR] [refactor](wg) enable wg by default and init normal wg in constructor [doris]

2024-02-24 Thread via GitHub
yiguolei merged PR #31373: URL: https://github.com/apache/doris/pull/31373 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

Re: [PR] [test](rpc) test thrift rpc fail [doris]

2024-02-24 Thread via GitHub
zclllyybb commented on PR #31359: URL: https://github.com/apache/doris/pull/31359#issuecomment-1962815868 run p1 50 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] [refactor](wg) enable wg by default and init normal wg in constructor [doris]

2024-02-24 Thread via GitHub
github-actions[bot] commented on PR #31373: URL: https://github.com/apache/doris/pull/31373#issuecomment-1962811693 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [refactor](wg) enable wg by default and init normal wg in constructor [doris]

2024-02-24 Thread via GitHub
github-actions[bot] commented on PR #31373: URL: https://github.com/apache/doris/pull/31373#issuecomment-1962811690 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] test regression [doris]

2024-02-24 Thread via GitHub
feiniaofeiafei commented on PR #31374: URL: https://github.com/apache/doris/pull/31374#issuecomment-1962804120 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] test regression [doris]

2024-02-24 Thread via GitHub
feiniaofeiafei commented on PR #31374: URL: https://github.com/apache/doris/pull/31374#issuecomment-1962804101 run pipelinex_p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] [Feature] Support to do schema change in cloud mode [doris]

2024-02-24 Thread via GitHub
doris-robot commented on PR #31055: URL: https://github.com/apache/doris/pull/31055#issuecomment-1962796064 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit 4c39df9bc6dab64b7fb1910d6f85b4de075672c3 with default session variables Stream

Re: [PR] [Feature](agg-state) support write_column_to_pb from DataTypeFixedLengthObjectSerDe [doris]

2024-02-24 Thread via GitHub
github-actions[bot] commented on PR #31171: URL: https://github.com/apache/doris/pull/31171#issuecomment-1962795681 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [Feature](agg-state) support write_column_to_pb from DataTypeFixedLengthObjectSerDe [doris]

2024-02-24 Thread via GitHub
github-actions[bot] commented on PR #31171: URL: https://github.com/apache/doris/pull/31171#issuecomment-1962795676 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [Feature] Support to do schema change in cloud mode [doris]

2024-02-24 Thread via GitHub
doris-robot commented on PR #31055: URL: https://github.com/apache/doris/pull/31055#issuecomment-1962795610 ClickBench: Total hot run time: 30.72 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [Feature] Support to do schema change in cloud mode [doris]

2024-02-24 Thread via GitHub
doris-robot commented on PR #31055: URL: https://github.com/apache/doris/pull/31055#issuecomment-1962794887 TPC-DS: Total hot run time: 188798 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Feature] Support to do schema change in cloud mode [doris]

2024-02-24 Thread via GitHub
doris-robot commented on PR #31055: URL: https://github.com/apache/doris/pull/31055#issuecomment-1962793555 TeamCity be ut coverage result: Function Coverage: 35.68% (8547/23954) Line Coverage: 27.48% (69359/252355) Region Coverage: 26.65% (35979/134995) Branch Coverage: 23.4

Re: [PR] [Feature] Support to do schema change in cloud mode [doris]

2024-02-24 Thread via GitHub
doris-robot commented on PR #31055: URL: https://github.com/apache/doris/pull/31055#issuecomment-1962793223 TPC-H: Total hot run time: 41455 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

(doris) branch master updated: [fix](parquet) Fix possible memory leak if ParquetReader::parse_thrift_footer failed (#31375)

2024-02-24 Thread dataroaring
This is an automated email from the ASF dual-hosted git repository. dataroaring pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 41f88ee18a7 [fix](parquet) Fix possible memo

Re: [PR] [fix](parquet) Fix possible memory leak if ParquetReader::parse_thrift_footer failed [doris]

2024-02-24 Thread via GitHub
dataroaring merged PR #31375: URL: https://github.com/apache/doris/pull/31375 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.

Re: [PR] [Feature] Support to do schema change in cloud mode [doris]

2024-02-24 Thread via GitHub
dataroaring commented on PR #31055: URL: https://github.com/apache/doris/pull/31055#issuecomment-1962785082 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

(doris-website) branch asf-site updated: Automated deployment with doris branch @ b6c38b73962a6d14baa807bccd20d3bdbbf540f5

2024-02-24 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/doris-website.git The following commit(s) were added to refs/heads/asf-site by this push: new a0dcb27a6fb Automated deployment

Re: [PR] [test](rpc) test thrift rpc fail [doris]

2024-02-24 Thread via GitHub
doris-robot commented on PR #31359: URL: https://github.com/apache/doris/pull/31359#issuecomment-1962427358 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit 2e94ac940d495d68bab1ad30c5fcf5531374b493 with default session variables Stream

Re: [PR] [test](rpc) test thrift rpc fail [doris]

2024-02-24 Thread via GitHub
zclllyybb commented on PR #31359: URL: https://github.com/apache/doris/pull/31359#issuecomment-1962427313 run p1 50 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] [test](rpc) test thrift rpc fail [doris]

2024-02-24 Thread via GitHub
doris-robot commented on PR #31359: URL: https://github.com/apache/doris/pull/31359#issuecomment-1962426676 ClickBench: Total hot run time: 31.52 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [test](rpc) test thrift rpc fail [doris]

2024-02-24 Thread via GitHub
doris-robot commented on PR #31359: URL: https://github.com/apache/doris/pull/31359#issuecomment-1962425459 TPC-DS: Total hot run time: 176491 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [refactor](wg) enable wg by default and init normal wg in constructor [doris]

2024-02-24 Thread via GitHub
doris-robot commented on PR #31373: URL: https://github.com/apache/doris/pull/31373#issuecomment-1962423657 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit b6378c5728887583bc7f29c3fc313511c03c4bde with default session variables Stream

Re: [PR] [refactor](wg) enable wg by default and init normal wg in constructor [doris]

2024-02-24 Thread via GitHub
doris-robot commented on PR #31373: URL: https://github.com/apache/doris/pull/31373#issuecomment-1962422976 ClickBench: Total hot run time: 30.76 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [test](rpc) test thrift rpc fail [doris]

2024-02-24 Thread via GitHub
doris-robot commented on PR #31359: URL: https://github.com/apache/doris/pull/31359#issuecomment-1962422972 TPC-H: Total hot run time: 41052 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [test](rpc) test thrift rpc fail [doris]

2024-02-24 Thread via GitHub
doris-robot commented on PR #31359: URL: https://github.com/apache/doris/pull/31359#issuecomment-1962421987 TeamCity be ut coverage result: Function Coverage: 35.71% (8547/23937) Line Coverage: 27.53% (69372/251985) Region Coverage: 26.68% (35978/134838) Branch Coverage: 23.5

Re: [PR] [refactor](wg) enable wg by default and init normal wg in constructor [doris]

2024-02-24 Thread via GitHub
doris-robot commented on PR #31373: URL: https://github.com/apache/doris/pull/31373#issuecomment-1962421928 TPC-DS: Total hot run time: 176129 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [refactor](wg) enable wg by default and init normal wg in constructor [doris]

2024-02-24 Thread via GitHub
doris-robot commented on PR #31373: URL: https://github.com/apache/doris/pull/31373#issuecomment-1962419401 TPC-H: Total hot run time: 41407 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [test](rpc) test thrift rpc fail [doris]

2024-02-24 Thread via GitHub
github-actions[bot] commented on PR #31359: URL: https://github.com/apache/doris/pull/31359#issuecomment-1962417723 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [test](rpc) test thrift failed and use glog to print [doris]

2024-02-24 Thread via GitHub
zclllyybb commented on PR #31359: URL: https://github.com/apache/doris/pull/31359#issuecomment-1962415791 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [refactor](wg) enable wg by default and init normal wg in constructor [doris]

2024-02-24 Thread via GitHub
yiguolei commented on PR #31373: URL: https://github.com/apache/doris/pull/31373#issuecomment-1962414782 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [chore] Fix possible memory leak if ParquetReader::parse_thrift_footer failed [doris]

2024-02-24 Thread via GitHub
doris-robot commented on PR #31375: URL: https://github.com/apache/doris/pull/31375#issuecomment-1962414229 ClickBench: Total hot run time: 31.17 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [chore] Fix possible memory leak if ParquetReader::parse_thrift_footer failed [doris]

2024-02-24 Thread via GitHub
doris-robot commented on PR #31375: URL: https://github.com/apache/doris/pull/31375#issuecomment-1962412915 TPC-DS: Total hot run time: 176141 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [chore] Fix possible memory leak if ParquetReader::parse_thrift_footer failed [doris]

2024-02-24 Thread via GitHub
doris-robot commented on PR #31375: URL: https://github.com/apache/doris/pull/31375#issuecomment-1962410192 TPC-H: Total hot run time: 41127 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [chore] Fix possible memory leak if ParquetReader::parse_thrift_footer failed [doris]

2024-02-24 Thread via GitHub
doris-robot commented on PR #31375: URL: https://github.com/apache/doris/pull/31375#issuecomment-1962410098 TeamCity be ut coverage result: Function Coverage: 35.71% (8547/23937) Line Coverage: 27.53% (69361/251984) Region Coverage: 26.68% (35979/134838) Branch Coverage: 23.4

Re: [PR] [chore] Fix possible memory leak if ParquetReader::parse_thrift_footer failed [doris]

2024-02-24 Thread via GitHub
github-actions[bot] commented on PR #31375: URL: https://github.com/apache/doris/pull/31375#issuecomment-1962405709 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [chore] Fix possible memory leak if ParquetReader::parse_thrift_footer failed [doris]

2024-02-24 Thread via GitHub
github-actions[bot] commented on PR #31375: URL: https://github.com/apache/doris/pull/31375#issuecomment-1962405699 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [chore] Fix possible memory leak if ParquetReader::parse_thrift_footer failed [doris]

2024-02-24 Thread via GitHub
github-actions[bot] commented on PR #31375: URL: https://github.com/apache/doris/pull/31375#issuecomment-1962405196 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [chore] Fix possible memory leak if ParquetReader::parse_thrift_footer failed [doris]

2024-02-24 Thread via GitHub
gavinchou commented on PR #31375: URL: https://github.com/apache/doris/pull/31375#issuecomment-1962402844 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [chore] Fix possible memory leak if ParquetReader::parse_thrift_footer failed [doris]

2024-02-24 Thread via GitHub
doris-robot commented on PR #31375: URL: https://github.com/apache/doris/pull/31375#issuecomment-1962402808 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

[PR] [chore] Fix possible memory leak if ParquetReader::parse_thrift_footer failed [doris]

2024-02-24 Thread via GitHub
gavinchou opened a new pull request, #31375: URL: https://github.com/apache/doris/pull/31375 `ParquetReader::parse_thrift_footer` will allocate memory for `_file_metadata`, the original implementation may leak if it returns without reclaiming it. -- This is an automated message from the

Re: [PR] test regression [doris]

2024-02-24 Thread via GitHub
feiniaofeiafei commented on PR #31374: URL: https://github.com/apache/doris/pull/31374#issuecomment-1962390762 run pipelinex_p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] test regression [doris]

2024-02-24 Thread via GitHub
feiniaofeiafei commented on PR #31374: URL: https://github.com/apache/doris/pull/31374#issuecomment-1962390635 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] test regression [doris]

2024-02-24 Thread via GitHub
doris-robot commented on PR #31374: URL: https://github.com/apache/doris/pull/31374#issuecomment-1962390312 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

[PR] test regression [doris]

2024-02-24 Thread via GitHub
feiniaofeiafei opened a new pull request, #31374: URL: https://github.com/apache/doris/pull/31374 test if the regression has something wrong -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

(doris) branch master updated: [Debug](thrift) add log for thrift transport error (#31366)

2024-02-24 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 920540e7d41 [Debug](thrift) add log for thrif

Re: [PR] [Debug](thrift) add log for thrift transport error [doris]

2024-02-24 Thread via GitHub
morningman merged PR #31366: URL: https://github.com/apache/doris/pull/31366 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.a

Re: [PR] [Feature] Support to do schema change in cloud mode [doris]

2024-02-24 Thread via GitHub
gavinchou commented on PR #31055: URL: https://github.com/apache/doris/pull/31055#issuecomment-1962380270 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [Feature] Support to do schema change in cloud mode [doris]

2024-02-24 Thread via GitHub
gavinchou commented on PR #31055: URL: https://github.com/apache/doris/pull/31055#issuecomment-1962380148 run buidlall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [fix](datetime) fix hour 24 on be [doris]

2024-02-24 Thread via GitHub
github-actions[bot] commented on PR #31304: URL: https://github.com/apache/doris/pull/31304#issuecomment-1962368350 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [Fix](fe-common) Fix the Pair.java code about the hidden danger of NullPointException [doris]

2024-02-24 Thread via GitHub
github-actions[bot] commented on PR #31371: URL: https://github.com/apache/doris/pull/31371#issuecomment-1962367137 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [Fix](fe-common) Fix the Pair.java code about the hidden danger of NullPointException [doris]

2024-02-24 Thread via GitHub
github-actions[bot] commented on PR #31371: URL: https://github.com/apache/doris/pull/31371#issuecomment-1962367146 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [feature](cloud) enable all p0 case [doris]

2024-02-24 Thread via GitHub
dataroaring commented on PR #31240: URL: https://github.com/apache/doris/pull/31240#issuecomment-1962360656 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [chore](ci) fix ak sk of cloud regression [doris]

2024-02-24 Thread via GitHub
dataroaring merged PR #31372: URL: https://github.com/apache/doris/pull/31372 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.

(doris) branch master updated: [chore](ci) fix ak sk of cloud regression (#31372)

2024-02-24 Thread dataroaring
This is an automated email from the ASF dual-hosted git repository. dataroaring pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 44b35bfe797 [chore](ci) fix ak sk of cloud r

Re: [PR] [chore](ci) fix ak sk of cloud regression [doris]

2024-02-24 Thread via GitHub
github-actions[bot] commented on PR #31372: URL: https://github.com/apache/doris/pull/31372#issuecomment-1962358697 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [chore](ci) fix ak sk of cloud regression [doris]

2024-02-24 Thread via GitHub
github-actions[bot] commented on PR #31372: URL: https://github.com/apache/doris/pull/31372#issuecomment-1962358689 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [refactor-wip](FS) Use golang-like generator to replace FS's list interface [doris]

2024-02-24 Thread via GitHub
ByteYue commented on PR #31214: URL: https://github.com/apache/doris/pull/31214#issuecomment-1962357654 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [refactor-wip](FS) Use golang-like generator to replace FS's list interface [doris]

2024-02-24 Thread via GitHub
ByteYue commented on PR #31214: URL: https://github.com/apache/doris/pull/31214#issuecomment-1962346160 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [refactor-wip](FS) Use golang-like generator to replace FS's list interface [doris]

2024-02-24 Thread via GitHub
ByteYue commented on PR #31214: URL: https://github.com/apache/doris/pull/31214#issuecomment-1962339568 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [refactor-wip](FS) Use golang-like generator to replace FS's list interface [doris]

2024-02-24 Thread via GitHub
ByteYue commented on PR #31214: URL: https://github.com/apache/doris/pull/31214#issuecomment-1962337283 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [Enhancement] fix potential bugs relating to discarded [doris]

2024-02-24 Thread via GitHub
wyxxxcat closed pull request #31296: [Enhancement] fix potential bugs relating to discarded URL: https://github.com/apache/doris/pull/31296 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] [refactor-wip](FS) Use golang-like generator to replace FS's list interface [doris]

2024-02-24 Thread via GitHub
github-actions[bot] commented on code in PR #31214: URL: https://github.com/apache/doris/pull/31214#discussion_r1501410376 ## be/src/io/fs/hdfs_file_system.cpp: ## @@ -261,13 +265,42 @@ Status HdfsFileSystem::file_size_impl(const Path& path, int64_t* file_size) cons return

Re: [PR] [refactor-wip](FS) Use golang-like generator to replace FS's list interface [doris]

2024-02-24 Thread via GitHub
ByteYue commented on PR #31214: URL: https://github.com/apache/doris/pull/31214#issuecomment-196295 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [refactor](wg) enable wg by default and init normal wg in constructor [doris]

2024-02-24 Thread via GitHub
doris-robot commented on PR #31373: URL: https://github.com/apache/doris/pull/31373#issuecomment-1962333097 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit 12220459529a5d10af34df84629d39c4b4ba6516 with default session variables Stream

Re: [PR] [refactor](wg) enable wg by default and init normal wg in constructor [doris]

2024-02-24 Thread via GitHub
doris-robot commented on PR #31373: URL: https://github.com/apache/doris/pull/31373#issuecomment-1962332488 ClickBench: Total hot run time: 31.62 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [refactor](wg) enable wg by default and init normal wg in constructor [doris]

2024-02-24 Thread via GitHub
doris-robot commented on PR #31373: URL: https://github.com/apache/doris/pull/31373#issuecomment-1962331411 TPC-DS: Total hot run time: 175893 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [refactor](wg) enable wg by default and init normal wg in constructor [doris]

2024-02-24 Thread via GitHub
doris-robot commented on PR #31373: URL: https://github.com/apache/doris/pull/31373#issuecomment-1962329340 TPC-H: Total hot run time: 41386 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [Enhancement] fix potential bugs relating to discarded [doris]

2024-02-24 Thread via GitHub
doris-robot commented on PR #31296: URL: https://github.com/apache/doris/pull/31296#issuecomment-1962328389 TeamCity be ut coverage result: Function Coverage: 35.71% (8547/23932) Line Coverage: 27.53% (69376/251985) Region Coverage: 26.67% (36014/135034) Branch Coverage: 23.4

Re: [PR] [refactor](wg) enable wg by default and init normal wg in constructor [doris]

2024-02-24 Thread via GitHub
yiguolei commented on PR #31373: URL: https://github.com/apache/doris/pull/31373#issuecomment-1962323856 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

  1   2   >