Re: [PR] [improvement](meta) Switch meta serialization to gson [doris]

2023-11-07 Thread via GitHub
gavinchou commented on code in PR #26316: URL: https://github.com/apache/doris/pull/26316#discussion_r1386150734 ## fe/fe-core/src/main/java/org/apache/doris/backup/RestoreJob.java: ## @@ -1994,84 +2016,16 @@ private void setTableStateToNormal(Database db, boolean committed, bo

Re: [PR] [feature](executor)Add switch enable_cgroup_cpu_soft_limit [doris]

2023-11-07 Thread via GitHub
wangbo merged PR #26510: URL: https://github.com/apache/doris/pull/26510 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apach

(doris) branch master updated: Add enable_cgroup_cpu_soft_limit (#26510)

2023-11-07 Thread wangbo
This is an automated email from the ASF dual-hosted git repository. wangbo pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 6637f9c15f9 Add enable_cgroup_cpu_soft_limit (#26

Re: [PR] [fix](move-memtable) pass load stream num to backends [doris]

2023-11-07 Thread via GitHub
github-actions[bot] commented on PR #26198: URL: https://github.com/apache/doris/pull/26198#issuecomment-1801259968 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [fix](move-memtable) pass load stream num to backends [doris]

2023-11-07 Thread via GitHub
github-actions[bot] commented on PR #26198: URL: https://github.com/apache/doris/pull/26198#issuecomment-1801259919 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [Opt](date_add/sub) Throw exception when result of date_add/sub out of range [doris]

2023-11-07 Thread via GitHub
doris-robot commented on PR #26475: URL: https://github.com/apache/doris/pull/26475#issuecomment-1801257556 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.13 seconds stream load tsv: 560 seconds loaded 74807831229 Bytes,

Re: [PR] [improvement](insert) support schema change and decommission for group commit [doris]

2023-11-07 Thread via GitHub
hust-hhb commented on PR #26359: URL: https://github.com/apache/doris/pull/26359#issuecomment-1801256869 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [regression-test](fix) fix case bug [doris]

2023-11-07 Thread via GitHub
shuke987 commented on PR #26578: URL: https://github.com/apache/doris/pull/26578#issuecomment-1801257086 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [fix](BE) unknown runtime filter when get filter from _consumer_map [doris]

2023-11-07 Thread via GitHub
doris-robot commented on PR #26570: URL: https://github.com/apache/doris/pull/26570#issuecomment-1801256227 TeamCity be ut coverage result: Function Coverage: 38.28% (7946/20755) Line Coverage: 30.17% (64490/213730) Region Coverage: 29.27% (33292/113740) Branch Coverage: 25.1

[PR] [regression-test](fix) fix case bug [doris]

2023-11-07 Thread via GitHub
shuke987 opened a new pull request, #26578: URL: https://github.com/apache/doris/pull/26578 ## Proposed changes pick #26561 into branch-2.0 Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at

Re: [I] flink-doris-connector写入日期数据为null [doris]

2023-11-07 Thread via GitHub
donsmile closed issue #26558: flink-doris-connector写入日期数据为null URL: https://github.com/apache/doris/issues/26558 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] [improvement](agg) speed up serialization of aggregation function collect_list/collect_set [doris]

2023-11-07 Thread via GitHub
JackDrogon commented on code in PR #26467: URL: https://github.com/apache/doris/pull/26467#discussion_r1386135259 ## be/src/vec/aggregate_functions/aggregate_function_collect.h: ## @@ -547,6 +559,25 @@ class AggregateFunctionCollect this->data(place).deserialize

Re: [PR] [don't merge] run move-memtable regression tests [doris]

2023-11-07 Thread via GitHub
doris-robot commented on PR #25796: URL: https://github.com/apache/doris/pull/25796#issuecomment-1801251274 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.43 seconds stream load tsv: 578 seconds loaded 74807831229 Bytes,

Re: [PR] [improvement](agg) speed up serialization of aggregation function collect_list/collect_set [doris]

2023-11-07 Thread via GitHub
JackDrogon commented on code in PR #26467: URL: https://github.com/apache/doris/pull/26467#discussion_r1386124927 ## be/src/agent/be_exec_version_manager.h: ## @@ -62,8 +62,10 @@ class BeExecVersionManager { *a. aggregation function do not serialize bitmap to string. *

Re: [PR] [feature](nereids) Support group commit insert [doris]

2023-11-07 Thread via GitHub
mymeiyi commented on code in PR #26075: URL: https://github.com/apache/doris/pull/26075#discussion_r1386132797 ## fe/fe-core/src/main/java/org/apache/doris/planner/GroupCommitPlanner.java: ## @@ -0,0 +1,181 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or

Re: [PR] [fix](transaction) Fix concurrent schema change and txn cause dead lock [doris]

2023-11-07 Thread via GitHub
luwei16 commented on PR #26428: URL: https://github.com/apache/doris/pull/26428#issuecomment-1801243781 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] [fix](schema change) fix bug of query failure after rename column [doris]

2023-11-07 Thread via GitHub
luwei16 commented on PR #26300: URL: https://github.com/apache/doris/pull/26300#issuecomment-1801242682 lgtm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] [enhancement](brpc) add a auto release closure to ensure the closue safety [doris]

2023-11-07 Thread via GitHub
doris-robot commented on PR #26567: URL: https://github.com/apache/doris/pull/26567#issuecomment-1801241245 TeamCity be ut coverage result: Function Coverage: 36.70% (8388/22858) Line Coverage: 29.21% (68007/232801) Region Coverage: 27.88% (35178/126198) Branch Coverage: 24.7

Re: [PR] [DNM](Nereids) test disable fallback [doris]

2023-11-07 Thread via GitHub
morrySnow commented on PR #25344: URL: https://github.com/apache/doris/pull/25344#issuecomment-1801240257 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [improvement](agg) speed up serialization of aggregation function collect_list/collect_set [doris]

2023-11-07 Thread via GitHub
github-actions[bot] commented on PR #26467: URL: https://github.com/apache/doris/pull/26467#issuecomment-1801238272 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [ci](perf) add new pipeline of tpch-sf100 [doris]

2023-11-07 Thread via GitHub
zhangstar333 merged PR #26334: URL: https://github.com/apache/doris/pull/26334 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris

Re: [PR] [fix](backup) Add repo id to local meta/info files to avoid overwriting [doris]

2023-11-07 Thread via GitHub
gavinchou commented on PR #26536: URL: https://github.com/apache/doris/pull/26536#issuecomment-1801237712 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

(doris) branch master updated (a3666aa87eb -> f018b00646e)

2023-11-07 Thread zhangstar333
This is an automated email from the ASF dual-hosted git repository. zhangstar333 pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from a3666aa87eb [feature](decimal) support decimal256 when creating table (#26308) add f018b00646e [ci](perf) a

Re: [PR] [improvement](agg) speed up serialization of aggregation function collect_list/collect_set [doris]

2023-11-07 Thread via GitHub
github-actions[bot] commented on PR #26467: URL: https://github.com/apache/doris/pull/26467#issuecomment-1801238221 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

(doris) branch branch-2.0 updated: [opt](Nereids) remove Nondeterministic trait from date related functions (#26444) (#26568)

2023-11-07 Thread morrysnow
This is an automated email from the ASF dual-hosted git repository. morrysnow pushed a commit to branch branch-2.0 in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/branch-2.0 by this push: new 9f76dde717d [opt](Nereids) remove Nond

Re: [PR] [opt](Nereids) remove Nondeterministic trait from date related functions (#26444) [doris]

2023-11-07 Thread via GitHub
morrySnow merged PR #26568: URL: https://github.com/apache/doris/pull/26568 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

Re: [PR] [fix](schema change) fix bug of query failure after rename column [doris]

2023-11-07 Thread via GitHub
doris-robot commented on PR #26300: URL: https://github.com/apache/doris/pull/26300#issuecomment-1801237292 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.38 seconds stream load tsv: 556 seconds loaded 74807831229 Bytes,

Re: [PR] [feature](nereids) Support group commit insert [doris]

2023-11-07 Thread via GitHub
mymeiyi commented on code in PR #26075: URL: https://github.com/apache/doris/pull/26075#discussion_r1386124046 ## regression-test/suites/insert_p0/insert_group_commit_with_prepare_stmt_nereids.groovy: ## @@ -0,0 +1,111 @@ +// Licensed to the Apache Software Foundation (ASF) unde

Re: [PR] [ci](perf) add new pipeline of tpch-sf100 [doris]

2023-11-07 Thread via GitHub
github-actions[bot] commented on PR #26334: URL: https://github.com/apache/doris/pull/26334#issuecomment-1801236992 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix](action) Update pr-approve-status.yml [doris]

2023-11-07 Thread via GitHub
github-actions[bot] commented on PR #26577: URL: https://github.com/apache/doris/pull/26577#issuecomment-1801236773 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [fix](action) Update pr-approve-status.yml [doris]

2023-11-07 Thread via GitHub
github-actions[bot] commented on PR #26577: URL: https://github.com/apache/doris/pull/26577#issuecomment-1801236720 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix](nereids)only enable colocate scan for one phase global parttion topn in some condition [doris]

2023-11-07 Thread via GitHub
starocean999 commented on PR #26473: URL: https://github.com/apache/doris/pull/26473#issuecomment-1801234448 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [fix](planner)isnull predicate can't be safely constant folded in inlineview [doris]

2023-11-07 Thread via GitHub
starocean999 commented on PR #25377: URL: https://github.com/apache/doris/pull/25377#issuecomment-1801234390 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [fix](nereids)don't normalize column name for base index [doris]

2023-11-07 Thread via GitHub
starocean999 commented on PR #26476: URL: https://github.com/apache/doris/pull/26476#issuecomment-1801234499 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [fix](action) Update pr-approve-status.yml [doris]

2023-11-07 Thread via GitHub
hello-stephen commented on PR #26577: URL: https://github.com/apache/doris/pull/26577#issuecomment-1801232175 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] [Opt](date_add/sub) Throw exception when result of date_add/sub out of range [doris]

2023-11-07 Thread via GitHub
doris-robot commented on PR #26475: URL: https://github.com/apache/doris/pull/26475#issuecomment-1801231937 TeamCity be ut coverage result: Function Coverage: 36.71% (8389/22851) Line Coverage: 29.21% (68011/232810) Region Coverage: 27.87% (35172/126196) Branch Coverage: 24.7

Re: [PR] [feature](nereids) Support group commit insert [doris]

2023-11-07 Thread via GitHub
mymeiyi commented on code in PR #26075: URL: https://github.com/apache/doris/pull/26075#discussion_r1386119613 ## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/InsertIntoTableCommand.java: ## @@ -152,7 +163,15 @@ public void run(ConnectContext ctx, StmtE

[PR] [fix](action) Update pr-approve-status.yml [doris]

2023-11-07 Thread via GitHub
hello-stephen opened a new pull request, #26577: URL: https://github.com/apache/doris/pull/26577 According to https://docs.github.com/en/rest/pulls/reviews?apiVersion=2022-11-28#list-reviews-for-a-pull-request the number of results per page default is 30 (max 100). review of APPROVED

Re: [PR] [improvement](meta) Improve the performance of getting expr name [doris]

2023-11-07 Thread via GitHub
github-actions[bot] commented on PR #26341: URL: https://github.com/apache/doris/pull/26341#issuecomment-1801227279 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [improvement](meta) Improve the performance of getting expr name [doris]

2023-11-07 Thread via GitHub
github-actions[bot] commented on PR #26341: URL: https://github.com/apache/doris/pull/26341#issuecomment-1801227321 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [fix](load)when enable_single_replica_load = true, load not failed a… [doris]

2023-11-07 Thread via GitHub
dataroaring commented on PR #26503: URL: https://github.com/apache/doris/pull/26503#issuecomment-1801227329 Could you explain it more? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

(doris) branch master updated (be7d49cb9f4 -> a3666aa87eb)

2023-11-07 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from be7d49cb9f4 [Fix](doc) Fixed some errors in the documentation (#26410) add a3666aa87eb [feature](decimal) suppor

Re: [PR] [feature](decimal) support creating table columns with type decimal256 [doris]

2023-11-07 Thread via GitHub
yiguolei merged PR #26308: URL: https://github.com/apache/doris/pull/26308 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

Re: [PR] [opt](Nereids) let DataType toSql same with legacy planner [doris]

2023-11-07 Thread via GitHub
morrySnow commented on PR #26576: URL: https://github.com/apache/doris/pull/26576#issuecomment-1801225376 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

(doris) branch master updated: [Fix](doc) Fixed some errors in the documentation (#26410)

2023-11-07 Thread dataroaring
This is an automated email from the ASF dual-hosted git repository. dataroaring pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new be7d49cb9f4 [Fix](doc) Fixed some errors in

Re: [PR] [Fix](doc) Fixed some errors in the documentation [doris]

2023-11-07 Thread via GitHub
dataroaring merged PR #26410: URL: https://github.com/apache/doris/pull/26410 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.

[PR] [opt](Nereids) let DataType toSql same with legacy planner [doris]

2023-11-07 Thread via GitHub
morrySnow opened a new pull request, #26576: URL: https://github.com/apache/doris/pull/26576 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailt

Re: [PR] [Fix](doc) Fixed some errors in the documentation [doris]

2023-11-07 Thread via GitHub
github-actions[bot] commented on PR #26410: URL: https://github.com/apache/doris/pull/26410#issuecomment-1801224016 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

(doris) branch master updated (5d4557938af -> f80495da837)

2023-11-07 Thread morrysnow
This is an automated email from the ASF dual-hosted git repository. morrysnow pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 5d4557938af [regression-test](fix) fix export_struct bug (#26561) add f80495da837 [fix](Nereids) ban right oute

Re: [PR] [fix](BE) unknown runtime filter when get filter from _consumer_map [doris]

2023-11-07 Thread via GitHub
morrySnow commented on PR #26570: URL: https://github.com/apache/doris/pull/26570#issuecomment-1801222117 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [Enhancemant](HLL) support export doris hll/bitmap data type [doris-spark-connector]

2023-11-07 Thread via GitHub
GoGoWen commented on PR #153: URL: https://github.com/apache/doris-spark-connector/pull/153#issuecomment-1801222476 > Can you post a usage example for this? Because I saw that Doris does not support converting Bitmap and HLL type data into arrow for spark to read ? https://github.com/apach

Re: [PR] [fix](Nereids) ban right outer, right anti, full outer with bucket shuffle [doris]

2023-11-07 Thread via GitHub
morrySnow merged PR #26529: URL: https://github.com/apache/doris/pull/26529 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

Re: [PR] [Fix](Planner) fix varchar does not show real length [doris]

2023-11-07 Thread via GitHub
LiBinfeng-01 commented on PR #25171: URL: https://github.com/apache/doris/pull/25171#issuecomment-1801221497 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [Improve](ddl) Use RecycleBin to force drop db/table asynchronously [doris]

2023-11-07 Thread via GitHub
github-actions[bot] commented on PR #26563: URL: https://github.com/apache/doris/pull/26563#issuecomment-1801216743 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [Improve](ddl) Use RecycleBin to force drop db/table asynchronously [doris]

2023-11-07 Thread via GitHub
github-actions[bot] commented on PR #26563: URL: https://github.com/apache/doris/pull/26563#issuecomment-1801216694 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [refactor](jni) unified jni framework for jdbc catalog [doris]

2023-11-07 Thread via GitHub
morningman commented on code in PR #26317: URL: https://github.com/apache/doris/pull/26317#discussion_r1384767458 ## fe/be-java-extensions/jdbc-scanner/src/main/java/org/apache/doris/jdbc/JdbcExecutor.java: ## @@ -483,1071 +362,402 @@ private void setValidationQuery(DruidDataSou

Re: [PR] [Opt](date_add/sub) Throw exception when result of date_add/sub out of range [doris]

2023-11-07 Thread via GitHub
github-actions[bot] commented on PR #26475: URL: https://github.com/apache/doris/pull/26475#issuecomment-1801211398 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [enhancement](brpc) add a auto release closure to ensure the closue safety [doris]

2023-11-07 Thread via GitHub
github-actions[bot] commented on code in PR #26567: URL: https://github.com/apache/doris/pull/26567#discussion_r1386101353 ## be/src/util/ref_count_closure.h: ## @@ -54,4 +54,85 @@ class RefCountClosure : public google::protobuf::Closure { std::atomic _refs; }; +template

Re: [PR] [enhancement](brpc) add a auto release closure to ensure the closue safety [doris]

2023-11-07 Thread via GitHub
github-actions[bot] commented on code in PR #26567: URL: https://github.com/apache/doris/pull/26567#discussion_r1386100841 ## be/src/util/ref_count_closure.h: ## @@ -54,4 +54,85 @@ class RefCountClosure : public google::protobuf::Closure { std::atomic _refs; }; +template

Re: [PR] [enhancement](brpc) add a auto release closure to ensure the closue safety [doris]

2023-11-07 Thread via GitHub
github-actions[bot] commented on PR #26567: URL: https://github.com/apache/doris/pull/26567#issuecomment-1801208763 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](Nereids) ban right outer, right anti, full outer with bucket shuffle [doris]

2023-11-07 Thread via GitHub
github-actions[bot] commented on PR #26529: URL: https://github.com/apache/doris/pull/26529#issuecomment-1801206238 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [enhancement](brpc) add a auto release closure to ensure the closue safety [doris]

2023-11-07 Thread via GitHub
github-actions[bot] commented on code in PR #26567: URL: https://github.com/apache/doris/pull/26567#discussion_r1386095548 ## be/src/util/ref_count_closure.h: ## @@ -54,4 +54,85 @@ class RefCountClosure : public google::protobuf::Closure { std::atomic _refs; }; +template

Re: [PR] [Opt](date_add/sub) Throw exception when result of date_add/sub out of range [doris]

2023-11-07 Thread via GitHub
zhiqiang- commented on PR #26475: URL: https://github.com/apache/doris/pull/26475#issuecomment-1801204232 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] [Feature](Planner) Support hint in `insert into` statement [doris]

2023-11-07 Thread via GitHub
zhannngchen commented on code in PR #26008: URL: https://github.com/apache/doris/pull/26008#discussion_r1386094057 ## fe/fe-core/src/test/java/org/apache/doris/analysis/SelectStmtTest.java: ## @@ -588,7 +588,7 @@ public void testSelectHints() throws Exception { } @Te

Re: [PR] [enhancement](brpc) add a auto release closure to ensure the closue safety [doris]

2023-11-07 Thread via GitHub
yiguolei commented on PR #26567: URL: https://github.com/apache/doris/pull/26567#issuecomment-1801202107 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [enhancement](brpc) add a auto release closure to ensure the closue safety [doris]

2023-11-07 Thread via GitHub
github-actions[bot] commented on code in PR #26567: URL: https://github.com/apache/doris/pull/26567#discussion_r1386093372 ## be/src/util/ref_count_closure.h: ## @@ -54,4 +54,88 @@ class RefCountClosure : public google::protobuf::Closure { std::atomic _refs; }; +template

Re: [PR] [Feature](Planner) Support hint in `insert into` statement [doris]

2023-11-07 Thread via GitHub
zhannngchen commented on code in PR #26008: URL: https://github.com/apache/doris/pull/26008#discussion_r1386093427 ## fe/fe-core/src/test/java/org/apache/doris/nereids/preprocess/StatementHintTest.java: ## @@ -36,7 +36,7 @@ import org.junit.jupiter.api.BeforeAll; import org.ju

(doris) branch master updated: [regression-test](fix) fix export_struct bug (#26561)

2023-11-07 Thread dataroaring
This is an automated email from the ASF dual-hosted git repository. dataroaring pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 5d4557938af [regression-test](fix) fix expor

Re: [PR] [enhancement](brpc) add a auto release closure to ensure the closue safety [doris]

2023-11-07 Thread via GitHub
github-actions[bot] commented on code in PR #26567: URL: https://github.com/apache/doris/pull/26567#discussion_r1386093154 ## be/src/util/ref_count_closure.h: ## @@ -54,4 +54,88 @@ class RefCountClosure : public google::protobuf::Closure { std::atomic _refs; }; +template

Re: [PR] [regression-test](fix) fix case bug [doris]

2023-11-07 Thread via GitHub
dataroaring merged PR #26561: URL: https://github.com/apache/doris/pull/26561 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.

Re: [PR] [Fix](be log)Support BE log 'sys_log_level' modify to take effect dynamically #26060 [doris]

2023-11-07 Thread via GitHub
yiguolei commented on PR #26061: URL: https://github.com/apache/doris/pull/26061#issuecomment-1801200465 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[PR] [feature](planner)Using cpu hard limit as session var [doris]

2023-11-07 Thread via GitHub
wangbo opened a new pull request, #26575: URL: https://github.com/apache/doris/pull/26575 ## Proposed changes 1 add forceGlobal for VarAttr. 2 using cpu_hard_limit as session var. -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] [cases](regression-test) add unique and duplicate backup and restore … [doris]

2023-11-07 Thread via GitHub
felixwluo commented on PR #26491: URL: https://github.com/apache/doris/pull/26491#issuecomment-1801199569 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [fix](schema change) fix bug of query failure after rename column [doris]

2023-11-07 Thread via GitHub
luwei16 commented on PR #26300: URL: https://github.com/apache/doris/pull/26300#issuecomment-1801198859 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [regression-test](fix) fix case bug [doris]

2023-11-07 Thread via GitHub
github-actions[bot] commented on PR #26561: URL: https://github.com/apache/doris/pull/26561#issuecomment-1801196751 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [Coverage](BE) Delete vinfo_func in BE [doris]

2023-11-07 Thread via GitHub
github-actions[bot] commented on PR #26562: URL: https://github.com/apache/doris/pull/26562#issuecomment-1801194125 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [refactor](jni) unified jni framework for jdbc catalog [doris]

2023-11-07 Thread via GitHub
github-actions[bot] commented on PR #26317: URL: https://github.com/apache/doris/pull/26317#issuecomment-1801192408 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [feature](decimal) support creating table columns with type decimal256 [doris]

2023-11-07 Thread via GitHub
github-actions[bot] commented on PR #26308: URL: https://github.com/apache/doris/pull/26308#issuecomment-1801191174 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [feature](decimal) support creating table columns with type decimal256 [doris]

2023-11-07 Thread via GitHub
github-actions[bot] commented on PR #26308: URL: https://github.com/apache/doris/pull/26308#issuecomment-1801191125 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [ci](perf) add new pipeline of tpch-sf100 [doris]

2023-11-07 Thread via GitHub
github-actions[bot] commented on PR #26334: URL: https://github.com/apache/doris/pull/26334#issuecomment-1801190479 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

(doris) branch master updated (44b51bf0b9e -> fc304c0e7cd)

2023-11-07 Thread ashingau
This is an automated email from the ASF dual-hosted git repository. ashingau pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 44b51bf0b9e [Feature](Variant) support variant load (#26572) add fc304c0e7cd (metric) add histogramJsonMetric an

Re: [PR] [opt](metric) add histogramJsonMetric and nodeInfo [doris]

2023-11-07 Thread via GitHub
AshinGau merged PR #26172: URL: https://github.com/apache/doris/pull/26172 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

Re: [PR] [Coverage](BE) Delete vinfo_func in BE [doris]

2023-11-07 Thread via GitHub
github-actions[bot] commented on PR #26562: URL: https://github.com/apache/doris/pull/26562#issuecomment-1801188849 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [Fix](partial update) Fix partial update info loss when the delete bitmaps of the committed transactions are calculated by the compaction [doris]

2023-11-07 Thread via GitHub
github-actions[bot] commented on PR #26556: URL: https://github.com/apache/doris/pull/26556#issuecomment-1801188064 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [regression-test](fix) fix case bug [doris]

2023-11-07 Thread via GitHub
github-actions[bot] commented on PR #26561: URL: https://github.com/apache/doris/pull/26561#issuecomment-1801188105 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [regression-test](framework) support Non concurrent mode in branch-2.0 [doris]

2023-11-07 Thread via GitHub
shuke987 commented on PR #26574: URL: https://github.com/apache/doris/pull/26574#issuecomment-1801187519 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [Fix](partial update) Fix partial update info loss when the delete bitmaps of the committed transactions are calculated by the compaction [doris]

2023-11-07 Thread via GitHub
github-actions[bot] commented on PR #26556: URL: https://github.com/apache/doris/pull/26556#issuecomment-1801188021 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[PR] [regression-test](framework) support Non concurrent mode in branch-2.0 [doris]

2023-11-07 Thread via GitHub
shuke987 opened a new pull request, #26574: URL: https://github.com/apache/doris/pull/26574 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto

Re: [PR] [fix](Nereids) ban right outer, right anti, full outer with bucket shuffle [doris]

2023-11-07 Thread via GitHub
github-actions[bot] commented on PR #26529: URL: https://github.com/apache/doris/pull/26529#issuecomment-1801185009 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [Feature](Variant) support variant load [doris]

2023-11-07 Thread via GitHub
xiaokang merged PR #26572: URL: https://github.com/apache/doris/pull/26572 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

Re: [PR] [fix](BE) unknown runtime filter when get filter from _consumer_map [doris]

2023-11-07 Thread via GitHub
github-actions[bot] commented on PR #26570: URL: https://github.com/apache/doris/pull/26570#issuecomment-1801181613 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[PR] [fix](fe)some aggregate function should be nullable in window function [doris]

2023-11-07 Thread via GitHub
starocean999 opened a new pull request, #26573: URL: https://github.com/apache/doris/pull/26573 sum, max, min and avg should be nullable if they are in window function Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, ki

Re: [PR] [Feature](Variant) support variant load [doris]

2023-11-07 Thread via GitHub
xiaokang commented on PR #26572: URL: https://github.com/apache/doris/pull/26572#issuecomment-1801182600 this pr is a clone of #24554 , which is reviewed but github workflow does not work. -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] [only test] avoid_using_blocked_queue [doris]

2023-11-07 Thread via GitHub
doris-robot commented on PR #26571: URL: https://github.com/apache/doris/pull/26571#issuecomment-1801181315 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.71 seconds stream load tsv: 560 seconds loaded 74807831229 Bytes,

Re: [PR] [Feature](Variant) support variant load [doris]

2023-11-07 Thread via GitHub
github-actions[bot] commented on PR #26572: URL: https://github.com/apache/doris/pull/26572#issuecomment-1801179013 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [opt](nereids) use 2 phase agg above union all [doris]

2023-11-07 Thread via GitHub
github-actions[bot] commented on PR #26245: URL: https://github.com/apache/doris/pull/26245#issuecomment-1801179036 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [Feature](Variant) support variant load [doris]

2023-11-07 Thread via GitHub
github-actions[bot] commented on PR #26572: URL: https://github.com/apache/doris/pull/26572#issuecomment-1801178973 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [Feature](Variant) support variant load [doris]

2023-11-07 Thread via GitHub
github-actions[bot] commented on code in PR #26572: URL: https://github.com/apache/doris/pull/26572#discussion_r1386069235 ## be/src/olap/rowset/beta_rowset_writer.cpp: ## @@ -544,6 +551,24 @@ bool BetaRowsetWriter::_is_segment_overlapping( return false; } +// update tab

Re: [PR] [fix](JdbcCatalog) fix that the predicate column name does not have back quote when querying the JDBC appearance [doris]

2023-11-07 Thread via GitHub
BePPPower commented on PR #26479: URL: https://github.com/apache/doris/pull/26479#issuecomment-1801175607 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [fix](BE) unknown runtime filter when get filter from _consumer_map [doris]

2023-11-07 Thread via GitHub
englefly commented on PR #26570: URL: https://github.com/apache/doris/pull/26570#issuecomment-1801173487 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

  1   2   3   4   5   6   7   8   9   >