Re: [PR] [nereids](map_agg)support map_agg in nereids [doris]

2023-10-10 Thread via GitHub
morrySnow commented on code in PR #25246: URL: https://github.com/apache/doris/pull/25246#discussion_r1354242529 ## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/agg/MapAgg.java: ## @@ -0,0 +1,92 @@ +// Licensed to the Apache Software Foundation (

Re: [PR] [feature](hive)Support hive tables after alter type. [doris]

2023-10-10 Thread via GitHub
github-actions[bot] commented on code in PR #25138: URL: https://github.com/apache/doris/pull/25138#discussion_r1354273370 ## be/src/vec/exec/format/parquet/vparquet_column_reader.cpp: ## @@ -476,6 +480,16 @@ Status ScalarColumnReader::_try_load_dict_page(bool* loaded, bool* ha

Re: [PR] [improvement](Block) Replace Block(const PBlock&) with deserialize because it has heavy operations in ctor [doris]

2023-10-10 Thread via GitHub
github-actions[bot] commented on PR #25291: URL: https://github.com/apache/doris/pull/25291#issuecomment-1756960068 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [function](nereids) support array_apply/array_repeat/group_uniq_array/ipv4numtostring [doris]

2023-10-10 Thread via GitHub
englefly commented on PR #25249: URL: https://github.com/apache/doris/pull/25249#issuecomment-1756957608 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [Enhancement](filter) support only min/max runtime filter in BE [doris]

2023-10-10 Thread via GitHub
github-actions[bot] commented on PR #25290: URL: https://github.com/apache/doris/pull/25290#issuecomment-1756955215 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [function](nereids) support array_apply/array_repeat/group_uniq_array/ipv4numtostring [doris]

2023-10-10 Thread via GitHub
englefly commented on code in PR #25249: URL: https://github.com/apache/doris/pull/25249#discussion_r1354264521 ## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/ArrayApply.java: ## @@ -0,0 +1,68 @@ +// Licensed to the Apache Software Founda

Re: [PR] [opt](load)change `load_to_single_tablet` tablet search algorithm from random to round-robin [doris]

2023-10-10 Thread via GitHub
github-actions[bot] commented on PR #25256: URL: https://github.com/apache/doris/pull/25256#issuecomment-1756943894 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[PR] [improvement](Block) Replace Block(const PBlock&) with deserialize because it has heavy operations in ctor [doris]

2023-10-10 Thread via GitHub
jacktengg opened a new pull request, #25291: URL: https://github.com/apache/doris/pull/25291 Pick from master #23672 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion a

Re: [PR] [function](nereids) support array_apply/array_repeat/group_uniq_array/ipv4numtostring [doris]

2023-10-10 Thread via GitHub
englefly commented on code in PR #25249: URL: https://github.com/apache/doris/pull/25249#discussion_r1354189064 ## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/ArrayApply.java: ## @@ -0,0 +1,68 @@ +// Licensed to the Apache Software Founda

Re: [PR] [function](nereids) support array_apply/array_repeat/group_uniq_array/ipv4numtostring [doris]

2023-10-10 Thread via GitHub
englefly commented on code in PR #25249: URL: https://github.com/apache/doris/pull/25249#discussion_r1354187452 ## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/ArrayApply.java: ## @@ -0,0 +1,68 @@ +// Licensed to the Apache Software Founda

Re: [PR] [Fix](Outfile) Use data_type_serde to export data to `parquet` file format [doris]

2023-10-10 Thread via GitHub
BePPPower commented on PR #24998: URL: https://github.com/apache/doris/pull/24998#issuecomment-1756890349 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [fix](Nereids) support nested complex type literal [doris]

2023-10-10 Thread via GitHub
morrySnow commented on PR #25287: URL: https://github.com/apache/doris/pull/25287#issuecomment-1756884690 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[PR] [Enhancement](filter) support only min/max runtime filter in BE [doris]

2023-10-10 Thread via GitHub
zhangstar333 opened a new pull request, #25290: URL: https://github.com/apache/doris/pull/25290 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](ma

Re: [PR] [improvement](fe and broker) support specify broker to getSplits, check isSplitable, file scan for HMS Multi-catalog [doris]

2023-10-10 Thread via GitHub
zhangguoqiang666 commented on PR #24830: URL: https://github.com/apache/doris/pull/24830#issuecomment-1756877070 run external -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [improvement](fe and broker) support specify broker to getSplits, check isSplitable, file scan for HMS Multi-catalog [doris]

2023-10-10 Thread via GitHub
zhangguoqiang666 commented on PR #24830: URL: https://github.com/apache/doris/pull/24830#issuecomment-1756873562 run external -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [pipelineX](operator) Support Set Operators [doris]

2023-10-10 Thread via GitHub
Gabriel39 closed pull request #25140: [pipelineX](operator) Support Set Operators URL: https://github.com/apache/doris/pull/25140 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] [opt](load)change `load_to_single_tablet` tablet search algorithm from random to round-robin [doris]

2023-10-10 Thread via GitHub
qidaye commented on code in PR #25256: URL: https://github.com/apache/doris/pull/25256#discussion_r1354147234 ## fe/fe-core/src/main/java/org/apache/doris/planner/SingleTabletLoadRecorderMgr.java: ## @@ -0,0 +1,119 @@ +// Licensed to the Apache Software Foundation (ASF) under on

Re: [PR] [feature](Nereids) covert predicate to sargable [doris]

2023-10-10 Thread via GitHub
doris-robot commented on PR #25180: URL: https://github.com/apache/doris/pull/25180#issuecomment-1756856860 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 44.93 seconds stream load tsv: 557 seconds loaded 74807831229 Bytes,

Re: [PR] [enhancement](Nereids): JoinCommute don't check bottom join [doris]

2023-10-10 Thread via GitHub
doris-robot commented on PR #25163: URL: https://github.com/apache/doris/pull/25163#issuecomment-1756844468 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.25 seconds stream load tsv: 559 seconds loaded 74807831229 Bytes,

Re: [PR] [enhancement](regression-test) add routine load json case [doris]

2023-10-10 Thread via GitHub
HHoflittlefish777 commented on PR #25253: URL: https://github.com/apache/doris/pull/25253#issuecomment-1756840376 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] [only test](pipelineX) test pipelineX without insert [doris]

2023-10-10 Thread via GitHub
doris-robot commented on PR #25269: URL: https://github.com/apache/doris/pull/25269#issuecomment-1756839932 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.29 seconds stream load tsv: 558 seconds loaded 74807831229 Bytes,

Re: [PR] [only test](pipelineX) test pipelineX without insert [doris]

2023-10-10 Thread via GitHub
doris-robot commented on PR #25269: URL: https://github.com/apache/doris/pull/25269#issuecomment-1756828205 TeamCity be ut coverage result: Function Coverage: 36.34% (8151/22431) Line Coverage: 28.46% (65180/229036) Region Coverage: 27.38% (33780/123358) Branch Coverage: 24.0

Re: [PR] [feature](Nereids) covert predicate to sargable [doris]

2023-10-10 Thread via GitHub
XieJiann commented on PR #25180: URL: https://github.com/apache/doris/pull/25180#issuecomment-1756826454 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [improvement](compaction) optimize compaction mem tracker statistics [doris]

2023-10-10 Thread via GitHub
doris-robot commented on PR #23385: URL: https://github.com/apache/doris/pull/23385#issuecomment-1756822495 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.29 seconds stream load tsv: 561 seconds loaded 74807831229 Bytes,

Re: [PR] [only test](pipelineX) test pipelineX without insert [doris]

2023-10-10 Thread via GitHub
github-actions[bot] commented on code in PR #25269: URL: https://github.com/apache/doris/pull/25269#discussion_r1354109820 ## be/src/pipeline/exec/set_probe_sink_operator.h: ## @@ -45,7 +42,7 @@ class SetProbeSinkOperatorBuilder final public: SetProbeSinkOperatorBuilder(

Re: [I] [Bug] INTERNAL_ERROR]Unknown expr node type: 0 [doris]

2023-10-10 Thread via GitHub
xavierzhao commented on issue #25215: URL: https://github.com/apache/doris/issues/25215#issuecomment-1756817964 > > > I tested it according to your sql script and got the result > > > ![image](https://user-images.githubusercontent.com/48236177/274118800-721e78e0-77c4-4990-bf9b-8b0eb557d2f

Re: [PR] [enhancement](Nereids): JoinCommute don't check bottom join [doris]

2023-10-10 Thread via GitHub
jackwener commented on PR #25163: URL: https://github.com/apache/doris/pull/25163#issuecomment-1756815476 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[doris] branch master updated: [fix](Nereids) fix toSql of date literal (#25243)

2023-10-10 Thread jakevin
This is an automated email from the ASF dual-hosted git repository. jakevin pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 47578c0fc9c [fix](Nereids) fix toSql of date lit

Re: [PR] [fix](Nereids) fix `toSql` of date literal [doris]

2023-10-10 Thread via GitHub
jackwener merged PR #25243: URL: https://github.com/apache/doris/pull/25243 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

Re: [PR] [only test](pipelineX) test pipelineX without insert [doris]

2023-10-10 Thread via GitHub
Mryange commented on PR #25269: URL: https://github.com/apache/doris/pull/25269#issuecomment-1756813049 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [only test](pipelineX) test pipelineX without insert [doris]

2023-10-10 Thread via GitHub
Mryange commented on PR #25269: URL: https://github.com/apache/doris/pull/25269#issuecomment-1756812967 now test partition sort fix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] [Fix](Outfile) Use data_type_serde to export data to `parquet` file format [doris]

2023-10-10 Thread via GitHub
doris-robot commented on PR #24998: URL: https://github.com/apache/doris/pull/24998#issuecomment-1756811860 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.01 seconds stream load tsv: 557 seconds loaded 74807831229 Bytes,

Re: [PR] [improvement](compaction) optimize compaction mem tracker statistics [doris]

2023-10-10 Thread via GitHub
doris-robot commented on PR #23385: URL: https://github.com/apache/doris/pull/23385#issuecomment-1756809600 TeamCity be ut coverage result: Function Coverage: 36.27% (8156/22490) Line Coverage: 28.38% (65243/229910) Region Coverage: 27.30% (33799/123809) Branch Coverage: 24.0

Re: [PR] [Fix](Outfile) Use data_type_serde to export data to `parquet` file format [doris]

2023-10-10 Thread via GitHub
doris-robot commented on PR #24998: URL: https://github.com/apache/doris/pull/24998#issuecomment-1756791048 TeamCity be ut coverage result: Function Coverage: 36.26% (8152/22484) Line Coverage: 28.43% (65185/229281) Region Coverage: 27.39% (33791/123375) Branch Coverage: 24.0

Re: [PR] [fix](broker-load) fix use_count() issue when doing broker load in debug mode [doris]

2023-10-10 Thread via GitHub
github-actions[bot] commented on PR #25288: URL: https://github.com/apache/doris/pull/25288#issuecomment-1756783404 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](Nereids) support nested complex type literal [doris]

2023-10-10 Thread via GitHub
doris-robot commented on PR #25287: URL: https://github.com/apache/doris/pull/25287#issuecomment-1756769559 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.25 seconds stream load tsv: 569 seconds loaded 74807831229 Bytes,

[PR] [fix](broker-load) fix use_count() issue when doing broker load in debug mode [doris]

2023-10-10 Thread via GitHub
morningman opened a new pull request, #25288: URL: https://github.com/apache/doris/pull/25288 ## Proposed changes When executing broker load in ASAN mode, BE may crash with error: ``` F20231010 18:18:17.044978 185490 block.cpp:694] Check failed: d.column->use_count() == 1 (3 vs.

Re: [PR] [Fix](Outfile) Use data_type_serde to export data to `parquet` file format [doris]

2023-10-10 Thread via GitHub
BePPPower commented on PR #24998: URL: https://github.com/apache/doris/pull/24998#issuecomment-1756765546 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [Improvement](statistics) Improve sample count accuracy. [doris]

2023-10-10 Thread via GitHub
doris-robot commented on PR #25175: URL: https://github.com/apache/doris/pull/25175#issuecomment-1756765159 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.11 seconds stream load tsv: 563 seconds loaded 74807831229 Bytes,

Re: [PR] [fix](Tvf) return empty set when tvf queries an empty file or an error uri [doris]

2023-10-10 Thread via GitHub
doris-robot commented on PR #25280: URL: https://github.com/apache/doris/pull/25280#issuecomment-1756764586 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.47 seconds stream load tsv: 560 seconds loaded 74807831229 Bytes,

Re: [PR] [Fix](Outfile) Use data_type_serde to export data to `parquet` file format [doris]

2023-10-10 Thread via GitHub
BePPPower commented on PR #24998: URL: https://github.com/apache/doris/pull/24998#issuecomment-1756759934 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [fix](Tvf) return empty set when tvf queries an empty file or an error uri [doris]

2023-10-10 Thread via GitHub
doris-robot commented on PR #25280: URL: https://github.com/apache/doris/pull/25280#issuecomment-1756758197 TeamCity be ut coverage result: Function Coverage: 36.24% (8149/22486) Line Coverage: 28.35% (65162/229840) Region Coverage: 27.28% (33768/123775) Branch Coverage: 23.9

Re: [PR] [improvement](fe and broker) support specify broker to getSplits, check isSplitable, file scan for HMS Multi-catalog [doris]

2023-10-10 Thread via GitHub
morningman commented on PR #24830: URL: https://github.com/apache/doris/pull/24830#issuecomment-1756748490 run buidall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [Fix](row store) Real default value should be used instead of default… [doris]

2023-10-10 Thread via GitHub
eldenmoon commented on code in PR #25230: URL: https://github.com/apache/doris/pull/25230#discussion_r1353991012 ## be/src/vec/jsonb/serialize.cpp: ## @@ -98,11 +102,20 @@ void JsonbSerializeUtil::jsonb_to_block(const DataTypeSerDeSPtrs& serdes, const } if (filled_col

Re: [PR] [Fix](row store) Real default value should be used instead of default… [doris]

2023-10-10 Thread via GitHub
eldenmoon commented on code in PR #25230: URL: https://github.com/apache/doris/pull/25230#discussion_r1353990502 ## gensrc/thrift/Descriptors.thrift: ## @@ -62,6 +62,7 @@ struct TSlotDescriptor { 14: optional bool is_auto_increment = false; // subcolumn path info list for

Re: [PR] [Fix](row store) Real default value should be used instead of default… [doris]

2023-10-10 Thread via GitHub
eldenmoon commented on code in PR #25230: URL: https://github.com/apache/doris/pull/25230#discussion_r1353990022 ## regression-test/suites/point_query_p0/test_point_query.groovy: ## @@ -188,10 +188,10 @@ suite("test_point_query") { qe_point_select stmt qe_point_sel

Re: [PR] [improvement](compaction) optimize compaction mem tracker statistics [doris]

2023-10-10 Thread via GitHub
hust-hhb commented on PR #23385: URL: https://github.com/apache/doris/pull/23385#issuecomment-1756737145 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [function](nereids) support array_apply/array_repeat/group_uniq_array/ipv4numtostring [doris]

2023-10-10 Thread via GitHub
XieJiann commented on code in PR #25249: URL: https://github.com/apache/doris/pull/25249#discussion_r1353985541 ## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/ArrayApply.java: ## @@ -0,0 +1,68 @@ +// Licensed to the Apache Software Founda

Re: [PR] [function](nereids) support array_apply/array_repeat/group_uniq_array/ipv4numtostring [doris]

2023-10-10 Thread via GitHub
XieJiann commented on code in PR #25249: URL: https://github.com/apache/doris/pull/25249#discussion_r1353985541 ## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/ArrayApply.java: ## @@ -0,0 +1,68 @@ +// Licensed to the Apache Software Founda

Re: [PR] [Fix](row store) Real default value should be used instead of default… [doris]

2023-10-10 Thread via GitHub
xiaokang commented on code in PR #25230: URL: https://github.com/apache/doris/pull/25230#discussion_r1353981226 ## regression-test/suites/point_query_p0/test_point_query.groovy: ## @@ -188,10 +188,10 @@ suite("test_point_query") { qe_point_select stmt qe_point_sele

Re: [PR] [enhancement](compaction) record base compaction schedule time and status [doris]

2023-10-10 Thread via GitHub
doris-robot commented on PR #25283: URL: https://github.com/apache/doris/pull/25283#issuecomment-1756731714 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.71 seconds stream load tsv: 564 seconds loaded 74807831229 Bytes,

Re: [PR] [fix](Nereids) support nested complex type literal [doris]

2023-10-10 Thread via GitHub
morrySnow commented on PR #25287: URL: https://github.com/apache/doris/pull/25287#issuecomment-1756730088 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[PR] [fix](Nereids) support nested complex type literal [doris]

2023-10-10 Thread via GitHub
morrySnow opened a new pull request, #25287: URL: https://github.com/apache/doris/pull/25287 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailt

Re: [PR] [typo](docs) add 'order by' when use 'limit m,n' [doris]

2023-10-10 Thread via GitHub
zy-kkk commented on PR #24236: URL: https://github.com/apache/doris/pull/24236#issuecomment-1756728434 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] [function](nereids) support array_apply/array_repeat/group_uniq_array/ipv4numtostring [doris]

2023-10-10 Thread via GitHub
XieJiann commented on code in PR #25249: URL: https://github.com/apache/doris/pull/25249#discussion_r1353977281 ## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/ArrayApply.java: ## @@ -0,0 +1,68 @@ +// Licensed to the Apache Software Founda

Re: [PR] [fix](Tvf) return empty set when tvf queries an empty file or an error uri [doris]

2023-10-10 Thread via GitHub
github-actions[bot] commented on PR #25280: URL: https://github.com/apache/doris/pull/25280#issuecomment-1756727270 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [Bug](delete) Use date as common type for date comparison [doris]

2023-10-10 Thread via GitHub
Gabriel39 merged PR #25262: URL: https://github.com/apache/doris/pull/25262 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

[doris] branch master updated: [Bug](delete) Use date as common type for date comparison (#25262)

2023-10-10 Thread gabriellee
This is an automated email from the ASF dual-hosted git repository. gabriellee pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 0d603dd4c35 [Bug](delete) Use date as common

[doris] branch master updated (cdf5f0fe687 -> bb670118f53)

2023-10-10 Thread gabriellee
This is an automated email from the ASF dual-hosted git repository. gabriellee pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from cdf5f0fe687 [fix](pipelineX) mark join column should be nullable (#25275) add bb670118f53 [coverage](test) D

Re: [PR] [coverage](test) Delete unused function to improve test coverage [doris]

2023-10-10 Thread via GitHub
Gabriel39 merged PR #25233: URL: https://github.com/apache/doris/pull/25233 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

Re: [PR] [coverage](test) Delete unused function to improve test coverage [doris]

2023-10-10 Thread via GitHub
github-actions[bot] commented on PR #25233: URL: https://github.com/apache/doris/pull/25233#issuecomment-1756723342 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [coverage](test) Delete unused function to improve test coverage [doris]

2023-10-10 Thread via GitHub
github-actions[bot] commented on PR #25233: URL: https://github.com/apache/doris/pull/25233#issuecomment-1756723319 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix](Tvf) return empty set when tvf queries an empty file or an error uri [doris]

2023-10-10 Thread via GitHub
BePPPower commented on PR #25280: URL: https://github.com/apache/doris/pull/25280#issuecomment-1756722138 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [function](nereids) support array_apply/array_repeat/group_uniq_array/ipv4numtostring [doris]

2023-10-10 Thread via GitHub
XieJiann commented on code in PR #25249: URL: https://github.com/apache/doris/pull/25249#discussion_r1353977281 ## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/ArrayApply.java: ## @@ -0,0 +1,68 @@ +// Licensed to the Apache Software Founda

Re: [PR] [function](nereids) support array_apply/array_repeat/group_uniq_array/ipv4numtostring [doris]

2023-10-10 Thread via GitHub
XieJiann commented on code in PR #25249: URL: https://github.com/apache/doris/pull/25249#discussion_r1353976915 ## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/ArrayRepeat.java: ## @@ -0,0 +1,67 @@ +// Licensed to the Apache Software Found

Re: [PR] [enhancement](compaction) record base compaction schedule time and status [doris]

2023-10-10 Thread via GitHub
doris-robot commented on PR #25283: URL: https://github.com/apache/doris/pull/25283#issuecomment-1756719555 TeamCity be ut coverage result: Function Coverage: 36.22% (8151/22503) Line Coverage: 28.33% (65185/230058) Region Coverage: 27.27% (33785/123871) Branch Coverage: 23.9

Re: [PR] [function](nereids) support array_apply/array_repeat/group_uniq_array/ipv4numtostring [doris]

2023-10-10 Thread via GitHub
morrySnow commented on code in PR #25249: URL: https://github.com/apache/doris/pull/25249#discussion_r1353976252 ## gensrc/script/doris_builtins_functions.py: ## @@ -493,15 +493,15 @@ [['array_apply'], 'ARRAY_SMALLINT', ['ARRAY_SMALLINT', 'VARCHAR', 'SMALLINT'], ''],

Re: [PR] [opt](load)change `load_to_single_tablet` tablet search algorithm from random to round-robin [doris]

2023-10-10 Thread via GitHub
xiaokang commented on code in PR #25256: URL: https://github.com/apache/doris/pull/25256#discussion_r1353973822 ## fe/fe-core/src/main/java/org/apache/doris/planner/SingleTabletLoadRecorderMgr.java: ## @@ -0,0 +1,119 @@ +// Licensed to the Apache Software Foundation (ASF) under

Re: [PR] [Bug](delete) Use date as common type for date comparison [doris]

2023-10-10 Thread via GitHub
github-actions[bot] commented on PR #25262: URL: https://github.com/apache/doris/pull/25262#issuecomment-1756717637 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [Bug](delete) Use date as common type for date comparison [doris]

2023-10-10 Thread via GitHub
github-actions[bot] commented on PR #25262: URL: https://github.com/apache/doris/pull/25262#issuecomment-1756717606 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [Improvement](statistics) Improve sample count accuracy. [doris]

2023-10-10 Thread via GitHub
Jibing-Li commented on PR #25175: URL: https://github.com/apache/doris/pull/25175#issuecomment-1756717078 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [feature](merge-cloud) Enable write into cache when uploading file to s3 using s3 file writer [doris]

2023-10-10 Thread via GitHub
Lchangliang commented on PR #24364: URL: https://github.com/apache/doris/pull/24364#issuecomment-1756716801 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[PR] [fix](multi-catalog)fix dependencies for dlf [doris-shade]

2023-10-10 Thread via GitHub
wsjz opened a new pull request, #26: URL: https://github.com/apache/doris-shade/pull/26 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[doris] branch master updated: [fix](pipelineX) mark join column should be nullable (#25275)

2023-10-10 Thread gabriellee
This is an automated email from the ASF dual-hosted git repository. gabriellee pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new cdf5f0fe687 [fix](pipelineX) mark join column

Re: [PR] [fix](pipelineX) mark join column should be nullable [doris]

2023-10-10 Thread via GitHub
Gabriel39 merged PR #25275: URL: https://github.com/apache/doris/pull/25275 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

Re: [PR] [fix](case) use the custom DB explicitly in analyze_stats.groovy [doris]

2023-10-10 Thread via GitHub
github-actions[bot] commented on PR #25285: URL: https://github.com/apache/doris/pull/25285#issuecomment-1756709429 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [fix](case) use the custom DB explicitly in analyze_stats.groovy [doris]

2023-10-10 Thread via GitHub
hello-stephen commented on PR #25285: URL: https://github.com/apache/doris/pull/25285#issuecomment-1756707488 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] [feature](load) add vertical segment writer [doris]

2023-10-10 Thread via GitHub
doris-robot commented on PR #24403: URL: https://github.com/apache/doris/pull/24403#issuecomment-1756707788 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.5 seconds stream load tsv: 554 seconds loaded 74807831229 Bytes, a

[PR] [fix](case) use the custom DB explicitly in analyze_stats.groovy [doris]

2023-10-10 Thread via GitHub
hello-stephen opened a new pull request, #25285: URL: https://github.com/apache/doris/pull/25285 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](m

Re: [PR] [fix](pipelineX) mark join column should be nullable [doris]

2023-10-10 Thread via GitHub
doris-robot commented on PR #25269: URL: https://github.com/apache/doris/pull/25269#issuecomment-1756704549 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.29 seconds stream load tsv: 584 seconds loaded 74807831229 Bytes,

Re: [PR] [enhancement](compaction) record base compaction schedule time and status [doris]

2023-10-10 Thread via GitHub
github-actions[bot] commented on PR #25283: URL: https://github.com/apache/doris/pull/25283#issuecomment-1756703090 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](format) be format [doris]

2023-10-10 Thread via GitHub
doris-robot commented on PR #25282: URL: https://github.com/apache/doris/pull/25282#issuecomment-1756703046 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.29 seconds stream load tsv: 580 seconds loaded 74807831229 Bytes,

Re: [PR] [Fix](Outfile) Use data_type_serde to export data to `parquet` file format [doris]

2023-10-10 Thread via GitHub
doris-robot commented on PR #24998: URL: https://github.com/apache/doris/pull/24998#issuecomment-1756702212 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.54 seconds stream load tsv: 577 seconds loaded 74807831229 Bytes,

Re: [PR] [opt](load)change `load_to_single_tablet` tablet search algorithm from random to round-robin [doris]

2023-10-10 Thread via GitHub
doris-robot commented on PR #25256: URL: https://github.com/apache/doris/pull/25256#issuecomment-1756701233 TeamCity be ut coverage result: Function Coverage: 36.32% (8151/22444) Line Coverage: 28.43% (65179/229224) Region Coverage: 27.36% (33778/123440) Branch Coverage: 24.0

Re: [PR] [Chore](cases) set enable_nereids_planner on mv cases [doris]

2023-10-10 Thread via GitHub
github-actions[bot] commented on PR #25277: URL: https://github.com/apache/doris/pull/25277#issuecomment-1756700653 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [Chore](cases) set enable_nereids_planner on mv cases [doris]

2023-10-10 Thread via GitHub
github-actions[bot] commented on PR #25277: URL: https://github.com/apache/doris/pull/25277#issuecomment-1756700622 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix](pipelineX) mark join column should be nullable [doris]

2023-10-10 Thread via GitHub
doris-robot commented on PR #25269: URL: https://github.com/apache/doris/pull/25269#issuecomment-1756700043 TeamCity be ut coverage result: Function Coverage: 36.22% (8149/22499) Line Coverage: 28.33% (65164/230035) Region Coverage: 27.25% (33759/123873) Branch Coverage: 23.9

Re: [PR] [feature](load) add vertical segment writer [doris]

2023-10-10 Thread via GitHub
doris-robot commented on PR #24403: URL: https://github.com/apache/doris/pull/24403#issuecomment-1756699838 TeamCity be ut coverage result: Function Coverage: 36.31% (8185/22543) Line Coverage: 28.38% (65526/230867) Region Coverage: 27.31% (33963/124344) Branch Coverage: 23.9

Re: [PR] [Improvement](statistics) Improve sample count accuracy. [doris]

2023-10-10 Thread via GitHub
Jibing-Li commented on code in PR #25175: URL: https://github.com/apache/doris/pull/25175#discussion_r1353963601 ## fe/fe-core/src/main/java/org/apache/doris/catalog/external/HMSExternalTable.java: ## @@ -635,6 +636,30 @@ public void gsonPostProcess() throws IOException {

Re: [PR] [fix](format) be format [doris]

2023-10-10 Thread via GitHub
doris-robot commented on PR #25282: URL: https://github.com/apache/doris/pull/25282#issuecomment-1756698893 TeamCity be ut coverage result: Function Coverage: 36.22% (8149/22499) Line Coverage: 28.33% (65163/230037) Region Coverage: 27.26% (33769/123865) Branch Coverage: 23.9

Re: [PR] [Fix](Outfile) Use data_type_serde to export data to `parquet` file format [doris]

2023-10-10 Thread via GitHub
doris-robot commented on PR #24998: URL: https://github.com/apache/doris/pull/24998#issuecomment-1756698799 TeamCity be ut coverage result: Function Coverage: 36.23% (8150/22497) Line Coverage: 28.40% (65174/229477) Region Coverage: 27.36% (33775/123461) Branch Coverage: 24.0

Re: [PR] [enhancement](compaction) record base compaction schedule time and status [doris]

2023-10-10 Thread via GitHub
hust-hhb commented on PR #25283: URL: https://github.com/apache/doris/pull/25283#issuecomment-1756697700 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[PR] [enhancement](compaction) record base compaction schedule time and status [doris]

2023-10-10 Thread via GitHub
hust-hhb opened a new pull request, #25283: URL: https://github.com/apache/doris/pull/25283 now base compaction thread may be not triger, so we need to record base compaction schedule time and status. ## Proposed changes Issue Number: close #xxx ## Further comme

Re: [PR] [Enhancement](merge on write) Add primary keys consistency check for partial update [doris]

2023-10-10 Thread via GitHub
bobhan1 commented on PR #23443: URL: https://github.com/apache/doris/pull/23443#issuecomment-1756694215 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[doris] branch master updated: [Enhancement](sql-cache) Add partition update time for hms table and use it at sql-cache. (#24491)

2023-10-10 Thread zouxinyi
This is an automated email from the ASF dual-hosted git repository. zouxinyi pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 1e6d34d1d06 [Enhancement](sql-cache) Add partit

Re: [PR] [Enhancement](sql-cache) Add partition update time for hms table and use it at sql-cache. [doris]

2023-10-10 Thread via GitHub
xinyiZzz merged PR #24491: URL: https://github.com/apache/doris/pull/24491 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

Re: [PR] [draft] add change [doris]

2023-10-10 Thread via GitHub
hello-stephen commented on PR #25223: URL: https://github.com/apache/doris/pull/25223#issuecomment-1756690774 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 47.84 seconds stream load tsv: 564 seconds loaded 74807831229 Bytes

Re: [PR] [opt](load)change `load_to_single_tablet` tablet search algorithm from random to round-robin [doris]

2023-10-10 Thread via GitHub
doris-robot commented on PR #25256: URL: https://github.com/apache/doris/pull/25256#issuecomment-1756687096 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.61 seconds stream load tsv: 559 seconds loaded 74807831229 Bytes,

Re: [PR] [fix](format) be format [doris]

2023-10-10 Thread via GitHub
github-actions[bot] commented on PR #25282: URL: https://github.com/apache/doris/pull/25282#issuecomment-1756670446 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [feature](load) add vertical segment writer [doris]

2023-10-10 Thread via GitHub
kaijchen commented on PR #24403: URL: https://github.com/apache/doris/pull/24403#issuecomment-1756669881 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

  1   2   3   4   5   6   7   >