[GitHub] [doris] HHoflittlefish777 commented on pull request #19655: [Refactor](load) Unify streamload BE and FE properties parsing

2023-06-09 Thread via GitHub
HHoflittlefish777 commented on PR #19655: URL: https://github.com/apache/doris/pull/19655#issuecomment-1585489539 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [doris] SaintBacchus commented on pull request #20241: [Regression](MTMV)Use lock instead of tryLock to get the jobManager lock

2023-06-09 Thread via GitHub
SaintBacchus commented on PR #20241: URL: https://github.com/apache/doris/pull/20241#issuecomment-1585486496 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [doris] morningman commented on a diff in pull request #20566: [Refactor](External) Move Common ODBC Methods to JDBC Class and Add Default config to Disable ODBC Creation

2023-06-09 Thread via GitHub
morningman commented on code in PR #20566: URL: https://github.com/apache/doris/pull/20566#discussion_r1225090144 ## fe/fe-core/src/main/java/org/apache/doris/analysis/CreateResourceStmt.java: ## @@ -93,6 +94,9 @@ public void analyze(Analyzer analyzer) throws UserException {

[doris] branch master updated: [Improvement](statistics)Support external table partition statistics (#20415)

2023-06-09 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 87bc405c41 [Improvement](statistics)Support e

[GitHub] [doris] morningman merged pull request #20415: [Improvement](statistics)Support external table partition statistics.

2023-06-09 Thread via GitHub
morningman merged PR #20415: URL: https://github.com/apache/doris/pull/20415 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.a

[doris] branch master updated (206b5a4235 -> 9a83d78dfe)

2023-06-09 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 206b5a4235 [doc](flink-connector) add flink cdc sync mysql database (#20486) add 9a83d78dfe [Enhancement](hud

[GitHub] [doris] morningman merged pull request #20570: [Enhancement](hudi) support hudi mor table, step2 follow #19909

2023-06-09 Thread via GitHub
morningman merged PR #20570: URL: https://github.com/apache/doris/pull/20570 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.a

[GitHub] [doris] github-actions[bot] commented on pull request #20523: [fix](nereids)avoid to derive rowCount NaN

2023-06-09 Thread via GitHub
github-actions[bot] commented on PR #20523: URL: https://github.com/apache/doris/pull/20523#issuecomment-1585452451 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #20523: [fix](nereids)avoid to derive rowCount NaN

2023-06-09 Thread via GitHub
github-actions[bot] commented on PR #20523: URL: https://github.com/apache/doris/pull/20523#issuecomment-1585452458 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] HHoflittlefish777 commented on pull request #19655: [Refactor](load) Unify streamload BE and FE properties parsing

2023-06-09 Thread via GitHub
HHoflittlefish777 commented on PR #19655: URL: https://github.com/apache/doris/pull/19655#issuecomment-1585448048 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [doris] englefly commented on pull request #20642: [tpcds](nereids) estimate distribution cost by byte size instead of row count

2023-06-09 Thread via GitHub
englefly commented on PR #20642: URL: https://github.com/apache/doris/pull/20642#issuecomment-1585445794 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [doris] HHoflittlefish777 commented on pull request #19655: [Refactor](load) Unify streamload BE and FE properties parsing

2023-06-09 Thread via GitHub
HHoflittlefish777 commented on PR #19655: URL: https://github.com/apache/doris/pull/19655#issuecomment-1585445052 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [doris] SaintBacchus commented on pull request #20241: [Regression](MTMV)Use lock instead of tryLock to get the jobManager lock

2023-06-09 Thread via GitHub
SaintBacchus commented on PR #20241: URL: https://github.com/apache/doris/pull/20241#issuecomment-1585442453 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [doris] nanfeng1999 opened a new pull request, #20657: [doc](insert-overwrite) add related doc

2023-06-09 Thread via GitHub
nanfeng1999 opened a new pull request, #20657: URL: https://github.com/apache/doris/pull/20657 add insert overwrite doc ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion

[doris] branch master updated: [doc](flink-connector) add flink cdc sync mysql database (#20486)

2023-06-09 Thread diwu
This is an automated email from the ASF dual-hosted git repository. diwu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 206b5a4235 [doc](flink-connector) add flink cdc syn

[GitHub] [doris] JNSimba merged pull request #20486: [doc](flink-connector) add flink cdc sync mysql database

2023-06-09 Thread via GitHub
JNSimba merged PR #20486: URL: https://github.com/apache/doris/pull/20486 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apac

[GitHub] [doris] HHoflittlefish777 commented on pull request #19655: [Refactor](load) Unify streamload BE and FE properties parsing

2023-06-09 Thread via GitHub
HHoflittlefish777 commented on PR #19655: URL: https://github.com/apache/doris/pull/19655#issuecomment-1585431211 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [doris] SaintBacchus commented on pull request #20241: [Regression](MTMV)Use lock instead of tryLock to get the jobManager lock

2023-06-09 Thread via GitHub
SaintBacchus commented on PR #20241: URL: https://github.com/apache/doris/pull/20241#issuecomment-1585424321 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [doris] xiaokang commented on pull request #20656: [bugfix](s3 fs) fix s3 uri parsing for http/https uri

2023-06-09 Thread via GitHub
xiaokang commented on PR #20656: URL: https://github.com/apache/doris/pull/20656#issuecomment-1585419052 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [doris] github-actions[bot] commented on pull request #20656: [bugfix](s3 fs) fix s3 uri parsing for http/https uri

2023-06-09 Thread via GitHub
github-actions[bot] commented on PR #20656: URL: https://github.com/apache/doris/pull/20656#issuecomment-1585418194 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] xiaokang opened a new pull request, #20656: [bugfix](s3 fs) fix s3 uri parsing for http/https uri

2023-06-09 Thread via GitHub
xiaokang opened a new pull request, #20656: URL: https://github.com/apache/doris/pull/20656 ## Proposed changes Issue Number: close #xxx Now, S3URI::parse() process all uri in format 's3://bucket/path/to/file', which is not true for http/https uri 'http(s)://host/bucket1/path/t

[GitHub] [doris] englefly commented on pull request #20642: Distr bytes

2023-06-09 Thread via GitHub
englefly commented on PR #20642: URL: https://github.com/apache/doris/pull/20642#issuecomment-1585390417 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [doris] HHoflittlefish777 commented on pull request #19655: [Refactor](load) Unify streamload BE and FE properties parsing

2023-06-09 Thread via GitHub
HHoflittlefish777 commented on PR #19655: URL: https://github.com/apache/doris/pull/19655#issuecomment-1585360262 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [doris] nsnhuang opened a new pull request, #20655: [fix] total_time of select_node not include the open phase

2023-06-09 Thread via GitHub
nsnhuang opened a new pull request, #20655: URL: https://github.com/apache/doris/pull/20655 ## Proposed changes Issue Number: close #xxx add SCOPED_TIMER at the begin of select_node's open function ## Further comments when using profile text, i found select_node's tota

[GitHub] [doris] github-actions[bot] commented on pull request #20544: [improvement](hdfs) add parquet footer cache and hdfs file handle cache

2023-06-09 Thread via GitHub
github-actions[bot] commented on PR #20544: URL: https://github.com/apache/doris/pull/20544#issuecomment-1584840353 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #20544: [improvement](hdfs) add parquet footer cache and hdfs file handle cache

2023-06-09 Thread via GitHub
github-actions[bot] commented on PR #20544: URL: https://github.com/apache/doris/pull/20544#issuecomment-1584837054 `sh-checker report` To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/5223940066";) output. shellcheck err

[doris] 10/13: [opt](Nereids) remove running in OptimizeGroup to avoid recompute on it parent (#20608)

2023-06-09 Thread kxiao
This is an automated email from the ASF dual-hosted git repository. kxiao pushed a commit to branch branch-2.0-beta in repository https://gitbox.apache.org/repos/asf/doris.git commit 8ec410794a4d16f40320942a141d641031d498e4 Author: morrySnow <101034200+morrys...@users.noreply.github.com> AuthorDa

[doris] 12/13: [fix](memory) Fix runtime state default mem tracker (#20615)

2023-06-09 Thread kxiao
This is an automated email from the ASF dual-hosted git repository. kxiao pushed a commit to branch branch-2.0-beta in repository https://gitbox.apache.org/repos/asf/doris.git commit de0bbc3d3c9731e3ca4616a307232a4ea72e1981 Author: Xinyi Zou AuthorDate: Fri Jun 9 21:09:07 2023 +0800 [fix](m

[doris] 05/13: [improvement](exception-safe) create and prepare node/sink support exception safe (#20551)

2023-06-09 Thread kxiao
This is an automated email from the ASF dual-hosted git repository. kxiao pushed a commit to branch branch-2.0-beta in repository https://gitbox.apache.org/repos/asf/doris.git commit 99615e31cbaf1fd8ca3df501c6bf9d800a50eb00 Author: Xinyi Zou AuthorDate: Fri Jun 9 21:06:59 2023 +0800 [improv

[doris] 07/13: [performance](executor) remove repeated call within the loop in validate_column

2023-06-09 Thread kxiao
This is an automated email from the ASF dual-hosted git repository. kxiao pushed a commit to branch branch-2.0-beta in repository https://gitbox.apache.org/repos/asf/doris.git commit 0be67858585547eed3578b52c86f3b76a0e1f933 Author: Mryange <59914473+mrya...@users.noreply.github.com> AuthorDate: F

[doris] 04/13: [enhancement](stats) Forbid unknown stats check for internal_column (#20535)

2023-06-09 Thread kxiao
This is an automated email from the ASF dual-hosted git repository. kxiao pushed a commit to branch branch-2.0-beta in repository https://gitbox.apache.org/repos/asf/doris.git commit 2121aa64601804bd272ecf2ba0cbe0bc5a3595ff Author: AKIRA <33112463+kikyou1...@users.noreply.github.com> AuthorDate:

[doris] 13/13: [enhancement](stats) ignore view by default when analyze whole DB #20630

2023-06-09 Thread kxiao
This is an automated email from the ASF dual-hosted git repository. kxiao pushed a commit to branch branch-2.0-beta in repository https://gitbox.apache.org/repos/asf/doris.git commit 237a4837e741499e77f6579df7f9cf6e5e3ec3ed Author: AKIRA <33112463+kikyou1...@users.noreply.github.com> AuthorDate:

[doris] 09/13: [minor](Nereids) remove some invasive code of minidump in cascades framework (#20606)

2023-06-09 Thread kxiao
This is an automated email from the ASF dual-hosted git repository. kxiao pushed a commit to branch branch-2.0-beta in repository https://gitbox.apache.org/repos/asf/doris.git commit cbfaec4c9c5da0cb7431d3fbf9be5083ddb92ee0 Author: morrySnow <101034200+morrys...@users.noreply.github.com> AuthorDa

[doris] 08/13: [enhancement](index) Nereids support no need to read raw data for index column that only in filter conditions (#20605)

2023-06-09 Thread kxiao
This is an automated email from the ASF dual-hosted git repository. kxiao pushed a commit to branch branch-2.0-beta in repository https://gitbox.apache.org/repos/asf/doris.git commit 4a33b956e620c969abbfccced21cf063ba3780e7 Author: YueW <45946325+tany...@users.noreply.github.com> AuthorDate: Fri

[doris] 06/13: [Improvement](column) reduce cache miss for data copy (#20583)

2023-06-09 Thread kxiao
This is an automated email from the ASF dual-hosted git repository. kxiao pushed a commit to branch branch-2.0-beta in repository https://gitbox.apache.org/repos/asf/doris.git commit 46e2277a304399a2ff77a41adcd82c26bb1eae94 Author: Gabriel AuthorDate: Fri Jun 9 13:10:57 2023 +0800 [Improvem

[doris] branch branch-2.0-beta updated (3dc9aa05ae -> 237a4837e7)

2023-06-09 Thread kxiao
This is an automated email from the ASF dual-hosted git repository. kxiao pushed a change to branch branch-2.0-beta in repository https://gitbox.apache.org/repos/asf/doris.git from 3dc9aa05ae [feature-wip](duplicate_no_keys) Add some test cases of all the duplicate tables in test case tpcds

[doris] 03/13: [fix](regression) unique_with_mow_p2/test_pk_uk_case (#20497)

2023-06-09 Thread kxiao
This is an automated email from the ASF dual-hosted git repository. kxiao pushed a commit to branch branch-2.0-beta in repository https://gitbox.apache.org/repos/asf/doris.git commit 56a6d566d9c45824631e0303eb8fe449e688e3bc Author: zhannngchen <48427519+zhannngc...@users.noreply.github.com> Autho

[doris] 01/13: [opt](planner)(Nereids) add switch to determine if some unfixed functions will be folded on fe. (#20270)

2023-06-09 Thread kxiao
This is an automated email from the ASF dual-hosted git repository. kxiao pushed a commit to branch branch-2.0-beta in repository https://gitbox.apache.org/repos/asf/doris.git commit 35f438ec74978baa37c578015aef3042096db73b Author: mch_ucchi <41606806+sohardforan...@users.noreply.github.com> Auth

[doris] 02/13: [fix](stats) set analysis job status to finished when be crashed by mistake (#20485)

2023-06-09 Thread kxiao
This is an automated email from the ASF dual-hosted git repository. kxiao pushed a commit to branch branch-2.0-beta in repository https://gitbox.apache.org/repos/asf/doris.git commit c43dcb222e4bb8f060842e6833db8a133f2b84a7 Author: AKIRA <33112463+kikyou1...@users.noreply.github.com> AuthorDate:

[doris] branch master updated (def6a8ec94 -> c79642781b)

2023-06-09 Thread morrysnow
This is an automated email from the ASF dual-hosted git repository. morrysnow pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from def6a8ec94 [regression](nereids) check tpch sf1T and sf500 plan shape on 3 BE environment #20610 add c79642781

[GitHub] [doris] morrySnow merged pull request #20606: [minor](Nereids) refactor some code in cascades framework

2023-06-09 Thread via GitHub
morrySnow merged PR #20606: URL: https://github.com/apache/doris/pull/20606 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

[GitHub] [doris] weizuo93 commented on a diff in pull request #20597: [Log](query) Add log of fragment instance num to recognize large query

2023-06-09 Thread via GitHub
weizuo93 commented on code in PR #20597: URL: https://github.com/apache/doris/pull/20597#discussion_r1224468428 ## fe/fe-core/src/main/java/org/apache/doris/qe/StmtExecutor.java: ## @@ -1371,6 +1371,18 @@ private void sendResult(boolean isOutfileQuery, boolean isSendFields, Que

[GitHub] [doris] github-actions[bot] commented on pull request #20570: [Enhancement](hudi) support hudi mor table, step2 follow #19909

2023-06-09 Thread via GitHub
github-actions[bot] commented on PR #20570: URL: https://github.com/apache/doris/pull/20570#issuecomment-1584782175 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #20570: [Enhancement](hudi) support hudi mor table, step2 follow #19909

2023-06-09 Thread via GitHub
github-actions[bot] commented on PR #20570: URL: https://github.com/apache/doris/pull/20570#issuecomment-1584782225 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on pull request #20606: [minor](Nereids) refactor some code in cascades framework

2023-06-09 Thread via GitHub
github-actions[bot] commented on PR #20606: URL: https://github.com/apache/doris/pull/20606#issuecomment-1584780860 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on pull request #20606: [minor](Nereids) refactor some code in cascades framework

2023-06-09 Thread via GitHub
github-actions[bot] commented on PR #20606: URL: https://github.com/apache/doris/pull/20606#issuecomment-1584780805 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #20654: [doc](create-function) Update CREATE-FUNCTION.md to remove the usage of c++

2023-06-09 Thread via GitHub
github-actions[bot] commented on PR #20654: URL: https://github.com/apache/doris/pull/20654#issuecomment-1584771534 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on pull request #20654: [doc](create-function) Update CREATE-FUNCTION.md to remove the usage of c++

2023-06-09 Thread via GitHub
github-actions[bot] commented on PR #20654: URL: https://github.com/apache/doris/pull/20654#issuecomment-1584771472 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] smallhibiscus opened a new pull request, #20654: [doc](create-function) Update CREATE-FUNCTION.md to remove the usage of c++

2023-06-09 Thread via GitHub
smallhibiscus opened a new pull request, #20654: URL: https://github.com/apache/doris/pull/20654 SInce 1.2.0 version,the create function do not support the udf with c++,so remove the doc. ## Further comments If this is a relatively large or complex change, kick off the

[GitHub] [doris] englefly commented on pull request #20523: [fix](nereids)avoid to derive rowCount NaN

2023-06-09 Thread via GitHub
englefly commented on PR #20523: URL: https://github.com/apache/doris/pull/20523#issuecomment-1584750971 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [doris] github-actions[bot] commented on pull request #20480: [fix](alter) fix potential concurrent issue for alter when check olap table state normal outside write lock scope is not atomic

2023-06-09 Thread via GitHub
github-actions[bot] commented on PR #20480: URL: https://github.com/apache/doris/pull/20480#issuecomment-1584748296 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] englefly merged pull request #20610: [regression](nereids) check tpch sf1T and sf500 plan shape on 3 BE environment

2023-06-09 Thread via GitHub
englefly merged PR #20610: URL: https://github.com/apache/doris/pull/20610 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

[GitHub] [doris] github-actions[bot] commented on pull request #20610: [regression](nereids) check tpch sf1T and sf500 plan shape on 3 BE environment

2023-06-09 Thread via GitHub
github-actions[bot] commented on PR #20610: URL: https://github.com/apache/doris/pull/20610#issuecomment-1584703412 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on pull request #20610: [regression](nereids) check tpch sf1T and sf500 plan shape on 3 BE environment

2023-06-09 Thread via GitHub
github-actions[bot] commented on PR #20610: URL: https://github.com/apache/doris/pull/20610#issuecomment-1584703370 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #20637: [Chore](build) adjust build script about pch setting

2023-06-09 Thread via GitHub
github-actions[bot] commented on PR #20637: URL: https://github.com/apache/doris/pull/20637#issuecomment-1584670433 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[doris] branch master updated: [Chore](build) adjust build script about pch setting (#20637)

2023-06-09 Thread panxiaolei
This is an automated email from the ASF dual-hosted git repository. panxiaolei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new ab6c1f152c [Chore](build) adjust build script

[GitHub] [doris] github-actions[bot] commented on pull request #20637: [Chore](build) adjust build script about pch setting

2023-06-09 Thread via GitHub
github-actions[bot] commented on PR #20637: URL: https://github.com/apache/doris/pull/20637#issuecomment-1584670360 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] BiteTheDDDDt merged pull request #20637: [Chore](build) adjust build script about pch setting

2023-06-09 Thread via GitHub
BiteThet merged PR #20637: URL: https://github.com/apache/doris/pull/20637 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris

[GitHub] [doris] caiconghui commented on a diff in pull request #20480: [fix](alter) fix potential concurrent issue for alter when check olap table state normal outside write lock scope is not atomic

2023-06-09 Thread via GitHub
caiconghui commented on code in PR #20480: URL: https://github.com/apache/doris/pull/20480#discussion_r1224362975 ## fe/fe-core/src/main/java/org/apache/doris/catalog/OlapTable.java: ## @@ -1489,21 +1489,9 @@ public long getReplicaCount() { return replicaCount; }

[GitHub] [doris] caiconghui commented on a diff in pull request #20480: [fix](alter) fix potential concurrent issue for alter when check olap table state normal outside write lock scope is not atomic

2023-06-09 Thread via GitHub
caiconghui commented on code in PR #20480: URL: https://github.com/apache/doris/pull/20480#discussion_r1224359378 ## fe/fe-core/src/main/java/org/apache/doris/alter/SchemaChangeHandler.java: ## @@ -2471,13 +2466,6 @@ public void modifyTableLightSchemaChange(Database db, OlapTab

[GitHub] [doris] DarvenDuan commented on pull request #20624: [fix](load)Support load json data with default value

2023-06-09 Thread via GitHub
DarvenDuan commented on PR #20624: URL: https://github.com/apache/doris/pull/20624#issuecomment-1584631493 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [doris] github-actions[bot] commented on pull request #20624: [fix](load)Support load json data with default value

2023-06-09 Thread via GitHub
github-actions[bot] commented on PR #20624: URL: https://github.com/apache/doris/pull/20624#issuecomment-1584630062 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] morrySnow commented on pull request #20523: [fix](nereids)avoid to derive rowCount NaN

2023-06-09 Thread via GitHub
morrySnow commented on PR #20523: URL: https://github.com/apache/doris/pull/20523#issuecomment-1584619785 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [doris] morrySnow commented on pull request #20606: [minor](Nereids) refactor some code in cascades framework

2023-06-09 Thread via GitHub
morrySnow commented on PR #20606: URL: https://github.com/apache/doris/pull/20606#issuecomment-1584619094 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[doris] branch master updated: [enhancement](index) Nereids support no need to read raw data for index column that only in filter conditions (#20605)

2023-06-09 Thread kxiao
This is an automated email from the ASF dual-hosted git repository. kxiao pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 656b9ad3da [enhancement](index) Nereids support no

[GitHub] [doris] xiaokang merged pull request #20605: [enhancement](index) Nereids support no need to read raw data for index column that only in filter conditions

2023-06-09 Thread via GitHub
xiaokang merged PR #20605: URL: https://github.com/apache/doris/pull/20605 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

[GitHub] [doris] github-actions[bot] commented on pull request #20605: [enhancement](index) Nereids support no need to read raw data for index column that only in filter conditions

2023-06-09 Thread via GitHub
github-actions[bot] commented on PR #20605: URL: https://github.com/apache/doris/pull/20605#issuecomment-1584616143 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on pull request #20605: [enhancement](index) Nereids support no need to read raw data for index column that only in filter conditions

2023-06-09 Thread via GitHub
github-actions[bot] commented on PR #20605: URL: https://github.com/apache/doris/pull/20605#issuecomment-1584616075 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] Tanya-W commented on a diff in pull request #20480: [fix](alter) fix potential concurrent issue for alter when check olap table state normal outside write lock scope is not atomic

2023-06-09 Thread via GitHub
Tanya-W commented on code in PR #20480: URL: https://github.com/apache/doris/pull/20480#discussion_r122433 ## fe/fe-core/src/main/java/org/apache/doris/alter/SchemaChangeHandler.java: ## @@ -2471,13 +2466,6 @@ public void modifyTableLightSchemaChange(Database db, OlapTable

[GitHub] [doris] zhannngchen commented on pull request #20633: [fix](regression) tests in unique_with_mow_p0/partial_update are flaky

2023-06-09 Thread via GitHub
zhannngchen commented on PR #20633: URL: https://github.com/apache/doris/pull/20633#issuecomment-1584605289 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [doris] zhangstar333 commented on pull request #20562: [bug](function) fix is_null/is_not_null check is_const has error

2023-06-09 Thread via GitHub
zhangstar333 commented on PR #20562: URL: https://github.com/apache/doris/pull/20562#issuecomment-1584554443 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[doris] branch master updated: [fix](memory) Fix runtime state default mem tracker (#20615)

2023-06-09 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 0f21166110 [fix](memory) Fix runtime state defa

[GitHub] [doris] yiguolei merged pull request #20615: [fix](memory) Fix runtime state default mem tracker

2023-06-09 Thread via GitHub
yiguolei merged PR #20615: URL: https://github.com/apache/doris/pull/20615 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

[doris] branch master updated: [improvement](exception-safe) create and prepare node/sink support exception safe (#20551)

2023-06-09 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 93b53cf2f4 [improvement](exception-safe) create

[GitHub] [doris] yiguolei merged pull request #20551: [improvement](exception-safe) create and prepare node/sink support exception safe

2023-06-09 Thread via GitHub
yiguolei merged PR #20551: URL: https://github.com/apache/doris/pull/20551 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

[GitHub] [doris] bobhan1 commented on a diff in pull request #19917: [feature-wip](auto-inc)(step-2) support auto-increment column for duplicate table

2023-06-09 Thread via GitHub
bobhan1 commented on code in PR #19917: URL: https://github.com/apache/doris/pull/19917#discussion_r1224265291 ## be/src/vec/sink/vtablet_sink.h: ## @@ -447,6 +449,73 @@ class IndexChannel { std::map>> _tablets_received_rows; }; +struct FetchAutoIncIDExecutor { +Fet

[GitHub] [doris] DarvenDuan commented on pull request #20624: [fix](load)Support load json data with default value

2023-06-09 Thread via GitHub
DarvenDuan commented on PR #20624: URL: https://github.com/apache/doris/pull/20624#issuecomment-1584518909 run P0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[GitHub] [doris] freemandealer commented on a diff in pull request #19655: [Refactor](load) Unify streamload BE and FE properties parsing

2023-06-09 Thread via GitHub
freemandealer commented on code in PR #19655: URL: https://github.com/apache/doris/pull/19655#discussion_r1224248314 ## fe/fe-core/src/main/java/org/apache/doris/analysis/StreamLoadTask.java: ## @@ -428,7 +446,7 @@ private Expr parseWhereExpr(String whereString) throws UserExce

[GitHub] [doris] freemandealer commented on a diff in pull request #19655: [Refactor](load) Unify streamload BE and FE properties parsing

2023-06-09 Thread via GitHub
freemandealer commented on code in PR #19655: URL: https://github.com/apache/doris/pull/19655#discussion_r1224247185 ## fe/fe-core/src/main/java/org/apache/doris/analysis/StreamLoadTask.java: ## @@ -400,7 +418,7 @@ private void setColumnToColumnExpr(String columns) throws UserE

[GitHub] [doris] freemandealer commented on a diff in pull request #19655: [Refactor](load) Unify streamload BE and FE properties parsing

2023-06-09 Thread via GitHub
freemandealer commented on code in PR #19655: URL: https://github.com/apache/doris/pull/19655#discussion_r1224246177 ## fe/fe-core/src/main/java/org/apache/doris/analysis/StreamLoadTask.java: ## @@ -287,104 +305,104 @@ public static StreamLoadTask fromTStreamLoadPutRequest(TStr

[GitHub] [doris] github-actions[bot] commented on pull request #20635: [fix](case expr) fix coredump of case for null value 2

2023-06-09 Thread via GitHub
github-actions[bot] commented on PR #20635: URL: https://github.com/apache/doris/pull/20635#issuecomment-1584482226 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on pull request #20635: [fix](case expr) fix coredump of case for null value 2

2023-06-09 Thread via GitHub
github-actions[bot] commented on PR #20635: URL: https://github.com/apache/doris/pull/20635#issuecomment-1584482142 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] dataroaring commented on a diff in pull request #19917: [feature-wip](auto-inc)(step-2) support auto-increment column for duplicate table

2023-06-09 Thread via GitHub
dataroaring commented on code in PR #19917: URL: https://github.com/apache/doris/pull/19917#discussion_r1223880507 ## fe/fe-core/src/main/java/org/apache/doris/catalog/AutoIncrementGenerator.java: ## @@ -0,0 +1,104 @@ +// Licensed to the Apache Software Foundation (ASF) under on

[GitHub] [doris] github-actions[bot] commented on pull request #19655: [Refactor](load) Unify streamload BE and FE properties parsing

2023-06-09 Thread via GitHub
github-actions[bot] commented on PR #19655: URL: https://github.com/apache/doris/pull/19655#issuecomment-1584470018 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #19655: [Refactor](load) Unify streamload BE and FE properties parsing

2023-06-09 Thread via GitHub
github-actions[bot] commented on PR #19655: URL: https://github.com/apache/doris/pull/19655#issuecomment-1584468665 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] HHoflittlefish777 commented on pull request #19655: [Refactor](load) Unify streamload BE and FE properties parsing

2023-06-09 Thread via GitHub
HHoflittlefish777 commented on PR #19655: URL: https://github.com/apache/doris/pull/19655#issuecomment-1584467054 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[doris] branch master updated: [performance](executor) remove repeated call within the loop in validate_column

2023-06-09 Thread lihaopeng
This is an automated email from the ASF dual-hosted git repository. lihaopeng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new abb2048d5d [performance](executor) remove rep

[GitHub] [doris] HappenLee merged pull request #20587: [performance](executor) remove repeated call within the loop in validate_column

2023-06-09 Thread via GitHub
HappenLee merged PR #20587: URL: https://github.com/apache/doris/pull/20587 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

[GitHub] [doris] hechao-ustc commented on issue #20650: [Bug] JSON string with negative numbers cannot be insert into field of JSON type correctly

2023-06-09 Thread via GitHub
hechao-ustc commented on issue #20650: URL: https://github.com/apache/doris/issues/20650#issuecomment-1584455850 2.0 alpha does not yet support the JSON type, you can use the master branch for test JSON type. But using JSONB type on 2.0 alpha, the result is correct. ![img_v2_084d6636-

[GitHub] [doris] SaintBacchus commented on pull request #20241: [Regression](MTMV)Use lock instead of tryLock to get the jobManager lock

2023-06-09 Thread via GitHub
SaintBacchus commented on PR #20241: URL: https://github.com/apache/doris/pull/20241#issuecomment-1584446946 run p1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [doris] bobhan1 commented on pull request #19917: [feature-wip](auto-inc)(step-2) support auto-increment column for duplicate table

2023-06-09 Thread via GitHub
bobhan1 commented on PR #19917: URL: https://github.com/apache/doris/pull/19917#issuecomment-1584435358 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [doris] hufengkai commented on issue #20650: [Bug] JSON string with negative numbers cannot be insert into field of JSON type correctly

2023-06-09 Thread via GitHub
hufengkai commented on issue #20650: URL: https://github.com/apache/doris/issues/20650#issuecomment-1584433097 CREATE TABLE EVENT ( id INT NOT NULL, event JSON NOT NULL, proc_time DATETIMEV2 NOT NULL ) ENGINE = OLAP UNIQUE KEY(`id`) DISTRIBUTED BY HASH (`id`) BUC

[GitHub] [doris] englefly commented on pull request #20610: [regression](nereids) check tpch sf1T and sf500 plan shape on 3 BE environment

2023-06-09 Thread via GitHub
englefly commented on PR #20610: URL: https://github.com/apache/doris/pull/20610#issuecomment-1584429527 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [doris] github-actions[bot] commented on pull request #20536: [improvement](jdbc) Set the JDBC connection timeout to be configurable

2023-06-09 Thread via GitHub
github-actions[bot] commented on PR #20536: URL: https://github.com/apache/doris/pull/20536#issuecomment-1584427778 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #20536: [improvement](jdbc) Set the JDBC connection timeout to be configurable

2023-06-09 Thread via GitHub
github-actions[bot] commented on PR #20536: URL: https://github.com/apache/doris/pull/20536#issuecomment-1584427551 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #20651: [typo](doc)1.2 fix some writing errors

2023-06-09 Thread via GitHub
github-actions[bot] commented on PR #20651: URL: https://github.com/apache/doris/pull/20651#issuecomment-1584425993 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] zy-kkk commented on pull request #20651: [typo](doc)1.2 fix some writing errors

2023-06-09 Thread via GitHub
zy-kkk commented on PR #20651: URL: https://github.com/apache/doris/pull/20651#issuecomment-1584425351 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [doris] github-actions[bot] commented on pull request #20651: [typo](doc)1.2 fix some writing errors

2023-06-09 Thread via GitHub
github-actions[bot] commented on PR #20651: URL: https://github.com/apache/doris/pull/20651#issuecomment-1584426027 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] zy-kkk commented on pull request #20536: [improvement](jdbc) Set the JDBC connection timeout to be configurable

2023-06-09 Thread via GitHub
zy-kkk commented on PR #20536: URL: https://github.com/apache/doris/pull/20536#issuecomment-1584422695 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [doris] starocean999 commented on pull request #20634: [fix](planner)the common type of floating and decimal should be floating type

2023-06-09 Thread via GitHub
starocean999 commented on PR #20634: URL: https://github.com/apache/doris/pull/20634#issuecomment-1584418464 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

  1   2   3   >