[GitHub] [doris] yangzhg opened a new pull request, #17335: [docs](link) Fix some links in docs is broken

2023-03-01 Thread via GitHub
yangzhg opened a new pull request, #17335: URL: https://github.com/apache/doris/pull/17335 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has un

[GitHub] [doris] ZhangYu0123 commented on pull request #17331: [Fix](Lightweight schema Change) query error caused by array default type is unsupported

2023-03-01 Thread via GitHub
ZhangYu0123 commented on PR #17331: URL: https://github.com/apache/doris/pull/17331#issuecomment-1451434294 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [doris] BiteTheDDDDt commented on pull request #17328: [Enchancement](function) Inline some aggregate function && remove nullable combinator

2023-03-01 Thread via GitHub
BiteThet commented on PR #17328: URL: https://github.com/apache/doris/pull/17328#issuecomment-1451432867 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [doris] eldenmoon commented on pull request #17325: [Bug](Block compression) Fix bug if `config::compress_rowbatches=fals…

2023-03-01 Thread via GitHub
eldenmoon commented on PR #17325: URL: https://github.com/apache/doris/pull/17325#issuecomment-1451432629 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[GitHub] [doris] wzymumon commented on issue #17176: [Good First Issue] Doris' Future

2023-03-01 Thread via GitHub
wzymumon commented on issue #17176: URL: https://github.com/apache/doris/issues/17176#issuecomment-1451431876 > > Hi, I'm new here. I'd like to do task 33: [array function] Support array_count function. > > okk, have fun here. Thank you! I create an issue of this task: https:

[GitHub] [doris] dataroaring merged pull request #17317: [bugfix](merger) traverse rs_meta in lock

2023-03-01 Thread via GitHub
dataroaring merged PR #17317: URL: https://github.com/apache/doris/pull/17317 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.

[doris] branch branch-1.2-lts updated: [bugfix](merger) traverse rs_meta in lock (#17317)

2023-03-01 Thread dataroaring
This is an automated email from the ASF dual-hosted git repository. dataroaring pushed a commit to branch branch-1.2-lts in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/branch-1.2-lts by this push: new 7a6bc9eb7f [bugfix](merger)

[GitHub] [doris] github-actions[bot] commented on pull request #16813: [enhance](cooldown)upload rowset meta once chosen to be new cooldown replica

2023-03-01 Thread via GitHub
github-actions[bot] commented on PR #16813: URL: https://github.com/apache/doris/pull/16813#issuecomment-1451426138 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #17328: [Enchancement](function) Inline some aggregate function && remove nullable combinator

2023-03-01 Thread via GitHub
github-actions[bot] commented on PR #17328: URL: https://github.com/apache/doris/pull/17328#issuecomment-1451424656 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #17325: [Bug](Block compression) Fix bug if `config::compress_rowbatches=fals…

2023-03-01 Thread via GitHub
github-actions[bot] commented on PR #17325: URL: https://github.com/apache/doris/pull/17325#issuecomment-1451422614 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] eldenmoon commented on pull request #17325: [Bug](Block compression) Fix bug if `config::compress_rowbatches=fals…

2023-03-01 Thread via GitHub
eldenmoon commented on PR #17325: URL: https://github.com/apache/doris/pull/17325#issuecomment-1451420102 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [doris] github-actions[bot] commented on pull request #17334: [fix](merge-on-write) fix that delete bitmap is not calculated correctly when clone tablet

2023-03-01 Thread via GitHub
github-actions[bot] commented on PR #17334: URL: https://github.com/apache/doris/pull/17334#issuecomment-1451414146 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] yuxuan-luo commented on a diff in pull request #17291: [fix](routine load) fix ROUTINE LOAD bug,kafka commit a lack of one(#17282)

2023-03-01 Thread via GitHub
yuxuan-luo commented on code in PR #17291: URL: https://github.com/apache/doris/pull/17291#discussion_r1122690347 ## be/src/runtime/routine_load/routine_load_task_executor.cpp: ## @@ -320,8 +320,8 @@ void RoutineLoadTaskExecutor::exec_task(std::shared_ptr ctx, std::v

[GitHub] [doris] liaoxin01 opened a new pull request, #17334: [fix](merge-on-write) fix that delete bitmap is not calculated correctly when clone tablet

2023-03-01 Thread via GitHub
liaoxin01 opened a new pull request, #17334: URL: https://github.com/apache/doris/pull/17334 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ]

[GitHub] [doris] eldenmoon commented on pull request #17325: [Bug](Block compression) Fix bug if `config::compress_rowbatches=fals…

2023-03-01 Thread via GitHub
eldenmoon commented on PR #17325: URL: https://github.com/apache/doris/pull/17325#issuecomment-1451407947 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[GitHub] [doris] freemandealer opened a new issue, #17333: [Enhancement] better merge single_replica_load_rpc_service into brpc_service

2023-03-01 Thread via GitHub
freemandealer opened a new issue, #17333: URL: https://github.com/apache/doris/issues/17333 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Description better merge s

[GitHub] [doris] hello-stephen commented on pull request #17325: [Bug](Block compression) Fix bug if `config::compress_rowbatches=fals…

2023-03-01 Thread via GitHub
hello-stephen commented on PR #17325: URL: https://github.com/apache/doris/pull/17325#issuecomment-1451400412 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 35.29 seconds stream load tsv: 473 seconds loaded 74807831229 Bytes, about 150 MB/s

[GitHub] [doris] AshinGau opened a new pull request, #17332: [fix](test) regression test file has been removed

2023-03-01 Thread via GitHub
AshinGau opened a new pull request, #17332: URL: https://github.com/apache/doris/pull/17332 # Proposed changes Data file in https://github.com/apache/doris/pull/16342/files has been removed for path conflict, so change the resource path. ## Checklist(Required) * [ ] Does

[GitHub] [doris] github-actions[bot] commented on pull request #17331: [Fix](Lightweight schema Change) query error caused by array default type is unsupported

2023-03-01 Thread via GitHub
github-actions[bot] commented on PR #17331: URL: https://github.com/apache/doris/pull/17331#issuecomment-1451399420 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] luozenglin commented on a diff in pull request #17298: [fix](array)(parquet) fix be core dump due to load from parquet file containing array types

2023-03-01 Thread via GitHub
luozenglin commented on code in PR #17298: URL: https://github.com/apache/doris/pull/17298#discussion_r1122675399 ## be/src/runtime/types.cpp: ## @@ -264,9 +264,9 @@ TypeDescriptor::TypeDescriptor(const google::protobuf::RepeatedPtrField

[GitHub] [doris] zddr commented on pull request #17236: [Enhance](auth)Users support multiple roles

2023-03-01 Thread via GitHub
zddr commented on PR #17236: URL: https://github.com/apache/doris/pull/17236#issuecomment-1451397402 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[GitHub] [doris] zddr commented on pull request #17281: [enhancement](k8s)K8s yml demo

2023-03-01 Thread via GitHub
zddr commented on PR #17281: URL: https://github.com/apache/doris/pull/17281#issuecomment-1451396921 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[GitHub] [doris] sangetang commented on issue #17214: [Bug] missing from GROUP BY

2023-03-01 Thread via GitHub
sangetang commented on issue #17214: URL: https://github.com/apache/doris/issues/17214#issuecomment-1451395820 > Hello, I think this PR #16854 can solve your problem. It has been merge into branch-1.2-lts, and we will release version 1.2.3 as soon as possible I`ll try it. 3ks -- Th

[GitHub] [doris] github-actions[bot] commented on pull request #17331: [Fix](Lightweight schema Change) query error caused by array default type is unsupported

2023-03-01 Thread via GitHub
github-actions[bot] commented on PR #17331: URL: https://github.com/apache/doris/pull/17331#issuecomment-1451395789 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #17330: [Refactor](map) remove using column array in map to reduce offset column

2023-03-01 Thread via GitHub
github-actions[bot] commented on PR #17330: URL: https://github.com/apache/doris/pull/17330#issuecomment-1451394717 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] ZhangYu0123 opened a new pull request, #17331: [Fix](Lightweight schema Change) query error caused by array default type is unsupported

2023-03-01 Thread via GitHub
ZhangYu0123 opened a new pull request, #17331: URL: https://github.com/apache/doris/pull/17331 When using lightweight schema Change to add column array type, query failed as follows: https://user-images.githubusercontent.com/67053339/222353542-e9e396d6-9951-469f-a409-24a3960bf245.png"

[GitHub] [doris] nextdreamblue commented on pull request #17327: [fix](restore) fix bug when replay restore with reserve dynamic partition cause OBSERVER down

2023-03-01 Thread via GitHub
nextdreamblue commented on PR #17327: URL: https://github.com/apache/doris/pull/17327#issuecomment-1451386820 run COMPILE -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [doris] yiguolei commented on a diff in pull request #15917: [improvement](scan) Support pushdown execute expr ctx

2023-03-01 Thread via GitHub
yiguolei commented on code in PR #15917: URL: https://github.com/apache/doris/pull/15917#discussion_r1122663273 ## be/src/vec/exec/scan/vscan_node.cpp: ## @@ -458,7 +461,15 @@ Status VScanNode::_normalize_conjuncts() { RETURN_IF_ERROR(_normalize_predicate((*_vconju

[GitHub] [doris] sangetang closed issue #17214: [Bug] missing from GROUP BY

2023-03-01 Thread via GitHub
sangetang closed issue #17214: [Bug] missing from GROUP BY URL: https://github.com/apache/doris/issues/17214 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

[GitHub] [doris] sangetang commented on issue #17214: [Bug] missing from GROUP BY

2023-03-01 Thread via GitHub
sangetang commented on issue #17214: URL: https://github.com/apache/doris/issues/17214#issuecomment-1451382163 > Hello, I think this PR #16854 can solve your problem. It has been merge into branch-1.2-lts, and we will release version 1.2.3 as soon as possible -- This is an automat

[GitHub] [doris] github-actions[bot] commented on a diff in pull request #17330: [Refactor](map) remove using column array in map to reduce offset column

2023-03-01 Thread via GitHub
github-actions[bot] commented on code in PR #17330: URL: https://github.com/apache/doris/pull/17330#discussion_r1122660820 ## be/src/vec/columns/column_map.cpp: ## @@ -135,71 +198,162 @@ } } +StringRef ColumnMap::serialize_value_into_arena(size_t n, Arena& arena, char c

[GitHub] [doris] github-actions[bot] commented on pull request #17328: [Enchancement](function) Inline some aggregate function && remove nullable combinator

2023-03-01 Thread via GitHub
github-actions[bot] commented on PR #17328: URL: https://github.com/apache/doris/pull/17328#issuecomment-1451380371 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] yinzhijian commented on pull request #17329: [enhancement](k8s) Support fqdn mode for fe in k8s enviroment

2023-03-01 Thread via GitHub
yinzhijian commented on PR #17329: URL: https://github.com/apache/doris/pull/17329#issuecomment-1451380049 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [doris] nextdreamblue commented on pull request #17327: [fix](restore) fix bug when replay restore with reserve dynamic partition cause OBSERVER down

2023-03-01 Thread via GitHub
nextdreamblue commented on PR #17327: URL: https://github.com/apache/doris/pull/17327#issuecomment-1451375633 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [doris] nextdreamblue commented on pull request #17326: [fix](restore) fix bug when replay restore with reserve dynamic partition cause OBSERVER down

2023-03-01 Thread via GitHub
nextdreamblue commented on PR #17326: URL: https://github.com/apache/doris/pull/17326#issuecomment-1451374996 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [doris] amorynan opened a new pull request, #17330: [Refactor](map) remove using column array in map to reduce offset column

2023-03-01 Thread via GitHub
amorynan opened a new pull request, #17330: URL: https://github.com/apache/doris/pull/17330 # Proposed changes 1. remove column array in map 2. add offsets column in map Aim to reduce duplicate offset from key-array and value-array in disk ## Problem summary Descri

[GitHub] [doris] BiteTheDDDDt commented on pull request #17202: [Chore](third-party) upgrade thrift from 0.13 to 0.16

2023-03-01 Thread via GitHub
BiteThet commented on PR #17202: URL: https://github.com/apache/doris/pull/17202#issuecomment-1451374830 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [doris] AshinGau commented on a diff in pull request #17298: [fix](array)(parquet) fix be core dump due to load from parquet file containing array types

2023-03-01 Thread via GitHub
AshinGau commented on code in PR #17298: URL: https://github.com/apache/doris/pull/17298#discussion_r1122654996 ## be/src/runtime/types.cpp: ## @@ -264,9 +264,9 @@ TypeDescriptor::TypeDescriptor(const google::protobuf::RepeatedPtrField

[GitHub] [doris] yinzhijian opened a new pull request, #17329: [enhancement](k8s) Support fqdn mode for fe in k8s enviroment

2023-03-01 Thread via GitHub
yinzhijian opened a new pull request, #17329: URL: https://github.com/apache/doris/pull/17329 # Proposed changes ## Problem summary 大体逻辑沿用#9172 ### 关键改动点: 1. FE的nodename从ip_port_timestamp改为hostname_port_timestamp,如下图中的fe3就是这个实例在k8s中的域名:https://user-images.githubus

[GitHub] [doris] BiteTheDDDDt opened a new pull request, #17328: [Enchancement](function) Inline some aggregate function && remove nullable combinator

2023-03-01 Thread via GitHub
BiteThet opened a new pull request, #17328: URL: https://github.com/apache/doris/pull/17328 # Proposed changes 1. Inline some aggregate function 2. remove nullable combinator ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does

[GitHub] [doris] nextdreamblue opened a new pull request, #17327: [fix](restore) fix bug when replay restore with reserve dynamic partition cause OBSERVER down

2023-03-01 Thread via GitHub
nextdreamblue opened a new pull request, #17327: URL: https://github.com/apache/doris/pull/17327 when replay restore a table with reserve_dynamic_partition_enable=true, must registerOrRemoveDynamicPartitionTable with isReplay=true, or maybe cause OBSERVER can not replay restore auditlog

[GitHub] [doris] nextdreamblue opened a new pull request, #17326: [fix](restore) fix bug when replay restore with reserve dynamic partition cause OBSERVER down

2023-03-01 Thread via GitHub
nextdreamblue opened a new pull request, #17326: URL: https://github.com/apache/doris/pull/17326 when replay restore a table with reserve_dynamic_partition_enable=true, must registerOrRemoveDynamicPartitionTable with isReplay=true, or maybe cause OBSERVER can not replay restore auditlog suc

[GitHub] [doris] morrySnow commented on pull request #17269: [test](Nereids) turn on all test in scalar function w

2023-03-01 Thread via GitHub
morrySnow commented on PR #17269: URL: https://github.com/apache/doris/pull/17269#issuecomment-1451360073 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [doris] morrySnow commented on pull request #17200: [enhancement](nereids) convert string literal to commontype in in-expr and cass-when-expr

2023-03-01 Thread via GitHub
morrySnow commented on PR #17200: URL: https://github.com/apache/doris/pull/17200#issuecomment-1451359882 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [doris] platoneko commented on pull request #17252: [fix](cooldown) Fix deadlock in tablet clone

2023-03-01 Thread via GitHub
platoneko commented on PR #17252: URL: https://github.com/apache/doris/pull/17252#issuecomment-1451358822 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[GitHub] [doris] TangSiyang2001 commented on a diff in pull request #17249: [Fix](Stmt)Move reset insert timeout in handleInsert

2023-03-01 Thread via GitHub
TangSiyang2001 commented on code in PR #17249: URL: https://github.com/apache/doris/pull/17249#discussion_r1122640852 ## fe/fe-core/src/main/java/org/apache/doris/qe/ConnectContext.java: ## @@ -640,12 +640,13 @@ public String getCurrentConnectedFEIp() { return currentCo

[doris] branch master updated: [fix](demo)fix cdc failed to synchronize datetime type in mysql, and added JsonDebeziumSchemaSerializer (#16971)

2023-03-01 Thread diwu
This is an automated email from the ASF dual-hosted git repository. diwu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 698e9cd243 [fix](demo)fix cdc failed to synchronize

[GitHub] [doris] JNSimba merged pull request #16971: [fix](demo)fix cdc failed to synchronize datetime type in mysql, and added JsonDebeziumSchemaSerializer

2023-03-01 Thread via GitHub
JNSimba merged PR #16971: URL: https://github.com/apache/doris/pull/16971 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apac

[GitHub] [doris] github-actions[bot] commented on a diff in pull request #17246: [feature](cooldown)add ut for cooldown on be

2023-03-01 Thread via GitHub
github-actions[bot] commented on code in PR #17246: URL: https://github.com/apache/doris/pull/17246#discussion_r1122638213 ## be/test/olap/tablet_cooldown_test.cpp: ## @@ -35,27 +39,67 @@ namespace doris { +using ::testing::_; +using ::testing::DoAll; +using ::testing::Retu

[doris] branch master updated (9155d8b9d1 -> 9f088f6e90)

2023-03-01 Thread xuyang
This is an automated email from the ASF dual-hosted git repository. xuyang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 9155d8b9d1 [fix](delete) fix 'is null' or 'is not null' delete predicate will get wrong result (#17190) add 9f088

[GitHub] [doris] xy720 closed issue #17216: [Feature] add some new json function

2023-03-01 Thread via GitHub
xy720 closed issue #17216: [Feature] add some new json function URL: https://github.com/apache/doris/issues/17216 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

[GitHub] [doris] xy720 merged pull request #17247: [feature](json) add json_valid function

2023-03-01 Thread via GitHub
xy720 merged PR #17247: URL: https://github.com/apache/doris/pull/17247 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache

[GitHub] [doris] hello-stephen commented on pull request #17291: [fix](routine load) fix ROUTINE LOAD bug,kafka commit a lack of one(#17282)

2023-03-01 Thread via GitHub
hello-stephen commented on PR #17291: URL: https://github.com/apache/doris/pull/17291#issuecomment-1451350659 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 33.83 seconds stream load tsv: 481 seconds loaded 74807831229 Bytes, about 148 MB/s

[GitHub] [doris] eldenmoon commented on pull request #17325: [Bug](Block compression) Fix bug if `config::compress_rowbatches=fals…

2023-03-01 Thread via GitHub
eldenmoon commented on PR #17325: URL: https://github.com/apache/doris/pull/17325#issuecomment-1451348114 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [doris] xy720 closed issue #17183: [Bug] delete from with is null predicate and then query will get wrong result with is not null predicate

2023-03-01 Thread via GitHub
xy720 closed issue #17183: [Bug] delete from with is null predicate and then query will get wrong result with is not null predicate URL: https://github.com/apache/doris/issues/17183 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [doris] xy720 merged pull request #17190: [fix](delete) fix 'is null' or 'is not null' delete predicate will get wrong result

2023-03-01 Thread via GitHub
xy720 merged PR #17190: URL: https://github.com/apache/doris/pull/17190 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache

[doris] branch master updated: [fix](delete) fix 'is null' or 'is not null' delete predicate will get wrong result (#17190)

2023-03-01 Thread xuyang
This is an automated email from the ASF dual-hosted git repository. xuyang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 9155d8b9d1 [fix](delete) fix 'is null' or 'is not

[GitHub] [doris] github-actions[bot] commented on pull request #17247: [feature](json) add json_valid function

2023-03-01 Thread via GitHub
github-actions[bot] commented on PR #17247: URL: https://github.com/apache/doris/pull/17247#issuecomment-1451347397 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #17325: [Bug](Block compression) Fix bug if `config::compress_rowbatches=fals…

2023-03-01 Thread via GitHub
github-actions[bot] commented on PR #17325: URL: https://github.com/apache/doris/pull/17325#issuecomment-1451346466 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] SaintBacchus commented on a diff in pull request #17249: [Fix](Stmt)Move reset insert timeout in handleInsert

2023-03-01 Thread via GitHub
SaintBacchus commented on code in PR #17249: URL: https://github.com/apache/doris/pull/17249#discussion_r1122630856 ## fe/fe-core/src/main/java/org/apache/doris/qe/ConnectContext.java: ## @@ -640,12 +640,13 @@ public String getCurrentConnectedFEIp() { return currentConn

[GitHub] [doris] eldenmoon opened a new pull request, #17325: [Bug](Block compression) Fix bug if `config::compress_rowbatches=fals…

2023-03-01 Thread via GitHub
eldenmoon opened a new pull request, #17325: URL: https://github.com/apache/doris/pull/17325 …e` then the block column values could be empty # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) *

[GitHub] [doris] SaintBacchus commented on pull request #17249: [Fix](Stmt)Move reset insert timeout in handleInsert

2023-03-01 Thread via GitHub
SaintBacchus commented on PR #17249: URL: https://github.com/apache/doris/pull/17249#issuecomment-1451339933 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [doris] github-actions[bot] commented on pull request #17324: [function](vec)use const_col to opt current functions.

2023-03-01 Thread via GitHub
github-actions[bot] commented on PR #17324: URL: https://github.com/apache/doris/pull/17324#issuecomment-1451337529 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] Bingandbing commented on pull request #17305: [enhancement](planner) support case transition of timestamp datatype when create table

2023-03-01 Thread via GitHub
Bingandbing commented on PR #17305: URL: https://github.com/apache/doris/pull/17305#issuecomment-1451337258 buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [doris] zclllyybb commented on pull request #17324: [function](vec)use const_col to opt current functions.

2023-03-01 Thread via GitHub
zclllyybb commented on PR #17324: URL: https://github.com/apache/doris/pull/17324#issuecomment-1451335233 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [doris] SaintBacchus commented on a diff in pull request #17249: [Fix](Stmt)Move reset insert timeout in handleInsert

2023-03-01 Thread via GitHub
SaintBacchus commented on code in PR #17249: URL: https://github.com/apache/doris/pull/17249#discussion_r1122623932 ## fe/fe-core/src/main/java/org/apache/doris/qe/StmtExecutor.java: ## @@ -1473,7 +1473,9 @@ private void beginTxn(String dbName, String tblName) throws UserExcept

[GitHub] [doris] zclllyybb opened a new pull request, #17324: [function](vec)use const_col to opt current functions.

2023-03-01 Thread via GitHub
zclllyybb opened a new pull request, #17324: URL: https://github.com/apache/doris/pull/17324 ## Problem Summary The changes are like https://github.com/apache/doris/pull/16953 , apply to CurrentDate and CurrentDateTime. ## Checklist(Required) * [ ] Does it affect the ori

[GitHub] [doris] WuWQ98 opened a new pull request, #17323: add profile download button

2023-03-01 Thread via GitHub
WuWQ98 opened a new pull request, #17323: URL: https://github.com/apache/doris/pull/17323 # Proposed changes Issue Number: doris's future task 23 ## Problem summary add profile download button -- This is an automated message from the Apache Git Service. To

[GitHub] [doris] englefly commented on pull request #17320: [feature](nereids) print memo and the choosed physical plan

2023-03-01 Thread via GitHub
englefly commented on PR #17320: URL: https://github.com/apache/doris/pull/17320#issuecomment-1451329227 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [doris] SaintBacchus commented on a diff in pull request #17249: [Fix](Stmt)Move reset insert timeout in handleInsert

2023-03-01 Thread via GitHub
SaintBacchus commented on code in PR #17249: URL: https://github.com/apache/doris/pull/17249#discussion_r1122617896 ## fe/fe-core/src/main/java/org/apache/doris/qe/StmtExecutor.java: ## @@ -1534,6 +1536,8 @@ private void handleInsertStmt() throws Exception { }

[GitHub] [doris] github-actions[bot] commented on a diff in pull request #17246: [feature](cooldown)add ut for cooldown on be

2023-03-01 Thread via GitHub
github-actions[bot] commented on code in PR #17246: URL: https://github.com/apache/doris/pull/17246#discussion_r1122613258 ## be/test/olap/tablet_cooldown_test.cpp: ## @@ -41,21 +45,56 @@ static const std::string kTestDir = "./ut_dir/tablet_cooldown_test"; static constexpr int

[GitHub] [doris] github-actions[bot] commented on pull request #17322: [fix](memory) Modify `mem_limit` default value

2023-03-01 Thread via GitHub
github-actions[bot] commented on PR #17322: URL: https://github.com/apache/doris/pull/17322#issuecomment-1451320933 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] xinyiZzz opened a new pull request, #17322: [fix](memory) Modify `mem_limit` default value

2023-03-01 Thread via GitHub
xinyiZzz opened a new pull request, #17322: URL: https://github.com/apache/doris/pull/17322 # Proposed changes Issue Number: close #xxx ## Problem summary Modify the default value of `mem_limit` to auto. `auto` means process mem limit is equal to max(physical mem * 0.9,

[GitHub] [doris] github-actions[bot] commented on pull request #17076: [optimize](vectorization)Optimize to_string's performance.

2023-03-01 Thread via GitHub
github-actions[bot] commented on PR #17076: URL: https://github.com/apache/doris/pull/17076#issuecomment-1451310904 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #17316: [fix](docs) Add the tag for insert_timeout.

2023-03-01 Thread via GitHub
github-actions[bot] commented on PR #17316: URL: https://github.com/apache/doris/pull/17316#issuecomment-1451307500 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on pull request #17316: [fix](docs) Add the tag for insert_timeout.

2023-03-01 Thread via GitHub
github-actions[bot] commented on PR #17316: URL: https://github.com/apache/doris/pull/17316#issuecomment-1451307445 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] dinggege1024 commented on issue #14937: [Bug] [daily]pymysql execute lost connection when sql failed

2023-03-01 Thread via GitHub
dinggege1024 commented on issue #14937: URL: https://github.com/apache/doris/issues/14937#issuecomment-1451305602 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [doris] zclllyybb commented on pull request #17076: [optimize](vectorization)Optimize to_string's performance.

2023-03-01 Thread via GitHub
zclllyybb commented on PR #17076: URL: https://github.com/apache/doris/pull/17076#issuecomment-1451305112 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [doris] yiguolei commented on pull request #17291: [fix](routine load) fix ROUTINE LOAD bug,kafka commit a lack of one(#17282)

2023-03-01 Thread via GitHub
yiguolei commented on PR #17291: URL: https://github.com/apache/doris/pull/17291#issuecomment-1451295077 ./run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [doris] XieJiann commented on pull request #16797: [feature](Nereids): add rule split limit into two phase

2023-03-01 Thread via GitHub
XieJiann commented on PR #16797: URL: https://github.com/apache/doris/pull/16797#issuecomment-1451294714 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [doris] github-actions[bot] commented on pull request #17314: [fix](expr) avoid crashing caused by big depth of expression tree

2023-03-01 Thread via GitHub
github-actions[bot] commented on PR #17314: URL: https://github.com/apache/doris/pull/17314#issuecomment-1451294591 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on pull request #17314: [fix](expr) avoid crashing caused by big depth of expression tree

2023-03-01 Thread via GitHub
github-actions[bot] commented on PR #17314: URL: https://github.com/apache/doris/pull/17314#issuecomment-1451294569 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] yiguolei commented on pull request #17314: [fix](expr) avoid crashing caused by big depth of expression tree

2023-03-01 Thread via GitHub
yiguolei commented on PR #17314: URL: https://github.com/apache/doris/pull/17314#issuecomment-1451294571 ./run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [doris] yiguolei commented on a diff in pull request #17314: [fix](expr) avoid crashing caused by big depth of expression tree

2023-03-01 Thread via GitHub
yiguolei commented on code in PR #17314: URL: https://github.com/apache/doris/pull/17314#discussion_r1122594049 ## be/src/vec/exprs/vexpr.cpp: ## @@ -85,9 +85,17 @@ VExpr::VExpr(const TypeDescriptor& type, bool is_slotref, bool is_nullable) } Status VExpr::prepare(RuntimeSt

[GitHub] [doris] zhengshiJ commented on pull request #16616: [Feature](nereids) Support Mark join

2023-03-01 Thread via GitHub
zhengshiJ commented on PR #16616: URL: https://github.com/apache/doris/pull/16616#issuecomment-1451292511 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [doris] starocean999 commented on pull request #17315: [fix](nereids)fix first_value/lead/lag window function bug in nereids

2023-03-01 Thread via GitHub
starocean999 commented on PR #17315: URL: https://github.com/apache/doris/pull/17315#issuecomment-1451289433 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [doris] starocean999 commented on a diff in pull request #17315: [fix](nereids)fix first_value/lead/lag window function bug in nereids

2023-03-01 Thread via GitHub
starocean999 commented on code in PR #17315: URL: https://github.com/apache/doris/pull/17315#discussion_r1122589837 ## be/src/vec/aggregate_functions/aggregate_function_window.h: ## @@ -274,6 +274,8 @@ struct LeadLagData { const auto* nullable_column = assert_ca

[GitHub] [doris] hello-stephen commented on pull request #17315: [fix](nereids)fix first_value/lead/lag window function bug in nereids

2023-03-01 Thread via GitHub
hello-stephen commented on PR #17315: URL: https://github.com/apache/doris/pull/17315#issuecomment-1451288995 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 33.78 seconds stream load tsv: 473 seconds loaded 74807831229 Bytes, about 150 MB/s

[GitHub] [doris] TangSiyang2001 commented on pull request #17249: [Fix](Stmt)Move reset insert timeout in handleInsert

2023-03-01 Thread via GitHub
TangSiyang2001 commented on PR #17249: URL: https://github.com/apache/doris/pull/17249#issuecomment-1451288521 > I think use `resetExecTimeForInsert` to do these job is better than `setExecTime` since it had called three times. Sorry for late reply, you may look at my comment above. W

[GitHub] [doris] github-actions[bot] commented on pull request #17315: [fix](nereids)fix first_value/lead/lag window function bug in nereids

2023-03-01 Thread via GitHub
github-actions[bot] commented on PR #17315: URL: https://github.com/apache/doris/pull/17315#issuecomment-1451286611 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] TangSiyang2001 commented on a diff in pull request #17249: [Fix](Stmt)Move reset insert timeout in handleInsert

2023-03-01 Thread via GitHub
TangSiyang2001 commented on code in PR #17249: URL: https://github.com/apache/doris/pull/17249#discussion_r1122587056 ## fe/fe-core/src/main/java/org/apache/doris/qe/StmtExecutor.java: ## @@ -1534,6 +1536,8 @@ private void handleInsertStmt() throws Exception { }

[GitHub] [doris] TangSiyang2001 commented on a diff in pull request #17249: [Fix](Stmt)Move reset insert timeout in handleInsert

2023-03-01 Thread via GitHub
TangSiyang2001 commented on code in PR #17249: URL: https://github.com/apache/doris/pull/17249#discussion_r1122586355 ## fe/fe-core/src/main/java/org/apache/doris/qe/StmtExecutor.java: ## @@ -1473,7 +1473,9 @@ private void beginTxn(String dbName, String tblName) throws UserExce

[GitHub] [doris] TangSiyang2001 commented on a diff in pull request #17249: [Fix](Stmt)Move reset insert timeout in handleInsert

2023-03-01 Thread via GitHub
TangSiyang2001 commented on code in PR #17249: URL: https://github.com/apache/doris/pull/17249#discussion_r1122584990 ## fe/fe-core/src/main/java/org/apache/doris/analysis/InsertStmt.java: ## @@ -304,7 +304,9 @@ public void analyze(Analyzer analyzer) throws UserException {

[GitHub] [doris] will86 opened a new issue, #17321: [Feature] explode_json_array_jsonobject

2023-03-01 Thread via GitHub
will86 opened a new issue, #17321: URL: https://github.com/apache/doris/issues/17321 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Description As Doris has prov

[GitHub] [doris] sohardforaname commented on pull request #17196: [Feature](Nereids)add check to disable unsupported type for Nereids

2023-03-01 Thread via GitHub
sohardforaname commented on PR #17196: URL: https://github.com/apache/doris/pull/17196#issuecomment-1451271842 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [doris] englefly opened a new pull request, #17320: [feature](nereids) print memo and the choosed physical plan

2023-03-01 Thread via GitHub
englefly opened a new pull request, #17320: URL: https://github.com/apache/doris/pull/17320 # Proposed changes session variable: dump_nereids_memo = true/false if true, nereids print memo and the chosen physical plan in stdout and log. Issue Number: close #xxx ## Probl

[GitHub] [doris] nextdreamblue opened a new issue, #17319: [Bug]

2023-03-01 Thread via GitHub
nextdreamblue opened a new issue, #17319: URL: https://github.com/apache/doris/issues/17319 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Version 1.1 1.2 mast

[GitHub] [doris] ZhangYu0123 commented on pull request #17260: [enhencement](csv_reader) support quotes content include delimiter and escape character

2023-03-01 Thread via GitHub
ZhangYu0123 commented on PR #17260: URL: https://github.com/apache/doris/pull/17260#issuecomment-1451262067 run p1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[GitHub] [doris] github-actions[bot] commented on pull request #17314: [fix](expr) avoid crashing caused by big depth of expression tree

2023-03-01 Thread via GitHub
github-actions[bot] commented on PR #17314: URL: https://github.com/apache/doris/pull/17314#issuecomment-1451261010 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] zddr opened a new pull request, #17318: [draft][k8s]K8s doc

2023-03-01 Thread via GitHub
zddr opened a new pull request, #17318: URL: https://github.com/apache/doris/pull/17318 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. document for doris on k8s ## Checklist(Required) * [ ] Does it affect the original be

  1   2   3   4   5   6   >