[GitHub] [doris] weizuo93 commented on a diff in pull request #10298: [Load][Enhancement] Support single replica load

2022-07-18 Thread GitBox
weizuo93 commented on code in PR #10298: URL: https://github.com/apache/doris/pull/10298#discussion_r923435779 ## be/src/common/config.h: ## @@ -35,6 +35,11 @@ CONF_Int32(brpc_port, "8060"); // the number of bthreads for brpc, the default value is set to -1, which means the nu

[GitHub] [doris] cambyzju commented on pull request #10980: [Bug][Array] cast array element to same type

2022-07-18 Thread GitBox
cambyzju commented on PR #10980: URL: https://github.com/apache/doris/pull/10980#issuecomment-1188657754 FE UT need to fix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [doris] cambyzju commented on pull request #10980: [Bug][Array] cast array element to same type

2022-07-18 Thread GitBox
cambyzju commented on PR #10980: URL: https://github.com/apache/doris/pull/10980#issuecomment-1188656420 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

[GitHub] [doris] morningman closed pull request #10952: [Draft] External catalog test

2022-07-18 Thread GitBox
morningman closed pull request #10952: [Draft] External catalog test URL: https://github.com/apache/doris/pull/10952 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[GitHub] [doris] morningman opened a new pull request, #11000: [feature-wip](multi-catalog) Support runtime filter for file scan node

2022-07-18 Thread GitBox
morningman opened a new pull request, #11000: URL: https://github.com/apache/doris/pull/11000 # Proposed changes Issue Number: close #xxx ## Problem Summary: 1. Support runtime filter for file scan node 2. Refactor some profile of file scan node ## Checklist(Req

[GitHub] [doris] qzsee commented on a diff in pull request #10667: [Enhancement](Nereids) add some expr rewrite rule and plan rewrite rule of rewrite its expression

2022-07-18 Thread GitBox
qzsee commented on code in PR #10667: URL: https://github.com/apache/doris/pull/10667#discussion_r924097995 ## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/rewrite/ExpressionOfPlanRewrite.java: ## @@ -0,0 +1,136 @@ +// Licensed to the Apache Software Founda

[GitHub] [doris] cambyzju commented on a diff in pull request #10824: [Fix] (array-type) add the supported sub-type and regression

2022-07-18 Thread GitBox
cambyzju commented on code in PR #10824: URL: https://github.com/apache/doris/pull/10824#discussion_r924096613 ## fe/fe-core/src/main/java/org/apache/doris/analysis/TypeDef.java: ## @@ -118,8 +118,11 @@ private void analyzeNestedType(ScalarType type) throws AnalysisException {

[GitHub] [doris] wangshuo128 commented on a diff in pull request #10890: [Feature](Nereids) Reorder join to eliminate cross join.

2022-07-18 Thread GitBox
wangshuo128 commented on code in PR #10890: URL: https://github.com/apache/doris/pull/10890#discussion_r924092890 ## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/logical/ReorderJoin.java: ## @@ -0,0 +1,215 @@ +// Licensed to the Apache Software Foundation (ASF

[GitHub] [doris] wangshuo128 commented on a diff in pull request #10890: [Feature](Nereids) Reorder join to eliminate cross join.

2022-07-18 Thread GitBox
wangshuo128 commented on code in PR #10890: URL: https://github.com/apache/doris/pull/10890#discussion_r924090598 ## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/logical/ReorderJoin.java: ## @@ -0,0 +1,201 @@ +// Licensed to the Apache Software Foundation (ASF

[GitHub] [doris] qzsee commented on a diff in pull request #10667: [Enhancement](Nereids) add some expr rewrite rule and plan rewrite rule of rewrite its expression

2022-07-18 Thread GitBox
qzsee commented on code in PR #10667: URL: https://github.com/apache/doris/pull/10667#discussion_r924090467 ## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/rewrite/ExpressionOfPlanRewrite.java: ## @@ -0,0 +1,136 @@ +// Licensed to the Apache Software Founda

[GitHub] [doris] github-actions[bot] commented on pull request #10970: [sample]Add flink doris connector 1.1 sample code

2022-07-18 Thread GitBox
github-actions[bot] commented on PR #10970: URL: https://github.com/apache/doris/pull/10970#issuecomment-1188632060 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on pull request #10970: [sample]Add flink doris connector 1.1 sample code

2022-07-18 Thread GitBox
github-actions[bot] commented on PR #10970: URL: https://github.com/apache/doris/pull/10970#issuecomment-1188632038 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] qzsee commented on a diff in pull request #10667: [Enhancement](Nereids) add some expr rewrite rule and plan rewrite rule of rewrite its expression

2022-07-18 Thread GitBox
qzsee commented on code in PR #10667: URL: https://github.com/apache/doris/pull/10667#discussion_r924087759 ## fe/fe-core/src/main/java/org/apache/doris/nereids/util/ExpressionUtils.java: ## @@ -102,8 +104,13 @@ public static Expression combine(ExpressionType op, List expressio

[GitHub] [doris] qzsee commented on a diff in pull request #10667: [Enhancement](Nereids) add some expr rewrite rule and plan rewrite rule of rewrite its expression

2022-07-18 Thread GitBox
qzsee commented on code in PR #10667: URL: https://github.com/apache/doris/pull/10667#discussion_r924087386 ## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/rewrite/rules/ExtractCommonFactorRule.java: ## @@ -0,0 +1,76 @@ +// Licensed to the Apache Software F

[GitHub] [doris] github-actions[bot] commented on pull request #10956: [refractor](array-type) use array sub types to register collect_list

2022-07-18 Thread GitBox
github-actions[bot] commented on PR #10956: URL: https://github.com/apache/doris/pull/10956#issuecomment-1188597169 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #10956: [refractor](array-type) use array sub types to register collect_list

2022-07-18 Thread GitBox
github-actions[bot] commented on PR #10956: URL: https://github.com/apache/doris/pull/10956#issuecomment-1188597181 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] yinzhijian opened a new pull request, #10999: [feature](nereids) support cast and extract date for TPC-H

2022-07-18 Thread GitBox
yinzhijian opened a new pull request, #10999: URL: https://github.com/apache/doris/pull/10999 # Proposed changes Issue Number: close #xxx ## Problem Summary: support cast and extract date for TPC-H, for example: 1. select cast(a as datetime) as d from test; 2. selec

[GitHub] [doris] smallhibiscus closed pull request #10985: [regression] Update ssb sf1 unique table load dir.

2022-07-18 Thread GitBox
smallhibiscus closed pull request #10985: [regression] Update ssb sf1 unique table load dir. URL: https://github.com/apache/doris/pull/10985 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [doris] smallhibiscus commented on pull request #10992: [regression] Revert Add ssb sf1 test under unique table with zstd

2022-07-18 Thread GitBox
smallhibiscus commented on PR #10992: URL: https://github.com/apache/doris/pull/10992#issuecomment-1188567203 The pipeline check fails and the pipeline check succeeds. This pr needs to be reverted to perform the pipeline check again. -- This is an automated message from the Apache Git Ser

[GitHub] [doris] freesinger commented on a diff in pull request #10322: [feature](JSON datatype)Support JSON datatype

2022-07-18 Thread GitBox
freesinger commented on code in PR #10322: URL: https://github.com/apache/doris/pull/10322#discussion_r924035717 ## be/src/runtime/json_value.cpp: ## @@ -0,0 +1,54 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See

[GitHub] [doris] github-actions[bot] commented on pull request #10995: [fix](cache) fix that ShardedLRUCache may coredump when destructor was called

2022-07-18 Thread GitBox
github-actions[bot] commented on PR #10995: URL: https://github.com/apache/doris/pull/10995#issuecomment-1188565841 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] morningman opened a new pull request, #10998: [doc] missing sidebar for cloudcanal

2022-07-18 Thread GitBox
morningman opened a new pull request, #10998: URL: https://github.com/apache/doris/pull/10998 # Proposed changes Issue Number: close #xxx ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original behavior: (Y

[GitHub] [doris] JNSimba opened a new pull request, #10997: [Doc] Resolve Historical Conflict Documents

2022-07-18 Thread GitBox
JNSimba opened a new pull request, #10997: URL: https://github.com/apache/doris/pull/10997 # Proposed changes Issue Number: NA ## Problem Summary: Due to the refactoring of the Doris document, there are conflicts in some historical document PRs. These documents are in ur

[GitHub] [doris] compiletheworld commented on pull request #10995: [fix](cache) fix that ShardedLRUCache may coredump when destructor was called

2022-07-18 Thread GitBox
compiletheworld commented on PR #10995: URL: https://github.com/apache/doris/pull/10995#issuecomment-1188545280 Nice catch! LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[doris] branch master updated: [Enhancement] [Memory] Limit memory usage use process actual physical memory (#10924)

2022-07-18 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new d5fa66d9a3 [Enhancement] [Memory] Limit memory

[GitHub] [doris] yiguolei closed issue #10923: [Enhancement] [Memory] Limit memory usage use process actual physical memory

2022-07-18 Thread GitBox
yiguolei closed issue #10923: [Enhancement] [Memory] Limit memory usage use process actual physical memory URL: https://github.com/apache/doris/issues/10923 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [doris] yiguolei merged pull request #10924: [Enhancement] [Memory] Limit memory usage use process actual physical memory

2022-07-18 Thread GitBox
yiguolei merged PR #10924: URL: https://github.com/apache/doris/pull/10924 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

[GitHub] [doris] ByteYue opened a new pull request, #10996: Fe build idea doc

2022-07-18 Thread GitBox
ByteYue opened a new pull request, #10996: URL: https://github.com/apache/doris/pull/10996 # Proposed changes Issue Number: close #10990 ## Problem Summary: Add solution for fe compile error on m1 mac to developer doc. ## Checklist(Required) 1. Does it affec

[GitHub] [doris] smallhibiscus closed pull request #10992: [regression] Revert Add ssb sf1 test under unique table with zstd

2022-07-18 Thread GitBox
smallhibiscus closed pull request #10992: [regression] Revert Add ssb sf1 test under unique table with zstd URL: https://github.com/apache/doris/pull/10992 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [doris] morrySnow commented on a diff in pull request #10947: [enhancement](nereids) support case when for TPC-H

2022-07-18 Thread GitBox
morrySnow commented on code in PR #10947: URL: https://github.com/apache/doris/pull/10947#discussion_r923277657 ## fe/fe-core/src/main/java/org/apache/doris/nereids/glue/translator/ExpressionTranslator.java: ## @@ -213,6 +218,23 @@ public Expr visitStringRegexPredicate(StringReg

[GitHub] [doris] liaoxin01 opened a new pull request, #10995: [fix](cache) fix that ShardedLRUCache may coredump when destructor was called

2022-07-18 Thread GitBox
liaoxin01 opened a new pull request, #10995: URL: https://github.com/apache/doris/pull/10995 # Proposed changes Issue Number: close #10991 ## Problem Summary: delete _shards has a competition with MetricRegistry::trigger_all_hooks. Describe the overview of changes

[GitHub] [doris] platoneko opened a new pull request, #10994: [Bug] fix DCHECK failure in remove_all_remote_rowsets

2022-07-18 Thread GitBox
platoneko opened a new pull request, #10994: URL: https://github.com/apache/doris/pull/10994 # Proposed changes Issue Number: close #10993 ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original behavior:

[GitHub] [doris] platoneko opened a new issue, #10993: [Bug] DCHECK failed in remove_all_remote_rowsets when drop tablet status not ok

2022-07-18 Thread GitBox
platoneko opened a new issue, #10993: URL: https://github.com/apache/doris/issues/10993 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Version master

[GitHub] [doris] smallhibiscus opened a new pull request, #10992: [regression] Revert Add ssb sf1 test under unique table with zstd

2022-07-18 Thread GitBox
smallhibiscus opened a new pull request, #10992: URL: https://github.com/apache/doris/pull/10992 Reverts apache/doris#10957 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[doris] 01/01: Revert "[regression] Add ssb sf1 test under unique table with zstd (#10957)"

2022-07-18 Thread diwu
This is an automated email from the ASF dual-hosted git repository. diwu pushed a commit to branch revert-10957-ssb_zstd_unique_table in repository https://gitbox.apache.org/repos/asf/doris.git commit bd6227ad3978d00adedf76b7e0e2ed1a80e0efb5 Author: wudi <676366...@qq.com> AuthorDate: Tue Jul 19

[doris] branch revert-10957-ssb_zstd_unique_table created (now bd6227ad39)

2022-07-18 Thread diwu
This is an automated email from the ASF dual-hosted git repository. diwu pushed a change to branch revert-10957-ssb_zstd_unique_table in repository https://gitbox.apache.org/repos/asf/doris.git at bd6227ad39 Revert "[regression] Add ssb sf1 test under unique table with zstd (#10957)" Thi

[GitHub] [doris] liaoxin01 opened a new issue, #10991: [Bug] ShardedLRUCache may coredump when destructor was called

2022-07-18 Thread GitBox
liaoxin01 opened a new issue, #10991: URL: https://github.com/apache/doris/issues/10991 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Version master

[GitHub] [doris] ByteYue opened a new issue, #10990: [Bug] FE compile failed on m1 mac

2022-07-18 Thread GitBox
ByteYue opened a new issue, #10990: URL: https://github.com/apache/doris/issues/10990 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Version `doris master1

[doris-website] branch asf-site updated: Update remove-non-reserved-dir.sh

2022-07-18 Thread jiafengzheng
This is an automated email from the ASF dual-hosted git repository. jiafengzheng pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/doris-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 4f009ab56f Update remove-non-re

[doris] branch master updated: [docs] Changing the symbol of dataX doriswriter table creation statement (#10632)

2022-07-18 Thread diwu
This is an automated email from the ASF dual-hosted git repository. diwu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new b70274e2af [docs] Changing the symbol of dataX dori

[GitHub] [doris] JNSimba merged pull request #10632: [docs] Changing the symbol of dataX doriswriter table creation statement

2022-07-18 Thread GitBox
JNSimba merged PR #10632: URL: https://github.com/apache/doris/pull/10632 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apac

[GitHub] [doris] github-actions[bot] commented on pull request #10171: Optimize flink oracle cdc, add flink read es to doris sample code

2022-07-18 Thread GitBox
github-actions[bot] commented on PR #10171: URL: https://github.com/apache/doris/pull/10171#issuecomment-1188518545 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on pull request #10171: Optimize flink oracle cdc, add flink read es to doris sample code

2022-07-18 Thread GitBox
github-actions[bot] commented on PR #10171: URL: https://github.com/apache/doris/pull/10171#issuecomment-1188518520 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] yixiutt commented on pull request #10985: [regression] Update ssb sf1 unique table load dir.

2022-07-18 Thread GitBox
yixiutt commented on PR #10985: URL: https://github.com/apache/doris/pull/10985#issuecomment-1188515492 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [doris] JNSimba commented on a diff in pull request #10171: Optimize flink oracle cdc, add flink read es to doris sample code

2022-07-18 Thread GitBox
JNSimba commented on code in PR #10171: URL: https://github.com/apache/doris/pull/10171#discussion_r923995188 ## samples/doris-demo/flink-demo/src/main/java/org/apache/doris/demo/flink/elasticsearch/ElasticsearchInput.java: ## @@ -0,0 +1,248 @@ +// Licensed to the Apache Softwar

[GitHub] [doris] yixiutt opened a new issue, #10989: [Bug] tpcds_sf1_unqiue_sql result error

2022-07-18 Thread GitBox
yixiutt opened a new issue, #10989: URL: https://github.com/apache/doris/issues/10989 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Version master

[GitHub] [doris] yixiutt opened a new issue, #10986: [Bug] remove_all_remote_rowset core

2022-07-18 Thread GitBox
yixiutt opened a new issue, #10986: URL: https://github.com/apache/doris/issues/10986 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Version master

[GitHub] [doris] compiletheworld commented on a diff in pull request #10921: [feature-wip](unique-key-merge-on-write) Add agg cache for delete bitmap DSIP-018

2022-07-18 Thread GitBox
compiletheworld commented on code in PR #10921: URL: https://github.com/apache/doris/pull/10921#discussion_r923984732 ## be/src/olap/tablet_meta.h: ## @@ -353,6 +353,69 @@ class DeleteBitmap { * @param other */ void merge(const DeleteBitmap& other); + +/** +

[GitHub] [doris] smallhibiscus opened a new pull request, #10985: [regression] Update ssb sf1 unique table load dir.

2022-07-18 Thread GitBox
smallhibiscus opened a new pull request, #10985: URL: https://github.com/apache/doris/pull/10985 # Proposed changes Issue Number: close #xxx ## Problem Summary: Update ssb sf1 unique table load dir. ## Checklist(Required) 1. Does it affect the original behav

[GitHub] [doris] github-actions[bot] commented on pull request #10921: [feature-wip](unique-key-merge-on-write) Add agg cache for delete bitmap DSIP-018

2022-07-18 Thread GitBox
github-actions[bot] commented on PR #10921: URL: https://github.com/apache/doris/pull/10921#issuecomment-1188495465 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] dataroaring commented on a diff in pull request #10921: [feature-wip](unique-key-merge-on-write) Add agg cache for delete bitmap DSIP-018

2022-07-18 Thread GitBox
dataroaring commented on code in PR #10921: URL: https://github.com/apache/doris/pull/10921#discussion_r923421933 ## be/src/olap/tablet_meta.h: ## @@ -353,6 +353,69 @@ class DeleteBitmap { * @param other */ void merge(const DeleteBitmap& other); + +/** +

[GitHub] [doris] yiguolei closed pull request #10934: [refactor] remove pending ids in DataDir

2022-07-18 Thread GitBox
yiguolei closed pull request #10934: [refactor] remove pending ids in DataDir URL: https://github.com/apache/doris/pull/10934 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [doris] yiguolei commented on pull request #10934: [refactor] remove pending ids in DataDir

2022-07-18 Thread GitBox
yiguolei commented on PR #10934: URL: https://github.com/apache/doris/pull/10934#issuecomment-1188479845 I will close this PR because pending id is still usefull in some cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] xiaokang commented on a diff in pull request #10322: [feature](JSON datatype)Support JSON datatype

2022-07-18 Thread GitBox
xiaokang commented on code in PR #10322: URL: https://github.com/apache/doris/pull/10322#discussion_r923967565 ## fe/fe-core/src/main/java/org/apache/doris/analysis/JsonLiteral.java: ## @@ -0,0 +1,197 @@ +// or more contributor license agreements. See the NOTICE file +// distri

[GitHub] [doris] xiaokang commented on a diff in pull request #10322: [feature](JSON datatype)Support JSON datatype

2022-07-18 Thread GitBox
xiaokang commented on code in PR #10322: URL: https://github.com/apache/doris/pull/10322#discussion_r923966756 ## fe/fe-core/src/main/java/org/apache/doris/analysis/JsonLiteral.java: ## @@ -0,0 +1,197 @@ +// or more contributor license agreements. See the NOTICE file +// distri

[doris] branch master updated (d2bee60251 -> f6cb7a838b)

2022-07-18 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from d2bee60251 [regressiontest] add tpcds_sf1 test (#10852) add f6cb7a838b [Optimize] Improve performance like/not l

[GitHub] [doris] yiguolei merged pull request #10355: [Optimize] Improve performance like/not like filter through pushdown function to storage engine

2022-07-18 Thread GitBox
yiguolei merged PR #10355: URL: https://github.com/apache/doris/pull/10355 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

[GitHub] [doris] xiaokang commented on a diff in pull request #10322: [feature](JSON datatype)Support JSON datatype

2022-07-18 Thread GitBox
xiaokang commented on code in PR #10322: URL: https://github.com/apache/doris/pull/10322#discussion_r923961127 ## be/src/runtime/json_value.h: ## @@ -0,0 +1,135 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the

[GitHub] [doris] xiaokang commented on a diff in pull request #10322: [feature](JSON datatype)Support JSON datatype

2022-07-18 Thread GitBox
xiaokang commented on code in PR #10322: URL: https://github.com/apache/doris/pull/10322#discussion_r923961127 ## be/src/runtime/json_value.h: ## @@ -0,0 +1,135 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the

[GitHub] [doris] yiguolei merged pull request #10852: [regression] add tpcds_sf1 test

2022-07-18 Thread GitBox
yiguolei merged PR #10852: URL: https://github.com/apache/doris/pull/10852 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

[GitHub] [doris] xiaokang commented on a diff in pull request #10322: [feature](JSON datatype)Support JSON datatype

2022-07-18 Thread GitBox
xiaokang commented on code in PR #10322: URL: https://github.com/apache/doris/pull/10322#discussion_r923960702 ## be/src/runtime/json_value.cpp: ## @@ -0,0 +1,54 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See th

[GitHub] [doris] yiguolei merged pull request #10910: print a log when got a lower image version

2022-07-18 Thread GitBox
yiguolei merged PR #10910: URL: https://github.com/apache/doris/pull/10910 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

[doris] branch master updated: [improvement-log]print a log when got a lower image version (#10910)

2022-07-18 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 2acd5efcd8 [improvement-log]print a log when go

[GitHub] [doris] xiaokang commented on a diff in pull request #10322: [feature](JSON datatype)Support JSON datatype

2022-07-18 Thread GitBox
xiaokang commented on code in PR #10322: URL: https://github.com/apache/doris/pull/10322#discussion_r923960417 ## be/src/runtime/json_value.cpp: ## @@ -0,0 +1,54 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See th

[GitHub] [doris] yiguolei merged pull request #10982: [refactor] Refactor time LUT

2022-07-18 Thread GitBox
yiguolei merged PR #10982: URL: https://github.com/apache/doris/pull/10982 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

[GitHub] [doris] xiaokang commented on a diff in pull request #10322: [feature](JSON datatype)Support JSON datatype

2022-07-18 Thread GitBox
xiaokang commented on code in PR #10322: URL: https://github.com/apache/doris/pull/10322#discussion_r923956619 ## fe/fe-core/src/main/java/org/apache/doris/catalog/ColumnType.java: ## @@ -94,6 +94,9 @@ public abstract class ColumnType { schemaChangeMatrix[PrimitiveType

[GitHub] [doris] morningman opened a new pull request, #10984: [fix](vectorized) Support outer join for vectorized exec engine

2022-07-18 Thread GitBox
morningman opened a new pull request, #10984: URL: https://github.com/apache/doris/pull/10984 # Proposed changes Issue Number: close #xxx Co-authored-by: EmmyMiao87 Co-authored-by: HappenLee Co-authored-by: morrySnow ## Problem Summary: This PR mainly contai

[GitHub] [doris] morningman merged pull request #9895: [Enhancement](DOE) Step1: Fe generates the DSL and is used to explain

2022-07-18 Thread GitBox
morningman merged PR #9895: URL: https://github.com/apache/doris/pull/9895 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

[doris] branch master updated: [improvement](doe) Step1: Fe generates the DSL and is used to explain (#9895)

2022-07-18 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 68b9a2936a [improvement](doe) Step1: Fe gener

[GitHub] [doris] weizuo93 commented on a diff in pull request #10298: [Load][Enhancement] Support single replica load

2022-07-18 Thread GitBox
weizuo93 commented on code in PR #10298: URL: https://github.com/apache/doris/pull/10298#discussion_r923435779 ## be/src/common/config.h: ## @@ -35,6 +35,11 @@ CONF_Int32(brpc_port, "8060"); // the number of bthreads for brpc, the default value is set to -1, which means the nu

[GitHub] [doris] weizuo93 commented on a diff in pull request #10298: [Load][Enhancement] Support single replica load

2022-07-18 Thread GitBox
weizuo93 commented on code in PR #10298: URL: https://github.com/apache/doris/pull/10298#discussion_r923433526 ## be/src/runtime/tablets_channel.cpp: ## @@ -124,20 +133,46 @@ Status TabletsChannel::close(int sender_id, int64_t backend_id, bool* finished, }

[GitHub] [doris] weizuo93 commented on a diff in pull request #10298: [Load][Enhancement] Support single replica load

2022-07-18 Thread GitBox
weizuo93 commented on code in PR #10298: URL: https://github.com/apache/doris/pull/10298#discussion_r923433112 ## be/src/runtime/tablets_channel.cpp: ## @@ -102,7 +111,7 @@ Status TabletsChannel::close(int sender_id, int64_t backend_id, bool* finished, _state = kFinish

[GitHub] [doris] weizuo93 commented on a diff in pull request #10298: [Load][Enhancement] Support single replica load

2022-07-18 Thread GitBox
weizuo93 commented on code in PR #10298: URL: https://github.com/apache/doris/pull/10298#discussion_r923426751 ## be/src/service/internal_service.h: ## @@ -175,9 +183,13 @@ class PInternalServiceImpl : public PBackendService { PTabletWriterAddB

[GitHub] [doris] weizuo93 commented on a diff in pull request #10298: [Load][Enhancement] Support single replica load

2022-07-18 Thread GitBox
weizuo93 commented on code in PR #10298: URL: https://github.com/apache/doris/pull/10298#discussion_r923426238 ## be/src/runtime/tablets_channel.cpp: ## @@ -124,20 +133,46 @@ Status TabletsChannel::close(int sender_id, int64_t backend_id, bool* finished, }

[GitHub] [doris] weizuo93 commented on a diff in pull request #10298: [Load][Enhancement] Support single replica load

2022-07-18 Thread GitBox
weizuo93 commented on code in PR #10298: URL: https://github.com/apache/doris/pull/10298#discussion_r923425768 ## be/src/olap/delta_writer.h: ## @@ -67,7 +67,13 @@ class DeltaWriter { Status close(); // wait for all memtables to be flushed. // mem_consumption() sh

[GitHub] [doris] weizuo93 commented on a diff in pull request #10298: [Load][Enhancement] Support single replica load

2022-07-18 Thread GitBox
weizuo93 commented on code in PR #10298: URL: https://github.com/apache/doris/pull/10298#discussion_r923425106 ## be/src/exec/tablet_sink.h: ## @@ -174,6 +174,10 @@ class NodeChannel { virtual Status init(RuntimeState* state); +void add_slave_tablet_nodes(int64_t ta

[GitHub] [doris] weizuo93 commented on a diff in pull request #10298: [Load][Enhancement] Support single replica load

2022-07-18 Thread GitBox
weizuo93 commented on code in PR #10298: URL: https://github.com/apache/doris/pull/10298#discussion_r923424425 ## fe/fe-core/src/main/java/org/apache/doris/common/Config.java: ## @@ -722,6 +722,24 @@ public class Config extends ConfigBase { @ConfField(mutable = true, master

[GitHub] [doris] weizuo93 commented on a diff in pull request #10298: [Load][Enhancement] Support single replica load

2022-07-18 Thread GitBox
weizuo93 commented on code in PR #10298: URL: https://github.com/apache/doris/pull/10298#discussion_r923424151 ## gensrc/proto/internal_service.proto: ## @@ -469,6 +492,32 @@ message PResetRPCChannelResponse { message PEmptyRequest {}; +message PTabletWriteSlaveRequest { +

[GitHub] [doris] Gabriel39 opened a new issue, #10983: [Enhancement] refactor time LUT

2022-07-18 Thread GitBox
Gabriel39 opened a new issue, #10983: URL: https://github.com/apache/doris/issues/10983 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Description This PR

[GitHub] [doris] Gabriel39 opened a new pull request, #10982: [refactor] Refactor time lut

2022-07-18 Thread GitBox
Gabriel39 opened a new pull request, #10982: URL: https://github.com/apache/doris/pull/10982 # Proposed changes This PR wants to refactor look-up table for datetime. LUT was written in a long array before which has less readability and hard to maintain. Since duration of the whole LU

[GitHub] [doris] qzsee opened a new pull request, #10981: [Enhancement](Nereids) add some basic data structure definitions.

2022-07-18 Thread GitBox
qzsee opened a new pull request, #10981: URL: https://github.com/apache/doris/pull/10981 # Proposed changes Issue Number: close #xxx ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original behavior: (Yes/No

[GitHub] [doris] yiguolei closed issue #10916: [Enhancement] Improve dateliteral precision

2022-07-18 Thread GitBox
yiguolei closed issue #10916: [Enhancement] Improve dateliteral precision URL: https://github.com/apache/doris/issues/10916 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[doris] branch master updated: [Improvement] (datetime) support microsecond for date literal (#10917)

2022-07-18 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new e769597fd2 [Improvement] (datetime) support mic

[GitHub] [doris] yiguolei merged pull request #10917: [Improvement] (datetime) support microsecond for date literal

2022-07-18 Thread GitBox
yiguolei merged PR #10917: URL: https://github.com/apache/doris/pull/10917 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

[GitHub] [doris] cambyzju commented on a diff in pull request #10980: [Bug][Array] cast array element to same type

2022-07-18 Thread GitBox
cambyzju commented on code in PR #10980: URL: https://github.com/apache/doris/pull/10980#discussion_r923375078 ## fe/fe-core/src/main/java/org/apache/doris/analysis/ArrayLiteral.java: ## @@ -39,20 +38,28 @@ public ArrayLiteral() { children = new ArrayList<>(); }

[GitHub] [doris] github-actions[bot] commented on pull request #10921: [feature-wip](unique-key-merge-on-write) Add agg cache for delete bitmap DSIP-018

2022-07-18 Thread GitBox
github-actions[bot] commented on PR #10921: URL: https://github.com/apache/doris/pull/10921#issuecomment-1187350935 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] SaintBacchus commented on a diff in pull request #10977: [feature-wip][multi-catalog] Support s3 storage for file scan node

2022-07-18 Thread GitBox
SaintBacchus commented on code in PR #10977: URL: https://github.com/apache/doris/pull/10977#discussion_r923336943 ## fe/fe-core/src/main/java/org/apache/doris/planner/external/ExternalHiveScanProvider.java: ## @@ -69,7 +69,13 @@ public TFileFormatType getTableFormatType() throw

[GitHub] [doris] morningman merged pull request #10843: [feature] (multi-catalog) read parquet file by start/offset

2022-07-18 Thread GitBox
morningman merged PR #10843: URL: https://github.com/apache/doris/pull/10843 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.a

[doris] branch master updated: [feature](multi-catalog) read parquet file by start/offset (#10843)

2022-07-18 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 8a366c9ba2 [feature](multi-catalog) read parq

[doris] branch master updated: [feature-wip](multi-catalog) Optimize threads and thrift interface of FileScanNode (#10942)

2022-07-18 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 60dd322aba [feature-wip](multi-catalog) Optim

[GitHub] [doris] morningman merged pull request #10942: [feature-wip](multi-catalog) Optimize threads and thrift interface of FileScanNode

2022-07-18 Thread GitBox
morningman merged PR #10942: URL: https://github.com/apache/doris/pull/10942 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.a

[GitHub] [doris] jackwener commented on a diff in pull request #10890: [Feature](Nereids) Reorder join to eliminate cross join.

2022-07-18 Thread GitBox
jackwener commented on code in PR #10890: URL: https://github.com/apache/doris/pull/10890#discussion_r923327650 ## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/logical/ReorderJoin.java: ## @@ -0,0 +1,215 @@ +// Licensed to the Apache Software Foundation (ASF)

[GitHub] [doris] morrySnow commented on a diff in pull request #10891: [refactor] Memo.copyIn() return a pair

2022-07-18 Thread GitBox
morrySnow commented on code in PR #10891: URL: https://github.com/apache/doris/pull/10891#discussion_r923315243 ## fe/fe-core/src/main/java/org/apache/doris/nereids/memo/Memo.java: ## @@ -69,10 +70,10 @@ public Map getGroupExpressions() { * @param rewrite whether to rewri

[GitHub] [doris] github-actions[bot] commented on pull request #9745: [enhancement] (planner) change Doris's query organization syntax to standard sql

2022-07-18 Thread GitBox
github-actions[bot] commented on PR #9745: URL: https://github.com/apache/doris/pull/9745#issuecomment-1187296689 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[doris] branch master updated: [feature](Nereids): hashCode(), equals() and UT. (#10870)

2022-07-18 Thread lingmiao
This is an automated email from the ASF dual-hosted git repository. lingmiao pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new a849f5be71 [feature](Nereids): hashCode(), equa

[GitHub] [doris] EmmyMiao87 merged pull request #10870: [feature](Nereids): hashCode(), equals() to Plan

2022-07-18 Thread GitBox
EmmyMiao87 merged PR #10870: URL: https://github.com/apache/doris/pull/10870 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.a

[GitHub] [doris] github-actions[bot] commented on pull request #10870: [feature](Nereids): hashCode(), equals() and UT.

2022-07-18 Thread GitBox
github-actions[bot] commented on PR #10870: URL: https://github.com/apache/doris/pull/10870#issuecomment-1187292969 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] morrySnow commented on a diff in pull request #10667: [Enhancement](Nereids) add some expr rewrite rule and plan rewrite rule of rewrite its expression

2022-07-18 Thread GitBox
morrySnow commented on code in PR #10667: URL: https://github.com/apache/doris/pull/10667#discussion_r923302421 ## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/rewrite/ExpressionOfPlanRewrite.java: ## @@ -0,0 +1,136 @@ +// Licensed to the Apache Software Fo

[GitHub] [doris] BiteTheDDDDt opened a new pull request, #10980: [Bug][Array] cast array element to same type

2022-07-18 Thread GitBox
BiteThet opened a new pull request, #10980: URL: https://github.com/apache/doris/pull/10980 # Proposed changes Issue Number: close #10978 ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original behavior

[GitHub] [doris] 924060929 commented on a diff in pull request #10890: [Feature](Nereids) Reorder join to eliminate cross join.

2022-07-18 Thread GitBox
924060929 commented on code in PR #10890: URL: https://github.com/apache/doris/pull/10890#discussion_r923285646 ## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/logical/ReorderJoin.java: ## @@ -0,0 +1,215 @@ +// Licensed to the Apache Software Foundation (ASF)

  1   2   >