[GitHub] [doris] wuyunfeng commented on a diff in pull request #10391: [Bug][DOE]: fix doe on es8

2022-06-24 Thread GitBox
wuyunfeng commented on code in PR #10391: URL: https://github.com/apache/doris/pull/10391#discussion_r906644372 ## be/src/exec/es/es_scan_reader.cpp: ## @@ -47,7 +47,11 @@ ESScanReader::ESScanReader(const std::string& target, _doc_value_mode(doc_value_mode) { _ta

[GitHub] [doris] wuyunfeng commented on pull request #10391: [Bug][DOE]: fix doe on es8

2022-06-24 Thread GitBox
wuyunfeng commented on PR #10391: URL: https://github.com/apache/doris/pull/10391#issuecomment-1166204420 @stalary Thanks for your contribution. I suggest remove the `include_type_name` branch, and do not pass `type` in ESScanNode, BE check whether the `type` parameter is empty and choos

[GitHub] [doris] wuyunfeng commented on a diff in pull request #10391: [Bug][DOE]: fix doe on es8

2022-06-24 Thread GitBox
wuyunfeng commented on code in PR #10391: URL: https://github.com/apache/doris/pull/10391#discussion_r906641833 ## fe/fe-core/src/main/java/org/apache/doris/external/elasticsearch/MappingPhase.java: ## @@ -45,7 +45,7 @@ public MappingPhase(EsRestClient client) { @Override

[GitHub] [doris] wuyunfeng commented on a diff in pull request #10391: [Bug][DOE]: fix doe on es8

2022-06-24 Thread GitBox
wuyunfeng commented on code in PR #10391: URL: https://github.com/apache/doris/pull/10391#discussion_r906641833 ## fe/fe-core/src/main/java/org/apache/doris/external/elasticsearch/MappingPhase.java: ## @@ -45,7 +45,7 @@ public MappingPhase(EsRestClient client) { @Override

[doris] branch master updated: [fix] (mem tracker) Fix inaccurate mem tracker leads to load OOM (#10409)

2022-06-24 Thread dataroaring
This is an automated email from the ASF dual-hosted git repository. dataroaring pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new eb25df5a2c [fix] (mem tracker) Fix inaccurat

[GitHub] [doris] dataroaring closed issue #10407: [Bug] Inaccurate mem tracker leads to load OOM

2022-06-24 Thread GitBox
dataroaring closed issue #10407: [Bug] Inaccurate mem tracker leads to load OOM URL: https://github.com/apache/doris/issues/10407 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [doris] dataroaring merged pull request #10409: [fix] (mem tracker) Fix inaccurate mem tracker leads to load OOM

2022-06-24 Thread GitBox
dataroaring merged PR #10409: URL: https://github.com/apache/doris/pull/10409 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.

[GitHub] [doris] github-actions[bot] commented on pull request #10409: [fix] (mem tracker) Fix inaccurate mem tracker leads to load OOM

2022-06-24 Thread GitBox
github-actions[bot] commented on PR #10409: URL: https://github.com/apache/doris/pull/10409#issuecomment-1166201854 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on pull request #10409: [fix] (mem tracker) Fix inaccurate mem tracker leads to load OOM

2022-06-24 Thread GitBox
github-actions[bot] commented on PR #10409: URL: https://github.com/apache/doris/pull/10409#issuecomment-1166201849 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] Hisoka-X commented on issue #10418: [Bug][Build] Can't build thirdparty dependency on Mac m1

2022-06-24 Thread GitBox
Hisoka-X commented on issue #10418: URL: https://github.com/apache/doris/issues/10418#issuecomment-1166200060 Is it that I must build on linux? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [doris] Hisoka-X opened a new issue, #10418: [Bug][Build] Can't build thirdparty dependency on Mac m1

2022-06-24 Thread GitBox
Hisoka-X opened a new issue, #10418: URL: https://github.com/apache/doris/issues/10418 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Version master

[GitHub] [doris] github-actions[bot] commented on pull request #10417: [Bug][Vectorized] Fix cord dump of BloomFilter not support DATE type

2022-06-24 Thread GitBox
github-actions[bot] commented on PR #10417: URL: https://github.com/apache/doris/pull/10417#issuecomment-1166199570 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on pull request #10417: [Bug][Vectorized] Fix cord dump of BloomFilter not support DATE type

2022-06-24 Thread GitBox
github-actions[bot] commented on PR #10417: URL: https://github.com/apache/doris/pull/10417#issuecomment-1166199563 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] HappenLee opened a new pull request, #10417: [Bug][Vectorized] Fix cord dump of BloomFilter not support DATE type

2022-06-24 Thread GitBox
HappenLee opened a new pull request, #10417: URL: https://github.com/apache/doris/pull/10417 # Proposed changes Issue Number: close #8796 #8967 ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original behavi

[doris] branch master updated: [feature-wip](multi-catalog) Add catalog name to information schema. (#10349)

2022-06-24 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 8abd00dcd5 [feature-wip](multi-catalog) Add c

[GitHub] [doris] morningman merged pull request #10349: [multi-catalog] (information schema step 1) Add catalog name to information_schema getDbNames and SchemaSchemataScanner

2022-06-24 Thread GitBox
morningman merged PR #10349: URL: https://github.com/apache/doris/pull/10349 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.a

[GitHub] [doris] github-actions[bot] commented on pull request #10416: [website]Website external resource

2022-06-24 Thread GitBox
github-actions[bot] commented on PR #10416: URL: https://github.com/apache/doris/pull/10416#issuecomment-1166184386 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on pull request #10416: [website]Website external resource

2022-06-24 Thread GitBox
github-actions[bot] commented on PR #10416: URL: https://github.com/apache/doris/pull/10416#issuecomment-1166184383 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] hf200012 opened a new pull request, #10416: [website]Website external resource

2022-06-24 Thread GitBox
hf200012 opened a new pull request, #10416: URL: https://github.com/apache/doris/pull/10416 # Proposed changes Issue Number: close #xxx ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original behavior: (Yes

[GitHub] [doris] hf200012 closed pull request #10384: [website]Website external resource

2022-06-24 Thread GitBox
hf200012 closed pull request #10384: [website]Website external resource URL: https://github.com/apache/doris/pull/10384 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [doris] 924060929 opened a new pull request, #10415: [feature](nereids) Support analyze for test SSB

2022-06-24 Thread GitBox
924060929 opened a new pull request, #10415: URL: https://github.com/apache/doris/pull/10415 # Proposed changes Issue Number: no issue ## Problem Summary: support analyze for test SSB. add describe later. ## Checklist(Required) 1. Does it affect the o

[doris] branch master updated: [feature](nereids)Convert the expression from nereids to stale expr. (#10343)

2022-06-24 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 3757bd521a [feature](nereids)Convert the expr

[GitHub] [doris] morningman merged pull request #10343: [feature](nereids)Convert the expression from nereids to stale expr.

2022-06-24 Thread GitBox
morningman merged PR #10343: URL: https://github.com/apache/doris/pull/10343 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.a

[GitHub] [doris] github-actions[bot] commented on pull request #10324: [Enhancement] (Doc) mod alter-table-replace

2022-06-24 Thread GitBox
github-actions[bot] commented on PR #10324: URL: https://github.com/apache/doris/pull/10324#issuecomment-1166174879 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on pull request #10324: [Enhancement] (Doc) mod alter-table-replace

2022-06-24 Thread GitBox
github-actions[bot] commented on PR #10324: URL: https://github.com/apache/doris/pull/10324#issuecomment-1166174873 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #10343: [feature](nereids)Convert the expression from nereids to stale expr.

2022-06-24 Thread GitBox
github-actions[bot] commented on PR #10343: URL: https://github.com/apache/doris/pull/10343#issuecomment-1166168780 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[doris] branch master updated: [fix]Make sure only call once set_dict_encoding_type for each ColumnReader (#10389)

2022-06-24 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 7921320124 [fix]Make sure only call once set_di

[GitHub] [doris] yiguolei merged pull request #10389: [fix]Make sure only call once set_dict_encoding_type for each ColumnReader

2022-06-24 Thread GitBox
yiguolei merged PR #10389: URL: https://github.com/apache/doris/pull/10389 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

[GitHub] [doris] yiguolei merged pull request #10386: [improvement]Use std::iota to set values of _block_rowids in SegmentIterator::_read_columns_by_index

2022-06-24 Thread GitBox
yiguolei merged PR #10386: URL: https://github.com/apache/doris/pull/10386 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

[doris] branch master updated: [improvement]Use std::iota to set values of _block_rowids in SegmentIterator::_read_columns_by_index (#10386)

2022-06-24 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new df908873bb [improvement]Use std::iota to set va

[GitHub] [doris] caiconghui opened a new pull request, #10414: [Bug][Random Distribution] Make aggregate keys table with replace type columns and unique keys table can only have hash distribution to m

2022-06-24 Thread GitBox
caiconghui opened a new pull request, #10414: URL: https://github.com/apache/doris/pull/10414 # Proposed changes Issue Number: close #10413 ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original behavior:

[GitHub] [doris] caiconghui opened a new issue, #10413: [Bug] Make aggregate keys table with replace type columns and unique keys table can only have hash distribution to make data computing correctly

2022-06-24 Thread GitBox
caiconghui opened a new issue, #10413: URL: https://github.com/apache/doris/issues/10413 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Version master

[GitHub] [doris] cambyzju commented on a diff in pull request #10388: [feature-wip] (array-type) add the array_distinct function

2022-06-24 Thread GitBox
cambyzju commented on code in PR #10388: URL: https://github.com/apache/doris/pull/10388#discussion_r906183972 ## gensrc/script/doris_builtins_functions.py: ## @@ -160,6 +160,18 @@ [['array_position'], 'BIGINT', ['ARRAY_STRING', 'STRING'], '', '', '', 'vec', ''], [[

[GitHub] [doris] cambyzju commented on a diff in pull request #10388: [feature-wip] (array-type) add the array_distinct function

2022-06-24 Thread GitBox
cambyzju commented on code in PR #10388: URL: https://github.com/apache/doris/pull/10388#discussion_r906179215 ## gensrc/script/doris_builtins_functions.py: ## @@ -160,6 +160,18 @@ [['array_position'], 'BIGINT', ['ARRAY_STRING', 'STRING'], '', '', '', 'vec', ''], [[

[GitHub] [doris] cambyzju commented on a diff in pull request #10388: [feature-wip] (array-type) add the array_distinct function

2022-06-24 Thread GitBox
cambyzju commented on code in PR #10388: URL: https://github.com/apache/doris/pull/10388#discussion_r906179215 ## gensrc/script/doris_builtins_functions.py: ## @@ -160,6 +160,18 @@ [['array_position'], 'BIGINT', ['ARRAY_STRING', 'STRING'], '', '', '', 'vec', ''], [[

[GitHub] [doris] stalary commented on pull request #10327: [Enhancement] modify comment " to ' compat mysql.

2022-06-24 Thread GitBox
stalary commented on PR #10327: URL: https://github.com/apache/doris/pull/10327#issuecomment-1165659768 superset and dathub use sqlalchemy by `show create table` sql get metadata,Standard mysql syntax, comment uses single quotes. -- This is an automated message from the Apache Git Service

[GitHub] [doris] github-actions[bot] commented on pull request #10406: [Bug][Doc] Fix Slack invitation link on README.md not working

2022-06-24 Thread GitBox
github-actions[bot] commented on PR #10406: URL: https://github.com/apache/doris/pull/10406#issuecomment-1165644578 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on pull request #10406: [Bug][Doc] Fix Slack invitation link on README.md not working

2022-06-24 Thread GitBox
github-actions[bot] commented on PR #10406: URL: https://github.com/apache/doris/pull/10406#issuecomment-1165644536 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #10391: [Bug][DOE]: fix doe on es8

2022-06-24 Thread GitBox
github-actions[bot] commented on PR #10391: URL: https://github.com/apache/doris/pull/10391#issuecomment-1165643144 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on pull request #10391: [Bug][DOE]: fix doe on es8

2022-06-24 Thread GitBox
github-actions[bot] commented on PR #10391: URL: https://github.com/apache/doris/pull/10391#issuecomment-1165643094 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] Kikyou1997 opened a new pull request, #10412: [Feature] [Draft] Agg rewrite rule of nereids optmizer

2022-06-24 Thread GitBox
Kikyou1997 opened a new pull request, #10412: URL: https://github.com/apache/doris/pull/10412 # Proposed changes Issue Number: close #xxx ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original behavior: (Y

[GitHub] [doris] adonis0147 commented on a diff in pull request #10386: [improvement]Use std::iota to set values of _block_rowids in SegmentIterator::_read_columns_by_index

2022-06-24 Thread GitBox
adonis0147 commented on code in PR #10386: URL: https://github.com/apache/doris/pull/10386#discussion_r905875127 ## be/src/olap/rowset/segment_v2/segment_iterator.cpp: ## @@ -872,9 +872,11 @@ Status SegmentIterator::_read_columns_by_index(uint32_t nrows_read_limit, uint32

[GitHub] [doris] adonis0147 commented on a diff in pull request #10386: [improvement]Use std::iota to set values of _block_rowids in SegmentIterator::_read_columns_by_index

2022-06-24 Thread GitBox
adonis0147 commented on code in PR #10386: URL: https://github.com/apache/doris/pull/10386#discussion_r906073521 ## be/src/olap/rowset/segment_v2/segment_iterator.cpp: ## @@ -872,9 +872,11 @@ Status SegmentIterator::_read_columns_by_index(uint32_t nrows_read_limit, uint32

[GitHub] [doris] adonis0147 commented on a diff in pull request #10386: [improvement]Use std::iota to set values of _block_rowids in SegmentIterator::_read_columns_by_index

2022-06-24 Thread GitBox
adonis0147 commented on code in PR #10386: URL: https://github.com/apache/doris/pull/10386#discussion_r90604 ## be/src/olap/rowset/segment_v2/segment_iterator.cpp: ## @@ -872,9 +872,11 @@ Status SegmentIterator::_read_columns_by_index(uint32_t nrows_read_limit, uint32

[GitHub] [doris] adonis0147 commented on a diff in pull request #10386: [improvement]Use std::iota to set values of _block_rowids in SegmentIterator::_read_columns_by_index

2022-06-24 Thread GitBox
adonis0147 commented on code in PR #10386: URL: https://github.com/apache/doris/pull/10386#discussion_r90604 ## be/src/olap/rowset/segment_v2/segment_iterator.cpp: ## @@ -872,9 +872,11 @@ Status SegmentIterator::_read_columns_by_index(uint32_t nrows_read_limit, uint32

[GitHub] [doris] adonis0147 commented on a diff in pull request #10386: [improvement]Use std::iota to set values of _block_rowids in SegmentIterator::_read_columns_by_index

2022-06-24 Thread GitBox
adonis0147 commented on code in PR #10386: URL: https://github.com/apache/doris/pull/10386#discussion_r90604 ## be/src/olap/rowset/segment_v2/segment_iterator.cpp: ## @@ -872,9 +872,11 @@ Status SegmentIterator::_read_columns_by_index(uint32_t nrows_read_limit, uint32

[GitHub] [doris] adonis0147 commented on a diff in pull request #10386: [improvement]Use std::iota to set values of _block_rowids in SegmentIterator::_read_columns_by_index

2022-06-24 Thread GitBox
adonis0147 commented on code in PR #10386: URL: https://github.com/apache/doris/pull/10386#discussion_r906045375 ## be/src/olap/rowset/segment_v2/segment_iterator.cpp: ## @@ -872,9 +872,11 @@ Status SegmentIterator::_read_columns_by_index(uint32_t nrows_read_limit, uint32

[GitHub] [doris] adonis0147 commented on a diff in pull request #10386: [improvement]Use std::iota to set values of _block_rowids in SegmentIterator::_read_columns_by_index

2022-06-24 Thread GitBox
adonis0147 commented on code in PR #10386: URL: https://github.com/apache/doris/pull/10386#discussion_r906045375 ## be/src/olap/rowset/segment_v2/segment_iterator.cpp: ## @@ -872,9 +872,11 @@ Status SegmentIterator::_read_columns_by_index(uint32_t nrows_read_limit, uint32

[GitHub] [doris] morrySnow commented on a diff in pull request #10335: [enhancement](Nereids): add more implmentation rules.

2022-06-24 Thread GitBox
morrySnow commented on code in PR #10335: URL: https://github.com/apache/doris/pull/10335#discussion_r906029487 ## fe/fe-core/src/main/java/org/apache/doris/nereids/operators/plans/logical/LogicalHeapSort.java: ## @@ -31,84 +32,51 @@ /** * Logical Sort plan operator. - * +

[GitHub] [doris] adonis0147 commented on a diff in pull request #10386: [improvement]Use std::iota to set values of _block_rowids in SegmentIterator::_read_columns_by_index

2022-06-24 Thread GitBox
adonis0147 commented on code in PR #10386: URL: https://github.com/apache/doris/pull/10386#discussion_r90604 ## be/src/olap/rowset/segment_v2/segment_iterator.cpp: ## @@ -872,9 +872,11 @@ Status SegmentIterator::_read_columns_by_index(uint32_t nrows_read_limit, uint32

[GitHub] [doris] adonis0147 commented on a diff in pull request #10386: [improvement]Use std::iota to set values of _block_rowids in SegmentIterator::_read_columns_by_index

2022-06-24 Thread GitBox
adonis0147 commented on code in PR #10386: URL: https://github.com/apache/doris/pull/10386#discussion_r90604 ## be/src/olap/rowset/segment_v2/segment_iterator.cpp: ## @@ -872,9 +872,11 @@ Status SegmentIterator::_read_columns_by_index(uint32_t nrows_read_limit, uint32

[GitHub] [doris] yinzhijian opened a new pull request, #10411: [feature](nereids) support like and regexp predicate

2022-06-24 Thread GitBox
yinzhijian opened a new pull request, #10411: URL: https://github.com/apache/doris/pull/10411 # Proposed changes Issue Number: close #xxx ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original behavior: (N

[GitHub] [doris] SWJTU-ZhangLei opened a new issue, #10410: [Bug] [Fe] BDBJE conflict socket when adding a new fe

2022-06-24 Thread GitBox
SWJTU-ZhangLei opened a new issue, #10410: URL: https://github.com/apache/doris/issues/10410 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Version root@re

[GitHub] [doris] zhengshiJ commented on a diff in pull request #10377: [feature](nereids) Add brackets expr and ssbSql and inPredicate Expr

2022-06-24 Thread GitBox
zhengshiJ commented on code in PR #10377: URL: https://github.com/apache/doris/pull/10377#discussion_r905997875 ## fe/fe-core/src/main/java/org/apache/doris/nereids/parser/LogicalPlanBuilder.java: ## @@ -537,11 +541,17 @@ public Expression visitPredicated(PredicatedContext ctx)

[GitHub] [doris] JNSimba commented on issue #10200: 整理了使用上的不方便之处

2022-06-24 Thread GitBox
JNSimba commented on issue #10200: URL: https://github.com/apache/doris/issues/10200#issuecomment-1165502971 > 2.fenodes和table.identifier 改成 url和database-name Fenodes is different from the url of jdbc, it is the http request address of fe, and supports multiple 3.flinkcdc写入doris 数

[GitHub] [doris] zenoyang commented on pull request #10084: [feature-wip](vectorized) Support block aggregate in scanner

2022-06-24 Thread GitBox
zenoyang commented on PR #10084: URL: https://github.com/apache/doris/pull/10084#issuecomment-1165502288 > Hi, I got a compile fail on clang > > ```c++ > segment_iterator.cpp:893:43: error: result of comparison of constant 18446744073709551615 with expression of type 'unsigned int'

[GitHub] [doris] eldenmoon commented on a diff in pull request #10388: [feature-wip] (array-type) add the array_distinct function

2022-06-24 Thread GitBox
eldenmoon commented on code in PR #10388: URL: https://github.com/apache/doris/pull/10388#discussion_r905977203 ## gensrc/script/doris_builtins_functions.py: ## @@ -160,6 +160,18 @@ [['array_position'], 'BIGINT', ['ARRAY_STRING', 'STRING'], '', '', '', 'vec', ''], [

[GitHub] [doris] eldenmoon commented on a diff in pull request #10388: [feature-wip] (array-type) add the array_distinct function

2022-06-24 Thread GitBox
eldenmoon commented on code in PR #10388: URL: https://github.com/apache/doris/pull/10388#discussion_r905977203 ## gensrc/script/doris_builtins_functions.py: ## @@ -160,6 +160,18 @@ [['array_position'], 'BIGINT', ['ARRAY_STRING', 'STRING'], '', '', '', 'vec', ''], [

[GitHub] [doris] eldenmoon commented on a diff in pull request #10388: [feature-wip] (array-type) add the array_distinct function

2022-06-24 Thread GitBox
eldenmoon commented on code in PR #10388: URL: https://github.com/apache/doris/pull/10388#discussion_r905977203 ## gensrc/script/doris_builtins_functions.py: ## @@ -160,6 +160,18 @@ [['array_position'], 'BIGINT', ['ARRAY_STRING', 'STRING'], '', '', '', 'vec', ''], [

[GitHub] [doris] eldenmoon commented on a diff in pull request #10388: [feature-wip] (array-type) add the array_distinct function

2022-06-24 Thread GitBox
eldenmoon commented on code in PR #10388: URL: https://github.com/apache/doris/pull/10388#discussion_r905977203 ## gensrc/script/doris_builtins_functions.py: ## @@ -160,6 +160,18 @@ [['array_position'], 'BIGINT', ['ARRAY_STRING', 'STRING'], '', '', '', 'vec', ''], [

[GitHub] [doris] carlvinhust2012 commented on pull request #10378: [Enhancement] support different python version in build-support scripts

2022-06-24 Thread GitBox
carlvinhust2012 commented on PR #10378: URL: https://github.com/apache/doris/pull/10378#issuecomment-1165481631 > Hi @carlvinhust2012 , please rebase the fix the BE ut. some commit has been reverted to fix that bug. ok,I will rebase later. -- This is an automated message from the A

[GitHub] [doris] morningman commented on pull request #10378: [Enhancement] support different python version in build-support scripts

2022-06-24 Thread GitBox
morningman commented on PR #10378: URL: https://github.com/apache/doris/pull/10378#issuecomment-1165478542 Hi @carlvinhust2012 , please rebase the fix the BE ut. some commit has been reverted to fix that bug. -- This is an automated message from the Apache Git Service. To respond to the m

[doris] branch master updated: [opt] delete the redundant parameter of _execute_non_nullable (#10173)

2022-06-24 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 89860fd0e3 [opt] delete the redundant paramet

[GitHub] [doris] morningman merged pull request #10173: [opt] delete the redundant parameter of _execute_non_nullable

2022-06-24 Thread GitBox
morningman merged PR #10173: URL: https://github.com/apache/doris/pull/10173 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.a

[GitHub] [doris] github-actions[bot] commented on pull request #10173: [opt] delete the redundant parameter of _execute_non_nullable

2022-06-24 Thread GitBox
github-actions[bot] commented on PR #10173: URL: https://github.com/apache/doris/pull/10173#issuecomment-1165477421 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] k-i-d-d opened a new pull request, #10409: [fix] (mem tracker) Fix inaccurate mem tracker leads to load OOM

2022-06-24 Thread GitBox
k-i-d-d opened a new pull request, #10409: URL: https://github.com/apache/doris/pull/10409 # Proposed changes Issue Number: close #10407 ## Problem Summary: 1. Fix `LoadChannelMgr mem tracker` statistic higher than actual value. 2. When the consumption of the mem t

[GitHub] [doris] github-actions[bot] commented on pull request #10384: [website]Website external resource

2022-06-24 Thread GitBox
github-actions[bot] commented on PR #10384: URL: https://github.com/apache/doris/pull/10384#issuecomment-1165471350 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #10384: [website]Website external resource

2022-06-24 Thread GitBox
github-actions[bot] commented on PR #10384: URL: https://github.com/apache/doris/pull/10384#issuecomment-1165471385 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[doris] branch master updated: [TYPO] fix typo 'destory' -> 'destroy' (#10373)

2022-06-24 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 476be35961 [TYPO] fix typo 'destory' -> 'destro

[GitHub] [doris] yiguolei merged pull request #10373: [TYPO] fix typo 'destory' -> 'destroy'

2022-06-24 Thread GitBox
yiguolei merged PR #10373: URL: https://github.com/apache/doris/pull/10373 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

[GitHub] [doris] github-actions[bot] commented on pull request #9954: [Fix](Join) Solve the problem of incorrectly evaluating column null properties when combining inline view and outer join.

2022-06-24 Thread GitBox
github-actions[bot] commented on PR #9954: URL: https://github.com/apache/doris/pull/9954#issuecomment-1165468587 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #9954: [Fix](Join) Solve the problem of incorrectly evaluating column null properties when combining inline view and outer join.

2022-06-24 Thread GitBox
github-actions[bot] commented on PR #9954: URL: https://github.com/apache/doris/pull/9954#issuecomment-1165468557 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [doris] github-actions[bot] commented on pull request #10386: [improvement]Use std::iota to set values of _block_rowids in SegmentIterator::_read_columns_by_index

2022-06-24 Thread GitBox
github-actions[bot] commented on PR #10386: URL: https://github.com/apache/doris/pull/10386#issuecomment-1165467828 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] hf200012 opened a new pull request, #10408: [TLP][Doc]Modify the incubator link in the ecological extension and community documentation

2022-06-24 Thread GitBox
hf200012 opened a new pull request, #10408: URL: https://github.com/apache/doris/pull/10408 # Proposed changes Issue Number: close #xxx ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original behavior: (Yes

[GitHub] [doris] k-i-d-d opened a new issue, #10407: [Bug] Inaccurate mem tracker leads to load OOM

2022-06-24 Thread GitBox
k-i-d-d opened a new issue, #10407: URL: https://github.com/apache/doris/issues/10407 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Version trunk #

[GitHub] [doris] Hisoka-X opened a new pull request, #10406: [Bug][Doc] Fix Slack invitation link on README.md not working

2022-06-24 Thread GitBox
Hisoka-X opened a new pull request, #10406: URL: https://github.com/apache/doris/pull/10406 # Proposed changes Issue Number: close #10399 ## Problem Summary: Slack invitation link on README.md not working ## Checklist(Required) 1. Does it affect the original b

[doris] branch master updated: [feature](nereids) Integrate nereids into current SQL process framework (#10304)

2022-06-24 Thread lingmiao
This is an automated email from the ASF dual-hosted git repository. lingmiao pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new e82d8433be [feature](nereids) Integrate nereids

[GitHub] [doris] EmmyMiao87 merged pull request #10304: [feature](nereids) Integrate nereids into current SQL process framework

2022-06-24 Thread GitBox
EmmyMiao87 merged PR #10304: URL: https://github.com/apache/doris/pull/10304 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.a

[GitHub] [doris] mrhhsg commented on pull request #10386: [improvement]Use std::iota to set values of _block_rowids in SegmentIterator::_read_columns_by_index

2022-06-24 Thread GitBox
mrhhsg commented on PR #10386: URL: https://github.com/apache/doris/pull/10386#issuecomment-1165430808 > #9111 How about test this pr? Let's see which is faster. @wangbo Great! It is the same with `std::iota` -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [doris] github-actions[bot] commented on pull request #10304: [feature](nereids) Integrate nereids into current SQL process framework

2022-06-24 Thread GitBox
github-actions[bot] commented on PR #10304: URL: https://github.com/apache/doris/pull/10304#issuecomment-1165425006 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] pengxiangyu opened a new pull request, #10405: Add MigrationHandler

2022-06-24 Thread GitBox
pengxiangyu opened a new pull request, #10405: URL: https://github.com/apache/doris/pull/10405 # Proposed changes Issue Number: close #10404 ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original behavior:

[GitHub] [doris] pengxiangyu opened a new issue, #10404: [Feature] Add MigrationHandler

2022-06-24 Thread GitBox
pengxiangyu opened a new issue, #10404: URL: https://github.com/apache/doris/issues/10404 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Description ### Se

[GitHub] [doris] wangbo commented on pull request #10386: [improvement]Use std::iota to set values of _block_rowids in SegmentIterator::_read_columns_by_index

2022-06-24 Thread GitBox
wangbo commented on PR #10386: URL: https://github.com/apache/doris/pull/10386#issuecomment-1165411960 https://github.com/apache/doris/pull/9111 How about test this pr? Let's see which is faster. -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [doris] github-actions[bot] commented on pull request #10320: [feature-wip](multi-catalog) refactor catalog interface

2022-06-24 Thread GitBox
github-actions[bot] commented on PR #10320: URL: https://github.com/apache/doris/pull/10320#issuecomment-1165410896 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on pull request #10320: [feature-wip](multi-catalog) refactor catalog interface

2022-06-24 Thread GitBox
github-actions[bot] commented on PR #10320: URL: https://github.com/apache/doris/pull/10320#issuecomment-1165410874 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] morrySnow commented on a diff in pull request #10377: [feature](nereids) Add brackets expr and ssbSql and inPredicate Expr

2022-06-24 Thread GitBox
morrySnow commented on code in PR #10377: URL: https://github.com/apache/doris/pull/10377#discussion_r905908998 ## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/InPredicate.java: ## @@ -0,0 +1,70 @@ +// Licensed to the Apache Software Foundation (ASF) under

[GitHub] [doris] mrhhsg commented on pull request #10389: [fix]Make sure only call once set_dict_encoding_type for each ColumnReader

2022-06-24 Thread GitBox
mrhhsg commented on PR #10389: URL: https://github.com/apache/doris/pull/10389#issuecomment-1165407748 > `std::once_flag` is used to process multiple threads, does we should use it on there? `ColumnReader` maybe be used by multiple queries. -- This is an automated message from the Apac

[GitHub] [doris] cambyzju commented on a diff in pull request #10388: [feature-wip] (array-type) add the array_distinct function

2022-06-24 Thread GitBox
cambyzju commented on code in PR #10388: URL: https://github.com/apache/doris/pull/10388#discussion_r905907255 ## gensrc/script/doris_builtins_functions.py: ## @@ -160,6 +160,18 @@ [['array_position'], 'BIGINT', ['ARRAY_STRING', 'STRING'], '', '', '', 'vec', ''], [[

[GitHub] [doris] SWJTU-ZhangLei opened a new issue, #10403: [Bug] [Fe] master fe wrong when add/drop table with expanding fe.

2022-06-24 Thread GitBox
SWJTU-ZhangLei opened a new issue, #10403: URL: https://github.com/apache/doris/issues/10403 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Version root@re

[GitHub] [doris] BiteTheDDDDt commented on pull request #10389: [fix]Make sure only call once set_dict_encoding_type for each ColumnReader

2022-06-24 Thread GitBox
BiteThet commented on PR #10389: URL: https://github.com/apache/doris/pull/10389#issuecomment-1165377823 `std::once_flag` is used to process multiple threads, does we should use it on there? -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [doris] mrhhsg commented on a diff in pull request #10386: [improvement]Use std::iota to set values of _block_rowids in SegmentIterator::_read_columns_by_index

2022-06-24 Thread GitBox
mrhhsg commented on code in PR #10386: URL: https://github.com/apache/doris/pull/10386#discussion_r905877588 ## be/src/olap/rowset/segment_v2/segment_iterator.cpp: ## @@ -872,9 +872,11 @@ Status SegmentIterator::_read_columns_by_index(uint32_t nrows_read_limit, uint32

[GitHub] [doris] adonis0147 commented on a diff in pull request #10386: [improvement]Use std::iota to set values of _block_rowids in SegmentIterator::_read_columns_by_index

2022-06-24 Thread GitBox
adonis0147 commented on code in PR #10386: URL: https://github.com/apache/doris/pull/10386#discussion_r905875127 ## be/src/olap/rowset/segment_v2/segment_iterator.cpp: ## @@ -872,9 +872,11 @@ Status SegmentIterator::_read_columns_by_index(uint32_t nrows_read_limit, uint32

[GitHub] [doris] adonis0147 commented on a diff in pull request #10386: [improvement]Use std::iota to set values of _block_rowids in SegmentIterator::_read_columns_by_index

2022-06-24 Thread GitBox
adonis0147 commented on code in PR #10386: URL: https://github.com/apache/doris/pull/10386#discussion_r905875127 ## be/src/olap/rowset/segment_v2/segment_iterator.cpp: ## @@ -872,9 +872,11 @@ Status SegmentIterator::_read_columns_by_index(uint32_t nrows_read_limit, uint32

[GitHub] [doris] zhengshiJ commented on a diff in pull request #10377: [feature](nereids) Add brackets expr and ssbSql and inPredicate Expr

2022-06-24 Thread GitBox
zhengshiJ commented on code in PR #10377: URL: https://github.com/apache/doris/pull/10377#discussion_r905873875 ## fe/fe-core/src/main/antlr4/org/apache/doris/nereids/DorisParser.g4: ## @@ -196,6 +196,7 @@ primaryExpression | LEFT_PAREN query RIGHT_PAREN

[GitHub] [doris] zhengshiJ commented on a diff in pull request #10377: [feature](nereids) Add brackets expr and ssbSql and inPredicate Expr

2022-06-24 Thread GitBox
zhengshiJ commented on code in PR #10377: URL: https://github.com/apache/doris/pull/10377#discussion_r905873731 ## fe/fe-core/src/test/java/org/apache/doris/nereids/trees/expressions/ExpressionParserTest.java: ## @@ -134,4 +134,10 @@ public void testSortClause() throws Exception

[GitHub] [doris] adonis0147 commented on a diff in pull request #10386: [improvement]Use std::iota to set values of _block_rowids in SegmentIterator::_read_columns_by_index

2022-06-24 Thread GitBox
adonis0147 commented on code in PR #10386: URL: https://github.com/apache/doris/pull/10386#discussion_r905871733 ## be/src/olap/rowset/segment_v2/segment_iterator.cpp: ## @@ -872,9 +872,11 @@ Status SegmentIterator::_read_columns_by_index(uint32_t nrows_read_limit, uint32

[GitHub] [doris] mrhhsg commented on a diff in pull request #10386: [improvement]Use std::iota to set values of _block_rowids in SegmentIterator::_read_columns_by_index

2022-06-24 Thread GitBox
mrhhsg commented on code in PR #10386: URL: https://github.com/apache/doris/pull/10386#discussion_r905868074 ## be/src/olap/rowset/segment_v2/segment_iterator.cpp: ## @@ -872,9 +872,11 @@ Status SegmentIterator::_read_columns_by_index(uint32_t nrows_read_limit, uint32

[GitHub] [doris] github-actions[bot] commented on pull request #10357: [fix UT](nereids) the check bound function lacks recursive processing

2022-06-24 Thread GitBox
github-actions[bot] commented on PR #10357: URL: https://github.com/apache/doris/pull/10357#issuecomment-1165361047 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #10357: [fix UT](nereids) the check bound function lacks recursive processing

2022-06-24 Thread GitBox
github-actions[bot] commented on PR #10357: URL: https://github.com/apache/doris/pull/10357#issuecomment-1165361086 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[doris] branch master updated: add dynamic partition DataProperty (#10338)

2022-06-24 Thread lihaopeng
This is an automated email from the ASF dual-hosted git repository. lihaopeng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 8f2b2b4457 add dynamic partition DataProperty

  1   2   >