dataalive commented on PR #9697:
URL: https://github.com/apache/incubator-doris/pull/9697#issuecomment-1133536565
title suggest to be [typo][docs]Rollup document fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
hf200012 commented on PR #9683:
URL: https://github.com/apache/incubator-doris/pull/9683#issuecomment-1133522582
> I think we should forbid FE from starting when the machine lacks memory.
In such way, users will modify the conf by themselves.
Here is the main solution to the problem o
hf200012 commented on PR #9683:
URL: https://github.com/apache/incubator-doris/pull/9683#issuecomment-1133522546
Here is the main solution to the problem of not modifying the default 4G
memory in the user's reproduction environment
--
This is an automated message from the Apache Git Servi
github-actions[bot] commented on PR #9692:
URL: https://github.com/apache/incubator-doris/pull/9692#issuecomment-1133522308
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
github-actions[bot] commented on PR #9699:
URL: https://github.com/apache/incubator-doris/pull/9699#issuecomment-1133522156
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
github-actions[bot] commented on PR #9699:
URL: https://github.com/apache/incubator-doris/pull/9699#issuecomment-1133522160
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
github-actions[bot] commented on PR #9701:
URL: https://github.com/apache/incubator-doris/pull/9701#issuecomment-1133522054
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
github-actions[bot] commented on PR #9710:
URL: https://github.com/apache/incubator-doris/pull/9710#issuecomment-1133521814
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
SaintBacchus commented on PR #9485:
URL: https://github.com/apache/incubator-doris/pull/9485#issuecomment-1133521458
@jackwener UT has been resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
songguangjie1987 commented on issue #9713:
URL:
https://github.com/apache/incubator-doris/issues/9713#issuecomment-1133512853
太好了，这是我的flink lib目录下的jar包，可以知道是那个jar包冲突么？
```
doris-flink-1.0-SNAPSHOT.jar
flink-csv-1.13.6.jar
flink-dist_2.12-1.13.6.jar
flink-format-changelog-json-
github-actions[bot] commented on PR #9701:
URL: https://github.com/apache/incubator-doris/pull/9701#issuecomment-1133512543
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
github-actions[bot] commented on PR #9710:
URL: https://github.com/apache/incubator-doris/pull/9710#issuecomment-1133511768
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
JNSimba commented on issue #9713:
URL:
https://github.com/apache/incubator-doris/issues/9713#issuecomment-1133509178
See if there is a conflict in the jar package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/fe/com.google.code.gson-gson-2.8.9
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git
at cc7b422aab Bump gson from 2.8.6 to 2.8.9 in /fe
No new rev
dependabot[bot] opened a new pull request, #9717:
URL: https://github.com/apache/incubator-doris/pull/9717
Bumps [gson](https://github.com/google/gson) from 2.8.6 to 2.8.9.
Release notes
Sourced from https://github.com/google/gson/releases";>gson's
releases.
Gson 2.8.9
BiteThet commented on issue #9711:
URL:
https://github.com/apache/incubator-doris/issues/9711#issuecomment-1132967917
>
Isn't the floor rounded down? like floor(0.6)=0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
dataalive commented on issue #9711:
URL:
https://github.com/apache/incubator-doris/issues/9711#issuecomment-1132965216
> why q1 expect result is `2022-05-04 00:00:00`?
In accordance with rounding, divided by 12 o'clock ?
--
This is an automated message from the Apache Git Serv
BiteThet opened a new pull request, #9716:
URL: https://github.com/apache/incubator-doris/pull/9716
# Proposed changes
Issue Number: close #9715
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original b
BiteThet opened a new issue, #9715:
URL: https://github.com/apache/incubator-doris/issues/9715
### Search before asking
- [X] I had searched in the
[issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and
found no similar issues.
### Version
m
xiaokang commented on PR #9714:
URL: https://github.com/apache/incubator-doris/pull/9714#issuecomment-1132914792
The thread_local approach is learned from
https://github.com/apache/incubator-doris/pull/7911 by @xinyiZzz . It will be
very appreciated if you have a look and check whether the
xiaokang opened a new pull request, #9714:
URL: https://github.com/apache/incubator-doris/pull/9714
# Proposed changes
Issue Number: close #9706 , which was introduced by
https://github.com/apache/incubator-doris/pull/9566
Make reusing compress/decompress context object thread
github-actions[bot] commented on PR #9459:
URL: https://github.com/apache/incubator-doris/pull/9459#issuecomment-1132875352
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
github-actions[bot] commented on PR #9459:
URL: https://github.com/apache/incubator-doris/pull/9459#issuecomment-1132875313
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
HappenLee commented on code in PR #9459:
URL: https://github.com/apache/incubator-doris/pull/9459#discussion_r878111822
##
be/src/olap/memtable.cpp:
##
@@ -263,11 +264,46 @@ vectorized::Block MemTable::_collect_vskiplist_results() {
auto function = _agg_function
github-actions[bot] commented on PR #9619:
URL: https://github.com/apache/incubator-doris/pull/9619#issuecomment-1132857519
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
github-actions[bot] commented on PR #9619:
URL: https://github.com/apache/incubator-doris/pull/9619#issuecomment-1132857472
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
BiteThet commented on issue #9711:
URL:
https://github.com/apache/incubator-doris/issues/9711#issuecomment-1132818052
why q1 expect result is `2022-05-04 00:00:00`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
songguangjie1987 opened a new issue, #9713:
URL: https://github.com/apache/incubator-doris/issues/9713
### Search before asking
- [X] I had searched in the
[issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and
found no similar issues.
### Version
BiteThet commented on PR #9712:
URL: https://github.com/apache/incubator-doris/pull/9712#issuecomment-1132791605
Are there any wrong cases?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
EmmyMiao87 commented on PR #9703:
URL: https://github.com/apache/incubator-doris/pull/9703#issuecomment-1132740308
> do we need to add some regression test to ensure that no performance
rollback occurs？
Yes, I think we especially need regression test about performance.
For example,
zhengshengjun commented on issue #9711:
URL:
https://github.com/apache/incubator-doris/issues/9711#issuecomment-1132736964
PR: https://github.com/apache/incubator-doris/pull/9712
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
zhengshengjun opened a new pull request, #9712:
URL: https://github.com/apache/incubator-doris/pull/9712
# Proposed changes
Issue Number: close #xxx
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original b
github-actions[bot] commented on PR #9703:
URL: https://github.com/apache/incubator-doris/pull/9703#issuecomment-1132736597
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
github-actions[bot] commented on PR #9703:
URL: https://github.com/apache/incubator-doris/pull/9703#issuecomment-1132736562
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
zhengshengjun opened a new issue, #9711:
URL: https://github.com/apache/incubator-doris/issues/9711
### Search before asking
- [X] I had searched in the
[issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and
found no similar issues.
### Version
zxealous opened a new pull request, #9710:
URL: https://github.com/apache/incubator-doris/pull/9710
# Proposed changes
Fix typos in comments
## Problem Summary:
Fix typos in comments
## Checklist(Required)
1. Does it affect the original behavior: (No)
2.
hqisog opened a new issue, #9709:
URL: https://github.com/apache/incubator-doris/issues/9709
### Search before asking
- [X] I had searched in the
[issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and
found no similar issues.
### Description
dor
xiaokang commented on issue #9706:
URL:
https://github.com/apache/incubator-doris/issues/9706#issuecomment-1132670694
It's introduced by https://github.com/apache/incubator-doris/pull/9566 for
thread safe problem, I will fix it as soon as possible.
--
This is an automated message from th
carlvinhust2012 commented on code in PR #9705:
URL: https://github.com/apache/incubator-doris/pull/9705#discussion_r877918676
##
fe/fe-core/src/main/java/org/apache/doris/clone/BackendLoadStatistic.java:
##
@@ -187,7 +187,7 @@ public void init() throws LoadBalanceException {
adonis0147 opened a new pull request, #9708:
URL: https://github.com/apache/incubator-doris/pull/9708
# Proposed changes
Issue Number: close #9707
## Problem Summary:
Please refer to #9707
## Checklist(Required)
1. Does it affect the original behavior: No
adonis0147 opened a new issue, #9707:
URL: https://github.com/apache/incubator-doris/issues/9707
### Search before asking
- [X] I had searched in the
[issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and
found no similar issues.
### Description
morrySnow commented on PR #9703:
URL: https://github.com/apache/incubator-doris/pull/9703#issuecomment-1132647170
do we need to add some regression test to ensure that no performance
rollback occurs？
--
This is an automated message from the Apache Git Service.
To respond to the message, p
zhengshiJ commented on code in PR #9703:
URL: https://github.com/apache/incubator-doris/pull/9703#discussion_r877886232
##
fe/fe-core/src/main/java/org/apache/doris/planner/PredicatePushDown.java:
##
@@ -0,0 +1,144 @@
+// Licensed to the Apache Software Foundation (ASF) under on
Gabriel39 commented on code in PR #9663:
URL: https://github.com/apache/incubator-doris/pull/9663#discussion_r877852699
##
be/src/vec/common/columns_hashing_impl.h:
##
@@ -132,12 +132,25 @@ class HashMethodBase {
return emplaceImpl(key_holder, data);
}
+templ
EmmyMiao87 commented on code in PR #9703:
URL: https://github.com/apache/incubator-doris/pull/9703#discussion_r877852412
##
fe/fe-core/src/main/java/org/apache/doris/planner/PredicatePushDown.java:
##
@@ -0,0 +1,144 @@
+// Licensed to the Apache Software Foundation (ASF) under o
adonis0147 commented on PR #9683:
URL: https://github.com/apache/incubator-doris/pull/9683#issuecomment-1132593294
I think we should forbid FE from starting when the machine lacks memory. In
such way, users will modify the conf by themselves.
--
This is an automated message from the Apach
adonis0147 commented on code in PR #9683:
URL: https://github.com/apache/incubator-doris/pull/9683#discussion_r877847296
##
conf/fe.conf:
##
@@ -25,11 +25,14 @@
LOG_DIR = ${DORIS_HOME}/log
DATE = `date +%Y%m%d-%H%M%S`
-JAVA_OPTS="-Xmx4096m -XX:+UseMembar -XX:SurvivorRatio=8
github-actions[bot] commented on PR #9689:
URL: https://github.com/apache/incubator-doris/pull/9689#issuecomment-1132583833
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
github-actions[bot] commented on PR #9689:
URL: https://github.com/apache/incubator-doris/pull/9689#issuecomment-1132583780
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
dataroaring opened a new issue, #9706:
URL: https://github.com/apache/incubator-doris/issues/9706
### Search before asking
- [X] I had searched in the
[issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and
found no similar issues.
### Version
ma
luozenglin commented on code in PR #9608:
URL: https://github.com/apache/incubator-doris/pull/9608#discussion_r877826139
##
thirdparty/patches/opentelemetry-cpp-1.2.0.patch:
##
@@ -0,0 +1,374 @@
+diff --git a/api/include/opentelemetry/common/threadlocal.h
b/api/include/opentele
ccoffline opened a new pull request, #9705:
URL: https://github.com/apache/incubator-doris/pull/9705
# Proposed changes
Issue Number: close #9704
## Problem Summary:
Calculate the disk used pct instead of data used pct.
## Checklist(Required)
1. Does it aff
ccoffline opened a new issue, #9704:
URL: https://github.com/apache/incubator-doris/issues/9704
### Search before asking
- [X] I had searched in the
[issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and
found no similar issues.
### Version
I'm
This is an automated email from the ASF dual-hosted git repository.
lingmiao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git
The following commit(s) were added to refs/heads/master by this push:
new 0c4b47756a [enhancement](community):
EmmyMiao87 merged PR #9693:
URL: https://github.com/apache/incubator-doris/pull/9693
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...
github-actions[bot] commented on PR #9693:
URL: https://github.com/apache/incubator-doris/pull/9693#issuecomment-1132568080
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
luozenglin commented on PR #9608:
URL: https://github.com/apache/incubator-doris/pull/9608#issuecomment-1132560841
> Nice work! i just wonder what percentage of performance drawback will be
caused by increasing the trace in general, looking forward to do a performance
test
Yeah, I wi
github-actions[bot] commented on PR #9693:
URL: https://github.com/apache/incubator-doris/pull/9693#issuecomment-1132545049
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
morrySnow commented on PR #9702:
URL: https://github.com/apache/incubator-doris/pull/9702#issuecomment-1132548047
title follows Commit Format Specification is better:
https://doris.apache.org/zh-CN/community/how-to-contribute/commit-format-specification.html
--
This is an automated messag
jackwener commented on PR #9703:
URL: https://github.com/apache/incubator-doris/pull/9703#issuecomment-1132544382
You can fix the `checkstyle` `wrong order declaration` follow the method
[auto rearrange code](https://github.com/apache/incubator-doris/pull/9693)
--
This is an automated mes
60 matches
Mail list logo
