[GitHub] [incubator-doris] 924060929 commented on pull request #5336: [Spark-Doris-Connector][Bug-Fix] Resolve deserialize exception when Spark Doris Connector in aync deserialize mode

2021-02-25 Thread GitBox
924060929 commented on pull request #5336: URL: https://github.com/apache/incubator-doris/pull/5336#issuecomment-786466573 @wuyunfeng OK, first I think the same solution as you note, but don't know where the place the NoOpLock, we can add a inner class, or add some public class in any pack

[GitHub] [incubator-doris] wuyunfeng commented on a change in pull request #5325: [Doris On ES][WIP] Support external ES table with `SSL` secured and configurable node sniffing

2021-02-25 Thread GitBox
wuyunfeng commented on a change in pull request #5325: URL: https://github.com/apache/incubator-doris/pull/5325#discussion_r583331970 ## File path: be/src/http/http_client.h ## @@ -66,6 +66,11 @@ class HttpClient { curl_easy_setopt(_curl, CURLOPT_COPYPOSTFIELDS, post_b

[GitHub] [incubator-doris] wuyunfeng commented on issue #5420: 挂一台BE之后使用Spark的读取Doris的分区表到dataframe会报错,在客户端用sql查询不会有问题

2021-02-25 Thread GitBox
wuyunfeng commented on issue #5420: URL: https://github.com/apache/incubator-doris/issues/5420#issuecomment-786451720 @demon-gu I would resolve this problem soon. This is an automated message from the Apache Git Service.

[GitHub] [incubator-doris] wuyunfeng commented on pull request #5336: [Spark-Doris-Connector][Bug-Fix] Resolve deserialize exception when Spark Doris Connector in aync deserialize mode

2021-02-25 Thread GitBox
wuyunfeng commented on pull request #5336: URL: https://github.com/apache/incubator-doris/pull/5336#issuecomment-786450377 I just using `Java` describe the implementation which I would prefer: First define a `NoOpLock`: ``` protected static final class NoOpLock implements Lo

[GitHub] [incubator-doris] 924060929 commented on pull request #5336: [Spark-Doris-Connector][Bug-Fix] Resolve deserialize exception when Spark Doris Connector in aync deserialize mode

2021-02-25 Thread GitBox
924060929 commented on pull request #5336: URL: https://github.com/apache/incubator-doris/pull/5336#issuecomment-786439923 > @924060929 I suggest that there can be such an optimization @wuyunfeng done This is an automa

[GitHub] [incubator-doris] 924060929 commented on pull request #5336: [Spark-Doris-Connector][Bug-Fix] Resolve deserialize exception when Spark Doris Connector in aync deserialize mode

2021-02-25 Thread GitBox
924060929 commented on pull request #5336: URL: https://github.com/apache/incubator-doris/pull/5336#issuecomment-786428886 @wuyunfeng OK, I will add this optimization soon This is an automated message from the Apache Git Serv

[GitHub] [incubator-doris] HangyuanLiu commented on a change in pull request #4479: [Apache][Doris]add query cache docs

2021-02-25 Thread GitBox
HangyuanLiu commented on a change in pull request #4479: URL: https://github.com/apache/incubator-doris/pull/4479#discussion_r513149723 ## File path: docs/zh-CN/administrator-guide/query_cache.md ## @@ -0,0 +1,147 @@ +--- +{ +"title": "QUERY CACHE", +"language": "zh-CN"

[incubator-doris] branch master updated: [Doc] correct format errors in English doc (#5321)

2021-02-25 Thread lingmiao
This is an automated email from the ASF dual-hosted git repository. lingmiao pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new e93a6da [Doc] correct format errors

[GitHub] [incubator-doris] EmmyMiao87 merged pull request #5321: [Doc] correct format errors in English doc

2021-02-25 Thread GitBox
EmmyMiao87 merged pull request #5321: URL: https://github.com/apache/incubator-doris/pull/5321 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [incubator-doris] nimuyuhan opened a new pull request #5428: Make sure the singleton thread is safe

2021-02-25 Thread GitBox
nimuyuhan opened a new pull request #5428: URL: https://github.com/apache/incubator-doris/pull/5428 ## Proposed changes The following class org.apache.doris.clone.ColocateTableBalancer org.apache.doris.common.proc.ProcService org.apache.doris.rpc.BackendServiceProxy org.

[GitHub] [incubator-doris] wuyunfeng commented on pull request #5336: [Spark-Doris-Connector][Bug-Fix] Resolve deserialize exception when Spark Doris Connector in aync deserialize mode

2021-02-25 Thread GitBox
wuyunfeng commented on pull request #5336: URL: https://github.com/apache/incubator-doris/pull/5336#issuecomment-786380570 @924060929 I suggest that there can be such an optimization This is an automated message from the Apac

[GitHub] [incubator-doris] 924060929 commented on pull request #5425: [Hll][Be][Bug-Fix] Resolve be crash when aggregate 160 hll items(#5424)

2021-02-25 Thread GitBox
924060929 commented on pull request #5425: URL: https://github.com/apache/incubator-doris/pull/5425#issuecomment-786375108 Gentle ping @imay This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [incubator-doris] 924060929 commented on pull request #5336: [Spark-Doris-Connector][Bug-Fix] Resolve deserialize exception when Spark Doris Connector in aync deserialize mode

2021-02-25 Thread GitBox
924060929 commented on pull request #5336: URL: https://github.com/apache/incubator-doris/pull/5336#issuecomment-786366712 > @924060929 This is a nice capture. I am curious about whether the lock is necessary when running in sync mode (default mode)? Unnecessary, just for simplify. S

[GitHub] [incubator-doris] demon-gu closed issue #5420: 挂一台BE之后使用Spark的读取Doris的分区表到dataframe会报错,在客户端用sql查询不会有问题

2021-02-25 Thread GitBox
demon-gu closed issue #5420: URL: https://github.com/apache/incubator-doris/issues/5420 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [incubator-doris] copperybean opened a new pull request #5427: [Enhancement] package all depended jars in a single jar file for fe-core (#5426)

2021-02-25 Thread GitBox
copperybean opened a new pull request #5427: URL: https://github.com/apache/incubator-doris/pull/5427 Currently, java codes in Doris are separated to several modules, users may forget to copy some jar file when upgrading the service. Such as fe-common.jar, and it's really dangerous because

[GitHub] [incubator-doris] copperybean opened a new issue #5426: [Enhancement] package all depended jars in a single jar file for fe-core

2021-02-25 Thread GitBox
copperybean opened a new issue #5426: URL: https://github.com/apache/incubator-doris/issues/5426 Currently, java codes in Doris are separated to several modules, users may forget to copy some jar file when upgrading the service. Such as fe-common.jar, and it's really dangerous because the

[GitHub] [incubator-doris] wuyunfeng edited a comment on pull request #5336: [Spark-Doris-Connector][Bug-Fix] Resolve deserialize exception when Spark Doris Connector in aync deserialize mode

2021-02-25 Thread GitBox
wuyunfeng edited a comment on pull request #5336: URL: https://github.com/apache/incubator-doris/pull/5336#issuecomment-785891786 @924060929 This is a nice capture. I am curious about whether the lock is necessary when running in sync mode (default mode)?

[GitHub] [incubator-doris] wuyunfeng commented on pull request #5336: [Spark-Doris-Connector][Bug-Fix] Resolve deserialize exception when Spark Doris Connector in aync deserialize mode

2021-02-25 Thread GitBox
wuyunfeng commented on pull request #5336: URL: https://github.com/apache/incubator-doris/pull/5336#issuecomment-785891786 @924060929 This is a nice capture. I am curious about whether the lock is necessary when running in sync mode? --

[GitHub] [incubator-doris] 924060929 opened a new pull request #5425: [BUG] hll could terminate be when aggregate 160 item (#5424)

2021-02-25 Thread GitBox
924060929 opened a new pull request #5425: URL: https://github.com/apache/incubator-doris/pull/5425 ## Proposed changes fix #5424 ## Types of changes What types of changes does your code introduce to Doris? _Put an `x` in the boxes that apply_ - [x] Bugfix (no

[GitHub] [incubator-doris] 924060929 commented on pull request #5336: [Bug] ScalaValueReader throw TApplicationException: get_next failed: out of sequence response: expected 21 but got 20

2021-02-25 Thread GitBox
924060929 commented on pull request #5336: URL: https://github.com/apache/incubator-doris/pull/5336#issuecomment-785865628 Gentle ping @wuyunfeng This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [incubator-doris] 924060929 opened a new issue #5424: [BUG] hll could terminate be will aggregate 160 item

2021-02-25 Thread GitBox
924060929 opened a new issue #5424: URL: https://github.com/apache/incubator-doris/issues/5424 **Describe the bug** hyper log log aggreate 160 items will terminate `backend` **To Reproduce** Steps to reproduce the behavior: 1. create a test table ```sql CREATE TABLE

[GitHub] [incubator-doris] EmmyMiao87 commented on issue #1362: Follower FE restart failed

2021-02-25 Thread GitBox
EmmyMiao87 commented on issue #1362: URL: https://github.com/apache/incubator-doris/issues/1362#issuecomment-785732219 This is a bdbje bug. The solution is following: clean the palo-meta/ dir start with --helper again it becomes normal. ---