[GitHub] [incubator-doris] caoyang10 commented on issue #4328: [BUG] fe will crash while be disk err with single data replica

2020-08-17 Thread GitBox
caoyang10 commented on issue #4328: URL: https://github.com/apache/incubator-doris/issues/4328#issuecomment-675289024 see the commit: https://github.com/apache/incubator-doris/commit/3359467b9a8750883f2ba4a0d5bd0e4298354b79

[GitHub] [incubator-doris] caoyang10 closed issue #4328: [BUG] fe will crash while be disk err with single data replica

2020-08-17 Thread GitBox
caoyang10 closed issue #4328: URL: https://github.com/apache/incubator-doris/issues/4328 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [incubator-doris] xinghuayu007 commented on pull request #4347: udf: replace function

2020-08-17 Thread GitBox
xinghuayu007 commented on pull request #4347: URL: https://github.com/apache/incubator-doris/pull/4347#issuecomment-675279285 > Hi @xinghuayu007 , please let know if you finish modifying this PR, thank you. I have fixed PR. --

[GitHub] [incubator-doris] EmmyMiao87 opened a new pull request #4382: Modify mv rewrite rule on 'Count distinct'

2020-08-17 Thread GitBox
EmmyMiao87 opened a new pull request #4382: URL: https://github.com/apache/incubator-doris/pull/4382 ## Proposed changes The rewrite rule named `CountToSum` does not distinguish between `Count` and `Count distinct` which causes `Count distinct` is rewritten as `Sum` incorrectly.

[GitHub] [incubator-doris] morningman merged pull request #4255: [Tablet][Recovery] Support using empty tablet to repair the damaged or missing tablet

2020-08-17 Thread GitBox
morningman merged pull request #4255: URL: https://github.com/apache/incubator-doris/pull/4255 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[incubator-doris] branch master updated (53d00d9 -> 3359467)

2020-08-17 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 53d00d9 [Doris On ES][Bug-Fix] ES queries always route at same 3 BE nodes (#4351) (#4352) add 335

[GitHub] [incubator-doris] morningman closed issue #4274: [Bug] FE crash when doing checkpoint

2020-08-17 Thread GitBox
morningman closed issue #4274: URL: https://github.com/apache/incubator-doris/issues/4274 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-doris] ZhangYu0123 edited a comment on pull request #4366: Optimise coding bit operation in BE

2020-08-17 Thread GitBox
ZhangYu0123 edited a comment on pull request #4366: URL: https://github.com/apache/incubator-doris/pull/4366#issuecomment-675244849 > Not intended to interfere, just curious about how many improvements can be achieved from this PR, are there any benchmarks? In my develop computure, w

[GitHub] [incubator-doris] ZhangYu0123 edited a comment on pull request #4366: Optimise coding bit operation in BE

2020-08-17 Thread GitBox
ZhangYu0123 edited a comment on pull request #4366: URL: https://github.com/apache/incubator-doris/pull/4366#issuecomment-675244849 > Not intended to interfere, just curious about how many improvements can be achieved from this PR, are there any benchmarks? In my develop computure, w

[GitHub] [incubator-doris] ZhangYu0123 edited a comment on pull request #4366: Optimise coding bit operation in BE

2020-08-17 Thread GitBox
ZhangYu0123 edited a comment on pull request #4366: URL: https://github.com/apache/incubator-doris/pull/4366#issuecomment-675244849 > Not intended to interfere, just curious about how many improvements can be achieved from this PR, are there any benchmarks? In my develop computure, w

[GitHub] [incubator-doris] ZhangYu0123 edited a comment on pull request #4366: Optimise coding bit operation in BE

2020-08-17 Thread GitBox
ZhangYu0123 edited a comment on pull request #4366: URL: https://github.com/apache/incubator-doris/pull/4366#issuecomment-675244849 > Not intended to interfere, just curious about how many improvements can be achieved from this PR, are there any benchmarks? In my develop computure, w

[GitHub] [incubator-doris] ZhangYu0123 commented on pull request #4366: Optimise coding bit operation in BE

2020-08-17 Thread GitBox
ZhangYu0123 commented on pull request #4366: URL: https://github.com/apache/incubator-doris/pull/4366#issuecomment-675244849 > Not intended to interfere, just curious about how many improvements can be achieved from this PR, are there any benchmarks? In my develop computure, when exe

[GitHub] [incubator-doris] EmmyMiao87 opened a new issue #4381: Query with `Count distinct` matches the incorrect materialized view

2020-08-17 Thread GitBox
EmmyMiao87 opened a new issue #4381: URL: https://github.com/apache/incubator-doris/issues/4381 **Describe the bug** The `count distinct` in query matches the incorrect materialized view which only has count() function. It causes the query result is incorrect. **To Reproduce**

[GitHub] [incubator-doris] ColinVon commented on issue #3306: [Doris On Elasticsearch] 2020 Develop Roadmap

2020-08-17 Thread GitBox
ColinVon commented on issue #3306: URL: https://github.com/apache/incubator-doris/issues/3306#issuecomment-675237113 > @ColinVon 更新下Doris的代码,现在已经完全支持 sometable-* 了,支持alias和wildcard两种 > > 参考下这个:#3968 非常感谢,我试试看 T

[GitHub] [incubator-doris] sduzh commented on pull request #4366: Optimise coding bit operation in BE

2020-08-17 Thread GitBox
sduzh commented on pull request #4366: URL: https://github.com/apache/incubator-doris/pull/4366#issuecomment-675225333 Not intended to interfere, just curious about how many improvements can be achieved from this PR, are there some benchmarks?

[GitHub] [incubator-doris] sduzh edited a comment on pull request #4366: Optimise coding bit operation in BE

2020-08-17 Thread GitBox
sduzh edited a comment on pull request #4366: URL: https://github.com/apache/incubator-doris/pull/4366#issuecomment-675225333 Not intended to interfere, just curious about how many improvements can be achieved from this PR, are there any benchmarks? --

[GitHub] [incubator-doris] morningman opened a new issue #4380: [Bug][JsonLoad] Row num stat is not correct

2020-08-17 Thread GitBox
morningman opened a new issue #4380: URL: https://github.com/apache/incubator-doris/issues/4380 **Describe the bug** When all columns in the loaded data are null, this row is illegal, but in some cases it will be loaded incorrectly. **To Reproduce** Steps to reproduce the b

[GitHub] [incubator-doris] yangzhg commented on a change in pull request #4310: Support batch delete [part 1]

2020-08-17 Thread GitBox
yangzhg commented on a change in pull request #4310: URL: https://github.com/apache/incubator-doris/pull/4310#discussion_r471879241 ## File path: fe/fe-core/pom.xml ## @@ -36,7 +36,7 @@ under the License. ${basedir}/../../ -${env.FE_UT_PARALLEL} +

[GitHub] [incubator-doris] wuyunfeng merged pull request #4352: [Doris On ES][Bug-Fix] ES queries always route at same 3 BE nodes (#4351)

2020-08-17 Thread GitBox
wuyunfeng merged pull request #4352: URL: https://github.com/apache/incubator-doris/pull/4352 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-doris] wuyunfeng closed issue #4351: [Doris On ES][Bug] ES queries always route at same 3 BE nodes

2020-08-17 Thread GitBox
wuyunfeng closed issue #4351: URL: https://github.com/apache/incubator-doris/issues/4351 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[incubator-doris] branch master updated: [Doris On ES][Bug-Fix] ES queries always route at same 3 BE nodes (#4351) (#4352)

2020-08-17 Thread wyf
This is an automated email from the ASF dual-hosted git repository. wyf pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 53d00d9 [Doris On ES][Bug-Fix] ES queries

[GitHub] [incubator-doris] yangzhg commented on a change in pull request #4310: Support batch delete [part 1]

2020-08-17 Thread GitBox
yangzhg commented on a change in pull request #4310: URL: https://github.com/apache/incubator-doris/pull/4310#discussion_r471878551 ## File path: fe/fe-core/src/main/java/org/apache/doris/analysis/AlterTableStmt.java ## @@ -70,6 +76,50 @@ public void analyze(Analyzer analyzer)

[GitHub] [incubator-doris] morningman opened a new pull request #4379: [JsonLoad] Fix bug that row num stat is not correct when loading json

2020-08-17 Thread GitBox
morningman opened a new pull request #4379: URL: https://github.com/apache/incubator-doris/pull/4379 ## Proposed changes When all fields are null, the row is invalid, it should be filtered ## Types of changes - [x] Bugfix (non-breaking change which fixes an issue)

[GitHub] [incubator-doris] ZhangYu0123 commented on a change in pull request #4366: Optimise coding bit operation in BE

2020-08-17 Thread GitBox
ZhangYu0123 commented on a change in pull request #4366: URL: https://github.com/apache/incubator-doris/pull/4366#discussion_r471867630 ## File path: be/src/util/coding.h ## @@ -143,7 +143,7 @@ extern uint8_t* encode_varint64(uint8_t* dst, uint64_t value); inline uint8_t* enc

[GitHub] [incubator-doris] ZhangYu0123 commented on a change in pull request #4366: Optimise coding bit operation in BE

2020-08-17 Thread GitBox
ZhangYu0123 commented on a change in pull request #4366: URL: https://github.com/apache/incubator-doris/pull/4366#discussion_r471867279 ## File path: be/src/util/coding.h ## @@ -143,7 +143,7 @@ extern uint8_t* encode_varint64(uint8_t* dst, uint64_t value); inline uint8_t* enc

[GitHub] [incubator-doris] morningman commented on a change in pull request #4377: [ODBC SCAN NODE] 1/4 Add unix odbc library.

2020-08-17 Thread GitBox
morningman commented on a change in pull request #4377: URL: https://github.com/apache/incubator-doris/pull/4377#discussion_r471863189 ## File path: be/test/exec/unix_odbc_test.cpp ## @@ -0,0 +1,28 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more co

[GitHub] [incubator-doris] chaoyli closed issue #4368: Except wrong answer

2020-08-17 Thread GitBox
chaoyli closed issue #4368: URL: https://github.com/apache/incubator-doris/issues/4368 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[incubator-doris] branch master updated: [BUG] Fix except wrong answer bug (#4369)

2020-08-17 Thread lichaoyong
This is an automated email from the ASF dual-hosted git repository. lichaoyong pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new d5e456a [BUG] Fix except wrong ans

[GitHub] [incubator-doris] chaoyli merged pull request #4369: [BUG] Fix except wrong answer bug

2020-08-17 Thread GitBox
chaoyli merged pull request #4369: URL: https://github.com/apache/incubator-doris/pull/4369 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [incubator-doris] imay commented on a change in pull request #4377: [ODBC SCAN NODE] 1/4 Add unix odbc library.

2020-08-17 Thread GitBox
imay commented on a change in pull request #4377: URL: https://github.com/apache/incubator-doris/pull/4377#discussion_r471855209 ## File path: be/test/exec/unix_odbc_test.cpp ## @@ -0,0 +1,28 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contribu

[GitHub] [incubator-doris] imay commented on issue #4355: [Proposal]Support new syntax CREATE TABLE AS to create a new table from existed table

2020-08-17 Thread GitBox
imay commented on issue #4355: URL: https://github.com/apache/incubator-doris/issues/4355#issuecomment-675189977 > @morningman @imay the syntax `create table xxx like` look good to me, I will change it to this, For some detail design, some schema including `column define`, `aggragete type

[GitHub] [incubator-doris] morningman commented on a change in pull request #4310: Support batch delete [part 1]

2020-08-17 Thread GitBox
morningman commented on a change in pull request #4310: URL: https://github.com/apache/incubator-doris/pull/4310#discussion_r471550193 ## File path: fe/fe-core/pom.xml ## @@ -36,7 +36,7 @@ under the License. ${basedir}/../../ -${env.FE_UT_PARALLEL} +

[GitHub] [incubator-doris] morningman commented on pull request #4347: udf: str_replace function

2020-08-17 Thread GitBox
morningman commented on pull request #4347: URL: https://github.com/apache/incubator-doris/pull/4347#issuecomment-674940135 Hi @xinghuayu007 , please let know if you finish modifying this PR, thank you. This is an automated

[GitHub] [incubator-doris] morningman commented on a change in pull request #4377: [ODBC SCAN NODE] 1/4 Add unix odbc library.

2020-08-17 Thread GitBox
morningman commented on a change in pull request #4377: URL: https://github.com/apache/incubator-doris/pull/4377#discussion_r471539561 ## File path: be/test/exec/unix_odbc_test.cpp ## @@ -0,0 +1,28 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more co

[incubator-doris] branch master updated (391d534 -> 26fe510)

2020-08-17 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 391d534 [Bug]Fix bug that BE crash when load ORC file (#4350) add 26fe510 [Doc] modify the docume

[GitHub] [incubator-doris] morningman merged pull request #4357: MOD: modify the document error

2020-08-17 Thread GitBox
morningman merged pull request #4357: URL: https://github.com/apache/incubator-doris/pull/4357 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [incubator-doris] morningman commented on a change in pull request #4375: Fix errors when alter materialized view which based on dup table

2020-08-17 Thread GitBox
morningman commented on a change in pull request #4375: URL: https://github.com/apache/incubator-doris/pull/4375#discussion_r471542377 ## File path: fe/fe-core/src/main/java/org/apache/doris/catalog/OlapTable.java ## @@ -556,7 +556,9 @@ public KeysType getKeysType() { }

[GitHub] [incubator-doris] wutiangan commented on a change in pull request #4375: Fix errors when alter materialized view which based on dup table

2020-08-17 Thread GitBox
wutiangan commented on a change in pull request #4375: URL: https://github.com/apache/incubator-doris/pull/4375#discussion_r471537858 ## File path: fe/fe-core/src/main/java/org/apache/doris/alter/SchemaChangeJobV2.java ## @@ -237,7 +238,9 @@ protected void runPendingJob() thro

[GitHub] [incubator-doris] wutiangan commented on a change in pull request #4375: Fix errors when alter materialized view which based on dup table

2020-08-17 Thread GitBox
wutiangan commented on a change in pull request #4375: URL: https://github.com/apache/incubator-doris/pull/4375#discussion_r471537748 ## File path: fe/fe-core/src/main/java/org/apache/doris/alter/SchemaChangeHandler.java ## @@ -556,6 +556,10 @@ private void addColumnInternal(O

[incubator-doris] branch master updated (e69496f -> 391d534)

2020-08-17 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from e69496f [MysqlCompatibility] Support collate field option in expr (#4365) add 391d534 [Bug]Fix b

[GitHub] [incubator-doris] morningman merged pull request #4350: [Bug]Fix bug that BE crash when load ORC file

2020-08-17 Thread GitBox
morningman merged pull request #4350: URL: https://github.com/apache/incubator-doris/pull/4350 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [incubator-doris] morningman closed issue #4349: [Bug]Using Broker load with ORC file may cause BE crash

2020-08-17 Thread GitBox
morningman closed issue #4349: URL: https://github.com/apache/incubator-doris/issues/4349 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[incubator-doris] branch master updated (38921d4 -> e69496f)

2020-08-17 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 38921d4 [MV]Forbidden aggregated partition key column on mv (#4343) add e69496f [MysqlCompatibili

[GitHub] [incubator-doris] morningman closed issue #4331: Doris对DataGrip的元数据的兼容

2020-08-17 Thread GitBox
morningman closed issue #4331: URL: https://github.com/apache/incubator-doris/issues/4331 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-doris] morningman merged pull request #4365: support collate field option in compare predicate sql from datagrip

2020-08-17 Thread GitBox
morningman merged pull request #4365: URL: https://github.com/apache/incubator-doris/pull/4365 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [incubator-doris] morningman commented on a change in pull request #4377: [ODBC SCAN NODE] 1/4 Add unix odbc library.

2020-08-17 Thread GitBox
morningman commented on a change in pull request #4377: URL: https://github.com/apache/incubator-doris/pull/4377#discussion_r471523634 ## File path: thirdparty/build-thirdparty.sh ## @@ -692,6 +705,7 @@ build_cctz() { # we just comment it, instead of remove it. # build_llvm

[GitHub] [incubator-doris] stalary opened a new pull request #4378: FIX: fix dynamic partition replicationNum error

2020-08-17 Thread GitBox
stalary opened a new pull request #4378: URL: https://github.com/apache/incubator-doris/pull/4378 dynamic_partition.replication_num default is replication_num, but show create table show -1 This is an automated message from

[GitHub] [incubator-doris] HappenLee opened a new pull request #4377: [ODBC SCAN NODE] 1/4 Add unix odbc library.

2020-08-17 Thread GitBox
HappenLee opened a new pull request #4377: URL: https://github.com/apache/incubator-doris/pull/4377 issue:#4376 ## Proposed changes Add unix odbc library for ODBC Scan Node ## Types of changes What types of changes does your code introduce to Doris? _Put an `x`

[GitHub] [incubator-doris] WingsGo edited a comment on issue #4355: [Proposal]Support new syntax CREATE TABLE AS to create a new table from existed table

2020-08-17 Thread GitBox
WingsGo edited a comment on issue #4355: URL: https://github.com/apache/incubator-doris/issues/4355#issuecomment-674860666 @morningman @imay the syntax `create table xxx like` look good to me, I will change it to this, For some detail design, some schema including `column define`, `aggrag

[GitHub] [incubator-doris] WingsGo edited a comment on issue #4355: [Proposal]Support new syntax CREATE TABLE AS to create a new table from existed table

2020-08-17 Thread GitBox
WingsGo edited a comment on issue #4355: URL: https://github.com/apache/incubator-doris/issues/4355#issuecomment-674860666 @morningman @imay the syntax `create table xxx like` look good to me, I will change it to this, For some detail design, I will add some schema including `column defin

[GitHub] [incubator-doris] WingsGo edited a comment on issue #4355: [Proposal]Support new syntax CREATE TABLE AS to create a new table from existed table

2020-08-17 Thread GitBox
WingsGo edited a comment on issue #4355: URL: https://github.com/apache/incubator-doris/issues/4355#issuecomment-674860666 @morningman @imay the syntax `create table xxx like` look good to me, I will change it to this, For some detail design, I will add some information including `column

[GitHub] [incubator-doris] WingsGo commented on issue #4355: [Proposal]Support new syntax CREATE TABLE AS to create a new table from existed table

2020-08-17 Thread GitBox
WingsGo commented on issue #4355: URL: https://github.com/apache/incubator-doris/issues/4355#issuecomment-674860666 @morningman @imay the syntax `create table xxx like` look good to me, I will change it to this, For some detail design, I will add some information including `column define`

[GitHub] [incubator-doris] HappenLee opened a new issue #4376: [Proposal] Support ODBC Scan Node for Doris

2020-08-17 Thread GitBox
HappenLee opened a new issue #4376: URL: https://github.com/apache/incubator-doris/issues/4376 ## Motivation At present, many customers need to access the external table through Doris, but Doris only supports accessing the external table of MySQL at present. This problem makes it diffic

[GitHub] [incubator-doris] EmmyMiao87 commented on issue #4370: Release Nodes 0.13.0

2020-08-17 Thread GitBox
EmmyMiao87 commented on issue #4370: URL: https://github.com/apache/incubator-doris/issues/4370#issuecomment-674835876 # Credits @ZhangYu0123 @wfjcmcb @Fullstop000 @sduzh @Stalary @worker24h

[GitHub] [incubator-doris] imay commented on issue #4355: [Proposal]Support new syntax CREATE TABLE AS to create a new table from existed table

2020-08-17 Thread GitBox
imay commented on issue #4355: URL: https://github.com/apache/incubator-doris/issues/4355#issuecomment-674786616 I aggree with @morningman maybe `create table xxx like ` is something what you needs. We can refer other's syntax. [redshift](https://docs.aws.amazon.com/redshift/latest

[GitHub] [incubator-doris] imay commented on a change in pull request #4366: Optimise coding bit operation in BE

2020-08-17 Thread GitBox
imay commented on a change in pull request #4366: URL: https://github.com/apache/incubator-doris/pull/4366#discussion_r471368389 ## File path: be/src/util/coding.h ## @@ -143,7 +143,7 @@ extern uint8_t* encode_varint64(uint8_t* dst, uint64_t value); inline uint8_t* encode_var

[GitHub] [incubator-doris] EmmyMiao87 opened a new pull request #4375: Fix errors when alter materialized view which based on dup table

2020-08-17 Thread GitBox
EmmyMiao87 opened a new pull request #4375: URL: https://github.com/apache/incubator-doris/pull/4375 ## Proposed changes 1. Input the correct keys type when mv is updated. The keys type of mv should be used in schema change job rather then keys type of base table. Otherwise, th

[GitHub] [incubator-doris] EmmyMiao87 opened a new issue #4374: Failed to drop column on materialized view

2020-08-17 Thread GitBox
EmmyMiao87 opened a new issue #4374: URL: https://github.com/apache/incubator-doris/issues/4374 **Describe the bug** Drop column on materialized view by AlterClause. The alter job is failed with error msg: Create replicas failed. **To Reproduce** Steps to reproduce the behavi

[GitHub] [incubator-doris] wuyunfeng commented on a change in pull request #4172: Simplify logic and improve efficiency

2020-08-17 Thread GitBox
wuyunfeng commented on a change in pull request #4172: URL: https://github.com/apache/incubator-doris/pull/4172#discussion_r471326590 ## File path: be/src/util/blocking_priority_queue.hpp ## @@ -85,34 +85,32 @@ class BlockingPriorityQueue { MonotonicStopWatch timer;

[GitHub] [incubator-doris] caoyang10 commented on pull request #4352: [Doris On ES][Bug-Fix] ES queries always route at same 3 BE nodes (#4351)

2020-08-17 Thread GitBox
caoyang10 commented on pull request #4352: URL: https://github.com/apache/incubator-doris/pull/4352#issuecomment-674709611 I've obtained size = backendList.size() in the front of loop. Is it better? please check the commit 6e17409