[GitHub] [incubator-doris] dependabot[bot] opened a new pull request #2273: Bump libthrift from 0.9.3 to 0.12.0 in /extension/spark-doris-connector

2019-11-21 Thread GitBox
dependabot[bot] opened a new pull request #2273: Bump libthrift from 0.9.3 to 0.12.0 in /extension/spark-doris-connector URL: https://github.com/apache/incubator-doris/pull/2273 Bumps [libthrift](https://github.com/apache/thrift) from 0.9.3 to 0.12.0. Release notes *Sourced fr

[incubator-doris] branch dependabot/maven/extension/spark-doris-connector/org.apache.thrift-libthrift-0.12.0 created (now 0a1881f)

2019-11-21 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/extension/spark-doris-connector/org.apache.thrift-libthrift-0.12.0 in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. at 0a1881f Bump libthrift fr

[incubator-doris] branch master updated (79ff0ad -> 732c473)

2019-11-21 Thread zhaoc
This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 79ff0ad Add pipes_as_concat_mode (#2252) add 732c473 Add spark-doris-connector extension (#2228) No n

[GitHub] [incubator-doris] imay merged pull request #2228: add spark-doris-connector extension

2019-11-21 Thread GitBox
imay merged pull request #2228: add spark-doris-connector extension URL: https://github.com/apache/incubator-doris/pull/2228 This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [incubator-doris] vagetablechicken opened a new issue #2272: Formatting C++ Code With clang-format?

2019-11-21 Thread GitBox
vagetablechicken opened a new issue #2272: Formatting C++ Code With clang-format? URL: https://github.com/apache/incubator-doris/issues/2272 Let's clang-format~ Clang-format supports two ways to provide custom style options: directly specify style configuration in the -style= comman

[incubator-doris] branch master updated (297542b -> 79ff0ad)

2019-11-21 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 297542b Delay start master only daemon threads (#2268) add 79ff0ad Add pipes_as_concat_mode (#225

[GitHub] [incubator-doris] morningman merged pull request #2252: Add pipes_as_concat_mode

2019-11-21 Thread GitBox
morningman merged pull request #2252: Add pipes_as_concat_mode URL: https://github.com/apache/incubator-doris/pull/2252 This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [incubator-doris] morningman commented on issue #2271: Does routine load will make oom?

2019-11-21 Thread GitBox
morningman commented on issue #2271: Does routine load will make oom? URL: https://github.com/apache/incubator-doris/issues/2271#issuecomment-557415938 `kafka consume timeout: -` will apear when there is no data to consume, and that is normal. It should not make OOM

[GitHub] [incubator-doris] imay commented on issue #2271: Does routine load will make oom?

2019-11-21 Thread GitBox
imay commented on issue #2271: Does routine load will make oom? URL: https://github.com/apache/incubator-doris/issues/2271#issuecomment-557415748 What's the version of your Doris BE? And there should be no memory leak even if you didn't stop your routine load job. Can you provide mo

[GitHub] [incubator-doris] XShun closed issue #2115: bitmap_union_int cause 'be' node hang

2019-11-21 Thread GitBox
XShun closed issue #2115: bitmap_union_int cause 'be' node hang URL: https://github.com/apache/incubator-doris/issues/2115 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-doris] XShun opened a new issue #2271: Does routine load will make oom?

2019-11-21 Thread GitBox
XShun opened a new issue #2271: Does routine load will make oom? URL: https://github.com/apache/incubator-doris/issues/2271 These days, I tried to load data to doris from kafka. I created a routine load and I wrote some data to kafka. Then I saw the status of load is RUNNING, and I can exe

[GitHub] [incubator-doris] imay merged pull request #2268: Delay start master only daemon threads

2019-11-21 Thread GitBox
imay merged pull request #2268: Delay start master only daemon threads URL: https://github.com/apache/incubator-doris/pull/2268 This is an automated message from the Apache Git Service. To respond to the message, please log o

[incubator-doris] branch master updated (f7d3af1 -> 297542b)

2019-11-21 Thread zhaoc
This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from f7d3af1 Fix export job bug (#2250) add 297542b Delay start master only daemon threads (#2268) No new

[GitHub] [incubator-doris] caiconghui opened a new pull request #2256: Create table with nullable column for default

2019-11-21 Thread GitBox
caiconghui opened a new pull request #2256: Create table with nullable column for default URL: https://github.com/apache/incubator-doris/pull/2256 on production enviroment, create table usually with so many nullable columns,so default nullable for column will be better ---

[GitHub] [incubator-doris] imay closed pull request #2256: Create table with nullable column for default

2019-11-21 Thread GitBox
imay closed pull request #2256: Create table with nullable column for default URL: https://github.com/apache/incubator-doris/pull/2256 This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [incubator-doris] lingbin commented on a change in pull request #2260: Add a tool to show segment status

2019-11-21 Thread GitBox
lingbin commented on a change in pull request #2260: Add a tool to show segment status URL: https://github.com/apache/incubator-doris/pull/2260#discussion_r349428992 ## File path: tools/show_segment_status/README ## @@ -0,0 +1,4 @@ +操作步骤: +1. conf中修改相应的集群配置,可以指定database, t

[GitHub] [incubator-doris] morningman commented on a change in pull request #2241: Fix some bugs about load label

2019-11-21 Thread GitBox
morningman commented on a change in pull request #2241: Fix some bugs about load label URL: https://github.com/apache/incubator-doris/pull/2241#discussion_r349396500 ## File path: fe/src/main/java/org/apache/doris/transaction/GlobalTransactionMgr.java ## @@ -493,18 +521,2

[GitHub] [incubator-doris] morningman commented on a change in pull request #2241: Fix some bugs about load label

2019-11-21 Thread GitBox
morningman commented on a change in pull request #2241: Fix some bugs about load label URL: https://github.com/apache/incubator-doris/pull/2241#discussion_r349392584 ## File path: fe/src/main/java/org/apache/doris/common/DuplicatedRequestException.java ## @@ -20,12 +20,24

[GitHub] [incubator-doris] morningman commented on a change in pull request #2241: Fix some bugs about load label

2019-11-21 Thread GitBox
morningman commented on a change in pull request #2241: Fix some bugs about load label URL: https://github.com/apache/incubator-doris/pull/2241#discussion_r349392401 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/LoadManager.java ## @@ -135,23 +138,23 @@ publi

[GitHub] [incubator-doris] morningman commented on a change in pull request #2241: Fix some bugs about load label

2019-11-21 Thread GitBox
morningman commented on a change in pull request #2241: Fix some bugs about load label URL: https://github.com/apache/incubator-doris/pull/2241#discussion_r349392016 ## File path: fe/src/main/java/org/apache/doris/common/DuplicatedRequestException.java ## @@ -20,12 +20,24

[GitHub] [incubator-doris] morningman commented on a change in pull request #2241: Fix some bugs about load label

2019-11-21 Thread GitBox
morningman commented on a change in pull request #2241: Fix some bugs about load label URL: https://github.com/apache/incubator-doris/pull/2241#discussion_r349391023 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/JobState.java ## @@ -18,8 +18,9 @@ package org

[GitHub] [incubator-doris] morningman closed pull request #2241: Fix some bugs about load label

2019-11-21 Thread GitBox
morningman closed pull request #2241: Fix some bugs about load label URL: https://github.com/apache/incubator-doris/pull/2241 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-doris] morningman opened a new pull request #2241: Fix some bugs about load label

2019-11-21 Thread GitBox
morningman opened a new pull request #2241: Fix some bugs about load label URL: https://github.com/apache/incubator-doris/pull/2241 1. `dbIdToTxnLabels` in `GlobalTransactionMgr` should be consistent with `idToTransactionState`, not only contains running or finished transactions' labels.

[GitHub] [incubator-doris] imay commented on a change in pull request #2241: Fix some bugs about load label

2019-11-21 Thread GitBox
imay commented on a change in pull request #2241: Fix some bugs about load label URL: https://github.com/apache/incubator-doris/pull/2241#discussion_r349147720 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/LoadJob.java ## @@ -132,6 +127,9 @@ protected L

[GitHub] [incubator-doris] imay commented on a change in pull request #2241: Fix some bugs about load label

2019-11-21 Thread GitBox
imay commented on a change in pull request #2241: Fix some bugs about load label URL: https://github.com/apache/incubator-doris/pull/2241#discussion_r349145786 ## File path: fe/src/main/java/org/apache/doris/common/DuplicatedRequestException.java ## @@ -20,12 +20,24 @@ pu

[GitHub] [incubator-doris] imay commented on a change in pull request #2241: Fix some bugs about load label

2019-11-21 Thread GitBox
imay commented on a change in pull request #2241: Fix some bugs about load label URL: https://github.com/apache/incubator-doris/pull/2241#discussion_r349160742 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/LoadManager.java ## @@ -583,6 +595,27 @@ public void u

[GitHub] [incubator-doris] imay commented on a change in pull request #2241: Fix some bugs about load label

2019-11-21 Thread GitBox
imay commented on a change in pull request #2241: Fix some bugs about load label URL: https://github.com/apache/incubator-doris/pull/2241#discussion_r349159280 ## File path: fe/src/main/java/org/apache/doris/common/DuplicatedRequestException.java ## @@ -20,12 +20,24 @@ pu

[GitHub] [incubator-doris] imay commented on a change in pull request #2241: Fix some bugs about load label

2019-11-21 Thread GitBox
imay commented on a change in pull request #2241: Fix some bugs about load label URL: https://github.com/apache/incubator-doris/pull/2241#discussion_r349166905 ## File path: fe/src/main/java/org/apache/doris/transaction/GlobalTransactionMgr.java ## @@ -493,18 +521,29 @@ pu

[GitHub] [incubator-doris] imay commented on a change in pull request #2241: Fix some bugs about load label

2019-11-21 Thread GitBox
imay commented on a change in pull request #2241: Fix some bugs about load label URL: https://github.com/apache/incubator-doris/pull/2241#discussion_r349147277 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/JobState.java ## @@ -18,8 +18,9 @@ package org.apache

[GitHub] [incubator-doris] imay commented on a change in pull request #2241: Fix some bugs about load label

2019-11-21 Thread GitBox
imay commented on a change in pull request #2241: Fix some bugs about load label URL: https://github.com/apache/incubator-doris/pull/2241#discussion_r349153890 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/LoadManager.java ## @@ -135,23 +138,23 @@ public long

[GitHub] [incubator-doris] morningman closed pull request #2241: Fix some bugs about load label

2019-11-21 Thread GitBox
morningman closed pull request #2241: Fix some bugs about load label URL: https://github.com/apache/incubator-doris/pull/2241 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-doris] morningman opened a new pull request #2241: Fix some bugs about load label

2019-11-21 Thread GitBox
morningman opened a new pull request #2241: Fix some bugs about load label URL: https://github.com/apache/incubator-doris/pull/2241 1. `dbIdToTxnLabels` in `GlobalTransactionMgr` should be consistent with `idToTransactionState`, not only contains running or finished transactions' labels.

[GitHub] [incubator-doris] imay commented on a change in pull request #2252: Add pipes_as_concat_mode

2019-11-21 Thread GitBox
imay commented on a change in pull request #2252: Add pipes_as_concat_mode URL: https://github.com/apache/incubator-doris/pull/2252#discussion_r349133430 ## File path: fe/src/test/java/org/apache/doris/analysis/SqlModeTest.java ## @@ -0,0 +1,62 @@ +package org.apache.doris.

[GitHub] [incubator-doris] morningman commented on a change in pull request #2222: Publish version immediately after txt commited

2019-11-21 Thread GitBox
morningman commented on a change in pull request #: Publish version immediately after txt commited URL: https://github.com/apache/incubator-doris/pull/#discussion_r349110246 ## File path: fe/src/main/java/org/apache/doris/transaction/GlobalTransactionMgr.java ## @

[GitHub] [incubator-doris] morningman commented on a change in pull request #2222: Publish version immediately after txt commited

2019-11-21 Thread GitBox
morningman commented on a change in pull request #: Publish version immediately after txt commited URL: https://github.com/apache/incubator-doris/pull/#discussion_r349108353 ## File path: fe/src/main/java/org/apache/doris/transaction/PublishVersionDaemon.java ## @

[GitHub] [incubator-doris] morningman commented on a change in pull request #2222: Publish version immediately after txt commited

2019-11-21 Thread GitBox
morningman commented on a change in pull request #: Publish version immediately after txt commited URL: https://github.com/apache/incubator-doris/pull/#discussion_r349109254 ## File path: fe/src/main/java/org/apache/doris/transaction/GlobalTransactionMgr.java ## @

[GitHub] [incubator-doris] morningman commented on a change in pull request #2222: Publish version immediately after txt commited

2019-11-21 Thread GitBox
morningman commented on a change in pull request #: Publish version immediately after txt commited URL: https://github.com/apache/incubator-doris/pull/#discussion_r349117427 ## File path: fe/src/main/java/org/apache/doris/transaction/GlobalTransactionMgr.java ## @

[GitHub] [incubator-doris] morningman commented on a change in pull request #2222: Publish version immediately after txt commited

2019-11-21 Thread GitBox
morningman commented on a change in pull request #: Publish version immediately after txt commited URL: https://github.com/apache/incubator-doris/pull/#discussion_r349109946 ## File path: fe/src/main/java/org/apache/doris/transaction/GlobalTransactionMgr.java ## @

[GitHub] [incubator-doris] morningman commented on a change in pull request #2260: Add a tool to show segment status

2019-11-21 Thread GitBox
morningman commented on a change in pull request #2260: Add a tool to show segment status URL: https://github.com/apache/incubator-doris/pull/2260#discussion_r349101544 ## File path: tools/show_segment_status/README ## @@ -0,0 +1,4 @@ +操作步骤: +1. conf中修改相应的集群配置,可以指定database

[GitHub] [incubator-doris] morningman commented on a change in pull request #2260: Add a tool to show segment status

2019-11-21 Thread GitBox
morningman commented on a change in pull request #2260: Add a tool to show segment status URL: https://github.com/apache/incubator-doris/pull/2260#discussion_r349100946 ## File path: tools/show_segment_status/README ## @@ -0,0 +1,4 @@ +操作步骤: +1. conf中修改相应的集群配置,可以指定database

[incubator-doris] branch master updated (bcc876e -> f7d3af1)

2019-11-21 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from bcc876e Fix some typos and grammar mistakes (#2269) add f7d3af1 Fix export job bug (#2250) No ne

[GitHub] [incubator-doris] morningman merged pull request #2250: fix export to hdfs bug

2019-11-21 Thread GitBox
morningman merged pull request #2250: fix export to hdfs bug URL: https://github.com/apache/incubator-doris/pull/2250 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [incubator-doris] morningman closed pull request #2269: Fix some typos and grammar mistakes

2019-11-21 Thread GitBox
morningman closed pull request #2269: Fix some typos and grammar mistakes URL: https://github.com/apache/incubator-doris/pull/2269 This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [incubator-doris] JustinTsui opened a new pull request #2269: Fix some typos and grammar mistakes

2019-11-21 Thread GitBox
JustinTsui opened a new pull request #2269: Fix some typos and grammar mistakes URL: https://github.com/apache/incubator-doris/pull/2269 Fixed some typos and grammar mistakes in README.md. NO guaranteed that all typos and mistakes are found and fixed. --

[incubator-doris] branch master updated (4fb498a -> bcc876e)

2019-11-21 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 4fb498a fix unit test failure for show columns from unknown table (#2261) add bcc876e Fix some t

[GitHub] [incubator-doris] morningman merged pull request #2269: Fix some typos and grammar mistakes

2019-11-21 Thread GitBox
morningman merged pull request #2269: Fix some typos and grammar mistakes URL: https://github.com/apache/incubator-doris/pull/2269 This is an automated message from the Apache Git Service. To respond to the message, please lo

[incubator-doris] branch master updated (9c85a04 -> 4fb498a)

2019-11-21 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 9c85a04 Add schema hash to tablet proc info (#2257) add 4fb498a fix unit test failure for show co

[GitHub] [incubator-doris] morningman merged pull request #2261: Fix unit test failure for show columns from unknown table

2019-11-21 Thread GitBox
morningman merged pull request #2261: Fix unit test failure for show columns from unknown table URL: https://github.com/apache/incubator-doris/pull/2261 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-doris] EmmyMiao87 opened a new issue #2270: Where stmt中支持结果为非 Salar 类型的子查询

2019-11-21 Thread GitBox
EmmyMiao87 opened a new issue #2270: Where stmt中支持结果为非 Salar 类型的子查询 URL: https://github.com/apache/incubator-doris/issues/2270 # 背景 目前 Doris 仅支持在 Where 语句中结果为 Salar 类型的子查询,比如: ``` select * from table1 where k1=(select sum(k1) from table2); select * from table1 where k1=(selec

[GitHub] [incubator-doris] JustinTsui opened a new pull request #2269: Fix some typos and grammar mistakes

2019-11-21 Thread GitBox
JustinTsui opened a new pull request #2269: Fix some typos and grammar mistakes URL: https://github.com/apache/incubator-doris/pull/2269 Fixed some typos and grammar mistakes in README.md. NO guaranteed that all typos and mistakes are found and fixed. --

[GitHub] [incubator-doris] morningman closed pull request #2241: Fix some bugs about load label

2019-11-21 Thread GitBox
morningman closed pull request #2241: Fix some bugs about load label URL: https://github.com/apache/incubator-doris/pull/2241 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-doris] morningman opened a new pull request #2241: Fix some bugs about load label

2019-11-21 Thread GitBox
morningman opened a new pull request #2241: Fix some bugs about load label URL: https://github.com/apache/incubator-doris/pull/2241 1. `dbIdToTxnLabels` in `GlobalTransactionMgr` should be consistent with `idToTransactionState`, not only contains running or finished transactions' labels.

[GitHub] [incubator-doris] morningman opened a new pull request #2268: Delay start master only daemon threads

2019-11-21 Thread GitBox
morningman opened a new pull request #2268: Delay start master only daemon threads URL: https://github.com/apache/incubator-doris/pull/2268 ISSUE: #2267 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-doris] morningman opened a new issue #2267: Delay start master only daemon threads

2019-11-21 Thread GitBox
morningman opened a new issue #2267: Delay start master only daemon threads URL: https://github.com/apache/incubator-doris/issues/2267 There are some daemon threads which only run on master FE. And these threads should be started after catalog is ready(finished to load image, replay edit l

[GitHub] [incubator-doris] morningman opened a new pull request #2266: Modify the password and privilege checking logic

2019-11-21 Thread GitBox
morningman opened a new pull request #2266: Modify the password and privilege checking logic URL: https://github.com/apache/incubator-doris/pull/2266 ISSUE #2205 This is an automated message from the Apache Git Service. To r

[GitHub] [incubator-doris] vinson0526 commented on a change in pull request #2228: add spark-doris-connector extension

2019-11-21 Thread GitBox
vinson0526 commented on a change in pull request #2228: add spark-doris-connector extension URL: https://github.com/apache/incubator-doris/pull/2228#discussion_r349018572 ## File path: extension/spark-doris-connector/src/main/java/org/apache/doris/spark/backend/BackendClient.java

[GitHub] [incubator-doris] vinson0526 commented on a change in pull request #2228: add spark-doris-connector extension

2019-11-21 Thread GitBox
vinson0526 commented on a change in pull request #2228: add spark-doris-connector extension URL: https://github.com/apache/incubator-doris/pull/2228#discussion_r349018129 ## File path: extension/spark-doris-connector/src/main/java/org/apache/doris/spark/backend/BackendClient.java

[GitHub] [incubator-doris] vinson0526 commented on a change in pull request #2228: add spark-doris-connector extension

2019-11-21 Thread GitBox
vinson0526 commented on a change in pull request #2228: add spark-doris-connector extension URL: https://github.com/apache/incubator-doris/pull/2228#discussion_r349015424 ## File path: extension/spark-doris-connector/src/main/java/org/apache/doris/spark/backend/BackendClient.java

[GitHub] [incubator-doris] vinson0526 commented on a change in pull request #2228: add spark-doris-connector extension

2019-11-21 Thread GitBox
vinson0526 commented on a change in pull request #2228: add spark-doris-connector extension URL: https://github.com/apache/incubator-doris/pull/2228#discussion_r349014113 ## File path: extension/spark-doris-connector/src/main/scala/org/apache/doris/spark/rdd/ScalaValueReader.scala

[GitHub] [incubator-doris] vinson0526 commented on a change in pull request #2228: add spark-doris-connector extension

2019-11-21 Thread GitBox
vinson0526 commented on a change in pull request #2228: add spark-doris-connector extension URL: https://github.com/apache/incubator-doris/pull/2228#discussion_r349013967 ## File path: extension/spark-doris-connector/src/main/scala/org/apache/doris/spark/rdd/ScalaValueReader.scala

[GitHub] [incubator-doris] wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension

2019-11-21 Thread GitBox
wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension URL: https://github.com/apache/incubator-doris/pull/2228#discussion_r349010927 ## File path: extension/spark-doris-connector/src/main/scala/org/apache/doris/spark/rdd/ScalaValueReader.scala

[GitHub] [incubator-doris] wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension

2019-11-21 Thread GitBox
wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension URL: https://github.com/apache/incubator-doris/pull/2228#discussion_r349011052 ## File path: extension/spark-doris-connector/src/main/scala/org/apache/doris/spark/rdd/ScalaValueReader.scala

[GitHub] [incubator-doris] wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension

2019-11-21 Thread GitBox
wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension URL: https://github.com/apache/incubator-doris/pull/2228#discussion_r349010306 ## File path: extension/spark-doris-connector/src/main/scala/org/apache/doris/spark/rdd/AbstractDorisRDD.scala

[GitHub] [incubator-doris] wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension

2019-11-21 Thread GitBox
wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension URL: https://github.com/apache/incubator-doris/pull/2228#discussion_r349009359 ## File path: extension/spark-doris-connector/src/main/java/org/apache/doris/spark/backend/BackendClient.java #

[GitHub] [incubator-doris] wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension

2019-11-21 Thread GitBox
wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension URL: https://github.com/apache/incubator-doris/pull/2228#discussion_r349007568 ## File path: extension/spark-doris-connector/src/main/java/org/apache/doris/spark/backend/BackendClient.java #

[GitHub] [incubator-doris] wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension

2019-11-21 Thread GitBox
wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension URL: https://github.com/apache/incubator-doris/pull/2228#discussion_r349008499 ## File path: extension/spark-doris-connector/src/main/java/org/apache/doris/spark/backend/BackendClient.java #

[GitHub] [incubator-doris] caiconghui edited a comment on issue #2242: Is that will be better create table with column default enable to be null?

2019-11-21 Thread GitBox
caiconghui edited a comment on issue #2242: Is that will be better create table with column default enable to be null? URL: https://github.com/apache/incubator-doris/issues/2242#issuecomment-556955387 @imay @morningman Maybe default nullable column may confuse users except hadoop users

[GitHub] [incubator-doris] lingbin opened a new pull request #2260: Add a tool to show segment status

2019-11-21 Thread GitBox
lingbin opened a new pull request #2260: Add a tool to show segment status URL: https://github.com/apache/incubator-doris/pull/2260 #2249 This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [incubator-doris] lingbin closed pull request #2260: Add a tool to show segment status

2019-11-21 Thread GitBox
lingbin closed pull request #2260: Add a tool to show segment status URL: https://github.com/apache/incubator-doris/pull/2260 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-doris] WingsGo opened a new pull request #2265: Implement Dynamic partition

2019-11-21 Thread GitBox
WingsGo opened a new pull request #2265: Implement Dynamic partition URL: https://github.com/apache/incubator-doris/pull/2265 #2262 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [incubator-doris] chaoyli commented on issue #2264: cumulative compaction is not performed

2019-11-21 Thread GitBox
chaoyli commented on issue #2264: cumulative compaction is not performed URL: https://github.com/apache/incubator-doris/issues/2264#issuecomment-557007019 ![image](https://user-images.githubusercontent.com/44767902/69326997-c7c64700-0c87-11ea-8622-2d82ad486028.png) --

[GitHub] [incubator-doris] chaoyli opened a new issue #2264: cumulative compaction is not performed

2019-11-21 Thread GitBox
chaoyli opened a new issue #2264: cumulative compaction is not performed URL: https://github.com/apache/incubator-doris/issues/2264 In Baidu Analytics, there is a bug in compaction. Cumulative Compaction is not performed even if there are many rowsets. After restart, cumulative compac

[GitHub] [incubator-doris] vinson0526 commented on a change in pull request #2228: add spark-doris-connector extension

2019-11-21 Thread GitBox
vinson0526 commented on a change in pull request #2228: add spark-doris-connector extension URL: https://github.com/apache/incubator-doris/pull/2228#discussion_r348978793 ## File path: extension/spark-doris-connector/src/main/java/org/apache/doris/spark/rest/RestService.java #

[GitHub] [incubator-doris] vinson0526 commented on a change in pull request #2228: add spark-doris-connector extension

2019-11-21 Thread GitBox
vinson0526 commented on a change in pull request #2228: add spark-doris-connector extension URL: https://github.com/apache/incubator-doris/pull/2228#discussion_r348971452 ## File path: extension/spark-doris-connector/src/main/java/org/apache/doris/spark/rest/RestService.java #

[GitHub] [incubator-doris] vinson0526 commented on a change in pull request #2228: add spark-doris-connector extension

2019-11-21 Thread GitBox
vinson0526 commented on a change in pull request #2228: add spark-doris-connector extension URL: https://github.com/apache/incubator-doris/pull/2228#discussion_r348971172 ## File path: extension/spark-doris-connector/src/main/java/org/apache/doris/spark/cfg/ConfigurationOptions.jav

[GitHub] [incubator-doris] vinson0526 commented on a change in pull request #2228: add spark-doris-connector extension

2019-11-21 Thread GitBox
vinson0526 commented on a change in pull request #2228: add spark-doris-connector extension URL: https://github.com/apache/incubator-doris/pull/2228#discussion_r348971133 ## File path: extension/spark-doris-connector/src/main/java/org/apache/doris/spark/cfg/ConfigurationOptions.jav

[GitHub] [incubator-doris] vinson0526 commented on a change in pull request #2228: add spark-doris-connector extension

2019-11-21 Thread GitBox
vinson0526 commented on a change in pull request #2228: add spark-doris-connector extension URL: https://github.com/apache/incubator-doris/pull/2228#discussion_r348970603 ## File path: extension/spark-doris-connector/src/main/java/org/apache/doris/spark/cfg/ConfigurationOptions.jav

[GitHub] [incubator-doris] vinson0526 commented on a change in pull request #2228: add spark-doris-connector extension

2019-11-21 Thread GitBox
vinson0526 commented on a change in pull request #2228: add spark-doris-connector extension URL: https://github.com/apache/incubator-doris/pull/2228#discussion_r348969582 ## File path: extension/spark-doris-connector/src/main/java/org/apache/doris/spark/backend/BackendClient.java

[GitHub] [incubator-doris] vinson0526 commented on a change in pull request #2228: add spark-doris-connector extension

2019-11-21 Thread GitBox
vinson0526 commented on a change in pull request #2228: add spark-doris-connector extension URL: https://github.com/apache/incubator-doris/pull/2228#discussion_r348969550 ## File path: extension/spark-doris-connector/src/main/java/org/apache/doris/spark/backend/BackendClient.java

[GitHub] [incubator-doris] vinson0526 commented on a change in pull request #2228: add spark-doris-connector extension

2019-11-21 Thread GitBox
vinson0526 commented on a change in pull request #2228: add spark-doris-connector extension URL: https://github.com/apache/incubator-doris/pull/2228#discussion_r348969147 ## File path: extension/spark-doris-connector/src/main/java/org/apache/doris/spark/backend/BackendClient.java

[GitHub] [incubator-doris] xy720 opened a new issue #2263: Replace powerMock/easyMock with JMockit in FE unit tests

2019-11-21 Thread GitBox
xy720 opened a new issue #2263: Replace powerMock/easyMock with JMockit in FE unit tests URL: https://github.com/apache/incubator-doris/issues/2263 We used to make use of powermock and easymock to count up branches in unit test, but the numbers we obtain are not accurate very much, so we n

[GitHub] [incubator-doris] WingsGo opened a new issue #2262: [Proposal] Support Dynamic Partition in Doris

2019-11-21 Thread GitBox
WingsGo opened a new issue #2262: [Proposal] Support Dynamic Partition in Doris URL: https://github.com/apache/incubator-doris/issues/2262 ## Background: In some scenarios, when a user creates an Olap table that is range partition by time, the user needs to periodically add and remove

[GitHub] [incubator-doris] caiconghui commented on issue #2261: Fix unit test failure for show columns from unknown table

2019-11-21 Thread GitBox
caiconghui commented on issue #2261: Fix unit test failure for show columns from unknown table URL: https://github.com/apache/incubator-doris/pull/2261#issuecomment-556983024 #2255 This is an automated message from the Apach

[GitHub] [incubator-doris] caiconghui opened a new pull request #2261: Fix unit test failure for show columns from unknown table

2019-11-21 Thread GitBox
caiconghui opened a new pull request #2261: Fix unit test failure for show columns from unknown table URL: https://github.com/apache/incubator-doris/pull/2261 When show columns from unknown table, show columns from unknown table failed, so fix it. -

[GitHub] [incubator-doris] morningman commented on issue #2256: Create table with nullable column for default

2019-11-21 Thread GitBox
morningman commented on issue #2256: Create table with nullable column for default URL: https://github.com/apache/incubator-doris/pull/2256#issuecomment-556982697 > I don't agree with this. More discuss should be made in issue #2242 You convince me. Plz modify the CREATE TABLE doc to

[GitHub] [incubator-doris] morningman commented on issue #2242: Is that will be better create table with column default enable to be null?

2019-11-21 Thread GitBox
morningman commented on issue #2242: Is that will be better create table with column default enable to be null? URL: https://github.com/apache/incubator-doris/issues/2242#issuecomment-556981708 OK, then you'd better modify the CREATE TABLE document to tell the user what is the default beh