[GitHub] [cloudstack] weizhouapache commented on pull request #7887: xen/xcpng: revert java changes in PR #4672

2023-08-28 Thread via GitHub
weizhouapache commented on PR #7887: URL: https://github.com/apache/cloudstack/pull/7887#issuecomment-1695144271 @harikrishna-patnala let's use cpuCores instead of cpuSockets, as @DaanHoogland suggested. -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [cloudstack] weizhouapache commented on pull request #7887: xen/xcpng: check hosts cpu cores intead of cpu sockets

2023-08-28 Thread via GitHub
weizhouapache commented on PR #7887: URL: https://github.com/apache/cloudstack/pull/7887#issuecomment-1695148639 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [cloudstack] blueorangutan commented on pull request #7887: xen/xcpng: check hosts cpu cores intead of cpu sockets

2023-08-28 Thread via GitHub
blueorangutan commented on PR #7887: URL: https://github.com/apache/cloudstack/pull/7887#issuecomment-1695149321 @weizhouapache a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progres

[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7712: [WIP] Extend import/export unmanaged instances to KVM

2023-08-28 Thread via GitHub
DaanHoogland commented on code in PR #7712: URL: https://github.com/apache/cloudstack/pull/7712#discussion_r1306999018 ## plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java: ## @@ -1185,7 +1196,6 @@ enum HostNicType { private Strin

[GitHub] [cloudstack] weizhouapache commented on pull request #7887: xen/xcpng: revert java changes in PR #4672

2023-08-28 Thread via GitHub
weizhouapache commented on PR #7887: URL: https://github.com/apache/cloudstack/pull/7887#issuecomment-1695153723 @harikrishna-patnala @DaanHoogland I thought about it again, I think we should not set the vcpu max limit to the minimum cpu cores of host in the cluster. it might be possi

[GitHub] [cloudstack] blueorangutan commented on pull request #7344: [HEALTH] 4.19/main Health Check, please don't merge this!

2023-08-28 Thread via GitHub
blueorangutan commented on PR #7344: URL: https://github.com/apache/cloudstack/pull/7344#issuecomment-1695154129 @DaanHoogland a [LL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress

[GitHub] [cloudstack] harikrishna-patnala commented on issue #7375: Can't create or scale VM to more then 2 vcpus. XCP-NG.

2023-08-28 Thread via GitHub
harikrishna-patnala commented on issue #7375: URL: https://github.com/apache/cloudstack/issues/7375#issuecomment-1695155988 > > > value greater than VCPUs-max > > > > > > @weizhouapache I think what we are configuring about vCPUs is correct but instead of failing the VM deployment

[GitHub] [cloudstack] DaanHoogland commented on pull request #7887: xen/xcpng: revert java changes in PR #4672

2023-08-28 Thread via GitHub
DaanHoogland commented on PR #7887: URL: https://github.com/apache/cloudstack/pull/7887#issuecomment-1695157440 > @harikrishna-patnala @DaanHoogland I thought about it again, I think we should not set the vcpu max limit to the minimum cpu cores of host in the cluster. it might be possible t

[cloudstack] branch 4.18-dummy updated (801c4bfdf33 -> 02e67e04d70)

2023-08-28 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch 4.18-dummy in repository https://gitbox.apache.org/repos/asf/cloudstack.git omit 801c4bfdf33 don't merge add 26581b77411 server: throw new exception when rootdisksize is required but not

[GitHub] [cloudstack] weizhouapache commented on issue #7375: Can't create or scale VM to more then 2 vcpus. XCP-NG.

2023-08-28 Thread via GitHub
weizhouapache commented on issue #7375: URL: https://github.com/apache/cloudstack/issues/7375#issuecomment-1695167184 > Okay I see your point about the check which we are doing it before any ways @weizhouapache > > About the max value to be set, https://support.citrix.com/article/CTX2

[cloudstack] branch main updated (f563c165cb3 -> 7362e5338c9)

2023-08-28 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git from f563c165cb3 Merge release branch 4.18 to main add 0dd6bb7c67b systemvm: update size and state of systemvm templa

[cloudstack] 01/01: Merge remote-tracking branch 'origin/4.18'

2023-08-28 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit 7362e5338c95cfa2dad0e3e566acd0cf47dad53d Merge: f563c165cb3 26581b77411 Author: Rohit Yadav AuthorDate: Mon Aug 28 12:5

[GitHub] [cloudstack] harikrishna-patnala commented on pull request #7887: xen/xcpng: revert java changes in PR #4672

2023-08-28 Thread via GitHub
harikrishna-patnala commented on PR #7887: URL: https://github.com/apache/cloudstack/pull/7887#issuecomment-1695189018 Reposting my comment here again (which is on the issue #7375 ) regarding cpuCores or cpuSockets. https://support.citrix.com/article/CTX236977/overcommitting-pcpus-on

[GitHub] [cloudstack] harikrishna-patnala commented on pull request #7887: xen/xcpng: revert java changes in PR #4672

2023-08-28 Thread via GitHub
harikrishna-patnala commented on PR #7887: URL: https://github.com/apache/cloudstack/pull/7887#issuecomment-1695195930 > > @harikrishna-patnala @DaanHoogland I thought about it again, I think we should not set the vcpu max limit to the minimum cpu cores of host in the cluster. it might be p

[GitHub] [cloudstack] weizhouapache commented on pull request #7887: xen/xcpng: revert java changes in PR #4672

2023-08-28 Thread via GitHub
weizhouapache commented on PR #7887: URL: https://github.com/apache/cloudstack/pull/7887#issuecomment-1695227602 > > > @harikrishna-patnala @DaanHoogland I thought about it again, I think we should not set the vcpu max limit to the minimum cpu cores of host in the cluster. it might be possi

[GitHub] [cloudstack] weizhouapache commented on pull request #7887: xen/xcpng: revert java changes in PR #4672

2023-08-28 Thread via GitHub
weizhouapache commented on PR #7887: URL: https://github.com/apache/cloudstack/pull/7887#issuecomment-1695227895 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [cloudstack] blueorangutan commented on pull request #7887: xen/xcpng: revert java changes in PR #4672

2023-08-28 Thread via GitHub
blueorangutan commented on PR #7887: URL: https://github.com/apache/cloudstack/pull/7887#issuecomment-1695228722 @weizhouapache a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progres

[GitHub] [cloudstack] blueorangutan commented on pull request #7887: xen/xcpng: revert java changes in PR #4672

2023-08-28 Thread via GitHub
blueorangutan commented on PR #7887: URL: https://github.com/apache/cloudstack/pull/7887#issuecomment-1695233981 Packaging result [SF]: :heavy_multiplication_x: el7 :heavy_check_mark: debian. SL-JID 6909 -- This is an automated message from the Apache Git Service. To respond to the messag

[cloudstack] branch dummy updated (eba1a078201 -> 171038eb8ad)

2023-08-28 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch dummy in repository https://gitbox.apache.org/repos/asf/cloudstack.git discard eba1a078201 do not merge add 0dd6bb7c67b systemvm: update size and state of systemvm template during registrati

[GitHub] [cloudstack] blueorangutan commented on pull request #7344: [HEALTH] 4.19/main Health Check, please don't merge this!

2023-08-28 Thread via GitHub
blueorangutan commented on PR #7344: URL: https://github.com/apache/cloudstack/pull/7344#issuecomment-1695262998 @DaanHoogland a [LL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7345: [HEALTH] 4.18 LTS Health Check, please don't merge this!

2023-08-28 Thread via GitHub
sonarcloud[bot] commented on PR #7345: URL: https://github.com/apache/cloudstack/pull/7345#issuecomment-1695268248 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Q

[GitHub] [cloudstack] vladimirpetrov commented on pull request #7752: ObjectStore Framework with MinIO and Simulator plugins

2023-08-28 Thread via GitHub
vladimirpetrov commented on PR #7752: URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1695277767 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [cloudstack] blueorangutan commented on pull request #7752: ObjectStore Framework with MinIO and Simulator plugins

2023-08-28 Thread via GitHub
blueorangutan commented on PR #7752: URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1695281008 @vladimirpetrov a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progre

[GitHub] [cloudstack] weizhouapache commented on pull request #7887: xen/xcpng: revert java changes in PR #4672

2023-08-28 Thread via GitHub
weizhouapache commented on PR #7887: URL: https://github.com/apache/cloudstack/pull/7887#issuecomment-1695283738 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [cloudstack] blueorangutan commented on pull request #7887: xen/xcpng: revert java changes in PR #4672

2023-08-28 Thread via GitHub
blueorangutan commented on PR #7887: URL: https://github.com/apache/cloudstack/pull/7887#issuecomment-1695284176 @weizhouapache a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progres

[GitHub] [cloudstack] blueorangutan commented on pull request #7887: xen/xcpng: revert java changes in PR #4672

2023-08-28 Thread via GitHub
blueorangutan commented on PR #7887: URL: https://github.com/apache/cloudstack/pull/7887#issuecomment-1695303442 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6911 -- This is an auto

[GitHub] [cloudstack] blueorangutan commented on pull request #7752: ObjectStore Framework with MinIO and Simulator plugins

2023-08-28 Thread via GitHub
blueorangutan commented on PR #7752: URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1695303441 Packaging result [SF]: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: el9 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-

[GitHub] [cloudstack] blueorangutan commented on pull request #7887: xen/xcpng: revert java changes in PR #4672

2023-08-28 Thread via GitHub
blueorangutan commented on PR #7887: URL: https://github.com/apache/cloudstack/pull/7887#issuecomment-1695313826 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6913 -- This is an auto

[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7887: xen/xcpng: revert java changes in PR #4672

2023-08-28 Thread via GitHub
weizhouapache commented on code in PR #7887: URL: https://github.com/apache/cloudstack/pull/7887#discussion_r1307160295 ## plugins/hypervisors/xenserver/src/main/java/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java: ## @@ -1338,7 +1338,7 @@ public VM createVmFrom

[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7887: xen/xcpng: revert java changes in PR #4672

2023-08-28 Thread via GitHub
weizhouapache commented on code in PR #7887: URL: https://github.com/apache/cloudstack/pull/7887#discussion_r1307161147 ## plugins/hypervisors/xenserver/src/main/java/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java: ## @@ -1338,7 +1338,7 @@ public VM createVmFrom

[GitHub] [cloudstack] weizhouapache commented on pull request #7887: xen/xcpng: revert java changes in PR #4672

2023-08-28 Thread via GitHub
weizhouapache commented on PR #7887: URL: https://github.com/apache/cloudstack/pull/7887#issuecomment-1695325358 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [cloudstack] blueorangutan commented on pull request #7887: xen/xcpng: revert java changes in PR #4672

2023-08-28 Thread via GitHub
blueorangutan commented on PR #7887: URL: https://github.com/apache/cloudstack/pull/7887#issuecomment-1695326166 @weizhouapache a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progres

[GitHub] [cloudstack] blueorangutan commented on pull request #7887: xen/xcpng: set vmr.VCPUsMax to minimum of global setting and host cpu cores

2023-08-28 Thread via GitHub
blueorangutan commented on PR #7887: URL: https://github.com/apache/cloudstack/pull/7887#issuecomment-1695411291 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6914 -- This is an auto

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7344: [HEALTH] 4.19/main Health Check, please don't merge this!

2023-08-28 Thread via GitHub
sonarcloud[bot] commented on PR #7344: URL: https://github.com/apache/cloudstack/pull/7344#issuecomment-1695412415 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Q

[GitHub] [cloudstack] vishesh92 commented on pull request #7723: Feature: Add support for DRS in a Cluster

2023-08-28 Thread via GitHub
vishesh92 commented on PR #7723: URL: https://github.com/apache/cloudstack/pull/7723#issuecomment-1695421220 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [cloudstack] blueorangutan commented on pull request #7723: Feature: Add support for DRS in a Cluster

2023-08-28 Thread via GitHub
blueorangutan commented on PR #7723: URL: https://github.com/apache/cloudstack/pull/7723#issuecomment-1695423144 @vishesh92 a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[GitHub] [cloudstack] blueorangutan commented on pull request #7723: Feature: Add support for DRS in a Cluster

2023-08-28 Thread via GitHub
blueorangutan commented on PR #7723: URL: https://github.com/apache/cloudstack/pull/7723#issuecomment-1695429979 Packaging result [SF]: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: el9 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-

[GitHub] [cloudstack] vishesh92 commented on pull request #7723: Feature: Add support for DRS in a Cluster

2023-08-28 Thread via GitHub
vishesh92 commented on PR #7723: URL: https://github.com/apache/cloudstack/pull/7723#issuecomment-1695447375 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [cloudstack] blueorangutan commented on pull request #7723: Feature: Add support for DRS in a Cluster

2023-08-28 Thread via GitHub
blueorangutan commented on PR #7723: URL: https://github.com/apache/cloudstack/pull/7723#issuecomment-1695449410 @vishesh92 a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[GitHub] [cloudstack] weizhouapache commented on pull request #7887: xen/xcpng: set vmr.VCPUsMax to minimum of global setting and host cpu cores

2023-08-28 Thread via GitHub
weizhouapache commented on PR #7887: URL: https://github.com/apache/cloudstack/pull/7887#issuecomment-1695461117 @blueorangutan test rocky8 xenserver-71 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [cloudstack] weizhouapache commented on pull request #7887: xen/xcpng: set vmr.VCPUsMax to minimum of global setting and host cpu cores

2023-08-28 Thread via GitHub
weizhouapache commented on PR #7887: URL: https://github.com/apache/cloudstack/pull/7887#issuecomment-1695526689 @DaanHoogland @harikrishna-patnala @shwstppr I have manually tested ok - The env have 2 hosts (3 sockets, 1 cpu per socket) ``` MariaDB [cloud]> select cpus,cpu_so

[GitHub] [cloudstack] weizhouapache commented on pull request #7887: xen/xcpng: set vmr.VCPUsMax to minimum of global setting and host cpu cores

2023-08-28 Thread via GitHub
weizhouapache commented on PR #7887: URL: https://github.com/apache/cloudstack/pull/7887#issuecomment-1695527445 @blueorangutan test rocky8 xenserver-71 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [cloudstack] DaanHoogland opened a new pull request, #7915: ldap trust map cleanup on domain delete

2023-08-28 Thread via GitHub
DaanHoogland opened a new pull request, #7915: URL: https://github.com/apache/cloudstack/pull/7915 ### Description This PR... Fixes: #6752 ### Types of changes - [ ] Breaking change (fix or feature that would cause exist

[GitHub] [cloudstack] blueorangutan commented on pull request #7723: Feature: Add support for DRS in a Cluster

2023-08-28 Thread via GitHub
blueorangutan commented on PR #7723: URL: https://github.com/apache/cloudstack/pull/7723#issuecomment-1695528874 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6916 -- This is an auto

[GitHub] [cloudstack] soreana commented on pull request #6812: Normalize encryption on global configurations values

2023-08-28 Thread via GitHub
soreana commented on PR #6812: URL: https://github.com/apache/cloudstack/pull/6812#issuecomment-1695530354 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [cloudstack] blueorangutan commented on pull request #6812: Normalize encryption on global configurations values

2023-08-28 Thread via GitHub
blueorangutan commented on PR #6812: URL: https://github.com/apache/cloudstack/pull/6812#issuecomment-1695533122 @soreana a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -

[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7915: ldap trust map cleanup on domain delete

2023-08-28 Thread via GitHub
weizhouapache commented on code in PR #7915: URL: https://github.com/apache/cloudstack/pull/7915#discussion_r1307311223 ## server/src/main/java/com/cloud/user/AccountManagerImpl.java: ## @@ -1847,6 +1832,29 @@ public boolean deleteUserAccount(long accountId) { return de

[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7915: ldap trust map cleanup on domain delete

2023-08-28 Thread via GitHub
DaanHoogland commented on code in PR #7915: URL: https://github.com/apache/cloudstack/pull/7915#discussion_r1307314820 ## plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/LdapManagerImpl.java: ## @@ -125,10 +134,28 @@ public void onPublishMessage(String

[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7915: ldap trust map cleanup on domain delete

2023-08-28 Thread via GitHub
DaanHoogland commented on code in PR #7915: URL: https://github.com/apache/cloudstack/pull/7915#discussion_r1307317754 ## server/src/main/java/com/cloud/user/AccountManagerImpl.java: ## @@ -1847,6 +1832,29 @@ public boolean deleteUserAccount(long accountId) { return del

[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7915: ldap trust map cleanup on domain delete

2023-08-28 Thread via GitHub
weizhouapache commented on code in PR #7915: URL: https://github.com/apache/cloudstack/pull/7915#discussion_r1307318745 ## plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/LdapManagerImpl.java: ## @@ -125,10 +134,28 @@ public void onPublishMessage(String

[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7915: ldap trust map cleanup on domain delete

2023-08-28 Thread via GitHub
weizhouapache commented on code in PR #7915: URL: https://github.com/apache/cloudstack/pull/7915#discussion_r1307318745 ## plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/LdapManagerImpl.java: ## @@ -125,10 +134,28 @@ public void onPublishMessage(String

[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7915: ldap trust map cleanup on domain delete

2023-08-28 Thread via GitHub
DaanHoogland commented on code in PR #7915: URL: https://github.com/apache/cloudstack/pull/7915#discussion_r1307314820 ## plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/LdapManagerImpl.java: ## @@ -125,10 +134,28 @@ public void onPublishMessage(String

[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7915: ldap trust map cleanup on domain delete

2023-08-28 Thread via GitHub
weizhouapache commented on code in PR #7915: URL: https://github.com/apache/cloudstack/pull/7915#discussion_r1307319564 ## server/src/main/java/com/cloud/user/AccountManagerImpl.java: ## @@ -1847,6 +1832,29 @@ public boolean deleteUserAccount(long accountId) { return de

[GitHub] [cloudstack] kiranchavala opened a new issue, #7916: Support separate compute offering for kubernetes nodes (Master and Worker nodes)

2023-08-28 Thread via GitHub
kiranchavala opened a new issue, #7916: URL: https://github.com/apache/cloudstack/issues/7916 ISSUE TYPE * Improvement Request * Enhancement Request COMPONENT NAME Compnent: Kubernetes CLOUDSTACK VERSION Cloudstack version 4.18

[GitHub] [cloudstack] kiranchavala opened a new issue, #7917: Egress rules present in a network are not getting applied to a kubernetes cluster

2023-08-28 Thread via GitHub
kiranchavala opened a new issue, #7917: URL: https://github.com/apache/cloudstack/issues/7917 ISSUE TYPE * BUG Report COMPONENT NAME Component: Kubernetes CLOUDSTACK VERSION Cloudstack version 4.18 SUMMARY Egress rules pr

[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7915: ldap trust map cleanup on domain delete

2023-08-28 Thread via GitHub
DaanHoogland commented on code in PR #7915: URL: https://github.com/apache/cloudstack/pull/7915#discussion_r1307343364 ## server/src/main/java/com/cloud/user/AccountManagerImpl.java: ## @@ -1847,6 +1832,29 @@ public boolean deleteUserAccount(long accountId) { return del

[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7915: ldap trust map cleanup on domain delete

2023-08-28 Thread via GitHub
DaanHoogland commented on code in PR #7915: URL: https://github.com/apache/cloudstack/pull/7915#discussion_r1307345239 ## plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/LdapManagerImpl.java: ## @@ -125,10 +134,28 @@ public void onPublishMessage(String

[GitHub] [cloudstack] kiranchavala commented on issue #7917: Egress rules present in a network are not getting applied to a kubernetes cluster

2023-08-28 Thread via GitHub
kiranchavala commented on issue #7917: URL: https://github.com/apache/cloudstack/issues/7917#issuecomment-1695591976 The issue will not occur, if you delete the application and reapply the egress rule by allowing the TCP traffic 1. kubectl delete deployment nginx-deployment 2

[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7915: ldap trust map cleanup on domain delete

2023-08-28 Thread via GitHub
weizhouapache commented on code in PR #7915: URL: https://github.com/apache/cloudstack/pull/7915#discussion_r1307348720 ## server/src/main/java/com/cloud/user/AccountManagerImpl.java: ## @@ -1847,6 +1832,29 @@ public boolean deleteUserAccount(long accountId) { return de

[GitHub] [cloudstack] weizhouapache commented on issue #7917: Egress rules present in a network are not getting applied to a kubernetes cluster

2023-08-28 Thread via GitHub
weizhouapache commented on issue #7917: URL: https://github.com/apache/cloudstack/issues/7917#issuecomment-1695598396 yes, @kiranchavala with the egress rule you added, all outgoing traffic will be blocked ![image](https://github.com/apache/cloudstack/assets/57355700/a23ccbe5-4c73

[GitHub] [cloudstack] weizhouapache closed issue #7917: Egress rules present in a network are not getting applied to a kubernetes cluster

2023-08-28 Thread via GitHub
weizhouapache closed issue #7917: Egress rules present in a network are not getting applied to a kubernetes cluster URL: https://github.com/apache/cloudstack/issues/7917 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [cloudstack] blueorangutan commented on pull request #6812: Normalize encryption on global configurations values

2023-08-28 Thread via GitHub
blueorangutan commented on PR #6812: URL: https://github.com/apache/cloudstack/pull/6812#issuecomment-1695605128 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6917 -- This is an auto

[GitHub] [cloudstack] DaanHoogland commented on pull request #7887: xen/xcpng: set vmr.VCPUsMax to minimum of global setting and host cpu cores

2023-08-28 Thread via GitHub
DaanHoogland commented on PR #7887: URL: https://github.com/apache/cloudstack/pull/7887#issuecomment-1695607184 reproduced and validated :+1: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] DaanHoogland merged pull request #7887: xen/xcpng: set vmr.VCPUsMax to minimum of global setting and host cpu cores

2023-08-28 Thread via GitHub
DaanHoogland merged PR #7887: URL: https://github.com/apache/cloudstack/pull/7887 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cl

[cloudstack] branch 4.18 updated: xen/xcpng: set vmr.VCPUsMax to minimum of global setting and host cpu cores (#7887)

2023-08-28 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch 4.18 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.18 by this push: new 439d70fd2b9 xen/xcpng: set vmr.VCPUsMax to minimum

[cloudstack] branch main updated (7362e5338c9 -> 40d7da6707d)

2023-08-28 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 7362e5338c9 Merge remote-tracking branch 'origin/4.18' add 439d70fd2b9 xen/xcpng: set vmr.VCPUsMax to minimum of

[cloudstack] 01/01: Merge release branch 4.18 to main

2023-08-28 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit 40d7da6707de5a0affb56f86c7bd97693460a8a7 Merge: 7362e5338c9 439d70fd2b9 Author: Daan Hoogland AuthorDate: Mon Aug 28 14:

[cloudstack] branch 6778-if-kafka-is-turned-on-internal-subs-dont-work created (now 40d7da6707d)

2023-08-28 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch 6778-if-kafka-is-turned-on-internal-subs-dont-work in repository https://gitbox.apache.org/repos/asf/cloudstack.git at 40d7da6707d Merge release branch 4.18 to main No new revisions were ad

[GitHub] [cloudstack] GaOrtiga commented on pull request #7416: remove supportedOwner from Resource.ResourceType

2023-08-28 Thread via GitHub
GaOrtiga commented on PR #7416: URL: https://github.com/apache/cloudstack/pull/7416#issuecomment-1695705197 @GutoVeronezi @weizhouapache Could you guys review this one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [cloudstack] DaanHoogland commented on pull request #6738: Disable logging of conntrack stats traffic

2023-08-28 Thread via GitHub
DaanHoogland commented on PR #6738: URL: https://github.com/apache/cloudstack/pull/6738#issuecomment-1695712768 Are you still looking at this @shawniverson ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [cloudstack] weizhouapache commented on pull request #7915: ldap trust map cleanup on domain delete

2023-08-28 Thread via GitHub
weizhouapache commented on PR #7915: URL: https://github.com/apache/cloudstack/pull/7915#issuecomment-1695735671 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [cloudstack] blueorangutan commented on pull request #7915: ldap trust map cleanup on domain delete

2023-08-28 Thread via GitHub
blueorangutan commented on PR #7915: URL: https://github.com/apache/cloudstack/pull/7915#issuecomment-1695737409 @weizhouapache a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progres

[GitHub] [cloudstack] codecov[bot] commented on pull request #7915: ldap trust map cleanup on domain delete

2023-08-28 Thread via GitHub
codecov[bot] commented on PR #7915: URL: https://github.com/apache/cloudstack/pull/7915#issuecomment-1695755331 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/7915?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)

[GitHub] [cloudstack] weizhouapache commented on pull request #7416: remove supportedOwner from Resource.ResourceType

2023-08-28 Thread via GitHub
weizhouapache commented on PR #7416: URL: https://github.com/apache/cloudstack/pull/7416#issuecomment-1695758895 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [cloudstack] weizhouapache commented on pull request #7915: ldap trust map cleanup on domain delete

2023-08-28 Thread via GitHub
weizhouapache commented on PR #7915: URL: https://github.com/apache/cloudstack/pull/7915#issuecomment-1695759903 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [cloudstack] blueorangutan commented on pull request #7915: ldap trust map cleanup on domain delete

2023-08-28 Thread via GitHub
blueorangutan commented on PR #7915: URL: https://github.com/apache/cloudstack/pull/7915#issuecomment-1695760321 @weizhouapache a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progres

[GitHub] [cloudstack] blueorangutan commented on pull request #7416: remove supportedOwner from Resource.ResourceType

2023-08-28 Thread via GitHub
blueorangutan commented on PR #7416: URL: https://github.com/apache/cloudstack/pull/7416#issuecomment-1695760382 @weizhouapache a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progres

[GitHub] [cloudstack] mlsorensen commented on issue #6778: If Kafka is turned on internal subs dont work

2023-08-28 Thread via GitHub
mlsorensen commented on issue #6778: URL: https://github.com/apache/cloudstack/issues/6778#issuecomment-1695772628 @DaanHoogland - No, I haven't done anything other than identify the issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7915: ldap trust map cleanup on domain delete

2023-08-28 Thread via GitHub
weizhouapache commented on code in PR #7915: URL: https://github.com/apache/cloudstack/pull/7915#discussion_r1307483032 ## plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/LdapManagerImpl.java: ## @@ -125,10 +135,28 @@ public void onPublishMessage(String

[GitHub] [cloudstack] weizhouapache commented on pull request #7915: ldap trust map cleanup on domain delete

2023-08-28 Thread via GitHub
weizhouapache commented on PR #7915: URL: https://github.com/apache/cloudstack/pull/7915#issuecomment-1695783762 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [cloudstack] blueorangutan commented on pull request #7915: ldap trust map cleanup on domain delete

2023-08-28 Thread via GitHub
blueorangutan commented on PR #7915: URL: https://github.com/apache/cloudstack/pull/7915#issuecomment-1695787483 @weizhouapache a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progres

[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7915: ldap trust map cleanup on domain delete

2023-08-28 Thread via GitHub
weizhouapache commented on code in PR #7915: URL: https://github.com/apache/cloudstack/pull/7915#discussion_r1307493184 ## plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/LdapManagerImpl.java: ## @@ -27,7 +27,9 @@ import java.util.Map; import java.uti

[GitHub] [cloudstack] weizhouapache commented on pull request #7915: ldap trust map cleanup on domain delete

2023-08-28 Thread via GitHub
weizhouapache commented on PR #7915: URL: https://github.com/apache/cloudstack/pull/7915#issuecomment-1695790063 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [cloudstack] blueorangutan commented on pull request #7915: ldap trust map cleanup on domain delete

2023-08-28 Thread via GitHub
blueorangutan commented on PR #7915: URL: https://github.com/apache/cloudstack/pull/7915#issuecomment-1695791261 @weizhouapache a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progres

[GitHub] [cloudstack] weizhouapache commented on pull request #7915: ldap trust map cleanup on domain delete

2023-08-28 Thread via GitHub
weizhouapache commented on PR #7915: URL: https://github.com/apache/cloudstack/pull/7915#issuecomment-1695802401 verified OK before domain removal (some mock data) ``` MariaDB [cloud]> select * from ldap_trust_map; ++---+--+--+--

[GitHub] [cloudstack] blueorangutan commented on pull request #7915: ldap trust map cleanup on domain delete

2023-08-28 Thread via GitHub
blueorangutan commented on PR #7915: URL: https://github.com/apache/cloudstack/pull/7915#issuecomment-1695840262 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6918 -- This is an auto

[GitHub] [cloudstack] nvazquez commented on a diff in pull request #7915: ldap trust map cleanup on domain delete

2023-08-28 Thread via GitHub
nvazquez commented on code in PR #7915: URL: https://github.com/apache/cloudstack/pull/7915#discussion_r1307535660 ## plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/LdapManagerImpl.java: ## @@ -115,7 +124,7 @@ public void onPublishMessage(String sender

[GitHub] [cloudstack] blueorangutan commented on pull request #7915: ldap trust map cleanup on domain delete

2023-08-28 Thread via GitHub
blueorangutan commented on PR #7915: URL: https://github.com/apache/cloudstack/pull/7915#issuecomment-1695865931 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6919 -- This is an auto

[GitHub] [cloudstack] blueorangutan commented on pull request #7416: remove supportedOwner from Resource.ResourceType

2023-08-28 Thread via GitHub
blueorangutan commented on PR #7416: URL: https://github.com/apache/cloudstack/pull/7416#issuecomment-1695865932 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6920 -- This is an auto

[GitHub] [cloudstack] weizhouapache commented on pull request #7416: remove supportedOwner from Resource.ResourceType

2023-08-28 Thread via GitHub
weizhouapache commented on PR #7416: URL: https://github.com/apache/cloudstack/pull/7416#issuecomment-1695867492 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [cloudstack] blueorangutan commented on pull request #7416: remove supportedOwner from Resource.ResourceType

2023-08-28 Thread via GitHub
blueorangutan commented on PR #7416: URL: https://github.com/apache/cloudstack/pull/7416#issuecomment-1695868453 @weizhouapache a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] weizhouapache opened a new issue, #7918: [4.19] UserData must have a header

2023-08-28 Thread via GitHub
weizhouapache opened a new issue, #7918: URL: https://github.com/apache/cloudstack/issues/7918 With #7643 , userdata must have a header, a plain text cannot be used as userdata any more. This breaks backward compatibility while in elder versions userdata can be any string. # I

[GitHub] [cloudstack] weizhouapache commented on pull request #7915: ldap trust map cleanup on domain delete

2023-08-28 Thread via GitHub
weizhouapache commented on PR #7915: URL: https://github.com/apache/cloudstack/pull/7915#issuecomment-1695884534 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [cloudstack] blueorangutan commented on pull request #7915: ldap trust map cleanup on domain delete

2023-08-28 Thread via GitHub
blueorangutan commented on PR #7915: URL: https://github.com/apache/cloudstack/pull/7915#issuecomment-1695884896 @weizhouapache a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] blueorangutan commented on pull request #7915: ldap trust map cleanup on domain delete

2023-08-28 Thread via GitHub
blueorangutan commented on PR #7915: URL: https://github.com/apache/cloudstack/pull/7915#issuecomment-1695887484 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6922 -- This is an auto

[GitHub] [cloudstack] blueorangutan commented on pull request #7915: ldap trust map cleanup on domain delete

2023-08-28 Thread via GitHub
blueorangutan commented on PR #7915: URL: https://github.com/apache/cloudstack/pull/7915#issuecomment-1695887493 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6921 -- This is an auto

[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7915: ldap trust map cleanup on domain delete

2023-08-28 Thread via GitHub
DaanHoogland commented on code in PR #7915: URL: https://github.com/apache/cloudstack/pull/7915#discussion_r1307574986 ## plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/LdapManagerImpl.java: ## @@ -65,6 +66,7 @@ @Component public class LdapManagerImp

[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7915: ldap trust map cleanup on domain delete

2023-08-28 Thread via GitHub
DaanHoogland commented on code in PR #7915: URL: https://github.com/apache/cloudstack/pull/7915#discussion_r1307576891 ## plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/LdapManagerImpl.java: ## @@ -115,7 +124,7 @@ public void onPublishMessage(String se

[GitHub] [cloudstack] nvazquez commented on a diff in pull request #7915: ldap trust map cleanup on domain delete

2023-08-28 Thread via GitHub
nvazquez commented on code in PR #7915: URL: https://github.com/apache/cloudstack/pull/7915#discussion_r1307586265 ## plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/LdapManagerImpl.java: ## @@ -65,6 +66,7 @@ @Component public class LdapManagerImpl ex

[GitHub] [cloudstack] weizhouapache commented on pull request #7915: ldap trust map cleanup on domain delete

2023-08-28 Thread via GitHub
weizhouapache commented on PR #7915: URL: https://github.com/apache/cloudstack/pull/7915#issuecomment-1695936048 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

  1   2   >