[GitHub] [cloudstack] blueorangutan commented on pull request #7609: ui: fix notification list reordering intermittently

2023-08-24 Thread via GitHub
blueorangutan commented on PR #7609: URL: https://github.com/apache/cloudstack/pull/7609#issuecomment-1691118526 UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/7609 (QA-JID-166) -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7898: server: allow user to list available IPs on shared networks

2023-08-24 Thread via GitHub
rohityadavcloud commented on PR #7898: URL: https://github.com/apache/cloudstack/pull/7898#issuecomment-1691170612 Excellent thanks @weizhouapache let's go ahead and merge this once it meets enought reviews; cc @DaanHoogland -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7761: vmware: improve solidfire storage plugin integration and fix cases

2023-08-24 Thread via GitHub
rohityadavcloud commented on PR #7761: URL: https://github.com/apache/cloudstack/pull/7761#issuecomment-1691173883 @NuxRo completed QA on this, against a community-supplied 4.17 Solidfire env (before he went on holidays). Now with @andrijapanicsb to finalise review. Thanks. @blueoran

[GitHub] [cloudstack] blueorangutan commented on pull request #7761: vmware: improve solidfire storage plugin integration and fix cases

2023-08-24 Thread via GitHub
blueorangutan commented on PR #7761: URL: https://github.com/apache/cloudstack/pull/7761#issuecomment-1691176134 @rohityadavcloud a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progr

[GitHub] [cloudstack] DaanHoogland commented on pull request #7892: Fix listLoadBalancerRuleInstances api call

2023-08-24 Thread via GitHub
DaanHoogland commented on PR #7892: URL: https://github.com/apache/cloudstack/pull/7892#issuecomment-1691185429 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [cloudstack] harikrishna-patnala commented on pull request #7225: [Veeam] Don't interrupt backup syncronization

2023-08-24 Thread via GitHub
harikrishna-patnala commented on PR #7225: URL: https://github.com/apache/cloudstack/pull/7225#issuecomment-1691186466 @blueorangutan test rocky8 vmware-70u3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [cloudstack] blueorangutan commented on pull request #7892: Fix listLoadBalancerRuleInstances api call

2023-08-24 Thread via GitHub
blueorangutan commented on PR #7892: URL: https://github.com/apache/cloudstack/pull/7892#issuecomment-1691187740 @DaanHoogland a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To r

[GitHub] [cloudstack] blueorangutan commented on pull request #7225: [Veeam] Don't interrupt backup syncronization

2023-08-24 Thread via GitHub
blueorangutan commented on PR #7225: URL: https://github.com/apache/cloudstack/pull/7225#issuecomment-1691187670 @harikrishna-patnala a [SF] Trillian-Jenkins test job (rocky8 mgmt + vmware-70u3) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service

[GitHub] [cloudstack] weizhouapache merged pull request #7900: UI: Add central project store and watch functionality

2023-08-24 Thread via GitHub
weizhouapache merged PR #7900: URL: https://github.com/apache/cloudstack/pull/7900 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@c

[cloudstack] branch 4.18 updated: UI: Add central project store and watch functionality (#7900)

2023-08-24 Thread weizhou
This is an automated email from the ASF dual-hosted git repository. weizhou pushed a commit to branch 4.18 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.18 by this push: new 2e1c2821a82 UI: Add central project store and w

[GitHub] [cloudstack] weizhouapache closed issue #7181: New project shown as -1

2023-08-24 Thread via GitHub
weizhouapache closed issue #7181: New project shown as -1 URL: https://github.com/apache/cloudstack/issues/7181 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[cloudstack] branch 4.18-dummy updated (dd0d05a6bbf -> 6c484c79997)

2023-08-24 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch 4.18-dummy in repository https://gitbox.apache.org/repos/asf/cloudstack.git discard dd0d05a6bbf don't merge add 6cded7e0102 Support GNU sed apidoc for MacOS build (#7888) add 405ef82aefd

[GitHub] [cloudstack] weizhouapache commented on pull request #7239: [Veeam] Fix restore of reimported VMs

2023-08-24 Thread via GitHub
weizhouapache commented on PR #7239: URL: https://github.com/apache/cloudstack/pull/7239#issuecomment-1691235028 moved to 4.19.0.0 as the target branch is `main` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [cloudstack] weizhouapache commented on pull request #7082: allow filtering of listDiskOffering and listServiceOffering APIs by account or project

2023-08-24 Thread via GitHub
weizhouapache commented on PR #7082: URL: https://github.com/apache/cloudstack/pull/7082#issuecomment-1691235928 moved to 4.18.2.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [cloudstack] weizhouapache commented on pull request #7878: Publish event for VM.STOP when out of band stop is detected

2023-08-24 Thread via GitHub
weizhouapache commented on PR #7878: URL: https://github.com/apache/cloudstack/pull/7878#issuecomment-1691236525 moved to 4.18.2.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [cloudstack] weizhouapache commented on pull request #7650: CKS: add ConfigDrive to cloud-init datasource_list in systemvm template

2023-08-24 Thread via GitHub
weizhouapache commented on PR #7650: URL: https://github.com/apache/cloudstack/pull/7650#issuecomment-1691239815 moved to 4.18.2.0 as it needs more work -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [cloudstack] blueorangutan commented on pull request #7761: vmware: improve solidfire storage plugin integration and fix cases

2023-08-24 Thread via GitHub
blueorangutan commented on PR #7761: URL: https://github.com/apache/cloudstack/pull/7761#issuecomment-169125 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6877 -- This is an auto

[GitHub] [cloudstack] weizhouapache commented on pull request #7880: Don't allow inadvertent deletion of hidden details via API

2023-08-24 Thread via GitHub
weizhouapache commented on PR #7880: URL: https://github.com/apache/cloudstack/pull/7880#issuecomment-1691267793 tested on a xcpng environment, the hidden vm setting is still there before vm setting change ``` mysql> select * from user_vm_details where vm_id=22;

[GitHub] [cloudstack] weizhouapache merged pull request #7880: Don't allow inadvertent deletion of hidden details via API

2023-08-24 Thread via GitHub
weizhouapache merged PR #7880: URL: https://github.com/apache/cloudstack/pull/7880 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@c

[cloudstack] branch 4.18 updated (2e1c2821a82 -> a0702279aae)

2023-08-24 Thread weizhou
This is an automated email from the ASF dual-hosted git repository. weizhou pushed a change to branch 4.18 in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 2e1c2821a82 UI: Add central project store and watch functionality (#7900) add a0702279aae server Don't allow

[GitHub] [cloudstack] weizhouapache commented on pull request #7761: vmware: improve solidfire storage plugin integration and fix cases

2023-08-24 Thread via GitHub
weizhouapache commented on PR #7761: URL: https://github.com/apache/cloudstack/pull/7761#issuecomment-1691273489 @blueorangutan test rocky8 vmware-67u3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [cloudstack] blueorangutan commented on pull request #7761: vmware: improve solidfire storage plugin integration and fix cases

2023-08-24 Thread via GitHub
blueorangutan commented on PR #7761: URL: https://github.com/apache/cloudstack/pull/7761#issuecomment-1691275661 @weizhouapache a [SF] Trillian-Jenkins test job (rocky8 mgmt + vmware-67u3) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To r

[GitHub] [cloudstack] DaanHoogland commented on pull request #7606: vm-import: fix stopped managed vms listing in unmanaged instances

2023-08-24 Thread via GitHub
DaanHoogland commented on PR #7606: URL: https://github.com/apache/cloudstack/pull/7606#issuecomment-1691309660 @shwstppr still a little snag (I don't know if you already gave that attention) ![image](https://github.com/apache/cloudstack/assets/2486961/1e1a1c19-cebe-4455-bb86-0d71c7c2365

[GitHub] [cloudstack] weizhouapache opened a new issue, #7902: Failed to attach iso to VM with ConfigDrive on xen/xcpng

2023-08-24 Thread via GitHub
weizhouapache opened a new issue, #7902: URL: https://github.com/apache/cloudstack/issues/7902 Steps to reproduce the issue - create network offering with userdata=ConfigDrive - create a network - create a vm on the new network - attach an ISO to the VM The issue is because

[GitHub] [cloudstack] weizhouapache commented on pull request #7761: vmware: improve solidfire storage plugin integration and fix cases

2023-08-24 Thread via GitHub
weizhouapache commented on PR #7761: URL: https://github.com/apache/cloudstack/pull/7761#issuecomment-1691314201 @blueorangutan test ubuntu22 vmware-70u3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [cloudstack] blueorangutan commented on pull request #7761: vmware: improve solidfire storage plugin integration and fix cases

2023-08-24 Thread via GitHub
blueorangutan commented on PR #7761: URL: https://github.com/apache/cloudstack/pull/7761#issuecomment-1691316723 @weizhouapache [SF] unsupported parameters provided. Supported mgmt server os are: `centos7, centos6, suse15, alma8, ubuntu18, ubuntu22, ubuntu20, rocky8, alma9`. Supported hyper

[GitHub] [cloudstack] DaanHoogland commented on pull request #7609: ui: fix notification list reordering intermittently

2023-08-24 Thread via GitHub
DaanHoogland commented on PR #7609: URL: https://github.com/apache/cloudstack/pull/7609#issuecomment-1691337686 so merging and let's deal with other issues separately -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [cloudstack] DaanHoogland merged pull request #7609: ui: fix notification list reordering intermittently

2023-08-24 Thread via GitHub
DaanHoogland merged PR #7609: URL: https://github.com/apache/cloudstack/pull/7609 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cl

[cloudstack] branch 4.18 updated: ui: fix notification list reordering intermittently (#7609)

2023-08-24 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch 4.18 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.18 by this push: new 8ad1009ad2d ui: fix notification list reordering i

[GitHub] [cloudstack] weizhouapache commented on pull request #7761: vmware: improve solidfire storage plugin integration and fix cases

2023-08-24 Thread via GitHub
weizhouapache commented on PR #7761: URL: https://github.com/apache/cloudstack/pull/7761#issuecomment-1691340148 @blueorangutan test rocky8 vmware-70u3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [cloudstack] blueorangutan commented on pull request #7761: vmware: improve solidfire storage plugin integration and fix cases

2023-08-24 Thread via GitHub
blueorangutan commented on PR #7761: URL: https://github.com/apache/cloudstack/pull/7761#issuecomment-1691342427 @weizhouapache a [SF] Trillian-Jenkins test job (rocky8 mgmt + vmware-70u3) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To r

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7345: [HEALTH] 4.18 LTS Health Check, please don't merge this!

2023-08-24 Thread via GitHub
sonarcloud[bot] commented on PR #7345: URL: https://github.com/apache/cloudstack/pull/7345#issuecomment-1691346432 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Q

[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7898: server: allow user to list available IPs on shared networks

2023-08-24 Thread via GitHub
DaanHoogland commented on code in PR #7898: URL: https://github.com/apache/cloudstack/pull/7898#discussion_r1304070684 ## server/src/main/java/com/cloud/server/ManagementServerImpl.java: ## @@ -2475,7 +2476,20 @@ public Pair, Integer> searchForIPAddresses(final ListP

[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7898: server: allow user to list available IPs on shared networks

2023-08-24 Thread via GitHub
weizhouapache commented on code in PR #7898: URL: https://github.com/apache/cloudstack/pull/7898#discussion_r1304126696 ## server/src/main/java/com/cloud/server/ManagementServerImpl.java: ## @@ -2475,7 +2476,20 @@ public Pair, Integer> searchForIPAddresses(final ListP

[cloudstack] branch nsx-integration updated: add NSX resource , api client, create tier1 gw

2023-08-24 Thread pearl11594
This is an automated email from the ASF dual-hosted git repository. pearl11594 pushed a commit to branch nsx-integration in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/nsx-integration by this push: new e0244e2f56c add NSX re

[GitHub] [cloudstack] vishesh92 opened a new pull request, #7903: Fix testReplugNic unit test

2023-08-24 Thread via GitHub
vishesh92 opened a new pull request, #7903: URL: https://github.com/apache/cloudstack/pull/7903 ### Description This PR... ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionali

[cloudstack] branch dummy updated (0e6a3f7a074 -> 593aecd8933)

2023-08-24 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch dummy in repository https://gitbox.apache.org/repos/asf/cloudstack.git discard 0e6a3f7a074 do not merge add b37834fe759 ui: bump UI pkg version to match CloudStacks (#7894) add 7cdf864c7

[GitHub] [cloudstack] blueorangutan commented on pull request #7344: [HEALTH] 4.19/main Health Check, please don't merge this!

2023-08-24 Thread via GitHub
blueorangutan commented on PR #7344: URL: https://github.com/apache/cloudstack/pull/7344#issuecomment-1691443315 @DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress

[cloudstack] branch 4.19-fix-kvm-LibvirtReplugNicCommandWrapperTest created (now e24716077ca)

2023-08-24 Thread weizhou
This is an automated email from the ASF dual-hosted git repository. weizhou pushed a change to branch 4.19-fix-kvm-LibvirtReplugNicCommandWrapperTest in repository https://gitbox.apache.org/repos/asf/cloudstack.git at e24716077ca kvm: fix unit test LibvirtReplugNicCommandWrapperTest This

[cloudstack] 01/01: kvm: fix unit test LibvirtReplugNicCommandWrapperTest

2023-08-24 Thread weizhou
This is an automated email from the ASF dual-hosted git repository. weizhou pushed a commit to branch 4.19-fix-kvm-LibvirtReplugNicCommandWrapperTest in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit e24716077ca803ea393f8985517b76562f25e68c Author: Wei Zhou AuthorDate: Thu

[GitHub] [cloudstack] blueorangutan commented on pull request #7344: [HEALTH] 4.19/main Health Check, please don't merge this!

2023-08-24 Thread via GitHub
blueorangutan commented on PR #7344: URL: https://github.com/apache/cloudstack/pull/7344#issuecomment-1691445767 @DaanHoogland a [LL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress

[GitHub] [cloudstack] vishesh92 closed pull request #7903: Fix testReplugNic unit test

2023-08-24 Thread via GitHub
vishesh92 closed pull request #7903: Fix testReplugNic unit test URL: https://github.com/apache/cloudstack/pull/7903 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[GitHub] [cloudstack] vishesh92 closed pull request #7903: Fix testReplugNic unit test

2023-08-24 Thread via GitHub
vishesh92 closed pull request #7903: Fix testReplugNic unit test URL: https://github.com/apache/cloudstack/pull/7903 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[GitHub] [cloudstack] vishesh92 opened a new pull request, #7904: Fix tungsten unit test

2023-08-24 Thread via GitHub
vishesh92 opened a new pull request, #7904: URL: https://github.com/apache/cloudstack/pull/7904 ### Description This PR... ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionali

[GitHub] [cloudstack] vishesh92 commented on pull request #7904: Fix tungsten unit test

2023-08-24 Thread via GitHub
vishesh92 commented on PR #7904: URL: https://github.com/apache/cloudstack/pull/7904#issuecomment-1691483183 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [cloudstack] blueorangutan commented on pull request #7904: Fix tungsten unit test

2023-08-24 Thread via GitHub
blueorangutan commented on PR #7904: URL: https://github.com/apache/cloudstack/pull/7904#issuecomment-1691485424 @vishesh92 a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7898: server: allow user to list available IPs on shared networks

2023-08-24 Thread via GitHub
DaanHoogland commented on code in PR #7898: URL: https://github.com/apache/cloudstack/pull/7898#discussion_r1304185351 ## server/src/main/java/com/cloud/server/ManagementServerImpl.java: ## @@ -2475,7 +2476,20 @@ public Pair, Integer> searchForIPAddresses(final ListP

[GitHub] [cloudstack] DaanHoogland opened a new pull request, #7905: Revert "Remove powermock from services (#7860)"

2023-08-24 Thread via GitHub
DaanHoogland opened a new pull request, #7905: URL: https://github.com/apache/cloudstack/pull/7905 This reverts commit fe70f4d801c39776d5e1dbd262247cd159b2cb04. ### Description This PR... ### Types of changes - [

[GitHub] [cloudstack] blueorangutan commented on pull request #7904: Fix tungsten unit test

2023-08-24 Thread via GitHub
blueorangutan commented on PR #7904: URL: https://github.com/apache/cloudstack/pull/7904#issuecomment-1691556464 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6879 -- This is an auto

[GitHub] [cloudstack] DaanHoogland opened a new pull request, #7906: try different reverts to get main back on track

2023-08-24 Thread via GitHub
DaanHoogland opened a new pull request, #7906: URL: https://github.com/apache/cloudstack/pull/7906 …ys (#7805)" This reverts commit 0b4afedb5b52a5ba7747eb17169cc856eb9a9459. ### Description This PR... ### Types of

[GitHub] [cloudstack] DaanHoogland closed pull request #7905: Revert "Remove powermock from services (#7860)"

2023-08-24 Thread via GitHub
DaanHoogland closed pull request #7905: Revert "Remove powermock from services (#7860)" URL: https://github.com/apache/cloudstack/pull/7905 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[cloudstack] branch 4.19-fix-kvm-LibvirtReplugNicCommandWrapperTest updated (e24716077ca -> 631615314a2)

2023-08-24 Thread weizhou
This is an automated email from the ASF dual-hosted git repository. weizhou pushed a change to branch 4.19-fix-kvm-LibvirtReplugNicCommandWrapperTest in repository https://gitbox.apache.org/repos/asf/cloudstack.git discard e24716077ca kvm: fix unit test LibvirtReplugNicCommandWrapperTest

[cloudstack] 01/01: kvm: add debug msg

2023-08-24 Thread weizhou
This is an automated email from the ASF dual-hosted git repository. weizhou pushed a commit to branch 4.19-fix-kvm-LibvirtReplugNicCommandWrapperTest in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit 631615314a22f7f0e982c215697acadc43ddf9b1 Author: Wei Zhou AuthorDate: Thu

[GitHub] [cloudstack] weizhouapache commented on pull request #7545: updated the api documentation for createNetworkOffering and updateNetworkOffering

2023-08-24 Thread via GitHub
weizhouapache commented on PR #7545: URL: https://github.com/apache/cloudstack/pull/7545#issuecomment-1691635751 moved to 4.18.2.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [cloudstack] weizhouapache commented on pull request #6812: Normalize encryption on global configurations values

2023-08-24 Thread via GitHub
weizhouapache commented on PR #6812: URL: https://github.com/apache/cloudstack/pull/6812#issuecomment-1691637357 @BryanMLima can you fix the conflicts ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [cloudstack] nvazquez commented on pull request #7904: Fix tungsten unit test

2023-08-24 Thread via GitHub
nvazquez commented on PR #7904: URL: https://github.com/apache/cloudstack/pull/7904#issuecomment-1691641808 Merging after approvals and packages built, no need to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [cloudstack] nvazquez merged pull request #7904: Fix tungsten unit test

2023-08-24 Thread via GitHub
nvazquez merged PR #7904: URL: https://github.com/apache/cloudstack/pull/7904 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@clouds

[cloudstack] branch main updated: Fix tungsten unit test (#7904)

2023-08-24 Thread nvazquez
This is an automated email from the ASF dual-hosted git repository. nvazquez pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/main by this push: new 47b6f0fd056 Fix tungsten unit test (#7904) 47b

[GitHub] [cloudstack] CharlesQueiroz commented on issue #7071: UI: creating a domain with a short name fails

2023-08-24 Thread via GitHub
CharlesQueiroz commented on issue #7071: URL: https://github.com/apache/cloudstack/issues/7071#issuecomment-1691681076 I couldn't reproduce the problem. I made a pull of the 4.18 branch and ran it... followed the step-by-step description, but the domain was created as expected. See:

[GitHub] [cloudstack] DaanHoogland commented on pull request #7904: Fix tungsten unit test

2023-08-24 Thread via GitHub
DaanHoogland commented on PR #7904: URL: https://github.com/apache/cloudstack/pull/7904#issuecomment-1691688546 I don't like this merge, the original method used a `when(..).thenReturn(..)` and I think that is more proper for unit tests. maybe we can change this back later. -- This is a

[GitHub] [cloudstack] vdombrovski opened a new issue, #7907: Race condition when automatically assigning IPs to VMs

2023-08-24 Thread via GitHub
vdombrovski opened a new issue, #7907: URL: https://github.com/apache/cloudstack/issues/7907 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ Core/Network ~~~ # CLOUDSTACK VERSION ~~~ 4.17.2 ~~~ # CONFIGURATION

[cloudstack] branch 4.19-fix-kvm-LibvirtReplugNicCommandWrapperTest updated (631615314a2 -> 7cdf864c71d)

2023-08-24 Thread weizhou
This is an automated email from the ASF dual-hosted git repository. weizhou pushed a change to branch 4.19-fix-kvm-LibvirtReplugNicCommandWrapperTest in repository https://gitbox.apache.org/repos/asf/cloudstack.git discard 631615314a2 kvm: add debug msg This update removed existing revisions

[cloudstack] 01/02: Merge branch 'main' of https://github.com/apache/cloudstack into nsx-integration

2023-08-24 Thread pearl11594
This is an automated email from the ASF dual-hosted git repository. pearl11594 pushed a commit to branch nsx-integration in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit d8998d083313e96f6853a430a3bb6f7f4f804a10 Merge: e0244e2f56c 7cdf864c71d Author: Pearl Dsilva AuthorDate

[cloudstack] branch nsx-integration updated (e0244e2f56c -> bb9b6441a23)

2023-08-24 Thread pearl11594
This is an automated email from the ASF dual-hosted git repository. pearl11594 pushed a change to branch nsx-integration in repository https://gitbox.apache.org/repos/asf/cloudstack.git from e0244e2f56c add NSX resource , api client, create tier1 gw add fe70f4d801c Remove powermock from

[cloudstack] 02/02: update db

2023-08-24 Thread pearl11594
This is an automated email from the ASF dual-hosted git repository. pearl11594 pushed a commit to branch nsx-integration in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit bb9b6441a238d94b70deb1f6fe727d7da9f1798f Author: Pearl Dsilva AuthorDate: Thu Aug 24 09:56:24 2023 -040

[cloudstack] branch 4.19-fix-kvm-LibvirtReplugNicCommandWrapperTest updated: kvm: fix unit test LibvirtReplugNicCommandWrapperTest

2023-08-24 Thread weizhou
This is an automated email from the ASF dual-hosted git repository. weizhou pushed a commit to branch 4.19-fix-kvm-LibvirtReplugNicCommandWrapperTest in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.19-fix-kvm-LibvirtReplugNicC

[GitHub] [cloudstack] weizhouapache commented on issue #6698: Dedication of public IP ranges broken after upgrade to 4.17.0.1

2023-08-24 Thread via GitHub
weizhouapache commented on issue #6698: URL: https://github.com/apache/cloudstack/issues/6698#issuecomment-1691745613 > I can reproduce the issue if (1) use.system.public.ips = true (2) system.vm.public.ip.reservation.mode.strictness = true (3) there is a dedicated IP range for ROOT

[GitHub] [cloudstack] soreana commented on issue #7071: UI: creating a domain with a short name fails

2023-08-24 Thread via GitHub
soreana commented on issue #7071: URL: https://github.com/apache/cloudstack/issues/7071#issuecomment-1691772318 @DaanHoogland I couldn't also reproduce it with the latest 4.18 branch. Shall we close it? -- This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [cloudstack] weizhouapache opened a new pull request, #7908: kvm: fix unit test LibvirtReplugNicCommandWrapperTest

2023-08-24 Thread via GitHub
weizhouapache opened a new pull request, #7908: URL: https://github.com/apache/cloudstack/pull/7908 ### Description This PR fixes the unit test error with LibvirtReplugNicCommandWrapperTest ### Types of changes - [ ]

[GitHub] [cloudstack] weizhouapache commented on pull request #7908: kvm: fix unit test LibvirtReplugNicCommandWrapperTest

2023-08-24 Thread via GitHub
weizhouapache commented on PR #7908: URL: https://github.com/apache/cloudstack/pull/7908#issuecomment-1691797917 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [cloudstack] weizhouapache commented on pull request #7908: kvm: fix unit test LibvirtReplugNicCommandWrapperTest

2023-08-24 Thread via GitHub
weizhouapache commented on PR #7908: URL: https://github.com/apache/cloudstack/pull/7908#issuecomment-1691798494 build job looks good. https://github.com/apache/cloudstack/actions/runs/5964707979 -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [cloudstack] weizhouapache commented on pull request #7615: server: Fix NPE when migrating volume without template

2023-08-24 Thread via GitHub
weizhouapache commented on PR #7615: URL: https://github.com/apache/cloudstack/pull/7615#issuecomment-1691802311 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [cloudstack] blueorangutan commented on pull request #7615: server: Fix NPE when migrating volume without template

2023-08-24 Thread via GitHub
blueorangutan commented on PR #7615: URL: https://github.com/apache/cloudstack/pull/7615#issuecomment-1691803123 @weizhouapache a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progres

[GitHub] [cloudstack] weizhouapache commented on pull request #7908: kvm: fix unit test LibvirtReplugNicCommandWrapperTest

2023-08-24 Thread via GitHub
weizhouapache commented on PR #7908: URL: https://github.com/apache/cloudstack/pull/7908#issuecomment-1691808161 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [cloudstack] blueorangutan commented on pull request #7908: kvm: fix unit test LibvirtReplugNicCommandWrapperTest

2023-08-24 Thread via GitHub
blueorangutan commented on PR #7908: URL: https://github.com/apache/cloudstack/pull/7908#issuecomment-1691810325 @weizhouapache a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progres

[GitHub] [cloudstack] BryanMLima commented on pull request #6812: Normalize encryption on global configurations values

2023-08-24 Thread via GitHub
BryanMLima commented on PR #6812: URL: https://github.com/apache/cloudstack/pull/6812#issuecomment-1691827796 > running again as the test_internal_lb failures seem consistent (cc @BryanMLima) Yeah, I will try to identify the cause, as it should not impact these kinda of tests. --

[GitHub] [cloudstack] weizhouapache opened a new pull request, #7909: server: fix global setting system.vm.public.ip.reservation.mode.strictness is not really dynamic

2023-08-24 Thread via GitHub
weizhouapache opened a new pull request, #7909: URL: https://github.com/apache/cloudstack/pull/7909 ### Description If the original value is `false`, and search build is configured without the condition. Now change the value to `true`, it will not get effective due to missing con

[GitHub] [cloudstack] weizhouapache commented on pull request #6812: Normalize encryption on global configurations values

2023-08-24 Thread via GitHub
weizhouapache commented on PR #6812: URL: https://github.com/apache/cloudstack/pull/6812#issuecomment-1691841839 > LGTM, tested the PR manually, here are the steps and results: > > 1. Created an account and domain in my test environment, and set the following configurations: >*

[GitHub] [cloudstack] weizhouapache commented on pull request #6812: Normalize encryption on global configurations values

2023-08-24 Thread via GitHub
weizhouapache commented on PR #6812: URL: https://github.com/apache/cloudstack/pull/6812#issuecomment-1691843192 > > running again as the test_internal_lb failures seem consistent (cc @BryanMLima) > > Yeah, I will try to identify the cause, as it should not impact these kinda of test

[GitHub] [cloudstack] weizhouapache commented on pull request #6812: Normalize encryption on global configurations values

2023-08-24 Thread via GitHub
weizhouapache commented on PR #6812: URL: https://github.com/apache/cloudstack/pull/6812#issuecomment-1691843422 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [cloudstack] blueorangutan commented on pull request #6812: Normalize encryption on global configurations values

2023-08-24 Thread via GitHub
blueorangutan commented on PR #6812: URL: https://github.com/apache/cloudstack/pull/6812#issuecomment-1691846008 @weizhouapache a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progres

[GitHub] [cloudstack] mlsorensen commented on a diff in pull request #7878: Publish event for VM.STOP when out of band stop is detected

2023-08-24 Thread via GitHub
mlsorensen commented on code in PR #7878: URL: https://github.com/apache/cloudstack/pull/7878#discussion_r1304468851 ## engine/orchestration/src/main/java/com/cloud/vm/VirtualMachinePowerStateSyncImpl.java: ## @@ -162,6 +177,8 @@ private void processReport(long hostId, Map tra

[GitHub] [cloudstack] codecov[bot] commented on pull request #7908: kvm: fix unit test LibvirtReplugNicCommandWrapperTest

2023-08-24 Thread via GitHub
codecov[bot] commented on PR #7908: URL: https://github.com/apache/cloudstack/pull/7908#issuecomment-1691884173 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/7908?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)

[GitHub] [cloudstack] blueorangutan commented on pull request #7615: server: Fix NPE when migrating volume without template

2023-08-24 Thread via GitHub
blueorangutan commented on PR #7615: URL: https://github.com/apache/cloudstack/pull/7615#issuecomment-1691919998 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6880 -- This is an auto

[GitHub] [cloudstack] blueorangutan commented on pull request #7908: kvm: fix unit test LibvirtReplugNicCommandWrapperTest

2023-08-24 Thread via GitHub
blueorangutan commented on PR #7908: URL: https://github.com/apache/cloudstack/pull/7908#issuecomment-1691929997 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6881 -- This is an auto

[GitHub] [cloudstack] weizhouapache commented on pull request #7615: server: Fix NPE when migrating volume without template

2023-08-24 Thread via GitHub
weizhouapache commented on PR #7615: URL: https://github.com/apache/cloudstack/pull/7615#issuecomment-1691934248 @blueorangutan test rocky8 kvm-rocky8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [cloudstack] blueorangutan commented on pull request #7615: server: Fix NPE when migrating volume without template

2023-08-24 Thread via GitHub
blueorangutan commented on PR #7615: URL: https://github.com/apache/cloudstack/pull/7615#issuecomment-1691937173 @weizhouapache a [SF] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To re

[GitHub] [cloudstack] vishesh92 closed pull request #7903: Fix testReplugNic unit test

2023-08-24 Thread via GitHub
vishesh92 closed pull request #7903: Fix testReplugNic unit test URL: https://github.com/apache/cloudstack/pull/7903 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[GitHub] [cloudstack] blueorangutan commented on pull request #6812: Normalize encryption on global configurations values

2023-08-24 Thread via GitHub
blueorangutan commented on PR #6812: URL: https://github.com/apache/cloudstack/pull/6812#issuecomment-1691954280 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6882 -- This is an auto

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7908: kvm: fix unit test LibvirtReplugNicCommandWrapperTest

2023-08-24 Thread via GitHub
sonarcloud[bot] commented on PR #7908: URL: https://github.com/apache/cloudstack/pull/7908#issuecomment-1691971236 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Q

[GitHub] [cloudstack] weizhouapache commented on pull request #7615: server: Fix NPE when migrating volume without template

2023-08-24 Thread via GitHub
weizhouapache commented on PR #7615: URL: https://github.com/apache/cloudstack/pull/7615#issuecomment-1691977851 @blueorangutan test rocky8 kvm-rocky8 keepEnv -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [cloudstack] blueorangutan commented on pull request #7615: server: Fix NPE when migrating volume without template

2023-08-24 Thread via GitHub
blueorangutan commented on PR #7615: URL: https://github.com/apache/cloudstack/pull/7615#issuecomment-1691979731 @weizhouapache a [SF] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To re

[GitHub] [cloudstack] codecov[bot] commented on pull request #7909: server: fix global setting system.vm.public.ip.reservation.mode.strictness is not really dynamic

2023-08-24 Thread via GitHub
codecov[bot] commented on PR #7909: URL: https://github.com/apache/cloudstack/pull/7909#issuecomment-1691988095 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/7909?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)

[GitHub] [cloudstack] rohityadavcloud merged pull request #7908: kvm: fix unit test LibvirtReplugNicCommandWrapperTest

2023-08-24 Thread via GitHub
rohityadavcloud merged PR #7908: URL: https://github.com/apache/cloudstack/pull/7908 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

[GitHub] [cloudstack] rohityadavcloud merged pull request #7898: server: allow user to list available IPs on shared networks

2023-08-24 Thread via GitHub
rohityadavcloud merged PR #7898: URL: https://github.com/apache/cloudstack/pull/7898 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7846: ui: Fix refresh and re-route behaviour

2023-08-24 Thread via GitHub
rohityadavcloud commented on PR #7846: URL: https://github.com/apache/cloudstack/pull/7846#issuecomment-1691994741 Needs assistance on fixing the UI unit tests - @nvazquez @Pearl1594 @shwstppr @blueorangutan package @blueorangutan ui -- This is an automated message from the Apa

[GitHub] [cloudstack] blueorangutan commented on pull request #7846: ui: Fix refresh and re-route behaviour

2023-08-24 Thread via GitHub
blueorangutan commented on PR #7846: URL: https://github.com/apache/cloudstack/pull/7846#issuecomment-1691997983 @rohityadavcloud a [SF] Jenkins job has been kicked to build packages. It will be bundled with@blueorangutan ui SystemVM template(s). I'll keep you posted as I make progress. -

[GitHub] [cloudstack] blueorangutan commented on pull request #7846: ui: Fix refresh and re-route behaviour

2023-08-24 Thread via GitHub
blueorangutan commented on PR #7846: URL: https://github.com/apache/cloudstack/pull/7846#issuecomment-1691998016 @rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To resp

[GitHub] [cloudstack] weizhouapache commented on pull request #7909: server: fix global setting system.vm.public.ip.reservation.mode.strictness is not really dynamic

2023-08-24 Thread via GitHub
weizhouapache commented on PR #7909: URL: https://github.com/apache/cloudstack/pull/7909#issuecomment-1692017029 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [cloudstack] blueorangutan commented on pull request #7909: server: fix global setting system.vm.public.ip.reservation.mode.strictness is not really dynamic

2023-08-24 Thread via GitHub
blueorangutan commented on PR #7909: URL: https://github.com/apache/cloudstack/pull/7909#issuecomment-1692019864 @weizhouapache a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progres

  1   2   >