[GitHub] [cloudstack] weizhouapache commented on a change in pull request #5769: New feature: give access permission of networks to other accounts in same domain

2022-01-05 Thread GitBox
weizhouapache commented on a change in pull request #5769: URL: https://github.com/apache/cloudstack/pull/5769#discussion_r778615529 ## File path: api/src/main/java/com/cloud/network/GuestVlan.java ## @@ -16,17 +16,26 @@ // under the License. package com.cloud.network; -imp

[GitHub] [cloudstack] weizhouapache commented on a change in pull request #5769: New feature: give access permission of networks to other accounts in same domain

2022-01-05 Thread GitBox
weizhouapache commented on a change in pull request #5769: URL: https://github.com/apache/cloudstack/pull/5769#discussion_r778625119 ## File path: server/src/main/java/com/cloud/api/ApiResponseHelper.java ## @@ -3188,6 +3206,16 @@ public PrivateGatewayResponse createPrivateGat

[GitHub] [cloudstack] weizhouapache commented on a change in pull request #5769: New feature: give access permission of networks to other accounts in same domain

2022-01-05 Thread GitBox
weizhouapache commented on a change in pull request #5769: URL: https://github.com/apache/cloudstack/pull/5769#discussion_r778626479 ## File path: api/src/main/java/org/apache/cloudstack/api/command/user/network/CreateNetworkCmd.java ## @@ -249,11 +260,31 @@ public Long getPhy

[GitHub] [cloudstack] weizhouapache commented on a change in pull request #5769: New feature: give access permission of networks to other accounts in same domain

2022-01-05 Thread GitBox
weizhouapache commented on a change in pull request #5769: URL: https://github.com/apache/cloudstack/pull/5769#discussion_r778628113 ## File path: test/integration/smoke/test_network_permissions.py ## @@ -0,0 +1,757 @@ +# Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [cloudstack] weizhouapache commented on a change in pull request #5769: New feature: give access permission of networks to other accounts in same domain

2022-01-05 Thread GitBox
weizhouapache commented on a change in pull request #5769: URL: https://github.com/apache/cloudstack/pull/5769#discussion_r778630098 ## File path: test/integration/smoke/test_network_permissions.py ## @@ -0,0 +1,757 @@ +# Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [cloudstack] weizhouapache commented on a change in pull request #5769: New feature: give access permission of networks to other accounts in same domain

2022-01-05 Thread GitBox
weizhouapache commented on a change in pull request #5769: URL: https://github.com/apache/cloudstack/pull/5769#discussion_r778631212 ## File path: test/integration/smoke/test_network_permissions.py ## @@ -0,0 +1,757 @@ +# Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [cloudstack] weizhouapache commented on a change in pull request #5769: New feature: give access permission of networks to other accounts in same domain

2022-01-05 Thread GitBox
weizhouapache commented on a change in pull request #5769: URL: https://github.com/apache/cloudstack/pull/5769#discussion_r778631977 ## File path: test/integration/smoke/test_network_permissions.py ## @@ -0,0 +1,757 @@ +# Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [cloudstack] weizhouapache commented on a change in pull request #5769: New feature: give access permission of networks to other accounts in same domain

2022-01-05 Thread GitBox
weizhouapache commented on a change in pull request #5769: URL: https://github.com/apache/cloudstack/pull/5769#discussion_r778634437 ## File path: test/integration/smoke/test_network_permissions.py ## @@ -0,0 +1,757 @@ +# Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [cloudstack] weizhouapache commented on a change in pull request #5769: New feature: give access permission of networks to other accounts in same domain

2022-01-05 Thread GitBox
weizhouapache commented on a change in pull request #5769: URL: https://github.com/apache/cloudstack/pull/5769#discussion_r778639942 ## File path: test/integration/smoke/test_network_permissions.py ## @@ -0,0 +1,757 @@ +# Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [cloudstack] weizhouapache commented on a change in pull request #5769: New feature: give access permission of networks to other accounts in same domain

2022-01-05 Thread GitBox
weizhouapache commented on a change in pull request #5769: URL: https://github.com/apache/cloudstack/pull/5769#discussion_r778640194 ## File path: test/integration/smoke/test_network_permissions.py ## @@ -0,0 +1,757 @@ +# Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [cloudstack] weizhouapache commented on a change in pull request #5769: New feature: give access permission of networks to other accounts in same domain

2022-01-05 Thread GitBox
weizhouapache commented on a change in pull request #5769: URL: https://github.com/apache/cloudstack/pull/5769#discussion_r778640597 ## File path: test/integration/smoke/test_user_shared_network.py ## @@ -0,0 +1,630 @@ +# Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [cloudstack] weizhouapache commented on a change in pull request #5769: New feature: give access permission of networks to other accounts in same domain

2022-01-05 Thread GitBox
weizhouapache commented on a change in pull request #5769: URL: https://github.com/apache/cloudstack/pull/5769#discussion_r778641820 ## File path: test/integration/smoke/test_user_shared_network.py ## @@ -0,0 +1,630 @@ +# Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [cloudstack] weizhouapache commented on a change in pull request #5769: New feature: give access permission of networks to other accounts in same domain

2022-01-05 Thread GitBox
weizhouapache commented on a change in pull request #5769: URL: https://github.com/apache/cloudstack/pull/5769#discussion_r778642363 ## File path: test/integration/smoke/test_user_shared_network.py ## @@ -0,0 +1,630 @@ +# Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [cloudstack] weizhouapache commented on a change in pull request #5769: New feature: give access permission of networks to other accounts in same domain

2022-01-05 Thread GitBox
weizhouapache commented on a change in pull request #5769: URL: https://github.com/apache/cloudstack/pull/5769#discussion_r778640272 ## File path: test/integration/smoke/test_network_permissions.py ## @@ -0,0 +1,757 @@ +# Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [cloudstack] weizhouapache commented on a change in pull request #5769: New feature: give access permission of networks to other accounts in same domain

2022-01-05 Thread GitBox
weizhouapache commented on a change in pull request #5769: URL: https://github.com/apache/cloudstack/pull/5769#discussion_r778663514 ## File path: test/integration/smoke/test_network_permissions.py ## @@ -0,0 +1,757 @@ +# Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [cloudstack] weizhouapache commented on a change in pull request #5769: New feature: give access permission of networks to other accounts in same domain

2022-01-05 Thread GitBox
weizhouapache commented on a change in pull request #5769: URL: https://github.com/apache/cloudstack/pull/5769#discussion_r778669080 ## File path: server/src/main/java/com/cloud/network/vpc/VpcManagerImpl.java ## @@ -1833,8 +1860,63 @@ public PrivateGateway createVpcPrivateGate

[GitHub] [cloudstack] weizhouapache commented on a change in pull request #5769: New feature: give access permission of networks to other accounts in same domain

2022-01-05 Thread GitBox
weizhouapache commented on a change in pull request #5769: URL: https://github.com/apache/cloudstack/pull/5769#discussion_r778671162 ## File path: server/src/main/java/com/cloud/network/vpc/VpcManagerImpl.java ## @@ -1833,8 +1860,63 @@ public PrivateGateway createVpcPrivateGate

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5825: [Vmware][Deploy-as-is] Add the list of supported namespaces per document and refactor OVF parsing

2022-01-05 Thread GitBox
DaanHoogland commented on a change in pull request #5825: URL: https://github.com/apache/cloudstack/pull/5825#discussion_r778673717 ## File path: api/src/main/java/com/cloud/agent/api/storage/OVFHelper.java ## @@ -366,21 +387,25 @@ private DatadiskTO generateDiskTO(OVFFile file

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5588: Mshost stats

2022-01-05 Thread GitBox
DaanHoogland commented on a change in pull request #5588: URL: https://github.com/apache/cloudstack/pull/5588#discussion_r778677597 ## File path: framework/cluster/src/main/java/com/cloud/cluster/ClusterManager.java ## @@ -53,19 +62,44 @@ void registerDispatcher(Dispatch

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5588: Mshost stats

2022-01-05 Thread GitBox
DaanHoogland commented on a change in pull request #5588: URL: https://github.com/apache/cloudstack/pull/5588#discussion_r778677912 ## File path: framework/cluster/src/main/java/com/cloud/cluster/dao/ManagementServerHostDao.java ## @@ -47,7 +47,12 @@ List listBy(Managem

[GitHub] [cloudstack] DaanHoogland commented on pull request #5588: Mshost stats

2022-01-05 Thread GitBox
DaanHoogland commented on pull request #5588: URL: https://github.com/apache/cloudstack/pull/5588#issuecomment-1005531144 > @DaanHoogland, is this PR ready for review? yes, but we have some extra internal testing and reviewing processes for which we don't want it werged yet, hence th

[GitHub] [cloudstack] Pearl1594 commented on a change in pull request #5750: use physical size instead of virtual size for migration.

2022-01-05 Thread GitBox
Pearl1594 commented on a change in pull request #5750: URL: https://github.com/apache/cloudstack/pull/5750#discussion_r778685136 ## File path: engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/StorageOrchestrator.java ## @@ -194,8 +197,9 @@ public M

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5825: [Vmware][Deploy-as-is] Add the list of supported namespaces per document and refactor OVF parsing

2022-01-05 Thread GitBox
sureshanaparti commented on a change in pull request #5825: URL: https://github.com/apache/cloudstack/pull/5825#discussion_r778689350 ## File path: api/src/main/java/com/cloud/agent/api/storage/OVFHelper.java ## @@ -366,21 +387,25 @@ private DatadiskTO generateDiskTO(OVFFile fi

[GitHub] [cloudstack] DaanHoogland edited a comment on pull request #5588: Mshost stats

2022-01-05 Thread GitBox
DaanHoogland edited a comment on pull request #5588: URL: https://github.com/apache/cloudstack/pull/5588#issuecomment-1005531144 > @DaanHoogland, is this PR ready for review? yes, but we have some extra internal testing and reviewing processes for which we don't want it merged yet, h

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5750: use physical size instead of virtual size for migration.

2022-01-05 Thread GitBox
sureshanaparti commented on a change in pull request #5750: URL: https://github.com/apache/cloudstack/pull/5750#discussion_r77869 ## File path: engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/DataMigrationUtility.java ## @@ -87,19 +92,22 @@

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5750: use physical size instead of virtual size for migration.

2022-01-05 Thread GitBox
sureshanaparti commented on a change in pull request #5750: URL: https://github.com/apache/cloudstack/pull/5750#discussion_r778693589 ## File path: engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/DataMigrationUtility.java ## @@ -87,19 +92,22 @@

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5750: use physical size instead of virtual size for migration.

2022-01-05 Thread GitBox
sureshanaparti commented on a change in pull request #5750: URL: https://github.com/apache/cloudstack/pull/5750#discussion_r778693740 ## File path: engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/DataMigrationUtility.java ## @@ -87,19 +92,22 @@

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5750: use physical size instead of virtual size for migration.

2022-01-05 Thread GitBox
DaanHoogland commented on a change in pull request #5750: URL: https://github.com/apache/cloudstack/pull/5750#discussion_r778695512 ## File path: engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/DataMigrationUtility.java ## @@ -87,19 +92,22 @@

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5750: use physical size instead of virtual size for migration.

2022-01-05 Thread GitBox
sureshanaparti commented on a change in pull request #5750: URL: https://github.com/apache/cloudstack/pull/5750#discussion_r778698334 ## File path: engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/DataMigrationUtility.java ## @@ -87,19 +92,22 @@

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5750: use physical size instead of virtual size for migration.

2022-01-05 Thread GitBox
sureshanaparti commented on a change in pull request #5750: URL: https://github.com/apache/cloudstack/pull/5750#discussion_r778698334 ## File path: engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/DataMigrationUtility.java ## @@ -87,19 +92,22 @@

[GitHub] [cloudstack] nvazquez commented on a change in pull request #5825: [Vmware][Deploy-as-is] Add the list of supported namespaces per document and refactor OVF parsing

2022-01-05 Thread GitBox
nvazquez commented on a change in pull request #5825: URL: https://github.com/apache/cloudstack/pull/5825#discussion_r778698931 ## File path: api/src/main/java/com/cloud/agent/api/storage/OVFHelper.java ## @@ -366,21 +387,25 @@ private DatadiskTO generateDiskTO(OVFFile file, OV

[GitHub] [cloudstack] nvazquez commented on a change in pull request #5825: [Vmware][Deploy-as-is] Add the list of supported namespaces per document and refactor OVF parsing

2022-01-05 Thread GitBox
nvazquez commented on a change in pull request #5825: URL: https://github.com/apache/cloudstack/pull/5825#discussion_r778700325 ## File path: api/src/main/java/com/cloud/agent/api/storage/OVFHelper.java ## @@ -366,21 +387,25 @@ private DatadiskTO generateDiskTO(OVFFile file, OV

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5750: use physical size instead of virtual size for migration.

2022-01-05 Thread GitBox
DaanHoogland commented on a change in pull request #5750: URL: https://github.com/apache/cloudstack/pull/5750#discussion_r778700552 ## File path: engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/DataMigrationUtility.java ## @@ -87,19 +92,22 @@

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5750: use physical size instead of virtual size for migration.

2022-01-05 Thread GitBox
DaanHoogland commented on a change in pull request #5750: URL: https://github.com/apache/cloudstack/pull/5750#discussion_r778700958 ## File path: engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/DataMigrationUtility.java ## @@ -87,19 +92,22 @@

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5750: use physical size instead of virtual size for migration.

2022-01-05 Thread GitBox
DaanHoogland commented on a change in pull request #5750: URL: https://github.com/apache/cloudstack/pull/5750#discussion_r778701420 ## File path: engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/DataMigrationUtility.java ## @@ -87,19 +92,22 @@

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5825: [Vmware][Deploy-as-is] Add the list of supported namespaces per document and refactor OVF parsing

2022-01-05 Thread GitBox
DaanHoogland commented on a change in pull request #5825: URL: https://github.com/apache/cloudstack/pull/5825#discussion_r778703751 ## File path: api/src/main/java/com/cloud/agent/api/storage/OVFHelper.java ## @@ -366,21 +387,25 @@ private DatadiskTO generateDiskTO(OVFFile file

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5750: use physical size instead of virtual size for migration.

2022-01-05 Thread GitBox
sureshanaparti commented on a change in pull request #5750: URL: https://github.com/apache/cloudstack/pull/5750#discussion_r778706206 ## File path: engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/DataMigrationUtility.java ## @@ -87,19 +92,22 @@

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5750: use physical size instead of virtual size for migration.

2022-01-05 Thread GitBox
sureshanaparti commented on a change in pull request #5750: URL: https://github.com/apache/cloudstack/pull/5750#discussion_r778706887 ## File path: engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/DataMigrationUtility.java ## @@ -87,19 +92,22 @@

[GitHub] [cloudstack] weizhouapache commented on a change in pull request #5769: New feature: give access permission of networks to other accounts in same domain

2022-01-05 Thread GitBox
weizhouapache commented on a change in pull request #5769: URL: https://github.com/apache/cloudstack/pull/5769#discussion_r778728310 ## File path: server/src/main/java/com/cloud/network/vpc/VpcManagerImpl.java ## @@ -1833,8 +1860,63 @@ public PrivateGateway createVpcPrivateGate

[GitHub] [cloudstack] weizhouapache commented on a change in pull request #5769: New feature: give access permission of networks to other accounts in same domain

2022-01-05 Thread GitBox
weizhouapache commented on a change in pull request #5769: URL: https://github.com/apache/cloudstack/pull/5769#discussion_r778731373 ## File path: server/src/main/java/com/cloud/network/vpc/VpcManagerImpl.java ## @@ -1833,8 +1860,63 @@ public PrivateGateway createVpcPrivateGate

[GitHub] [cloudstack] weizhouapache commented on a change in pull request #5769: New feature: give access permission of networks to other accounts in same domain

2022-01-05 Thread GitBox
weizhouapache commented on a change in pull request #5769: URL: https://github.com/apache/cloudstack/pull/5769#discussion_r778732745 ## File path: server/src/main/java/com/cloud/network/NetworkServiceImpl.java ## @@ -4560,13 +4783,22 @@ public Network createPrivateNetwork(final

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5769: New feature: give access permission of networks to other accounts in same domain

2022-01-05 Thread GitBox
DaanHoogland commented on a change in pull request #5769: URL: https://github.com/apache/cloudstack/pull/5769#discussion_r778737706 ## File path: server/src/main/java/com/cloud/network/NetworkServiceImpl.java ## @@ -4560,13 +4783,22 @@ public Network createPrivateNetwork(final

[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5658: remove VmWorkJob after adding a nic to a vm

2022-01-05 Thread GitBox
blueorangutan removed a comment on pull request #5658: URL: https://github.com/apache/cloudstack/pull/5658#issuecomment-1004650277 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2085 -- This is an automated mess

[GitHub] [cloudstack] weizhouapache commented on pull request #5658: remove VmWorkJob after adding a nic to a vm

2022-01-05 Thread GitBox
weizhouapache commented on pull request #5658: URL: https://github.com/apache/cloudstack/pull/5658#issuecomment-1005615680 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [cloudstack] blueorangutan commented on pull request #5658: remove VmWorkJob after adding a nic to a vm

2022-01-05 Thread GitBox
blueorangutan commented on pull request #5658: URL: https://github.com/apache/cloudstack/pull/5658#issuecomment-1005616605 @weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] RodrigoDLopez commented on a change in pull request #5588: Mshost stats

2022-01-05 Thread GitBox
RodrigoDLopez commented on a change in pull request #5588: URL: https://github.com/apache/cloudstack/pull/5588#discussion_r778777603 ## File path: framework/cluster/src/main/java/com/cloud/cluster/ClusterManager.java ## @@ -53,19 +62,44 @@ void registerDispatcher(Dispatc

[GitHub] [cloudstack] blueorangutan commented on pull request #5658: remove VmWorkJob after adding a nic to a vm

2022-01-05 Thread GitBox
blueorangutan commented on pull request #5658: URL: https://github.com/apache/cloudstack/pull/5658#issuecomment-1005656900 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2092 -- This is an automated message from

[GitHub] [cloudstack] nvazquez commented on pull request #5825: [Vmware][Deploy-as-is] Add the list of supported namespaces per document and refactor OVF parsing

2022-01-05 Thread GitBox
nvazquez commented on pull request #5825: URL: https://github.com/apache/cloudstack/pull/5825#issuecomment-1005663862 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [cloudstack] blueorangutan commented on pull request #5825: [Vmware][Deploy-as-is] Refactor the OVF parsing

2022-01-05 Thread GitBox
blueorangutan commented on pull request #5825: URL: https://github.com/apache/cloudstack/pull/5825#issuecomment-1005664459 @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To r

[GitHub] [cloudstack] blueorangutan commented on pull request #5658: remove VmWorkJob after adding a nic to a vm

2022-01-05 Thread GitBox
blueorangutan commented on pull request #5658: URL: https://github.com/apache/cloudstack/pull/5658#issuecomment-1005677149 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2093 -- This is an automated message from

[GitHub] [cloudstack] GabrielBrascher commented on pull request #4978: KVM High Availability regardless of storage

2022-01-05 Thread GitBox
GabrielBrascher commented on pull request #4978: URL: https://github.com/apache/cloudstack/pull/4978#issuecomment-1005685909 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [cloudstack] blueorangutan commented on pull request #4978: KVM High Availability regardless of storage

2022-01-05 Thread GitBox
blueorangutan commented on pull request #4978: URL: https://github.com/apache/cloudstack/pull/4978#issuecomment-1005686488 @GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Servic

[GitHub] [cloudstack] blueorangutan commented on pull request #5825: [Vmware][Deploy-as-is] Refactor the OVF parsing

2022-01-05 Thread GitBox
blueorangutan commented on pull request #5825: URL: https://github.com/apache/cloudstack/pull/5825#issuecomment-1005688393 Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 2095 -- This is a

[GitHub] [cloudstack] blueorangutan commented on pull request #5750: use physical size instead of virtual size for migration.

2022-01-05 Thread GitBox
blueorangutan commented on pull request #5750: URL: https://github.com/apache/cloudstack/pull/5750#issuecomment-1005688392 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2094 -- This is an automated message from

[GitHub] [cloudstack] weizhouapache commented on pull request #5658: remove VmWorkJob after adding a nic to a vm

2022-01-05 Thread GitBox
weizhouapache commented on pull request #5658: URL: https://github.com/apache/cloudstack/pull/5658#issuecomment-1005697603 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [cloudstack] blueorangutan commented on pull request #5658: remove VmWorkJob after adding a nic to a vm

2022-01-05 Thread GitBox
blueorangutan commented on pull request #5658: URL: https://github.com/apache/cloudstack/pull/5658#issuecomment-1005698572 @weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Servic

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5658: remove VmWorkJob after adding a nic to a vm

2022-01-05 Thread GitBox
DaanHoogland commented on a change in pull request #5658: URL: https://github.com/apache/cloudstack/pull/5658#discussion_r77888 ## File path: engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java ## @@ -5631,35 +5640,72 @@ private void checkConcur

[GitHub] [cloudstack] weizhouapache commented on pull request #5769: New feature: give access permission of networks to other accounts in same domain

2022-01-05 Thread GitBox
weizhouapache commented on pull request #5769: URL: https://github.com/apache/cloudstack/pull/5769#issuecomment-1005716596 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [cloudstack] blueorangutan commented on pull request #5769: New feature: give access permission of networks to other accounts in same domain

2022-01-05 Thread GitBox
blueorangutan commented on pull request #5769: URL: https://github.com/apache/cloudstack/pull/5769#issuecomment-1005717218 @weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] blueorangutan commented on pull request #4978: KVM High Availability regardless of storage

2022-01-05 Thread GitBox
blueorangutan commented on pull request #4978: URL: https://github.com/apache/cloudstack/pull/4978#issuecomment-1005727937 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2096 -- This is an automated message from

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5588: Mshost stats

2022-01-05 Thread GitBox
DaanHoogland commented on a change in pull request #5588: URL: https://github.com/apache/cloudstack/pull/5588#discussion_r778859376 ## File path: framework/cluster/src/main/java/com/cloud/cluster/ClusterManager.java ## @@ -53,19 +62,44 @@ void registerDispatcher(Dispatch

[GitHub] [cloudstack] blueorangutan commented on pull request #5769: New feature: give access permission of networks to other accounts in same domain

2022-01-05 Thread GitBox
blueorangutan commented on pull request #5769: URL: https://github.com/apache/cloudstack/pull/5769#issuecomment-1005767705 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2097 -- This is an automated message from

[GitHub] [cloudstack] SadiJr commented on a change in pull request #5774: [Veeam] Force ACS to use the template repository to clone job

2022-01-05 Thread GitBox
SadiJr commented on a change in pull request #5774: URL: https://github.com/apache/cloudstack/pull/5774#discussion_r778896407 ## File path: plugins/backup/veeam/src/main/java/org/apache/cloudstack/backup/veeam/VeeamClient.java ## @@ -337,25 +337,47 @@ private boolean checkTask

[GitHub] [cloudstack] SadiJr commented on a change in pull request #5774: [Veeam] Force ACS to use the template repository to clone job

2022-01-05 Thread GitBox
SadiJr commented on a change in pull request #5774: URL: https://github.com/apache/cloudstack/pull/5774#discussion_r778896717 ## File path: plugins/backup/veeam/src/main/java/org/apache/cloudstack/backup/veeam/VeeamClient.java ## @@ -337,25 +337,47 @@ private boolean checkTask

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5750: use physical size instead of virtual size for migration.

2022-01-05 Thread GitBox
DaanHoogland commented on a change in pull request #5750: URL: https://github.com/apache/cloudstack/pull/5750#discussion_r778896975 ## File path: engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/StorageOrchestrator.java ## @@ -194,8 +197,9 @@ publi

[GitHub] [cloudstack] GabrielBrascher commented on pull request #5774: [Veeam] Force ACS to use the template repository to clone job

2022-01-05 Thread GitBox
GabrielBrascher commented on pull request #5774: URL: https://github.com/apache/cloudstack/pull/5774#issuecomment-1005779391 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [cloudstack] blueorangutan commented on pull request #5774: [Veeam] Force ACS to use the template repository to clone job

2022-01-05 Thread GitBox
blueorangutan commented on pull request #5774: URL: https://github.com/apache/cloudstack/pull/5774#issuecomment-1005781201 @GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Servic

[GitHub] [cloudstack] blueorangutan commented on pull request #5700: [HEALTH] 4.16 Health Check please don't merge this

2022-01-05 Thread GitBox
blueorangutan commented on pull request #5700: URL: https://github.com/apache/cloudstack/pull/5700#issuecomment-1005794831 Trillian test result (tid-2783) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 31587 seconds Marvin logs: https://gith

[GitHub] [cloudstack] Pearl1594 commented on a change in pull request #5750: use physical size instead of virtual size for migration.

2022-01-05 Thread GitBox
Pearl1594 commented on a change in pull request #5750: URL: https://github.com/apache/cloudstack/pull/5750#discussion_r778921363 ## File path: engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/StorageOrchestrator.java ## @@ -194,8 +197,9 @@ public M

[GitHub] [cloudstack] weizhouapache commented on pull request #5769: New feature: give access permission of networks to other accounts in same domain

2022-01-05 Thread GitBox
weizhouapache commented on pull request #5769: URL: https://github.com/apache/cloudstack/pull/5769#issuecomment-1005841389 @blueorangutan test matrix keepEnv -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [cloudstack] blueorangutan commented on pull request #5769: New feature: give access permission of networks to other accounts in same domain

2022-01-05 Thread GitBox
blueorangutan commented on pull request #5769: URL: https://github.com/apache/cloudstack/pull/5769#issuecomment-1005841970 @weizhouapache a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests -- This is

[GitHub] [cloudstack] blueorangutan commented on pull request #5811: [HEALTH] 4.17 Health Check please don't merge this

2022-01-05 Thread GitBox
blueorangutan commented on pull request #5811: URL: https://github.com/apache/cloudstack/pull/5811#issuecomment-1005848633 Trillian test result (tid-2786) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 31544 seconds Marvin logs: https://gith

[GitHub] [cloudstack] blueorangutan commented on pull request #5774: [Veeam] Force ACS to use the template repository to clone job

2022-01-05 Thread GitBox
blueorangutan commented on pull request #5774: URL: https://github.com/apache/cloudstack/pull/5774#issuecomment-1005858104 Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 2098 -- This is a

[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5750: use physical size instead of virtual size for migration.

2022-01-05 Thread GitBox
blueorangutan removed a comment on pull request #5750: URL: https://github.com/apache/cloudstack/pull/5750#issuecomment-1004432627 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2078 -- This is an automated mess

[GitHub] [cloudstack] DaanHoogland removed a comment on pull request #5750: use physical size instead of virtual size for migration.

2022-01-05 Thread GitBox
DaanHoogland removed a comment on pull request #5750: URL: https://github.com/apache/cloudstack/pull/5750#issuecomment-1004596861 @blueorangutan test keepEnv -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5750: use physical size instead of virtual size for migration.

2022-01-05 Thread GitBox
blueorangutan removed a comment on pull request #5750: URL: https://github.com/apache/cloudstack/pull/5750#issuecomment-1004597422 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git

[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5750: use physical size instead of virtual size for migration.

2022-01-05 Thread GitBox
blueorangutan removed a comment on pull request #5750: URL: https://github.com/apache/cloudstack/pull/5750#issuecomment-1005006306 Trillian test result (tid-2777) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 31119 seconds Marvin logs: http

[GitHub] [cloudstack] DaanHoogland commented on pull request #5750: use physical size instead of virtual size for migration.

2022-01-05 Thread GitBox
DaanHoogland commented on pull request #5750: URL: https://github.com/apache/cloudstack/pull/5750#issuecomment-1005866758 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] blueorangutan commented on pull request #5700: [HEALTH] 4.16 Health Check please don't merge this

2022-01-05 Thread GitBox
blueorangutan commented on pull request #5700: URL: https://github.com/apache/cloudstack/pull/5700#issuecomment-1005859630 Trillian test result (tid-2782) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 34273 seconds Marvin logs: https://git

[GitHub] [cloudstack] blueorangutan commented on pull request #5750: use physical size instead of virtual size for migration.

2022-01-05 Thread GitBox
blueorangutan commented on pull request #5750: URL: https://github.com/apache/cloudstack/pull/5750#issuecomment-1005867645 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service

[GitHub] [cloudstack] blueorangutan commented on pull request #5811: [HEALTH] 4.17 Health Check please don't merge this

2022-01-05 Thread GitBox
blueorangutan commented on pull request #5811: URL: https://github.com/apache/cloudstack/pull/5811#issuecomment-1005893529 Trillian test result (tid-2785) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 34914 seconds Marvin logs: https://git

[GitHub] [cloudstack] blueorangutan commented on pull request #5822: server: fix vm can be recovered by other accounts

2022-01-05 Thread GitBox
blueorangutan commented on pull request #5822: URL: https://github.com/apache/cloudstack/pull/5822#issuecomment-1005899685 Trillian test result (tid-2788) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 32561 seconds Marvin logs: https://gith

[GitHub] [cloudstack] blueorangutan commented on pull request #5811: [HEALTH] 4.17 Health Check please don't merge this

2022-01-05 Thread GitBox
blueorangutan commented on pull request #5811: URL: https://github.com/apache/cloudstack/pull/5811#issuecomment-1005924672 Trillian test result (tid-2787) Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7 Total time taken: 37192 seconds Marvin logs: https://gith

[GitHub] [cloudstack] nvazquez commented on pull request #5825: [Vmware][Deploy-as-is] Refactor the OVF parsing

2022-01-05 Thread GitBox
nvazquez commented on pull request #5825: URL: https://github.com/apache/cloudstack/pull/5825#issuecomment-1005956427 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [cloudstack] GabrielBrascher commented on pull request #5774: [Veeam] Force ACS to use the template repository to clone job

2022-01-05 Thread GitBox
GabrielBrascher commented on pull request #5774: URL: https://github.com/apache/cloudstack/pull/5774#issuecomment-1005956610 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [cloudstack] blueorangutan commented on pull request #5774: [Veeam] Force ACS to use the template repository to clone job

2022-01-05 Thread GitBox
blueorangutan commented on pull request #5774: URL: https://github.com/apache/cloudstack/pull/5774#issuecomment-1005957100 @GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Servic

[GitHub] [cloudstack] blueorangutan commented on pull request #5825: [Vmware][Deploy-as-is] Refactor the OVF parsing

2022-01-05 Thread GitBox
blueorangutan commented on pull request #5825: URL: https://github.com/apache/cloudstack/pull/5825#issuecomment-1005957116 @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To r

[GitHub] [cloudstack] blueorangutan commented on pull request #5774: [Veeam] Force ACS to use the template repository to clone job

2022-01-05 Thread GitBox
blueorangutan commented on pull request #5774: URL: https://github.com/apache/cloudstack/pull/5774#issuecomment-1006000692 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2099 -- This is an automated message from

[GitHub] [cloudstack] blueorangutan commented on pull request #5825: [Vmware][Deploy-as-is] Refactor the OVF parsing

2022-01-05 Thread GitBox
blueorangutan commented on pull request #5825: URL: https://github.com/apache/cloudstack/pull/5825#issuecomment-1006000693 Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 2100 -- This is a

[GitHub] [cloudstack] andrijapanicsb commented on issue #4657: Management server looses MySQL connection: Timeout waiting for idle object

2022-01-05 Thread GitBox
andrijapanicsb commented on issue #4657: URL: https://github.com/apache/cloudstack/issues/4657#issuecomment-1006025595 ping @GabrielBrascher did you hit this issue again or was it resolved for good? Can you specify (if you recall) what variables did you change on the MySQL side?

[GitHub] [cloudstack] sureshanaparti commented on pull request #5774: [Veeam] Force ACS to use the template repository to clone job

2022-01-05 Thread GitBox
sureshanaparti commented on pull request #5774: URL: https://github.com/apache/cloudstack/pull/5774#issuecomment-1006038796 @blueorangutan test centos7 vmware-67u3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [cloudstack] blueorangutan commented on pull request #5774: [Veeam] Force ACS to use the template repository to clone job

2022-01-05 Thread GitBox
blueorangutan commented on pull request #5774: URL: https://github.com/apache/cloudstack/pull/5774#issuecomment-1006039491 @sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests -- This is an automated message from the Apache Git Servi

[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5700: [HEALTH] 4.16 Health Check please don't merge this

2022-01-05 Thread GitBox
blueorangutan removed a comment on pull request #5700: URL: https://github.com/apache/cloudstack/pull/5700#issuecomment-1005411391 Trillian Build Failed (tid-2784) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [cloudstack] weizhouapache commented on pull request #5822: server: fix vm can be recovered by other accounts

2022-01-05 Thread GitBox
weizhouapache commented on pull request #5822: URL: https://github.com/apache/cloudstack/pull/5822#issuecomment-1006064079 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [cloudstack] blueorangutan commented on pull request #5822: server: fix vm can be recovered by other accounts

2022-01-05 Thread GitBox
blueorangutan commented on pull request #5822: URL: https://github.com/apache/cloudstack/pull/5822#issuecomment-1006064490 @weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Servic

[GitHub] [cloudstack] GabrielBrascher opened a new pull request #5826: Allow templates & ISOs from IPv6 host address.

2022-01-05 Thread GitBox
GabrielBrascher opened a new pull request #5826: URL: https://github.com/apache/cloudstack/pull/5826 ### Description This PR removes a conditional in [com.cloud.utils.UriUtils.validateUrl(java.lang.String, java.lang.String)](https://github.com/apache/cloudstack/blob/44c08b5acc598972

[GitHub] [cloudstack] GabrielBrascher commented on pull request #5826: Allow templates & ISOs from IPv6 host address.

2022-01-05 Thread GitBox
GabrielBrascher commented on pull request #5826: URL: https://github.com/apache/cloudstack/pull/5826#issuecomment-1006123290 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [cloudstack] blueorangutan commented on pull request #5826: Allow templates & ISOs from IPv6 host address.

2022-01-05 Thread GitBox
blueorangutan commented on pull request #5826: URL: https://github.com/apache/cloudstack/pull/5826#issuecomment-1006123624 @GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Servic

[GitHub] [cloudstack] blueorangutan commented on pull request #5826: Allow templates & ISOs from IPv6 host address.

2022-01-05 Thread GitBox
blueorangutan commented on pull request #5826: URL: https://github.com/apache/cloudstack/pull/5826#issuecomment-1006125364 Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 2101 -- This is a

[GitHub] [cloudstack] Damans227 commented on issue #5563: OpenJDK17 + new dependency migration

2022-01-05 Thread GitBox
Damans227 commented on issue #5563: URL: https://github.com/apache/cloudstack/issues/5563#issuecomment-1006141649 Hey @rohityadavcloud Let me know if I can help with the migration of OpenJDK to 17. I am guessing we will propose a roadmap or a plan to complete this migration. So if there is

  1   2   >