[GitHub] [cloudstack] shwstppr commented on pull request #5333: vmware: delete snapshot disk after backup to secondary storage

2021-08-27 Thread GitBox
shwstppr commented on pull request #5333: URL: https://github.com/apache/cloudstack/pull/5333#issuecomment-906976127 @harikrishna-patnala @sureshanaparti made the change for volume to template export. Also, renamed a confusing variable for restore volume case -- This is an automated m

[GitHub] [cloudstack] shwstppr commented on pull request #5333: vmware: delete snapshot disk after backup to secondary storage

2021-08-27 Thread GitBox
shwstppr commented on pull request #5333: URL: https://github.com/apache/cloudstack/pull/5333#issuecomment-906976250 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [cloudstack] blueorangutan commented on pull request #5333: vmware: delete snapshot disk after backup to secondary storage

2021-08-27 Thread GitBox
blueorangutan commented on pull request #5333: URL: https://github.com/apache/cloudstack/pull/5333#issuecomment-906976865 @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To re

[GitHub] [cloudstack] blueorangutan commented on pull request #4329: Adding AutoScaling for cks + CKS CoreOS EOL update + systemvmtemplate improvements

2021-08-27 Thread GitBox
blueorangutan commented on pull request #4329: URL: https://github.com/apache/cloudstack/pull/4329#issuecomment-906981057 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1028 -- This is an automated message from

[GitHub] [cloudstack] Pearl1594 commented on pull request #5379: api: List details of template download state for stores corresponding to a zone

2021-08-27 Thread GitBox
Pearl1594 commented on pull request #5379: URL: https://github.com/apache/cloudstack/pull/5379#issuecomment-906985167 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [cloudstack] blueorangutan commented on pull request #5379: api: List details of template download state for stores corresponding to a zone

2021-08-27 Thread GitBox
blueorangutan commented on pull request #5379: URL: https://github.com/apache/cloudstack/pull/5379#issuecomment-906985318 @Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To r

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5335: xcp-ng: allow passing vm boot options

2021-08-27 Thread GitBox
DaanHoogland commented on a change in pull request #5335: URL: https://github.com/apache/cloudstack/pull/5335#discussion_r697215644 ## File path: plugins/hypervisors/xenserver/src/main/java/com/cloud/hypervisor/xenserver/discoverer/XcpServerDiscoverer.java ## @@ -122,6 +123,15

[GitHub] [cloudstack] DaanHoogland commented on pull request #3975: Issue #3974 Deploying mysql-ha jar file into its own path...

2021-08-27 Thread GitBox
DaanHoogland commented on pull request #3975: URL: https://github.com/apache/cloudstack/pull/3975#issuecomment-906993808 The fact that smoke tests pass now is good enough for me, as it proves the point that the move of the jar works (for centos7). LGTM -- This is an automated message fro

[GitHub] [cloudstack] blueorangutan commented on pull request #5380: vmware: check checksum while copying systemvm ISO

2021-08-27 Thread GitBox
blueorangutan commented on pull request #5380: URL: https://github.com/apache/cloudstack/pull/5380#issuecomment-906998178 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1029 -- This is an automated message from

[GitHub] [cloudstack] blueorangutan commented on pull request #5333: vmware: delete snapshot disk after backup to secondary storage

2021-08-27 Thread GitBox
blueorangutan commented on pull request #5333: URL: https://github.com/apache/cloudstack/pull/5333#issuecomment-907002123 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 1030 -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] blueorangutan commented on pull request #5379: api: List details of template download state for stores corresponding to a zone

2021-08-27 Thread GitBox
blueorangutan commented on pull request #5379: URL: https://github.com/apache/cloudstack/pull/5379#issuecomment-907004576 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 1031 -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5297: KVM disk-only based snapshot of volumes instead of taking VM's full snapshot and extracting disks

2021-08-27 Thread GitBox
DaanHoogland commented on a change in pull request #5297: URL: https://github.com/apache/cloudstack/pull/5297#discussion_r697225748 ## File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtRevertSnapshotCommandWrapper.java ## @@ -42,

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5297: KVM disk-only based snapshot of volumes instead of taking VM's full snapshot and extracting disks

2021-08-27 Thread GitBox
DaanHoogland commented on a change in pull request #5297: URL: https://github.com/apache/cloudstack/pull/5297#discussion_r697235222 ## File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtRevertSnapshotCommandWrapper.java ## @@ -42,

[GitHub] [cloudstack] DaanHoogland closed issue #3966: fix logs and modularisation leftovers from #3638

2021-08-27 Thread GitBox
DaanHoogland closed issue #3966: URL: https://github.com/apache/cloudstack/issues/3966 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [cloudstack] DaanHoogland commented on issue #3966: fix logs and modularisation leftovers from #3638

2021-08-27 Thread GitBox
DaanHoogland commented on issue #3966: URL: https://github.com/apache/cloudstack/issues/3966#issuecomment-907011135 addressed in a.o. #3985. I think we should move on and pick further UEFI issues stand alone. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack] ravening opened a new issue #5381: Unable to migrate volume of large size to another pool

2021-08-27 Thread GitBox
ravening opened a new issue #5381: URL: https://github.com/apache/cloudstack/issues/5381 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ API, Volume ~~~ # CLOUDSTACK VERSION ~~~ 4.14 onwards ~~~ # CONFIGUR

[GitHub] [cloudstack] DaanHoogland commented on issue #3652: improve logging in vmware storage processor

2021-08-27 Thread GitBox
DaanHoogland commented on issue #3652: URL: https://github.com/apache/cloudstack/issues/3652#issuecomment-907018018 #5353 looks promissing, I think we'll need to get further requirements from practical use after it had been merged, @nvazquez . let's consider that one closing this. -- Th

[GitHub] [cloudstack] Pearl1594 commented on pull request #4329: Adding AutoScaling for cks + CKS CoreOS EOL update + systemvmtemplate improvements

2021-08-27 Thread GitBox
Pearl1594 commented on pull request #4329: URL: https://github.com/apache/cloudstack/pull/4329#issuecomment-907018273 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [cloudstack] blueorangutan commented on pull request #4329: Adding AutoScaling for cks + CKS CoreOS EOL update + systemvmtemplate improvements

2021-08-27 Thread GitBox
blueorangutan commented on pull request #4329: URL: https://github.com/apache/cloudstack/pull/4329#issuecomment-907018875 @Pearl1594 a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests -- This is an au

[GitHub] [cloudstack] shwstppr commented on a change in pull request #5335: xcp-ng: allow passing vm boot options

2021-08-27 Thread GitBox
shwstppr commented on a change in pull request #5335: URL: https://github.com/apache/cloudstack/pull/5335#discussion_r697246509 ## File path: plugins/hypervisors/xenserver/src/main/java/com/cloud/hypervisor/xenserver/discoverer/XcpServerDiscoverer.java ## @@ -122,6 +123,15 @@

[GitHub] [cloudstack] shwstppr commented on pull request #5335: xcp-ng: allow passing vm boot options

2021-08-27 Thread GitBox
shwstppr commented on pull request #5335: URL: https://github.com/apache/cloudstack/pull/5335#issuecomment-907019209 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [cloudstack] blueorangutan commented on pull request #5335: xcp-ng: allow passing vm boot options

2021-08-27 Thread GitBox
blueorangutan commented on pull request #5335: URL: https://github.com/apache/cloudstack/pull/5335#issuecomment-907019491 @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To re

[GitHub] [cloudstack] DaanHoogland merged pull request #5360: ui: Go back for delete actions before querying async job

2021-08-27 Thread GitBox
DaanHoogland merged pull request #5360: URL: https://github.com/apache/cloudstack/pull/5360 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commit

[cloudstack] branch 4.15 updated: ui: Go back for delete actions before querying async job (#5360)

2021-08-27 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch 4.15 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.15 by this push: new b3dca8c ui: Go back for delete actions before que

[GitHub] [cloudstack] DaanHoogland commented on pull request #5366: updated maven dependency due to #5363

2021-08-27 Thread GitBox
DaanHoogland commented on pull request #5366: URL: https://github.com/apache/cloudstack/pull/5366#issuecomment-907020653 looks ok @rvalle @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [cloudstack] blueorangutan commented on pull request #5366: updated maven dependency due to #5363

2021-08-27 Thread GitBox
blueorangutan commented on pull request #5366: URL: https://github.com/apache/cloudstack/pull/5366#issuecomment-907020795 @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. T

[GitHub] [cloudstack] DaanHoogland commented on pull request #5366: updated maven dependency due to #5363

2021-08-27 Thread GitBox
DaanHoogland commented on pull request #5366: URL: https://github.com/apache/cloudstack/pull/5366#issuecomment-907020947 @rvalle did you test/encounter this in 4.15 as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [cloudstack] DaanHoogland commented on pull request #4701: Added support for removing unused port groups on VMWare

2021-08-27 Thread GitBox
DaanHoogland commented on pull request #4701: URL: https://github.com/apache/cloudstack/pull/4701#issuecomment-907021900 @Spaceman1984, can you look at the conflicts here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [cloudstack] DaanHoogland commented on issue #5336: Public IP for system VM is unreachable

2021-08-27 Thread GitBox
DaanHoogland commented on issue #5336: URL: https://github.com/apache/cloudstack/issues/5336#issuecomment-907024965 > > @fengdoudm could you check if you register correct systemvm template ? > > https://download.cloudstack.org/systemvm/ > > Systemvm template is systemvmtemplate-4.15.1-

[GitHub] [cloudstack] rhtyd commented on pull request #5369: kvm: Add check if host meets the minimum requirements

2021-08-27 Thread GitBox
rhtyd commented on pull request #5369: URL: https://github.com/apache/cloudstack/pull/5369#issuecomment-907027600 @davidjumani does it affect only main or 4.15 too? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5349: Fix of creating volumes from snapshots without backup to secondary storage

2021-08-27 Thread GitBox
DaanHoogland commented on a change in pull request #5349: URL: https://github.com/apache/cloudstack/pull/5349#discussion_r697254336 ## File path: engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java ## @@ -497,6 +492,25 @@ publi

[GitHub] [cloudstack] DaanHoogland commented on pull request #4200: Allow domain admins to create offering without mentioning domainid

2021-08-27 Thread GitBox
DaanHoogland commented on pull request #4200: URL: https://github.com/apache/cloudstack/pull/4200#issuecomment-907033109 > @PaulAngus, @DaanHoogland > Is there anything else that could be done by @ravening to proceed with this proposal? @RodrigoDLopez , as you can see this PR alre

[GitHub] [cloudstack] DaanHoogland edited a comment on pull request #4200: Allow domain admins to create offering without mentioning domainid

2021-08-27 Thread GitBox
DaanHoogland edited a comment on pull request #4200: URL: https://github.com/apache/cloudstack/pull/4200#issuecomment-907033109 > @PaulAngus, @DaanHoogland > Is there anything else that could be done by @ravening to proceed with this proposal? @RodrigoDLopez , as you can see this

[GitHub] [cloudstack] edikevich commented on issue #5378: Affinity Groups don't work

2021-08-27 Thread GitBox
edikevich commented on issue #5378: URL: https://github.com/apache/cloudstack/issues/5378#issuecomment-907034768 OK. Thx for answer. Issue is closed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [cloudstack] rhtyd commented on a change in pull request #4329: Adding AutoScaling for cks + CKS CoreOS EOL update + systemvmtemplate improvements

2021-08-27 Thread GitBox
rhtyd commented on a change in pull request #4329: URL: https://github.com/apache/cloudstack/pull/4329#discussion_r697264025 ## File path: engine/schema/src/main/java/com/cloud/upgrade/SystemVmTemplateRegistration.java ## @@ -0,0 +1,778 @@ +// Licensed to the Apache Software F

[GitHub] [cloudstack] DaanHoogland commented on issue #5370: Can't upload ISO - secondary storage not found

2021-08-27 Thread GitBox
DaanHoogland commented on issue #5370: URL: https://github.com/apache/cloudstack/issues/5370#issuecomment-907036409 @tetra12 the combination ``` Local Storage NO SSL/TLS ``` means you can't upload from local. At least it did mean that. I don't think this has been implemented.

[GitHub] [cloudstack] rhtyd commented on a change in pull request #4329: Adding AutoScaling for cks + CKS CoreOS EOL update + systemvmtemplate improvements

2021-08-27 Thread GitBox
rhtyd commented on a change in pull request #4329: URL: https://github.com/apache/cloudstack/pull/4329#discussion_r697267650 ## File path: engine/schema/src/main/java/com/cloud/upgrade/SystemVmTemplateRegistration.java ## @@ -0,0 +1,778 @@ +// Licensed to the Apache Software F

[GitHub] [cloudstack] rhtyd commented on a change in pull request #4329: Adding AutoScaling for cks + CKS CoreOS EOL update + systemvmtemplate improvements

2021-08-27 Thread GitBox
rhtyd commented on a change in pull request #4329: URL: https://github.com/apache/cloudstack/pull/4329#discussion_r697268660 ## File path: engine/schema/src/main/java/com/cloud/upgrade/SystemVmTemplateRegistration.java ## @@ -0,0 +1,778 @@ +// Licensed to the Apache Software F

[GitHub] [cloudstack] DaanHoogland commented on pull request #3997: New API endpoint: UpdateVlanIpRange

2021-08-27 Thread GitBox
DaanHoogland commented on pull request #3997: URL: https://github.com/apache/cloudstack/pull/3997#issuecomment-907040968 @sureshanaparti , @kioie has not been active on github since februari. I think we'll need to adopt this if we want it in. (cc @nvazquez ) -- This is an automated messa

[GitHub] [cloudstack] rhtyd commented on a change in pull request #4329: Adding AutoScaling for cks + CKS CoreOS EOL update + systemvmtemplate improvements

2021-08-27 Thread GitBox
rhtyd commented on a change in pull request #4329: URL: https://github.com/apache/cloudstack/pull/4329#discussion_r697270693 ## File path: engine/schema/src/main/java/com/cloud/upgrade/SystemVmTemplateRegistration.java ## @@ -0,0 +1,778 @@ +// Licensed to the Apache Software F

[GitHub] [cloudstack] blueorangutan commented on pull request #5335: xcp-ng: allow passing vm boot options

2021-08-27 Thread GitBox
blueorangutan commented on pull request #5335: URL: https://github.com/apache/cloudstack/pull/5335#issuecomment-907042147 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 1032 -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] DaanHoogland commented on pull request #4010: New API endpoint to update size of Pod Management IP Range.

2021-08-27 Thread GitBox
DaanHoogland commented on pull request #4010: URL: https://github.com/apache/cloudstack/pull/4010#issuecomment-907042086 see my last comment on #3997 , @sureshanaparti (cc @nvazquez ) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [cloudstack] rhtyd commented on a change in pull request #4329: Adding AutoScaling for cks + CKS CoreOS EOL update + systemvmtemplate improvements

2021-08-27 Thread GitBox
rhtyd commented on a change in pull request #4329: URL: https://github.com/apache/cloudstack/pull/4329#discussion_r697271548 ## File path: engine/schema/src/main/java/com/cloud/upgrade/SystemVmTemplateRegistration.java ## @@ -0,0 +1,778 @@ +// Licensed to the Apache Software F

[GitHub] [cloudstack] shwstppr commented on pull request #5371: server: improve attach volume in specific cases

2021-08-27 Thread GitBox
shwstppr commented on pull request #5371: URL: https://github.com/apache/cloudstack/pull/5371#issuecomment-907042976 I've tested VMware hypervisor. Though code doesn't suggest, I will try to test other hypervisors for any regression. @blueorangutan package -- This is an automated mess

[GitHub] [cloudstack] blueorangutan commented on pull request #5366: updated maven dependency due to #5363

2021-08-27 Thread GitBox
blueorangutan commented on pull request #5366: URL: https://github.com/apache/cloudstack/pull/5366#issuecomment-907043142 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1033 -- This is an automated message from

[GitHub] [cloudstack] blueorangutan commented on pull request #5371: server: improve attach volume in specific cases

2021-08-27 Thread GitBox
blueorangutan commented on pull request #5371: URL: https://github.com/apache/cloudstack/pull/5371#issuecomment-907043321 @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To re

[GitHub] [cloudstack] rhtyd commented on a change in pull request #4329: Adding AutoScaling for cks + CKS CoreOS EOL update + systemvmtemplate improvements

2021-08-27 Thread GitBox
rhtyd commented on a change in pull request #4329: URL: https://github.com/apache/cloudstack/pull/4329#discussion_r697277585 ## File path: engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade41510to41600.java ## @@ -66,10 +71,15 @@ public boolean supportsRollingUpgrade()

[GitHub] [cloudstack] rhtyd commented on a change in pull request #4329: Adding AutoScaling for cks + CKS CoreOS EOL update + systemvmtemplate improvements

2021-08-27 Thread GitBox
rhtyd commented on a change in pull request #4329: URL: https://github.com/apache/cloudstack/pull/4329#discussion_r697285144 ## File path: plugins/integrations/kubernetes-service/src/main/resources/conf/k8s-control-node-add.yml ## @@ -17,12 +17,16 @@ # under the License. -

[GitHub] [cloudstack] DaanHoogland commented on pull request #4966: Refactor few process of VirtualMachineManagerImpl and improve logs

2021-08-27 Thread GitBox
DaanHoogland commented on pull request #4966: URL: https://github.com/apache/cloudstack/pull/4966#issuecomment-907056617 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [cloudstack] rhtyd commented on a change in pull request #4329: Adding AutoScaling for cks + CKS CoreOS EOL update + systemvmtemplate improvements

2021-08-27 Thread GitBox
rhtyd commented on a change in pull request #4329: URL: https://github.com/apache/cloudstack/pull/4329#discussion_r697286446 ## File path: server/src/main/java/org/apache/cloudstack/diagnostics/DiagnosticsServiceImpl.java ## @@ -341,7 +341,8 @@ private Answer deleteDiagnostic

[GitHub] [cloudstack] blueorangutan commented on pull request #4966: Refactor few process of VirtualMachineManagerImpl and improve logs

2021-08-27 Thread GitBox
blueorangutan commented on pull request #4966: URL: https://github.com/apache/cloudstack/pull/4966#issuecomment-907057013 @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. T

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4966: Refactor few process of VirtualMachineManagerImpl and improve logs

2021-08-27 Thread GitBox
DaanHoogland commented on a change in pull request #4966: URL: https://github.com/apache/cloudstack/pull/4966#discussion_r697287537 ## File path: engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java ## @@ -4390,13 +4390,18 @@ public VMInstanceVO reCon

[GitHub] [cloudstack] blueorangutan commented on pull request #5371: server: improve attach volume in specific cases

2021-08-27 Thread GitBox
blueorangutan commented on pull request #5371: URL: https://github.com/apache/cloudstack/pull/5371#issuecomment-907060547 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1034 -- This is an automated message from

[GitHub] [cloudstack] rhtyd commented on a change in pull request #4329: Adding AutoScaling for cks + CKS CoreOS EOL update + systemvmtemplate improvements

2021-08-27 Thread GitBox
rhtyd commented on a change in pull request #4329: URL: https://github.com/apache/cloudstack/pull/4329#discussion_r697290677 ## File path: tools/marvin/marvin/config/test_data.py ## @@ -2058,46 +2052,11 @@ }, "1.16.3": { "semanticversion": "1.16.3

[GitHub] [cloudstack] rhtyd commented on a change in pull request #4329: Adding AutoScaling for cks + CKS CoreOS EOL update + systemvmtemplate improvements

2021-08-27 Thread GitBox
rhtyd commented on a change in pull request #4329: URL: https://github.com/apache/cloudstack/pull/4329#discussion_r697291233 ## File path: ui/src/components/view/ResourceView.vue ## @@ -135,27 +135,8 @@ export default { this.$emit('onTabChange', key) }, showTab

[GitHub] [cloudstack] DaanHoogland commented on pull request #5356: server: detach data disks before destroying vms

2021-08-27 Thread GitBox
DaanHoogland commented on pull request #5356: URL: https://github.com/apache/cloudstack/pull/5356#issuecomment-907064675 clgtm, tests done. I've given the failed travis tests another spin. -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [cloudstack] DaanHoogland commented on pull request #5296: [WIP] Centralized logging capability. Follow up on the #4108

2021-08-27 Thread GitBox
DaanHoogland commented on pull request #5296: URL: https://github.com/apache/cloudstack/pull/5296#issuecomment-907070266 > I think It is better to go with the libvirt command option. I found lot of samples in `plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper`

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5373: server: do not remove volume from DB if fail to expunge it from primary storage or secondary storage

2021-08-27 Thread GitBox
DaanHoogland commented on a change in pull request #5373: URL: https://github.com/apache/cloudstack/pull/5373#discussion_r697304106 ## File path: server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java ## @@ -1411,7 +1411,15 @@ protected void expungeVolumesInPrimarySt

[GitHub] [cloudstack] davidjumani commented on pull request #5369: kvm: Add check if host meets the minimum requirements

2021-08-27 Thread GitBox
davidjumani commented on pull request #5369: URL: https://github.com/apache/cloudstack/pull/5369#issuecomment-907074447 Will raise a separate one against 4.15 since it doesn't have suse support -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [cloudstack] davidjumani edited a comment on pull request #5369: kvm: Add check if host meets the minimum requirements

2021-08-27 Thread GitBox
davidjumani edited a comment on pull request #5369: URL: https://github.com/apache/cloudstack/pull/5369#issuecomment-907074447 Affects both, I can raise a separate one against 4.15 since it doesn't have suse support -- This is an automated message from the Apache Git Service. To respond

[GitHub] [cloudstack] blueorangutan commented on pull request #4966: Refactor few process of VirtualMachineManagerImpl and improve logs

2021-08-27 Thread GitBox
blueorangutan commented on pull request #4966: URL: https://github.com/apache/cloudstack/pull/4966#issuecomment-907076002 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1035 -- This is an automated message from

[GitHub] [cloudstack] davidjumani commented on pull request #4636: Prevent vm's from stopping while enabling maintenance mode

2021-08-27 Thread GitBox
davidjumani commented on pull request #4636: URL: https://github.com/apache/cloudstack/pull/4636#issuecomment-907077270 @ravening The host fails to go into maintenance mode if the agent is down, so I have to kill it after I send the command to the MS. Guess that during that time the migrat

[GitHub] [cloudstack] ravening commented on pull request #4636: Prevent vm's from stopping while enabling maintenance mode

2021-08-27 Thread GitBox
ravening commented on pull request #4636: URL: https://github.com/apache/cloudstack/pull/4636#issuecomment-907079031 > @ravening The host fails to go into maintenance mode if the agent is down, so I have to kill it after I send the command to the MS. Guess that during that time the migrati

[GitHub] [cloudstack] rhtyd commented on pull request #5368: ui: Fix action bar in place

2021-08-27 Thread GitBox
rhtyd commented on pull request #5368: URL: https://github.com/apache/cloudstack/pull/5368#issuecomment-907084854 @davidjumani does this affect 4.15 too? Maybe the floating right thingy can be at bottom-right? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack] rhtyd closed pull request #5024: Health Check PR: 4.15

2021-08-27 Thread GitBox
rhtyd closed pull request #5024: URL: https://github.com/apache/cloudstack/pull/5024 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsub

[GitHub] [cloudstack] rhtyd commented on pull request #5024: Health Check PR: 4.15

2021-08-27 Thread GitBox
rhtyd commented on pull request #5024: URL: https://github.com/apache/cloudstack/pull/5024#issuecomment-907085360 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [cloudstack] weizhouapache commented on a change in pull request #5373: server: do not remove volume from DB if fail to expunge it from primary storage or secondary storage

2021-08-27 Thread GitBox
weizhouapache commented on a change in pull request #5373: URL: https://github.com/apache/cloudstack/pull/5373#discussion_r697317698 ## File path: server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java ## @@ -1411,7 +1411,15 @@ protected void expungeVolumesInPrimaryS

[GitHub] [cloudstack] blueorangutan commented on pull request #5024: Health Check PR: 4.15

2021-08-27 Thread GitBox
blueorangutan commented on pull request #5024: URL: https://github.com/apache/cloudstack/pull/5024#issuecomment-907085943 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respo

[GitHub] [cloudstack] PaulAngus commented on pull request #4200: Allow domain admins to create offering without mentioning domainid

2021-08-27 Thread GitBox
PaulAngus commented on pull request #4200: URL: https://github.com/apache/cloudstack/pull/4200#issuecomment-907087891 to reiterate; - I'm -0 on this. - This adds some amount of risk with no real stated justification as far as I can see - There are over 40 parameters to the crea

[cloudstack] branch main updated (8e0e5ac -> f957457)

2021-08-27 Thread davidjumani
This is an automated email from the ASF dual-hosted git repository. davidjumani pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 8e0e5ac Externalize VMWare stats time window config (#5357) add b3dca8c ui: Go back for delete actions

[cloudstack] 01/01: Merge remote-tracking branch 'apache/4.15' into main

2021-08-27 Thread davidjumani
This is an automated email from the ASF dual-hosted git repository. davidjumani pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit f957457c05ef775bcaead5218d31413d876a2bf6 Merge: 8e0e5ac b3dca8c Author: davidjumani AuthorDate: Fri Aug 27 15:39:

[GitHub] [cloudstack] blueorangutan commented on pull request #5024: Health Check PR: 4.15

2021-08-27 Thread GitBox
blueorangutan commented on pull request #5024: URL: https://github.com/apache/cloudstack/pull/5024#issuecomment-907099677 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 1036 -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] Pearl1594 commented on pull request #5379: api: List details of template download state for stores corresponding to a zone

2021-08-27 Thread GitBox
Pearl1594 commented on pull request #5379: URL: https://github.com/apache/cloudstack/pull/5379#issuecomment-907102213 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [cloudstack] blueorangutan commented on pull request #5379: api: List details of template download state for stores corresponding to a zone

2021-08-27 Thread GitBox
blueorangutan commented on pull request #5379: URL: https://github.com/apache/cloudstack/pull/5379#issuecomment-907102739 @Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] soreana commented on pull request #5296: [WIP] Centralized logging capability. Follow up on the #4108

2021-08-27 Thread GitBox
soreana commented on pull request #5296: URL: https://github.com/apache/cloudstack/pull/5296#issuecomment-907103272 @DaanHoogland Honestly, when I tried to change the code to add a libvirt command, I noticed how many changes it requires for such a small task. I searched for other options.

[GitHub] [cloudstack] DK101010 opened a new pull request #5382: fix mismatching between db uuids and custom attributes uuids

2021-08-27 Thread GitBox
DK101010 opened a new pull request #5382: URL: https://github.com/apache/cloudstack/pull/5382 ### Description During the datastore cluster creation, cloudstack could not recognize the existing primary storage and create a new one because uuid format not equal.

[GitHub] [cloudstack] rhtyd commented on pull request #5024: Health Check PR: 4.15

2021-08-27 Thread GitBox
rhtyd commented on pull request #5024: URL: https://github.com/apache/cloudstack/pull/5024#issuecomment-907109538 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [cloudstack] blueorangutan commented on pull request #5024: Health Check PR: 4.15

2021-08-27 Thread GitBox
blueorangutan commented on pull request #5024: URL: https://github.com/apache/cloudstack/pull/5024#issuecomment-907109743 @rhtyd a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests -- This is an automa

[GitHub] [cloudstack] DaanHoogland commented on pull request #5296: [WIP] Centralized logging capability. Follow up on the #4108

2021-08-27 Thread GitBox
DaanHoogland commented on pull request #5296: URL: https://github.com/apache/cloudstack/pull/5296#issuecomment-90748 sounds like a plan @soreana -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [cloudstack] rhtyd closed pull request #5008: Decouple service (compute) offering and disk offering

2021-08-27 Thread GitBox
rhtyd closed pull request #5008: URL: https://github.com/apache/cloudstack/pull/5008 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsub

[GitHub] [cloudstack] rhtyd commented on pull request #5008: Decouple service (compute) offering and disk offering

2021-08-27 Thread GitBox
rhtyd commented on pull request #5008: URL: https://github.com/apache/cloudstack/pull/5008#issuecomment-907112719 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [cloudstack] rhtyd commented on pull request #5374: [VMware] Cancel the pending tasks for a worker VM before destroying it

2021-08-27 Thread GitBox
rhtyd commented on pull request #5374: URL: https://github.com/apache/cloudstack/pull/5374#issuecomment-907113200 @sureshanaparti does it affect 4.15 too? If yes pl raise PR against 4.15. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [cloudstack] blueorangutan commented on pull request #5008: Decouple service (compute) offering and disk offering

2021-08-27 Thread GitBox
blueorangutan commented on pull request #5008: URL: https://github.com/apache/cloudstack/pull/5008#issuecomment-907113268 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respo

[GitHub] [cloudstack] rhtyd commented on pull request #5311: [VMware] Start VM with deploy-as-is template having multiple controller types

2021-08-27 Thread GitBox
rhtyd commented on pull request #5311: URL: https://github.com/apache/cloudstack/pull/5311#issuecomment-907114110 @sureshanaparti does this affect 4.15 too? If so, pl raise PR against 4.15 branch. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [cloudstack] rhtyd commented on pull request #5333: vmware: delete snapshot disk after backup to secondary storage

2021-08-27 Thread GitBox
rhtyd commented on pull request #5333: URL: https://github.com/apache/cloudstack/pull/5333#issuecomment-907114300 There may be related PR, @sureshanaparti @harikrishna-patnala can you check and advise if I should close it? -- This is an automated message from the Apache Git Service. To r

[GitHub] [cloudstack] rhtyd commented on pull request #5339: server: check server capacity when start/deploy a vm

2021-08-27 Thread GitBox
rhtyd commented on pull request #5339: URL: https://github.com/apache/cloudstack/pull/5339#issuecomment-907114663 @weizhouapache does this affect 4.15 too? If so, pl raise PR against 4.15 branch. -- This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5382: fix mismatching between db uuids and custom attributes uuids

2021-08-27 Thread GitBox
DaanHoogland commented on a change in pull request #5382: URL: https://github.com/apache/cloudstack/pull/5382#discussion_r697347340 ## File path: server/src/main/java/com/cloud/storage/StorageManagerImpl.java ## @@ -1834,6 +1836,43 @@ public void syncDatastoreClusterStoragePool

[GitHub] [cloudstack] rhtyd commented on pull request #5356: server: detach data disks before destroying vms

2021-08-27 Thread GitBox
rhtyd commented on pull request #5356: URL: https://github.com/apache/cloudstack/pull/5356#issuecomment-907115258 @weizhouapache does this affect 4.15 too? If so, pl raise PR against 4.15 branch if it's a bug fix. Thanks. -- This is an automated message from the Apache Git Service. To re

[GitHub] [cloudstack] rhtyd merged pull request #5367: ui: Fix search with same parameters

2021-08-27 Thread GitBox
rhtyd merged pull request #5367: URL: https://github.com/apache/cloudstack/pull/5367 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsub

[cloudstack] branch 4.15 updated (b3dca8c -> 442f89c)

2021-08-27 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch 4.15 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from b3dca8c ui: Go back for delete actions before querying async job (#5360) add 442f89c ui: Fix search with sam

[GitHub] [cloudstack] rhtyd commented on pull request #5371: server: improve attach volume in specific cases

2021-08-27 Thread GitBox
rhtyd commented on pull request #5371: URL: https://github.com/apache/cloudstack/pull/5371#issuecomment-907116939 @shwstppr does this affect 4.15? If so please change PR branch to 4.15 esp for bugfixes, thanks. -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [cloudstack] rhtyd commented on pull request #5377: [VMware] Added Worker VM tags for few cloned VMs while performing some volume operations.

2021-08-27 Thread GitBox
rhtyd commented on pull request #5377: URL: https://github.com/apache/cloudstack/pull/5377#issuecomment-907117246 @sureshanaparti does this affect 4.15? If so please change PR branch to 4.15 esp for bugfixes, thanks. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [cloudstack] weizhouapache commented on pull request #5356: server: detach data disks before destroying vms

2021-08-27 Thread GitBox
weizhouapache commented on pull request #5356: URL: https://github.com/apache/cloudstack/pull/5356#issuecomment-907119819 > @weizhouapache does this affect 4.15 too? If so, pl raise PR against 4.15 branch if it's a bug fix. Thanks. @rhtyd @nvazquez changed base branch back to 4.15

[GitHub] [cloudstack] rhtyd commented on a change in pull request #5008: Decouple service (compute) offering and disk offering

2021-08-27 Thread GitBox
rhtyd commented on a change in pull request #5008: URL: https://github.com/apache/cloudstack/pull/5008#discussion_r697353145 ## File path: api/src/main/java/org/apache/cloudstack/api/command/user/volume/ChangeOfferingForVolumeCmd.java ## @@ -0,0 +1,141 @@ +// Licensed to the A

[GitHub] [cloudstack] shwstppr commented on pull request #5371: server: improve attach volume in specific cases

2021-08-27 Thread GitBox
shwstppr commented on pull request #5371: URL: https://github.com/apache/cloudstack/pull/5371#issuecomment-907123832 @rhtyd will check but as per my understanding migrating VM across clusters with only cluster scope pools might fail in 4.15 especially for VMware -- This is an automated m

[GitHub] [cloudstack] rhtyd opened a new pull request #5383: engine/schema: Upgrade path from 4.15.1.0 to 4.15.2.0

2021-08-27 Thread GitBox
rhtyd opened a new pull request #5383: URL: https://github.com/apache/cloudstack/pull/5383 The explicit no-op upgrade path. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [cloudstack] rhtyd commented on pull request #5383: engine/schema: Upgrade path from 4.15.1.0 to 4.15.2.0

2021-08-27 Thread GitBox
rhtyd commented on pull request #5383: URL: https://github.com/apache/cloudstack/pull/5383#issuecomment-907127246 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [cloudstack] blueorangutan commented on pull request #5383: engine/schema: Upgrade path from 4.15.1.0 to 4.15.2.0

2021-08-27 Thread GitBox
blueorangutan commented on pull request #5383: URL: https://github.com/apache/cloudstack/pull/5383#issuecomment-907127783 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respo

[GitHub] [cloudstack] blueorangutan commented on pull request #5008: Decouple service (compute) offering and disk offering

2021-08-27 Thread GitBox
blueorangutan commented on pull request #5008: URL: https://github.com/apache/cloudstack/pull/5008#issuecomment-907127789 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1037 -- This is an automated message from

[cloudstack] 01/01: Merge remote-tracking branch 'origin/4.15' into main

2021-08-27 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit 7f3bb940997d38309fb6aecd87625b2b9924a715 Merge: f957457 442f89c Author: Rohit Yadav AuthorDate: Fri Aug 27 16:47:06 202

  1   2   3   >