[GitHub] [cloudstack] Pearl1594 commented on pull request #5337: Bypass empty string check for username and password

2021-08-20 Thread GitBox
Pearl1594 commented on pull request #5337: URL: https://github.com/apache/cloudstack/pull/5337#issuecomment-902621006 @weizhouapache I believe this issue is only seen on main branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5337: Bypass empty string check for username and password

2021-08-20 Thread GitBox
DaanHoogland commented on a change in pull request #5337: URL: https://github.com/apache/cloudstack/pull/5337#discussion_r692867216 ## File path: server/src/main/java/com/cloud/resource/ResourceManagerImpl.java ## @@ -687,6 +688,10 @@ public Discoverer getMatchingDiscover(final

[GitHub] [cloudstack] DaanHoogland merged pull request #5328: Fix iptable rules when chain reference count is 0

2021-08-20 Thread GitBox
DaanHoogland merged pull request #5328: URL: https://github.com/apache/cloudstack/pull/5328 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commit

[cloudstack] branch 4.15 updated: Fix iptable rules when chain reference count is 0 (#5328)

2021-08-20 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch 4.15 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.15 by this push: new c1fc002 Fix iptable rules when chain reference co

[GitHub] [cloudstack] DaanHoogland commented on pull request #4200: Allow domain admins to create offering without mentioning domainid

2021-08-20 Thread GitBox
DaanHoogland commented on pull request #4200: URL: https://github.com/apache/cloudstack/pull/4200#issuecomment-902623331 > negligible benefit. I think the benefit is commercial, but can't be sure. and yes, oxygen is getting low. put it behind a setting that defaults to false please.

[cloudstack] branch main updated (25206e4 -> d841709)

2021-08-20 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 25206e4 test: Frix travis failure - test_outofbandmanagement.py (#5346) add c1fc002 Fix iptable rules when c

[cloudstack] 01/01: Merge remote-tracking branch 'origin/4.15' into main

2021-08-20 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit d841709efc6fd8cea0bf4ec6e41b6f8ca2571eff Merge: 25206e4 c1fc002 Author: Rohit Yadav AuthorDate: Fri Aug 20 16:52:32 202

[GitHub] [cloudstack] rhtyd commented on a change in pull request #5319: vr: reload dnsmasq when start vms

2021-08-20 Thread GitBox
rhtyd commented on a change in pull request #5319: URL: https://github.com/apache/cloudstack/pull/5319#discussion_r692871608 ## File path: systemvm/debian/opt/cloud/bin/cs/CsDhcp.py ## @@ -58,17 +58,11 @@ def process(self): if self.conf.commit(): restart_d

[GitHub] [cloudstack] ravening opened a new pull request #4259: Reserve memory for host

2021-08-20 Thread GitBox
ravening opened a new pull request #4259: URL: https://github.com/apache/cloudstack/pull/4259 ## Description By default cloudstack reserves 1Gb of RAM in hosts using _dom0_memory field. Add a global setting "host.reserved.mem.mb" which can used to either increase or decrese t

[GitHub] [cloudstack] nvazquez closed pull request #4259: Reserve memory for host

2021-08-20 Thread GitBox
nvazquez closed pull request #4259: URL: https://github.com/apache/cloudstack/pull/4259 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-un

[GitHub] [cloudstack] slavkap opened a new pull request #5349: Fix of creating volumes from snapshots without backup to secondary storage

2021-08-20 Thread GitBox
slavkap opened a new pull request #5349: URL: https://github.com/apache/cloudstack/pull/5349 ### Description Fixes #4433 - `snapshot.backup.to.secondary=false` - Create 2 or more snapshots on Ceph/NFS - Create volume/template from a snapshot. The snapshot first is copied

[GitHub] [cloudstack] rhtyd commented on pull request #5319: vr: reload dnsmasq when start vms

2021-08-20 Thread GitBox
rhtyd commented on pull request #5319: URL: https://github.com/apache/cloudstack/pull/5319#issuecomment-902627375 Suggested tests if not already done - please check/confirm @weizhouapache cc @nvazquez Monitor dnsmasq service and check expected outcome for cases in both isolated netw

[GitHub] [cloudstack] nvazquez closed pull request #5339: server: check server capacity when start/deploy or migrate a vm

2021-08-20 Thread GitBox
nvazquez closed pull request #5339: URL: https://github.com/apache/cloudstack/pull/5339 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-un

[GitHub] [cloudstack] blueorangutan commented on pull request #5346: test: Fix travis failure - test_outofbandmanagement.py

2021-08-20 Thread GitBox
blueorangutan commented on pull request #5346: URL: https://github.com/apache/cloudstack/pull/5346#issuecomment-902628222 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 953 -- This is an automated message from t

[cloudstack] branch main updated (d841709 -> 4d9f178)

2021-08-20 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from d841709 Merge remote-tracking branch 'origin/4.15' into main add 4d9f178 README: update travis badge No new

[GitHub] [cloudstack] rhtyd commented on pull request #5349: Fix of creating volumes from snapshots without backup to secondary storage

2021-08-20 Thread GitBox
rhtyd commented on pull request #5349: URL: https://github.com/apache/cloudstack/pull/5349#issuecomment-902629025 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [cloudstack] blueorangutan commented on pull request #5349: Fix of creating volumes from snapshots without backup to secondary storage

2021-08-20 Thread GitBox
blueorangutan commented on pull request #5349: URL: https://github.com/apache/cloudstack/pull/5349#issuecomment-902629225 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respo

[GitHub] [cloudstack] rhtyd commented on a change in pull request #5348: security group: fix component test test_multiple_nic_support.py failures

2021-08-20 Thread GitBox
rhtyd commented on a change in pull request #5348: URL: https://github.com/apache/cloudstack/pull/5348#discussion_r692875853 ## File path: test/integration/component/test_multiple_nic_support.py ## @@ -224,7 +224,7 @@ def setUpClass(cls): cls.virtual_machin

[GitHub] [cloudstack] rhtyd commented on a change in pull request #5348: security group: fix component test test_multiple_nic_support.py failures

2021-08-20 Thread GitBox
rhtyd commented on a change in pull request #5348: URL: https://github.com/apache/cloudstack/pull/5348#discussion_r692876989 ## File path: test/integration/component/test_multiple_nic_support.py ## @@ -224,7 +224,7 @@ def setUpClass(cls): cls.virtual_machin

[GitHub] [cloudstack] blueorangutan commented on pull request #5157: UI: Support to upload resource icons

2021-08-20 Thread GitBox
blueorangutan commented on pull request #5157: URL: https://github.com/apache/cloudstack/pull/5157#issuecomment-902630583 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 954 -- This is an automated message from t

[GitHub] [cloudstack] rhtyd merged pull request #5348: security group: fix component test test_multiple_nic_support.py failures

2021-08-20 Thread GitBox
rhtyd merged pull request #5348: URL: https://github.com/apache/cloudstack/pull/5348 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsub

[cloudstack] branch 4.15 updated: security group: fix component test test_multiple_nic_support.py failures (#5348)

2021-08-20 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch 4.15 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.15 by this push: new f9fe9da security group: fix component test test

[GitHub] [cloudstack] shwstppr commented on pull request #5335: xcp-ng: allow passing vm boot options

2021-08-20 Thread GitBox
shwstppr commented on pull request #5335: URL: https://github.com/apache/cloudstack/pull/5335#issuecomment-902631287 @tsinik-dw Will have to check migration but at the moment I think that may not be needed as `createVmFromTemplate` (and in turn `setVmBootDetails`) method is called every ti

[GitHub] [cloudstack] rhtyd closed pull request #5341: remove doubles before save

2021-08-20 Thread GitBox
rhtyd closed pull request #5341: URL: https://github.com/apache/cloudstack/pull/5341 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsub

[GitHub] [cloudstack] rhtyd commented on pull request #5341: remove doubles before save

2021-08-20 Thread GitBox
rhtyd commented on pull request #5341: URL: https://github.com/apache/cloudstack/pull/5341#issuecomment-902631335 (rekicked travis) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [cloudstack] blueorangutan commented on pull request #5335: xcp-ng: allow passing vm boot options

2021-08-20 Thread GitBox
blueorangutan commented on pull request #5335: URL: https://github.com/apache/cloudstack/pull/5335#issuecomment-902631384 @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To re

[GitHub] [cloudstack] rhtyd commented on pull request #5337: Bypass empty string check for username and password

2021-08-20 Thread GitBox
rhtyd commented on pull request #5337: URL: https://github.com/apache/cloudstack/pull/5337#issuecomment-902631858 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [cloudstack] blueorangutan commented on pull request #5337: Bypass empty string check for username and password

2021-08-20 Thread GitBox
blueorangutan commented on pull request #5337: URL: https://github.com/apache/cloudstack/pull/5337#issuecomment-902632320 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respo

[GitHub] [cloudstack] rhtyd merged pull request #5331: vr: cleanup files in /var/cache/cloud/processed every day

2021-08-20 Thread GitBox
rhtyd merged pull request #5331: URL: https://github.com/apache/cloudstack/pull/5331 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsub

[cloudstack] branch 4.15 updated: vr: cleanup files in /var/cache/cloud/processed every day (#5331)

2021-08-20 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch 4.15 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.15 by this push: new 0390281 vr: cleanup files in /var/cache/cloud/pr

[GitHub] [cloudstack] rhtyd commented on issue #3757: Files in /var/cache/cloud/processed on virtual router are not cleaned up

2021-08-20 Thread GitBox
rhtyd commented on issue #3757: URL: https://github.com/apache/cloudstack/issues/3757#issuecomment-902632434 Fixed by https://github.com/apache/cloudstack/pull/5331 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [cloudstack] rhtyd closed issue #3757: Files in /var/cache/cloud/processed on virtual router are not cleaned up

2021-08-20 Thread GitBox
rhtyd closed issue #3757: URL: https://github.com/apache/cloudstack/issues/3757 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr..

[GitHub] [cloudstack] shwstppr commented on issue #5204: After update to 4.15.1 all windows vms switch to uefi and they don't boot (xcp-ng 8.2)

2021-08-20 Thread GitBox
shwstppr commented on issue #5204: URL: https://github.com/apache/cloudstack/issues/5204#issuecomment-902632925 @AlexanderKgr don't think the values form UI were honored by ACS Xen orchestration code. Don't see anything there. Hi guys, any idea how to check if a Xen/XCP-ng host has U

[GitHub] [cloudstack] rhtyd commented on pull request #5324: Improve Travis CI build Performance

2021-08-20 Thread GitBox
rhtyd commented on pull request #5324: URL: https://github.com/apache/cloudstack/pull/5324#issuecomment-902633007 If you/we search we've had a discussion somewhere about this, I don't think removing the travis_wait benefits; instead removing it may cause failures if/when deploy datacenter

[GitHub] [cloudstack] rhtyd edited a comment on pull request #5324: Improve Travis CI build Performance

2021-08-20 Thread GitBox
rhtyd edited a comment on pull request #5324: URL: https://github.com/apache/cloudstack/pull/5324#issuecomment-902633007 If you/we search we've had a discussion somewhere about this, I don't think removing the travis_wait benefits; instead removing it may cause failures if/when deploy data

[GitHub] [cloudstack] shwstppr commented on pull request #5335: xcp-ng: allow passing vm boot options

2021-08-20 Thread GitBox
shwstppr commented on pull request #5335: URL: https://github.com/apache/cloudstack/pull/5335#issuecomment-902633741 With current changes by setting boot type and mode from UI/API, I was able to get VM running with desired boot options, ```[17:00 xcp-ng1 ~]# xe vm-list params=all uuid=4

[GitHub] [cloudstack] rhtyd commented on a change in pull request #5259: usage: create backup usage record for vmId-offeringId pair

2021-08-20 Thread GitBox
rhtyd commented on a change in pull request #5259: URL: https://github.com/apache/cloudstack/pull/5259#discussion_r692881237 ## File path: usage/src/main/java/com/cloud/usage/parser/BackupUsageParser.java ## @@ -68,18 +68,7 @@ public static boolean parse(AccountVO account, Date

[GitHub] [cloudstack] rhtyd commented on pull request #5259: usage: create backup usage record for vmId-offeringId pair

2021-08-20 Thread GitBox
rhtyd commented on pull request #5259: URL: https://github.com/apache/cloudstack/pull/5259#issuecomment-902634338 @Pearl1594 I think you're aware of the original issue, can you review this? cc @nvazquez @weizhouapache -- This is an automated message from the Apache Git Service. To respo

[GitHub] [cloudstack] rhtyd closed pull request #5259: usage: create backup usage record for vmId-offeringId pair

2021-08-20 Thread GitBox
rhtyd closed pull request #5259: URL: https://github.com/apache/cloudstack/pull/5259 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsub

[GitHub] [cloudstack] rhtyd commented on pull request #5194: adapt condition to use the correct letter for pvlan types

2021-08-20 Thread GitBox
rhtyd commented on pull request #5194: URL: https://github.com/apache/cloudstack/pull/5194#issuecomment-902634847 Ping @davidjumani can you review this - I think you worked on pvlan related feature so you may have some ideas to review/test this? cc @nvazquez -- This is an automated mess

[GitHub] [cloudstack] weizhouapache commented on pull request #5337: Bypass empty string check for username and password

2021-08-20 Thread GitBox
weizhouapache commented on pull request #5337: URL: https://github.com/apache/cloudstack/pull/5337#issuecomment-902635785 > @weizhouapache I believe this issue is only seen on main branch @Pearl1594 ok, got it. thanks for confirm -- This is an automated message from the Apache Git

[GitHub] [cloudstack] rhtyd commented on issue #5204: After update to 4.15.1 all windows vms switch to uefi and they don't boot (xcp-ng 8.2)

2021-08-20 Thread GitBox
rhtyd commented on issue #5204: URL: https://github.com/apache/cloudstack/issues/5204#issuecomment-902636224 @shwstppr the dom0 is linux so you check if `/sys/firmware/efi` exists https://askubuntu.com/questions/162564/how-can-i-tell-if-my-system-was-booted-as-efi-uefi-or-bios -- This

[cloudstack] branch main updated (4d9f178 -> 57a55bd)

2021-08-20 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 4d9f178 README: update travis badge add f9fe9da security group: fix component test test_multiple_nic_support

[cloudstack] 01/01: Merge remote-tracking branch 'origin/4.15' into main

2021-08-20 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit 57a55bd77729e63d290c003aac63b33f145e3d7b Merge: 4d9f178 0390281 Author: Rohit Yadav AuthorDate: Fri Aug 20 17:19:40 202

[GitHub] [cloudstack] weizhouapache commented on a change in pull request #5348: security group: fix component test test_multiple_nic_support.py failures

2021-08-20 Thread GitBox
weizhouapache commented on a change in pull request #5348: URL: https://github.com/apache/cloudstack/pull/5348#discussion_r692886230 ## File path: test/integration/component/test_multiple_nic_support.py ## @@ -224,7 +224,7 @@ def setUpClass(cls): cls.virtua

[GitHub] [cloudstack] blueorangutan commented on pull request #5337: Bypass empty string check for username and password

2021-08-20 Thread GitBox
blueorangutan commented on pull request #5337: URL: https://github.com/apache/cloudstack/pull/5337#issuecomment-902640188 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: debian. SL-JID 955 -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack] tcp-dw commented on issue #5204: After update to 4.15.1 all windows vms switch to uefi and they don't boot (xcp-ng 8.2)

2021-08-20 Thread GitBox
tcp-dw commented on issue #5204: URL: https://github.com/apache/cloudstack/issues/5204#issuecomment-902646599 @shwstppr I think that the only way to do it is to check the destination hypervisor's version. Citrix Hypervisor 8.0 and XCP-ng 8.0 firstly supported UEFI as experimental feature.

[GitHub] [cloudstack] blueorangutan commented on pull request #5349: Fix of creating volumes from snapshots without backup to secondary storage

2021-08-20 Thread GitBox
blueorangutan commented on pull request #5349: URL: https://github.com/apache/cloudstack/pull/5349#issuecomment-902649522 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 956 -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] blueorangutan commented on pull request #5337: Bypass empty string check for username and password

2021-08-20 Thread GitBox
blueorangutan commented on pull request #5337: URL: https://github.com/apache/cloudstack/pull/5337#issuecomment-902650745 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 958 -- This is an automated message from t

[GitHub] [cloudstack] blueorangutan commented on pull request #5335: xcp-ng: allow passing vm boot options

2021-08-20 Thread GitBox
blueorangutan commented on pull request #5335: URL: https://github.com/apache/cloudstack/pull/5335#issuecomment-902650746 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 957 -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] Pearl1594 commented on pull request #5337: Bypass empty string check for username and password

2021-08-20 Thread GitBox
Pearl1594 commented on pull request #5337: URL: https://github.com/apache/cloudstack/pull/5337#issuecomment-902651653 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [cloudstack] blueorangutan commented on pull request #5337: Bypass empty string check for username and password

2021-08-20 Thread GitBox
blueorangutan commented on pull request #5337: URL: https://github.com/apache/cloudstack/pull/5337#issuecomment-902651844 @Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] blueorangutan commented on pull request #5321: Remove storage scope validation on KVM live migration

2021-08-20 Thread GitBox
blueorangutan commented on pull request #5321: URL: https://github.com/apache/cloudstack/pull/5321#issuecomment-902653720 Trillian test result (tid-1729) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 32803 seconds Marvin logs: https://githu

[GitHub] [cloudstack] tetra12 opened a new issue #5350: Drop Agent dependency on qemu-kvm for Ubuntu

2021-08-20 Thread GitBox
tetra12 opened a new issue #5350: URL: https://github.com/apache/cloudstack/issues/5350 # ISSUE TYPE * Improvement Request # COMPONENT NAME ~~~ Agent, Core ~~~ # CLOUDSTACK VERSION ~~~ 4.16.0-Snapshot ~~~ # CO

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5348: security group: fix component test test_multiple_nic_support.py failures

2021-08-20 Thread GitBox
DaanHoogland commented on a change in pull request #5348: URL: https://github.com/apache/cloudstack/pull/5348#discussion_r692903525 ## File path: test/integration/component/test_multiple_nic_support.py ## @@ -224,7 +224,7 @@ def setUpClass(cls): cls.virtual

[GitHub] [cloudstack] weizhouapache commented on pull request #4200: Allow domain admins to create offering without mentioning domainid

2021-08-20 Thread GitBox
weizhouapache commented on pull request #4200: URL: https://github.com/apache/cloudstack/pull/4200#issuecomment-902654251 > > negligible benefit. > > I think the benefit is commercial, but can't be sure. and yes, oxygen is getting low. put it behind a setting that defaults to false p

[GitHub] [cloudstack] DaanHoogland commented on pull request #5348: security group: fix component test test_multiple_nic_support.py failures

2021-08-20 Thread GitBox
DaanHoogland commented on pull request #5348: URL: https://github.com/apache/cloudstack/pull/5348#issuecomment-902655477 wait, this was merged with these suggestions? Do we need to revert? -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [cloudstack] weizhouapache commented on pull request #5348: security group: fix component test test_multiple_nic_support.py failures

2021-08-20 Thread GitBox
weizhouapache commented on pull request #5348: URL: https://github.com/apache/cloudstack/pull/5348#issuecomment-902656132 > wait, this was merged with these suggestions? Do we need to revert? @DaanHoogland if it works with python3, no need to revert it. it is just component test whic

[GitHub] [cloudstack] DaanHoogland commented on pull request #5348: security group: fix component test test_multiple_nic_support.py failures

2021-08-20 Thread GitBox
DaanHoogland commented on pull request #5348: URL: https://github.com/apache/cloudstack/pull/5348#issuecomment-902656888 ok, i didn't test it yet, but i will and amend if needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [cloudstack] weizhouapache commented on a change in pull request #5345: UI - VM - hide button take vm volume snapshot for Destroyed state

2021-08-20 Thread GitBox
weizhouapache commented on a change in pull request #5345: URL: https://github.com/apache/cloudstack/pull/5345#discussion_r692911989 ## File path: ui/src/config/section/compute.js ## @@ -181,6 +181,10 @@ export default { docHelp: 'adminguide/virtual_machines.html#vi

[GitHub] [cloudstack] weizhouapache commented on a change in pull request #5345: UI - VM - hide button take vm volume snapshot for Destroyed state

2021-08-20 Thread GitBox
weizhouapache commented on a change in pull request #5345: URL: https://github.com/apache/cloudstack/pull/5345#discussion_r692912553 ## File path: ui/src/config/section/compute.js ## @@ -181,6 +181,10 @@ export default { docHelp: 'adminguide/virtual_machines.html#vi

[GitHub] [cloudstack] apurv-1 commented on pull request #5122: UI: Keyboard label shortcut

2021-08-20 Thread GitBox
apurv-1 commented on pull request #5122: URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-902664681 > Hi @apurv-1, can we make some small cosmetic changes to the shortcuts please > > **Compute** > > * c + i = Instances > * c + k = Kubernetes > > **Sto

[GitHub] [cloudstack] vladimirpetrov commented on pull request #5157: UI: Support to upload resource icons

2021-08-20 Thread GitBox
vladimirpetrov commented on pull request #5157: URL: https://github.com/apache/cloudstack/pull/5157#issuecomment-902664747 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [cloudstack] apurv-1 edited a comment on pull request #5122: UI: Keyboard label shortcut

2021-08-20 Thread GitBox
apurv-1 edited a comment on pull request #5122: URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-902664681 > Hi @apurv-1, can we make some small cosmetic changes to the shortcuts please > > **Compute** > > * c + i = Instances > * c + k = Kubernetes >

[GitHub] [cloudstack] weizhouapache closed pull request #4534: Migrate vm across clusters

2021-08-20 Thread GitBox
weizhouapache closed pull request #4534: URL: https://github.com/apache/cloudstack/pull/4534 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commi

[GitHub] [cloudstack] blueorangutan commented on pull request #5157: UI: Support to upload resource icons

2021-08-20 Thread GitBox
blueorangutan commented on pull request #5157: URL: https://github.com/apache/cloudstack/pull/5157#issuecomment-902665198 @vladimirpetrov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] apurv-1 edited a comment on pull request #5122: UI: Keyboard label shortcut

2021-08-20 Thread GitBox
apurv-1 edited a comment on pull request #5122: URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-902664681 @borisstoyanov, I've updated the keys! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [cloudstack] apurv-1 commented on pull request #5122: UI: Keyboard label shortcut

2021-08-20 Thread GitBox
apurv-1 commented on pull request #5122: URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-902665882 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [cloudstack] blueorangutan commented on pull request #5122: UI: Keyboard label shortcut

2021-08-20 Thread GitBox
blueorangutan commented on pull request #5122: URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-902666229 @apurv-1 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To re

[GitHub] [cloudstack] nvazquez commented on pull request #5194: adapt condition to use the correct letter for pvlan types

2021-08-20 Thread GitBox
nvazquez commented on pull request #5194: URL: https://github.com/apache/cloudstack/pull/5194#issuecomment-902668248 @rhtyd as discussed in #5202 this PR is good to go, but needs a separate PR to address the upgrade for older pvlans (DB upgrade will not work) -- This is an automated mess

[GitHub] [cloudstack] nvazquez merged pull request #5194: adapt condition to use the correct letter for pvlan types

2021-08-20 Thread GitBox
nvazquez merged pull request #5194: URL: https://github.com/apache/cloudstack/pull/5194 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-un

[cloudstack] branch main updated (57a55bd -> 1b041ee)

2021-08-20 Thread nvazquez
This is an automated email from the ASF dual-hosted git repository. nvazquez pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 57a55bd Merge remote-tracking branch 'origin/4.15' into main add 1b041ee adapt condition to use the correc

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5348: security group: fix component test test_multiple_nic_support.py failures

2021-08-20 Thread GitBox
DaanHoogland commented on a change in pull request #5348: URL: https://github.com/apache/cloudstack/pull/5348#discussion_r692921578 ## File path: test/integration/component/test_multiple_nic_support.py ## @@ -224,7 +224,7 @@ def setUpClass(cls): cls.virtual

[GitHub] [cloudstack] blueorangutan commented on pull request #5122: UI: Keyboard label shortcut

2021-08-20 Thread GitBox
blueorangutan commented on pull request #5122: URL: https://github.com/apache/cloudstack/pull/5122#issuecomment-902670787 UI build: :heavy_check_mark: Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5122 (SL-JID-542) -- This is an automated message from the Apache Git Service. T

[GitHub] [cloudstack] weizhouapache commented on issue #5350: Drop Agent dependency on qemu-kvm for Ubuntu

2021-08-20 Thread GitBox
weizhouapache commented on issue #5350: URL: https://github.com/apache/cloudstack/issues/5350#issuecomment-902673857 @rhtyd @DaanHoogland do we support non-stock qemu version on hypervisors ? do we support non-LTS ubuntu versions as hypervisors ? qemu-kvm is not installed in ubuntu

[GitHub] [cloudstack] tetra12 commented on issue #5350: Drop Agent dependency on qemu-kvm for Ubuntu

2021-08-20 Thread GitBox
tetra12 commented on issue #5350: URL: https://github.com/apache/cloudstack/issues/5350#issuecomment-902676532 That's what ppl say about `qemu-kvm` [here](https://linux.debian.user.narkive.com/yv4308hI/qemu-kvm-won-t-install-on-bullseye-installs-qemu-system-x86-instead) -- This is an aut

[GitHub] [cloudstack] weizhouapache commented on a change in pull request #4362: Match template tags with host tag for vm deployment

2021-08-20 Thread GitBox
weizhouapache commented on a change in pull request #4362: URL: https://github.com/apache/cloudstack/pull/4362#discussion_r692928496 ## File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java ## @@ -3672,6 +3676,10 @@ else if (!template.isPublicTemplate() &&

[GitHub] [cloudstack] GabrielBrascher commented on pull request #4200: Allow domain admins to create offering without mentioning domainid

2021-08-20 Thread GitBox
GabrielBrascher commented on pull request #4200: URL: https://github.com/apache/cloudstack/pull/4200#issuecomment-902679167 I would be "-1" only in the case of a domain admin creating public offerings when the domain ID is NULL. However, this has been already checked and that's not the cas

[GitHub] [cloudstack] SadiJr opened a new pull request #5351: Externalize vm stats increment in memory

2021-08-20 Thread GitBox
SadiJr opened a new pull request #5351: URL: https://github.com/apache/cloudstack/pull/5351 ### Description CloudStack has a feature to keep and increment the VM metrics in memory. This PR intends to externalize one new configuration, `vm.stats.increment.metrics.in.memory` to allow

[GitHub] [cloudstack] DaanHoogland commented on pull request #5349: Fix of creating volumes from snapshots without backup to secondary storage

2021-08-20 Thread GitBox
DaanHoogland commented on pull request #5349: URL: https://github.com/apache/cloudstack/pull/5349#issuecomment-902682195 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [cloudstack] blueorangutan commented on pull request #5349: Fix of creating volumes from snapshots without backup to secondary storage

2021-08-20 Thread GitBox
blueorangutan commented on pull request #5349: URL: https://github.com/apache/cloudstack/pull/5349#issuecomment-902682385 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] blueorangutan commented on pull request #5157: UI: Support to upload resource icons

2021-08-20 Thread GitBox
blueorangutan commented on pull request #5157: URL: https://github.com/apache/cloudstack/pull/5157#issuecomment-902682892 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 959 -- This is an automated message from t

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5335: xcp-ng: allow passing vm boot options

2021-08-20 Thread GitBox
DaanHoogland commented on a change in pull request #5335: URL: https://github.com/apache/cloudstack/pull/5335#discussion_r692935821 ## File path: plugins/hypervisors/xenserver/src/main/java/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java ## @@ -1955,10 +1955,10

[GitHub] [cloudstack] slavkap commented on issue #5347: Cannot delete volume in Destroy state not attached to Instance

2021-08-20 Thread GitBox
slavkap commented on issue #5347: URL: https://github.com/apache/cloudstack/issues/5347#issuecomment-902684893 @weizhouapache, if this could help you I was able to reproduce the issue. Probably there are different scenarios, but here is mine: I've tried on a zone with one KVM hypervisor

[GitHub] [cloudstack] weizhouapache commented on issue #5347: Cannot delete volume in Destroy state not attached to Instance

2021-08-20 Thread GitBox
weizhouapache commented on issue #5347: URL: https://github.com/apache/cloudstack/issues/5347#issuecomment-902696372 > @weizhouapache, if this could help you I was able to reproduce the issue. Probably there are different scenarios, but here is mine: > I've tried on a zone with one KVM h

[GitHub] [cloudstack] DaanHoogland commented on issue #5350: Drop Agent dependency on qemu-kvm for Ubuntu

2021-08-20 Thread GitBox
DaanHoogland commented on issue #5350: URL: https://github.com/apache/cloudstack/issues/5350#issuecomment-902701825 @weizhouapache @tetra12 I'm not sure how we can insert this altered dependency but for sure we'll need a separate packaging for newer distributions. If we feel it serves a pu

[GitHub] [cloudstack] vladimirpetrov opened a new issue #5352: Strange error message when deleting account

2021-08-20 Thread GitBox
vladimirpetrov opened a new issue #5352: URL: https://github.com/apache/cloudstack/issues/5352 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ UI ~~~ # CLOUDSTACK VERSION ~~~ 4.16 latest main ~~~ # CONFIGURATIO

[GitHub] [cloudstack] vladimirpetrov commented on pull request #5157: UI: Support to upload resource icons

2021-08-20 Thread GitBox
vladimirpetrov commented on pull request #5157: URL: https://github.com/apache/cloudstack/pull/5157#issuecomment-902703276 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] blueorangutan commented on pull request #5157: UI: Support to upload resource icons

2021-08-20 Thread GitBox
blueorangutan commented on pull request #5157: URL: https://github.com/apache/cloudstack/pull/5157#issuecomment-902703527 @vladimirpetrov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Servic

[GitHub] [cloudstack] weizhouapache commented on issue #5347: Cannot delete volume in Destroy state not attached to Instance

2021-08-20 Thread GitBox
weizhouapache commented on issue #5347: URL: https://github.com/apache/cloudstack/issues/5347#issuecomment-902717362 @slavkap @kricud I am able to reproduce the issue, following the steps provided by @slavkap (I did not shutdown the host, but stop all cloudstack-agent instead).

[GitHub] [cloudstack] weizhouapache commented on issue #5350: Drop Agent dependency on qemu-kvm for Ubuntu

2021-08-20 Thread GitBox
weizhouapache commented on issue #5350: URL: https://github.com/apache/cloudstack/issues/5350#issuecomment-902729940 > @weizhouapache @tetra12 I'm not sure how we can insert this altered dependency but for sure we'll need a separate packaging for newer distributions. If we feel it serves a

[GitHub] [cloudstack] slavkap commented on issue #5347: Cannot delete volume in Destroy state not attached to Instance

2021-08-20 Thread GitBox
slavkap commented on issue #5347: URL: https://github.com/apache/cloudstack/issues/5347#issuecomment-902740803 that's great, @weizhouapache :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] vladimirpetrov commented on pull request #5157: UI: Support to upload resource icons

2021-08-20 Thread GitBox
vladimirpetrov commented on pull request #5157: URL: https://github.com/apache/cloudstack/pull/5157#issuecomment-902744454 Manual tests: Support for adding/removing resource icons for Zones, templates, ISOs, UserVMs, Networks, VPCs, Domains, Projects, Accounts and users - OK U

[GitHub] [cloudstack] GabrielBrascher commented on pull request #5323: UI - systemVM - Fix error message `jobid` not found when moving to another host

2021-08-20 Thread GitBox
GabrielBrascher commented on pull request #5323: URL: https://github.com/apache/cloudstack/pull/5323#issuecomment-902747874 @rhtyd @utchoang @shwstppr I've seen this happening when migrating VMs with volume (local storage + KVM) in **4.15**. Does it make sense to backporting this change

[GitHub] [cloudstack] GabrielBrascher edited a comment on pull request #5323: UI - systemVM - Fix error message `jobid` not found when moving to another host

2021-08-20 Thread GitBox
GabrielBrascher edited a comment on pull request #5323: URL: https://github.com/apache/cloudstack/pull/5323#issuecomment-902747874 @rhtyd @utchoang @shwstppr I've seen this happening when migrating VMs with volume (local storage + KVM) in **4.15**. Does it make sense to backport this cha

[GitHub] [cloudstack] blueorangutan commented on pull request #5082: component test ports/fixes in python3

2021-08-20 Thread GitBox
blueorangutan commented on pull request #5082: URL: https://github.com/apache/cloudstack/pull/5082#issuecomment-902786011 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 960 -- This is an automated message from t

[GitHub] [cloudstack] SadiJr commented on pull request #5351: Externalize vm stats increment in memory

2021-08-20 Thread GitBox
SadiJr commented on pull request #5351: URL: https://github.com/apache/cloudstack/pull/5351#issuecomment-902796322 Thanks @DaanHoogland for the review. This feature will allow operators to see real time statistics, what was not possible before. I can't say it will be useful or not, but the

[GitHub] [cloudstack] SadiJr edited a comment on pull request #5351: Externalize vm stats increment in memory

2021-08-20 Thread GitBox
SadiJr edited a comment on pull request #5351: URL: https://github.com/apache/cloudstack/pull/5351#issuecomment-902796322 Thanks @DaanHoogland for the review. This feature will allow operators to see real time statistics, what was not possible before (because the statistics of NetworkReadK

[GitHub] [cloudstack] nvazquez merged pull request #5321: Remove storage scope validation on KVM live migration

2021-08-20 Thread GitBox
nvazquez merged pull request #5321: URL: https://github.com/apache/cloudstack/pull/5321 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-un

[cloudstack] branch main updated: Remove storage scope validation on KVM live migration (#5321)

2021-08-20 Thread nvazquez
This is an automated email from the ASF dual-hosted git repository. nvazquez pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/main by this push: new 9c51009 Remove storage scope validation on KV

<    1   2   3   >