[GitHub] [cloudstack] ustcweizhou commented on issue #3585: agent.log should not be rotated by logrotate

2019-10-17 Thread GitBox
ustcweizhou commented on issue #3585: agent.log should not be rotated by logrotate URL: https://github.com/apache/cloudstack/issues/3585#issuecomment-543069388 this has been solved by #3597 This is an automated message from

[GitHub] [cloudstack] blueorangutan commented on issue #3627: [do not merge] server: Do NOT cleanup dhcp and dns when stop a vm

2019-10-17 Thread GitBox
blueorangutan commented on issue #3627: [do not merge] server: Do NOT cleanup dhcp and dns when stop a vm URL: https://github.com/apache/cloudstack/pull/3627#issuecomment-543074119 @andrijapanicsb a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --

[GitHub] [cloudstack] andrijapanicsb commented on issue #3627: [do not merge] server: Do NOT cleanup dhcp and dns when stop a vm

2019-10-17 Thread GitBox
andrijapanicsb commented on issue #3627: [do not merge] server: Do NOT cleanup dhcp and dns when stop a vm URL: https://github.com/apache/cloudstack/pull/3627#issuecomment-543073882 @blueorangutan package This is an automated

[GitHub] [cloudstack] ustcweizhou opened a new pull request #3639: Multiple networks support for vms in advanced zone with security group (and kvm support)

2019-10-17 Thread GitBox
ustcweizhou opened a new pull request #3639: Multiple networks support for vms in advanced zone with security group (and kvm support) URL: https://github.com/apache/cloudstack/pull/3639 ## Description In advanced zone with security groups, there can be multiple shared network

[GitHub] [cloudstack] ustcweizhou commented on issue #3639: Multiple networks support for vms in advanced zone with security group (and kvm support)

2019-10-17 Thread GitBox
ustcweizhou commented on issue #3639: Multiple networks support for vms in advanced zone with security group (and kvm support) URL: https://github.com/apache/cloudstack/pull/3639#issuecomment-543079672 @rakgenius @wido @GabrielBrascher @rhtyd Please review it ! We have tested wi

[GitHub] [cloudstack] onitake commented on issue #3597: kvm: Logrotate should not touch agent.log

2019-10-17 Thread GitBox
onitake commented on issue #3597: kvm: Logrotate should not touch agent.log URL: https://github.com/apache/cloudstack/pull/3597#issuecomment-543082007 Isn't the commit message a bit misleading? Aside from removing agent.log from the logrotate config, it also added /var/log/cloudstack/age

[GitHub] [cloudstack] blueorangutan commented on issue #3627: [do not merge] server: Do NOT cleanup dhcp and dns when stop a vm

2019-10-17 Thread GitBox
blueorangutan commented on issue #3627: [do not merge] server: Do NOT cleanup dhcp and dns when stop a vm URL: https://github.com/apache/cloudstack/pull/3627#issuecomment-543082735 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-317

[GitHub] [cloudstack] rhtyd commented on issue #3627: [do not merge] server: Do NOT cleanup dhcp and dns when stop a vm

2019-10-17 Thread GitBox
rhtyd commented on issue #3627: [do not merge] server: Do NOT cleanup dhcp and dns when stop a vm URL: https://github.com/apache/cloudstack/pull/3627#issuecomment-543086941 @ustcweizhou @andrijapanicsb - have you tested the case that when a VM is stopped, its rules are not removed from the

[GitHub] [cloudstack] blueorangutan commented on issue #3627: [do not merge] server: Do NOT cleanup dhcp and dns when stop a vm

2019-10-17 Thread GitBox
blueorangutan commented on issue #3627: [do not merge] server: Do NOT cleanup dhcp and dns when stop a vm URL: https://github.com/apache/cloudstack/pull/3627#issuecomment-543087198 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -

[GitHub] [cloudstack] andrijapanicsb commented on issue #3627: [do not merge] server: Do NOT cleanup dhcp and dns when stop a vm

2019-10-17 Thread GitBox
andrijapanicsb commented on issue #3627: [do not merge] server: Do NOT cleanup dhcp and dns when stop a vm URL: https://github.com/apache/cloudstack/pull/3627#issuecomment-543087618 yes @rhtyd , tested pretty thoroughly. Also tested when VR is stopped (and VM expunge automatically kicks in

[GitHub] [cloudstack] ustcweizhou commented on issue #3597: kvm: Logrotate should not touch agent.log

2019-10-17 Thread GitBox
ustcweizhou commented on issue #3597: kvm: Logrotate should not touch agent.log URL: https://github.com/apache/cloudstack/pull/3597#issuecomment-543089541 @onitake no, resizevolume.log is new in logrotate I think it would be good to add security_group.log to logrotate. --

[GitHub] [cloudstack] ustcweizhou opened a new pull request #3640: consoleproxy: Enable console for vms in Stopping/Migrating state

2019-10-17 Thread GitBox
ustcweizhou opened a new pull request #3640: consoleproxy: Enable console for vms in Stopping/Migrating state URL: https://github.com/apache/cloudstack/pull/3640 ## Description Currently vm console is not enabled if vm is in stopping or migrating. Enabling vm console will help

[GitHub] [cloudstack] ustcweizhou opened a new pull request #3641: security_group.py: fix NameError: name 'd' is not defined

2019-10-17 Thread GitBox
ustcweizhou opened a new pull request #3641: security_group.py: fix NameError: name 'd' is not defined URL: https://github.com/apache/cloudstack/pull/3641 ## Description in agent.log on a host running with cloudstack 4.14.0.0-SNAPSHOT, it gives error ``` Traceback

[GitHub] [cloudstack] ustcweizhou commented on issue #3641: security_group.py: fix NameError: name 'd' is not defined

2019-10-17 Thread GitBox
ustcweizhou commented on issue #3641: security_group.py: fix NameError: name 'd' is not defined URL: https://github.com/apache/cloudstack/pull/3641#issuecomment-543104248 @wido could you please review it ? This is an auto

[GitHub] [cloudstack] ustcweizhou commented on issue #3629: Unable to add host to cloudstack UI

2019-10-17 Thread GitBox
ustcweizhou commented on issue #3629: Unable to add host to cloudstack UI URL: https://github.com/apache/cloudstack/issues/3629#issuecomment-543105348 @gngusen could you post the logs in /var/log/cloudstack/agent/setup.log on host ? and your cloudstack version, os /version, etc ---

[GitHub] [cloudstack] borisstoyanov opened a new issue #3642: type

2019-10-17 Thread GitBox
borisstoyanov opened a new issue #3642: type URL: https://github.com/apache/cloudstack/issues/3642 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ API ~~~ # CLOUDSTACK VERSION ~~~ 4.14 ~~~ # CONFIGURATION

[GitHub] [cloudstack] borisstoyanov commented on issue #3642: typo in error message

2019-10-17 Thread GitBox
borisstoyanov commented on issue #3642: typo in error message URL: https://github.com/apache/cloudstack/issues/3642#issuecomment-543112253 @shwstppr can you have a look pls? This is an automated message from the Apache Git Ser

[GitHub] [cloudstack] shwstppr commented on issue #3642: typo in error message

2019-10-17 Thread GitBox
shwstppr commented on issue #3642: typo in error message URL: https://github.com/apache/cloudstack/issues/3642#issuecomment-543113927 @borisstoyanov sure This is an automated message from the Apache Git Service. To respond to

[GitHub] [cloudstack] pavanaravapalli commented on a change in pull request #3638: WIP: UEFI Support on CloudStack

2019-10-17 Thread GitBox
pavanaravapalli commented on a change in pull request #3638: WIP: UEFI Support on CloudStack URL: https://github.com/apache/cloudstack/pull/3638#discussion_r335932418 ## File path: plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java ##

[GitHub] [cloudstack] ustcweizhou commented on issue #3640: consoleproxy: Enable console for vms in Stopping/Migrating state

2019-10-17 Thread GitBox
ustcweizhou commented on issue #3640: consoleproxy: Enable console for vms in Stopping/Migrating state URL: https://github.com/apache/cloudstack/pull/3640#issuecomment-543115562 @andrijapanicsb this fixes your issue #3631 Th

[GitHub] [cloudstack] shwstppr edited a comment on issue #3642: typo in error message

2019-10-17 Thread GitBox
shwstppr edited a comment on issue #3642: typo in error message URL: https://github.com/apache/cloudstack/issues/3642#issuecomment-543113927 @borisstoyanov sure but PR is not merged yet, do we need an issue here? This is an au

[GitHub] [cloudstack] shwstppr commented on issue #3642: typo in error message

2019-10-17 Thread GitBox
shwstppr commented on issue #3642: typo in error message URL: https://github.com/apache/cloudstack/issues/3642#issuecomment-543135300 @borisstoyanov Exclaimation issue was fixed with this change 6 days back, https://github.com/apache/cloudstack/pull/3606/commits/ffa90b96ac5bb854032be8972137

[GitHub] [cloudstack] nvazquez commented on issue #3638: WIP: UEFI Support on CloudStack

2019-10-17 Thread GitBox
nvazquez commented on issue #3638: WIP: UEFI Support on CloudStack URL: https://github.com/apache/cloudstack/pull/3638#issuecomment-543166087 @nathanejohnson sure, I can manually test it on Vmware once the PR is complete @pavanaravapalli please let us know when this is complete, afaik it

[GitHub] [cloudstack] svenvogel commented on issue #3186: Add possibility to set KVM MTU size for all NIC

2019-10-17 Thread GitBox
svenvogel commented on issue #3186: Add possibility to set KVM MTU size for all NIC URL: https://github.com/apache/cloudstack/pull/3186#issuecomment-543182427 @wido @GabrielBrascher could you find time to look at it? This is

[GitHub] [cloudstack] svenvogel commented on issue #3640: consoleproxy: Enable console for vms in Stopping/Migrating state

2019-10-17 Thread GitBox
svenvogel commented on issue #3640: consoleproxy: Enable console for vms in Stopping/Migrating state URL: https://github.com/apache/cloudstack/pull/3640#issuecomment-543184119 @ustcweizhou nice enhancement! This is an automat

[GitHub] [cloudstack] andrijapanicsb commented on issue #3615: Handle Ceph/RBD snapshot delete

2019-10-17 Thread GitBox
andrijapanicsb commented on issue #3615: Handle Ceph/RBD snapshot delete URL: https://github.com/apache/cloudstack/pull/3615#issuecomment-543211659 @rhtyd @GabrielBrascher this seems to be an issue with any storage and any? hypervisor (KVM and XS tested) even on 4.11(.2) releases. Ma

[GitHub] [cloudstack] DmB991 commented on issue #3513: Incorrect isolated network creation

2019-10-17 Thread GitBox
DmB991 commented on issue #3513: Incorrect isolated network creation URL: https://github.com/apache/cloudstack/issues/3513#issuecomment-543213449 The same problem with L2 networks This is an automated message from the Apache G

[GitHub] [cloudstack] onitake commented on issue #3597: kvm: Logrotate should not touch agent.log

2019-10-17 Thread GitBox
onitake commented on issue #3597: kvm: Logrotate should not touch agent.log URL: https://github.com/apache/cloudstack/pull/3597#issuecomment-543266536 Ah, ok. Just thought it may be good if this is mentioned somewhere. This

[GitHub] [cloudstack] GabrielBrascher commented on issue #3615: Handle Ceph/RBD snapshot delete

2019-10-17 Thread GitBox
GabrielBrascher commented on issue #3615: Handle Ceph/RBD snapshot delete URL: https://github.com/apache/cloudstack/pull/3615#issuecomment-543284856 @andrijapanicsb thanks for the feedback. It is a bigger issue than we thought. I was going to update this PR today adding a commit for Ceph

[GitHub] [cloudstack] blueorangutan commented on issue #3627: [do not merge] server: Do NOT cleanup dhcp and dns when stop a vm

2019-10-17 Thread GitBox
blueorangutan commented on issue #3627: [do not merge] server: Do NOT cleanup dhcp and dns when stop a vm URL: https://github.com/apache/cloudstack/pull/3627#issuecomment-543323706 Trillian test result (tid-413) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Tot

[GitHub] [cloudstack] rhtyd merged pull request #3627: [do not merge] server: Do NOT cleanup dhcp and dns when stop a vm

2019-10-17 Thread GitBox
rhtyd merged pull request #3627: [do not merge] server: Do NOT cleanup dhcp and dns when stop a vm URL: https://github.com/apache/cloudstack/pull/3627 This is an automated message from the Apache Git Service. To respond to t

[cloudstack] branch 4.13 updated: server: Do NOT cleanup dhcp and dns when stop a vm (#3627)

2019-10-17 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch 4.13 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.13 by this push: new cc27095 server: Do NOT cleanup dhcp and dns when