[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3522: New API endpoint: UpdateVlanIpRange

2019-08-10 Thread GitBox
DaanHoogland commented on a change in pull request #3522: New API endpoint: UpdateVlanIpRange URL: https://github.com/apache/cloudstack/pull/3522#discussion_r312695653 ## File path: server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java ## @@ -3958,6 +

[GitHub] [cloudstack] DaanHoogland commented on issue #3522: New API endpoint: UpdateVlanIpRange

2019-08-10 Thread GitBox
DaanHoogland commented on issue #3522: New API endpoint: UpdateVlanIpRange URL: https://github.com/apache/cloudstack/pull/3522#issuecomment-520131017 according to travis there are still checkstyle problems in cloud-api. I can't find what they are in the logs. --

[GitHub] [cloudstack] svenvogel commented on issue #3510: [WIP DO NOT MERGE] Allow additional config to vms

2019-08-10 Thread GitBox
svenvogel commented on issue #3510: [WIP DO NOT MERGE] Allow additional config to vms URL: https://github.com/apache/cloudstack/pull/3510#issuecomment-520138562 @anuragaw Hi. Small question. how does this work in practise? Th

[GitHub] [cloudstack] svenvogel edited a comment on issue #3510: [WIP DO NOT MERGE] Allow additional config to vms

2019-08-10 Thread GitBox
svenvogel edited a comment on issue #3510: [WIP DO NOT MERGE] Allow additional config to vms URL: https://github.com/apache/cloudstack/pull/3510#issuecomment-520138562 @anuragaw Hi. Small question. how does this work in practise? do we speak about the systemvm? ---

[GitHub] [cloudstack] blueorangutan removed a comment on issue #3547: [WIP] 4.13/master stabilisation PR

2019-08-10 Thread GitBox
blueorangutan removed a comment on issue #3547: [WIP] 4.13/master stabilisation PR URL: https://github.com/apache/cloudstack/pull/3547#issuecomment-520014689 Trillian test result (tid-295) Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7 Total time taken: 23065 se

[GitHub] [cloudstack] rhtyd commented on issue #3547: [WIP] 4.13/master stabilisation PR

2019-08-10 Thread GitBox
rhtyd commented on issue #3547: [WIP] 4.13/master stabilisation PR URL: https://github.com/apache/cloudstack/pull/3547#issuecomment-520159141 @blueorangutan package This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] blueorangutan commented on issue #3547: [WIP] 4.13/master stabilisation PR

2019-08-10 Thread GitBox
blueorangutan commented on issue #3547: [WIP] 4.13/master stabilisation PR URL: https://github.com/apache/cloudstack/pull/3547#issuecomment-520159178 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. ---

[GitHub] [cloudstack] blueorangutan commented on issue #3547: [WIP] 4.13/master stabilisation PR

2019-08-10 Thread GitBox
blueorangutan commented on issue #3547: [WIP] 4.13/master stabilisation PR URL: https://github.com/apache/cloudstack/pull/3547#issuecomment-520160784 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-244 This is an automated me

[GitHub] [cloudstack] rhtyd commented on issue #3547: [WIP] 4.13/master stabilisation PR

2019-08-10 Thread GitBox
rhtyd commented on issue #3547: [WIP] 4.13/master stabilisation PR URL: https://github.com/apache/cloudstack/pull/3547#issuecomment-520168512 @blueorangutan test centos7 xenserver-71 This is an automated message from the Apach

[GitHub] [cloudstack] blueorangutan commented on issue #3547: [WIP] 4.13/master stabilisation PR

2019-08-10 Thread GitBox
blueorangutan commented on issue #3547: [WIP] 4.13/master stabilisation PR URL: https://github.com/apache/cloudstack/pull/3547#issuecomment-520168538 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + xenserver-71) has been kicked to run smoke tests

[GitHub] [cloudstack] kioie commented on a change in pull request #3532: Add new "Add volume" button, to add volume to VM instance directly

2019-08-10 Thread GitBox
kioie commented on a change in pull request #3532: Add new "Add volume" button, to add volume to VM instance directly URL: https://github.com/apache/cloudstack/pull/3532#discussion_r312724185 ## File path: server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java ##

[GitHub] [cloudstack] kioie commented on a change in pull request #3532: Add new "Add volume" button, to add volume to VM instance directly

2019-08-10 Thread GitBox
kioie commented on a change in pull request #3532: Add new "Add volume" button, to add volume to VM instance directly URL: https://github.com/apache/cloudstack/pull/3532#discussion_r312724237 ## File path: server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java ##

[GitHub] [cloudstack] kioie commented on a change in pull request #3532: Add new "Add volume" button, to add volume to VM instance directly

2019-08-10 Thread GitBox
kioie commented on a change in pull request #3532: Add new "Add volume" button, to add volume to VM instance directly URL: https://github.com/apache/cloudstack/pull/3532#discussion_r312724253 ## File path: server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java ##