[GitHub] [cloudstack] blueorangutan commented on issue #3454: [WIP DO NOT MERGE] Add support for new heuristics based VM Deployement

2019-07-02 Thread GitBox
blueorangutan commented on issue #3454: [WIP DO NOT MERGE] Add support for new heuristics based VM Deployement URL: https://github.com/apache/cloudstack/pull/3454#issuecomment-507548764 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-72

[GitHub] [cloudstack] blueorangutan commented on issue #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure

2019-07-02 Thread GitBox
blueorangutan commented on issue #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure URL: https://github.com/apache/cloudstack/pull/3425#issuecomment-507549262 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-73 ---

[GitHub] [cloudstack] rhtyd closed issue #2895: ssh-keys instances ERROR

2019-07-02 Thread GitBox
rhtyd closed issue #2895: ssh-keys instances ERROR URL: https://github.com/apache/cloudstack/issues/2895 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [cloudstack] rhtyd merged pull request #3435: ui: don't pass account name when in project mode to VMs from sshkeypair reference

2019-07-02 Thread GitBox
rhtyd merged pull request #3435: ui: don't pass account name when in project mode to VMs from sshkeypair reference URL: https://github.com/apache/cloudstack/pull/3435 This is an automated message from the Apache Git Service.

[cloudstack] branch master updated: ui: Don't pass account name when in project mode (#3435)

2019-07-02 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new 14bf2e9 ui: Don't pass account name when in

[GitHub] [cloudstack] rhtyd merged pull request #3445: Fix sorting order bug in UI Code with usage of sortkey.algorithm global config

2019-07-02 Thread GitBox
rhtyd merged pull request #3445: Fix sorting order bug in UI Code with usage of sortkey.algorithm global config URL: https://github.com/apache/cloudstack/pull/3445 This is an automated message from the Apache Git Service. To

[cloudstack] branch master updated: ui: Fix sorting bug in UI Code (#3445)

2019-07-02 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new 4185452 ui: Fix sorting bug in UI Code (#344

[GitHub] [cloudstack] rhtyd commented on issue #3449: utils: reverse ip addresses of a nic returned by java to get the first ip address

2019-07-02 Thread GitBox
rhtyd commented on issue #3449: utils: reverse ip addresses of a nic returned by java to get the first ip address URL: https://github.com/apache/cloudstack/pull/3449#issuecomment-507554266 Can you review @anuragaw @shwstppr

[GitHub] [cloudstack] rhtyd merged pull request #3449: utils: reverse ip addresses of a nic returned by java to get the first ip address

2019-07-02 Thread GitBox
rhtyd merged pull request #3449: utils: reverse ip addresses of a nic returned by java to get the first ip address URL: https://github.com/apache/cloudstack/pull/3449 This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] rhtyd closed issue #3311: Issues when multiple management IP addresses are set in the KVM hypervisor (with fix)

2019-07-02 Thread GitBox
rhtyd closed issue #3311: Issues when multiple management IP addresses are set in the KVM hypervisor (with fix) URL: https://github.com/apache/cloudstack/issues/3311 This is an automated message from the Apache Git Service.

[cloudstack] branch master updated: utils: reverse ip addresses of a nic returned by java to get the first ip address (#3449)

2019-07-02 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new 0470033 utils: reverse ip addresses of a nic

[GitHub] [cloudstack] rhtyd commented on issue #3306: server: reduce execution time while listing project if projects have many resource tags

2019-07-02 Thread GitBox
rhtyd commented on issue #3306: server: reduce execution time while listing project if projects have many resource tags URL: https://github.com/apache/cloudstack/pull/3306#issuecomment-507564972 @blueorangutan test This is an

[GitHub] [cloudstack] blueorangutan commented on issue #3306: server: reduce execution time while listing project if projects have many resource tags

2019-07-02 Thread GitBox
blueorangutan commented on issue #3306: server: reduce execution time while listing project if projects have many resource tags URL: https://github.com/apache/cloudstack/pull/3306#issuecomment-507565200 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run

[GitHub] [cloudstack] webermaximilian92 commented on issue #3434: Build css from scss sources in client ui build

2019-07-02 Thread GitBox
webermaximilian92 commented on issue #3434: Build css from scss sources in client ui build URL: https://github.com/apache/cloudstack/pull/3434#issuecomment-507572128 Hey @rhtyd Please show us some examples of "large changes" and "file renames". May I ask you to be a bit more specifi

[GitHub] [cloudstack] ustcweizhou opened a new issue #3455: Configurable disk size of systemvm

2019-07-02 Thread GitBox
ustcweizhou opened a new issue #3455: Configurable disk size of systemvm URL: https://github.com/apache/cloudstack/issues/3455 Currently we have systemvm template which has very small disk size. Because of this, it is difficult to install new packages or upgrade existing packages. Ano

[GitHub] [cloudstack] onitake commented on issue #3455: Configurable disk size of systemvm

2019-07-02 Thread GitBox
onitake commented on issue #3455: Configurable disk size of systemvm URL: https://github.com/apache/cloudstack/issues/3455#issuecomment-507581479 I think it would be much better to create a new template instead of modifying VRs in-place. That way, you will always get a consistent setup w

[GitHub] [cloudstack] ustcweizhou commented on issue #3455: Configurable disk size of systemvm

2019-07-02 Thread GitBox
ustcweizhou commented on issue #3455: Configurable disk size of systemvm URL: https://github.com/apache/cloudstack/issues/3455#issuecomment-507587333 @onitake do you mean create a new systemvm template with bigger disk size ? official release or by ourselves ? If by ourselves, we nee

[GitHub] [cloudstack] kioie opened a new issue #3456: Memory Used is incorrect

2019-07-02 Thread GitBox
kioie opened a new issue #3456: Memory Used is incorrect URL: https://github.com/apache/cloudstack/issues/3456 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ API ~~~ # CLOUDSTACK VERSION ~~~ 4.11+ ~~~ # SUMMAR

[GitHub] [cloudstack] anuragaw opened a new pull request #3457: Fix bug in counting items for search query

2019-07-02 Thread GitBox
anuragaw opened a new pull request #3457: Fix bug in counting items for search query URL: https://github.com/apache/cloudstack/pull/3457 The implementation of GenericBaseDao#searchAndCount() can result in incorrect count. This happens because the implementation of the GenericBaseDao#getCo

[GitHub] [cloudstack] anuragaw edited a comment on issue #2874: incorrect number of public lb ip in UI

2019-07-02 Thread GitBox
anuragaw edited a comment on issue #2874: incorrect number of public lb ip in UI URL: https://github.com/apache/cloudstack/issues/2874#issuecomment-507154370 Close to finalizing this. Discovered during investigation that GenericDaoBase#searchAndCount needs fixing.

[GitHub] [cloudstack] blueorangutan removed a comment on issue #3350: [WIP] Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router

2019-07-02 Thread GitBox
blueorangutan removed a comment on issue #3350: [WIP] Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router URL: https://github.com/apache/cloudstack/pull/3350#issuecomment-507402369 Trillian test result (tid-79) Environment: vmware-65u2 (x2), Advanced Networking wi

[GitHub] [cloudstack] anuragaw commented on issue #3457: Fix bug in counting items for search query

2019-07-02 Thread GitBox
anuragaw commented on issue #3457: Fix bug in counting items for search query URL: https://github.com/apache/cloudstack/pull/3457#issuecomment-507628929 @blueorangutan package This is an automated message from the Apache Git S

[GitHub] [cloudstack] anuragaw commented on issue #3457: Fix bug in counting items for search query

2019-07-02 Thread GitBox
anuragaw commented on issue #3457: Fix bug in counting items for search query URL: https://github.com/apache/cloudstack/pull/3457#issuecomment-50762 ping for review - @rhtyd , @shwstppr , @borisstoyanov , @PaulAngus , @nvazquez -

[GitHub] [cloudstack] blueorangutan commented on issue #3457: Fix bug in counting items for search query

2019-07-02 Thread GitBox
blueorangutan commented on issue #3457: Fix bug in counting items for search query URL: https://github.com/apache/cloudstack/pull/3457#issuecomment-507629138 @anuragaw a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. ---

[GitHub] [cloudstack] anuragaw edited a comment on issue #3457: Fix bug in counting items for search query

2019-07-02 Thread GitBox
anuragaw edited a comment on issue #3457: Fix bug in counting items for search query URL: https://github.com/apache/cloudstack/pull/3457#issuecomment-50762 ping for review - @rhtyd , @shwstppr , @borisstoyanov , @PaulAngus , @nvazquez , @DaanHoogland -

[GitHub] [cloudstack] rhtyd commented on issue #3456: Memory Used is incorrect

2019-07-02 Thread GitBox
rhtyd commented on issue #3456: Memory Used is incorrect URL: https://github.com/apache/cloudstack/issues/3456#issuecomment-507629949 On which hypervisor are you seeing this @kioie, if it's simulator - note that values are mocked by simulator and are not representative of real-world-hyperv

[GitHub] [cloudstack] rhtyd commented on issue #3400: Allow normal users to download template when template are not extractable

2019-07-02 Thread GitBox
rhtyd commented on issue #3400: Allow normal users to download template when template are not extractable URL: https://github.com/apache/cloudstack/issues/3400#issuecomment-507630571 @Spaceman1984 can you have a look on it? T

[GitHub] [cloudstack] kioie commented on issue #3456: Memory Used is incorrect

2019-07-02 Thread GitBox
kioie commented on issue #3456: Memory Used is incorrect URL: https://github.com/apache/cloudstack/issues/3456#issuecomment-507631078 @rhtyd Hypervisor is KVM actually the simulator for some interesting reason doesn't mock any values for memory -

[GitHub] [cloudstack] kioie commented on issue #3456: Memory Used is incorrect

2019-07-02 Thread GitBox
kioie commented on issue #3456: Memory Used is incorrect URL: https://github.com/apache/cloudstack/issues/3456#issuecomment-507632698 I'm thinking the issue could be because of the below ``` public VmStatsEntry getVmStat(final Connect conn, final String vmName) throws LibvirtExce

[GitHub] [cloudstack] DaanHoogland commented on issue #3451: [UI] Fix wrap text for accounts on project view

2019-07-02 Thread GitBox
DaanHoogland commented on issue #3451: [UI] Fix wrap text for accounts on project view URL: https://github.com/apache/cloudstack/pull/3451#issuecomment-507635824 @nvazquez No, I think it is fine for other cases as well. let's collect a list here if we encounter them. -

[GitHub] [cloudstack] blueorangutan commented on issue #3457: Fix bug in counting items for search query

2019-07-02 Thread GitBox
blueorangutan commented on issue #3457: Fix bug in counting items for search query URL: https://github.com/apache/cloudstack/pull/3457#issuecomment-507636192 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-74 This is an auto

[GitHub] [cloudstack] rhtyd commented on issue #3400: Allow normal users to download template when template are not extractable

2019-07-02 Thread GitBox
rhtyd commented on issue #3400: Allow normal users to download template when template are not extractable URL: https://github.com/apache/cloudstack/issues/3400#issuecomment-507641428 Log examples: ``` 2019-07-02 17:15:28,721 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] (API-Job-Executor-1

[cloudstack] branch master updated: ui: Fix wrap text for accounts on project view (#3451)

2019-07-02 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new 4c28a2b ui: Fix wrap text for accounts on pr

[GitHub] [cloudstack] rhtyd merged pull request #3451: [UI] Fix wrap text for accounts on project view

2019-07-02 Thread GitBox
rhtyd merged pull request #3451: [UI] Fix wrap text for accounts on project view URL: https://github.com/apache/cloudstack/pull/3451 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [cloudstack] svenvogel commented on issue #3186: [WIP DO NOT MERGE] Add possibility to set KVM MTU size for NIC

2019-07-02 Thread GitBox
svenvogel commented on issue #3186: [WIP DO NOT MERGE] Add possibility to set KVM MTU size for NIC URL: https://github.com/apache/cloudstack/pull/3186#issuecomment-507661477 @gmueller-ewerk can you rebase it? @rhtyd @ustcweizhou @wido there are anybody has an ideas why we get these

[GitHub] [cloudstack] svenvogel edited a comment on issue #3186: [WIP DO NOT MERGE] Add possibility to set KVM MTU size for NIC

2019-07-02 Thread GitBox
svenvogel edited a comment on issue #3186: [WIP DO NOT MERGE] Add possibility to set KVM MTU size for NIC URL: https://github.com/apache/cloudstack/pull/3186#issuecomment-507661477 @gmueller-ewerk can you rebase it? @rhtyd @ustcweizhou @wido there are anybody has an ideas why we get

[GitHub] [cloudstack] rhtyd commented on issue #3457: Fix bug in counting items for search query

2019-07-02 Thread GitBox
rhtyd commented on issue #3457: Fix bug in counting items for search query URL: https://github.com/apache/cloudstack/pull/3457#issuecomment-507661630 @blueorangutan test This is an automated message from the Apache Git Service

[GitHub] [cloudstack] blueorangutan commented on issue #3457: Fix bug in counting items for search query

2019-07-02 Thread GitBox
blueorangutan commented on issue #3457: Fix bug in counting items for search query URL: https://github.com/apache/cloudstack/pull/3457#issuecomment-507661858 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] [cloudstack] svenvogel commented on issue #3454: [WIP DO NOT MERGE] Add support for new heuristics based VM Deployement

2019-07-02 Thread GitBox
svenvogel commented on issue #3454: [WIP DO NOT MERGE] Add support for new heuristics based VM Deployement URL: https://github.com/apache/cloudstack/pull/3454#issuecomment-507662143 LGTM! This is an automated message from the

[GitHub] [cloudstack] rhtyd commented on issue #3457: Fix bug in counting items for search query

2019-07-02 Thread GitBox
rhtyd commented on issue #3457: Fix bug in counting items for search query URL: https://github.com/apache/cloudstack/pull/3457#issuecomment-507662043 I'll review it tomorrow @anuragaw thanks. This is an automated message from

[GitHub] [cloudstack] AndreaGHG opened a new issue #3458: Cannot create zone. "Fail to create a physical network" error with VMWare 6.5 hypervisor

2019-07-02 Thread GitBox
AndreaGHG opened a new issue #3458: Cannot create zone. "Fail to create a physical network" error with VMWare 6.5 hypervisor URL: https://github.com/apache/cloudstack/issues/3458 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ UI ~~~ #

[GitHub] [cloudstack] blueorangutan commented on issue #3306: server: reduce execution time while listing project if projects have many resource tags

2019-07-02 Thread GitBox
blueorangutan commented on issue #3306: server: reduce execution time while listing project if projects have many resource tags URL: https://github.com/apache/cloudstack/pull/3306#issuecomment-507671722 Trillian test result (tid-84) Environment: kvm-centos7 (x2), Advanced Networking with

[GitHub] [cloudstack] blueorangutan removed a comment on issue #3306: server: reduce execution time while listing project if projects have many resource tags

2019-07-02 Thread GitBox
blueorangutan removed a comment on issue #3306: server: reduce execution time while listing project if projects have many resource tags URL: https://github.com/apache/cloudstack/pull/3306#issuecomment-507671722 Trillian test result (tid-84) Environment: kvm-centos7 (x2), Advanced Network

[GitHub] [cloudstack] rhtyd commented on issue #3306: server: reduce execution time while listing project if projects have many resource tags

2019-07-02 Thread GitBox
rhtyd commented on issue #3306: server: reduce execution time while listing project if projects have many resource tags URL: https://github.com/apache/cloudstack/pull/3306#issuecomment-507673923 @blueorangutan test Th

[GitHub] [cloudstack] blueorangutan commented on issue #3306: server: reduce execution time while listing project if projects have many resource tags

2019-07-02 Thread GitBox
blueorangutan commented on issue #3306: server: reduce execution time while listing project if projects have many resource tags URL: https://github.com/apache/cloudstack/pull/3306#issuecomment-507674147 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run

[GitHub] [cloudstack] GabrielBrascher closed pull request #3453: Bind port 8096 to 127.0.0.1

2019-07-02 Thread GitBox
GabrielBrascher closed pull request #3453: Bind port 8096 to 127.0.0.1 URL: https://github.com/apache/cloudstack/pull/3453 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [cloudstack] GabrielBrascher commented on issue #3453: Bind port 8096 to 127.0.0.1

2019-07-02 Thread GitBox
GabrielBrascher commented on issue #3453: Bind port 8096 to 127.0.0.1 URL: https://github.com/apache/cloudstack/pull/3453#issuecomment-507679363 @rhtyd I will close this PR for now then, thanks for the feedback. However, I did look around and could find such issue (8096 enabled) even on

[GitHub] [cloudstack] GabrielBrascher closed issue #3450: Port 8096 allows unauthenticated access from any IP.

2019-07-02 Thread GitBox
GabrielBrascher closed issue #3450: Port 8096 allows unauthenticated access from any IP. URL: https://github.com/apache/cloudstack/issues/3450 This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [cloudstack] GabrielBrascher commented on issue #3450: Port 8096 allows unauthenticated access from any IP.

2019-07-02 Thread GitBox
GabrielBrascher commented on issue #3450: Port 8096 allows unauthenticated access from any IP. URL: https://github.com/apache/cloudstack/issues/3450#issuecomment-507682112 Closing this issue. However, I think that port 8096 is not disabled by default, at least on ACS environments deployed

[GitHub] [cloudstack] onitake commented on issue #3450: Port 8096 allows unauthenticated access from any IP.

2019-07-02 Thread GitBox
onitake commented on issue #3450: Port 8096 allows unauthenticated access from any IP. URL: https://github.com/apache/cloudstack/issues/3450#issuecomment-507697560 I don't think "works as designed" is going to cut it here. The upgrade docs from 4.5 explicitly mention this management

[GitHub] [cloudstack] ustcweizhou commented on issue #3458: Cannot create zone. "Fail to create a physical network" error with VMWare 6.5 hypervisor

2019-07-02 Thread GitBox
ustcweizhou commented on issue #3458: Cannot create zone. "Fail to create a physical network" error with VMWare 6.5 hypervisor URL: https://github.com/apache/cloudstack/issues/3458#issuecomment-507699260 this seems to be caused by some database issues. @AndreaGHG can you delete the zone

[GitHub] [cloudstack] onitake commented on issue #3450: Port 8096 allows unauthenticated access from any IP.

2019-07-02 Thread GitBox
onitake commented on issue #3450: Port 8096 allows unauthenticated access from any IP. URL: https://github.com/apache/cloudstack/issues/3450#issuecomment-507702456 The code treats `null` as `disabled`: https://github.com/apache/cloudstack/blob/master/server/src/main/java/com/cloud/api/ApiS

[GitHub] [cloudstack] GabrielBrascher edited a comment on issue #3450: Port 8096 allows unauthenticated access from any IP.

2019-07-02 Thread GitBox
GabrielBrascher edited a comment on issue #3450: Port 8096 allows unauthenticated access from any IP. URL: https://github.com/apache/cloudstack/issues/3450#issuecomment-507714026 @onitake I agree, I have seen some gray lines on this implementation as well. However, it is possible to disabl

[GitHub] [cloudstack] GabrielBrascher commented on issue #3450: Port 8096 allows unauthenticated access from any IP.

2019-07-02 Thread GitBox
GabrielBrascher commented on issue #3450: Port 8096 allows unauthenticated access from any IP. URL: https://github.com/apache/cloudstack/issues/3450#issuecomment-507714026 @onitake I agree, I have seen some gray lines on this implementation as well. However, it is possible to disable it by

[GitHub] [cloudstack] AndreaGHG commented on issue #3458: Cannot create zone. "Fail to create a physical network" error with VMWare 6.5 hypervisor

2019-07-02 Thread GitBox
AndreaGHG commented on issue #3458: Cannot create zone. "Fail to create a physical network" error with VMWare 6.5 hypervisor URL: https://github.com/apache/cloudstack/issues/3458#issuecomment-507723334 I've tried many installation and this happens almost every time. Now I've deleted

[GitHub] [cloudstack] rhtyd commented on issue #3450: Port 8096 allows unauthenticated access from any IP.

2019-07-02 Thread GitBox
rhtyd commented on issue #3450: Port 8096 allows unauthenticated access from any IP. URL: https://github.com/apache/cloudstack/issues/3450#issuecomment-507726833 I would advise to keep the feature as is, and improve the cloudstack-sysvmadm to accept apikey or secret key, or username passwo

[GitHub] [cloudstack] onitake commented on issue #3450: Port 8096 allows unauthenticated access from any IP.

2019-07-02 Thread GitBox
onitake commented on issue #3450: Port 8096 allows unauthenticated access from any IP. URL: https://github.com/apache/cloudstack/issues/3450#issuecomment-507730833 That sounds promising. Perhaps it makes sense to deploy a local access key during CloudStack installation (or upgrade), tha

[GitHub] [cloudstack] onitake edited a comment on issue #3450: Port 8096 allows unauthenticated access from any IP.

2019-07-02 Thread GitBox
onitake edited a comment on issue #3450: Port 8096 allows unauthenticated access from any IP. URL: https://github.com/apache/cloudstack/issues/3450#issuecomment-507730833 That sounds promising. Perhaps it makes sense to deploy a local access key during CloudStack installation (or upgrad

[GitHub] [cloudstack] GabrielBrascher commented on issue #3450: Port 8096 allows unauthenticated access from any IP.

2019-07-02 Thread GitBox
GabrielBrascher commented on issue #3450: Port 8096 allows unauthenticated access from any IP. URL: https://github.com/apache/cloudstack/issues/3450#issuecomment-507733006 I agree with you both @rhtyd @onitake. Considering the risks involved, I see some quick and easy ways to mitigate s

[GitHub] [cloudstack] ustcweizhou commented on issue #3458: Cannot create zone. "Fail to create a physical network" error with VMWare 6.5 hypervisor

2019-07-02 Thread GitBox
ustcweizhou commented on issue #3458: Cannot create zone. "Fail to create a physical network" error with VMWare 6.5 hypervisor URL: https://github.com/apache/cloudstack/issues/3458#issuecomment-507748584 @AndreaGHG could you please upload the management server log ? It seems the global s

[GitHub] [cloudstack] mhp0rtal opened a new issue #3459: Misuses of cryptographic APIs

2019-07-02 Thread GitBox
mhp0rtal opened a new issue #3459: Misuses of cryptographic APIs URL: https://github.com/apache/cloudstack/issues/3459 Hi The following lines have cryptographic API misuses. File name => utils/src/main/java/com/cloud/utils/ssh/SSHKeysHelper.java: Line number => 75: API name => MessageD

[GitHub] [cloudstack] zjohn77 opened a new issue #3460: CloudStack install on Ubuntu 18.04 fails on mvn -P deps

2019-07-02 Thread GitBox
zjohn77 opened a new issue #3460: CloudStack install on Ubuntu 18.04 fails on mvn -P deps URL: https://github.com/apache/cloudstack/issues/3460 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ API ~~~ # CLOUDSTACK VERSION ~~~ 4.11.2.0 ~~~

[GitHub] [cloudstack] blueorangutan commented on issue #3457: Fix bug in counting items for search query

2019-07-02 Thread GitBox
blueorangutan commented on issue #3457: Fix bug in counting items for search query URL: https://github.com/apache/cloudstack/pull/3457#issuecomment-507854233 Trillian test result (tid-85) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 30224 sec

[GitHub] [cloudstack] blueorangutan commented on issue #3306: server: reduce execution time while listing project if projects have many resource tags

2019-07-02 Thread GitBox
blueorangutan commented on issue #3306: server: reduce execution time while listing project if projects have many resource tags URL: https://github.com/apache/cloudstack/pull/3306#issuecomment-507879794 Trillian test result (tid-86) Environment: kvm-centos7 (x2), Advanced Networking with

[GitHub] [cloudstack] anuragaw commented on issue #3297: Support copy tags from template/iso image to VM from deploy vm command

2019-07-02 Thread GitBox
anuragaw commented on issue #3297: Support copy tags from template/iso image to VM from deploy vm command URL: https://github.com/apache/cloudstack/pull/3297#issuecomment-507930725 Looked at logs but test failures seem unrelated to the PR. The tests show that in the environment hosts end u

[GitHub] [cloudstack] blueorangutan commented on issue #3297: Support copy tags from template/iso image to VM from deploy vm command

2019-07-02 Thread GitBox
blueorangutan commented on issue #3297: Support copy tags from template/iso image to VM from deploy vm command URL: https://github.com/apache/cloudstack/pull/3297#issuecomment-507930794 @anuragaw I understand these words: "help", "hello", "thanks", "package", "test" Test command usage:

[GitHub] [cloudstack] anuragaw commented on issue #3297: Support copy tags from template/iso image to VM from deploy vm command

2019-07-02 Thread GitBox
anuragaw commented on issue #3297: Support copy tags from template/iso image to VM from deploy vm command URL: https://github.com/apache/cloudstack/pull/3297#issuecomment-507931152 @blueorangutan test smoke/test_host_maintenance.py --

[GitHub] [cloudstack] anuragaw removed a comment on issue #3297: Support copy tags from template/iso image to VM from deploy vm command

2019-07-02 Thread GitBox
anuragaw removed a comment on issue #3297: Support copy tags from template/iso image to VM from deploy vm command URL: https://github.com/apache/cloudstack/pull/3297#issuecomment-507931152 @blueorangutan test smoke/test_host_maintenance.py --

[GitHub] [cloudstack] rhtyd commented on issue #3331: api/server: Add option 'details' to listProjects and listAccounts

2019-07-02 Thread GitBox
rhtyd commented on issue #3331: api/server: Add option 'details' to listProjects and listAccounts URL: https://github.com/apache/cloudstack/pull/3331#issuecomment-507934689 @blueorangutan package This is an automated message

[GitHub] [cloudstack] blueorangutan commented on issue #3331: api/server: Add option 'details' to listProjects and listAccounts

2019-07-02 Thread GitBox
blueorangutan commented on issue #3331: api/server: Add option 'details' to listProjects and listAccounts URL: https://github.com/apache/cloudstack/pull/3331#issuecomment-507934833 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. ---

[GitHub] [cloudstack] blueorangutan commented on issue #3331: api/server: Add option 'details' to listProjects and listAccounts

2019-07-02 Thread GitBox
blueorangutan commented on issue #3331: api/server: Add option 'details' to listProjects and listAccounts URL: https://github.com/apache/cloudstack/pull/3331#issuecomment-507938630 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-75 -

[GitHub] [cloudstack] rhtyd commented on issue #3331: api/server: Add option 'details' to listProjects and listAccounts

2019-07-02 Thread GitBox
rhtyd commented on issue #3331: api/server: Add option 'details' to listProjects and listAccounts URL: https://github.com/apache/cloudstack/pull/3331#issuecomment-507953451 @blueorangutan test This is an automated message fro

[GitHub] [cloudstack] blueorangutan commented on issue #3331: api/server: Add option 'details' to listProjects and listAccounts

2019-07-02 Thread GitBox
blueorangutan commented on issue #3331: api/server: Add option 'details' to listProjects and listAccounts URL: https://github.com/apache/cloudstack/pull/3331#issuecomment-507953537 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -

[GitHub] [cloudstack] rhtyd commented on issue #3297: Support copy tags from template/iso image to VM from deploy vm command

2019-07-02 Thread GitBox
rhtyd commented on issue #3297: Support copy tags from template/iso image to VM from deploy vm command URL: https://github.com/apache/cloudstack/pull/3297#issuecomment-507953629 Yes some of the tests fail intermittently, are not related to this PR. -

[GitHub] [cloudstack] rhtyd merged pull request #3306: server: reduce execution time while listing project if projects have many resource tags

2019-07-02 Thread GitBox
rhtyd merged pull request #3306: server: reduce execution time while listing project if projects have many resource tags URL: https://github.com/apache/cloudstack/pull/3306 This is an automated message from the Apache Git Se

[GitHub] [cloudstack] rhtyd closed issue #3178: GUI project pulldown list slowdown on large number of projects

2019-07-02 Thread GitBox
rhtyd closed issue #3178: GUI project pulldown list slowdown on large number of projects URL: https://github.com/apache/cloudstack/issues/3178 This is an automated message from the Apache Git Service. To respond to the messa

[cloudstack] branch master updated: server: reduce execution time while listing project if projects have many resource tags (#3306)

2019-07-02 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new 452b48e server: reduce execution time while

[GitHub] [cloudstack] rhtyd commented on issue #3178: GUI project pulldown list slowdown on large number of projects

2019-07-02 Thread GitBox
rhtyd commented on issue #3178: GUI project pulldown list slowdown on large number of projects URL: https://github.com/apache/cloudstack/issues/3178#issuecomment-507954207 @ustcweizhou #3306 is merged now, looking forward to any further improvements you've to send around VM listings.

[GitHub] [cloudstack] rhtyd commented on issue #3331: api/server: Add option 'details' to listProjects and listAccounts

2019-07-02 Thread GitBox
rhtyd commented on issue #3331: api/server: Add option 'details' to listProjects and listAccounts URL: https://github.com/apache/cloudstack/pull/3331#issuecomment-507954545 @ustcweizhou can you fix the merge conflict? Thanks.

[GitHub] [cloudstack] rhtyd commented on issue #3152: Refactoring to remove duplicate code.

2019-07-02 Thread GitBox
rhtyd commented on issue #3152: Refactoring to remove duplicate code. URL: https://github.com/apache/cloudstack/pull/3152#issuecomment-507954836 Pinging for review @anuragaw @shwstppr @DaanHoogland and others. This is an autom

[GitHub] [cloudstack] rhtyd commented on issue #3186: [WIP DO NOT MERGE] Add possibility to set KVM MTU size for NIC

2019-07-02 Thread GitBox
rhtyd commented on issue #3186: [WIP DO NOT MERGE] Add possibility to set KVM MTU size for NIC URL: https://github.com/apache/cloudstack/pull/3186#issuecomment-507955633 @svenvogel I'm not sure about OVS issues. Fixed db upgrade path conflict

[GitHub] [cloudstack] rhtyd commented on issue #3248: [WIP DO NOT MERGE] server: offerings for specified domain(s) and zone(s)

2019-07-02 Thread GitBox
rhtyd commented on issue #3248: [WIP DO NOT MERGE] server: offerings for specified domain(s) and zone(s) URL: https://github.com/apache/cloudstack/pull/3248#issuecomment-507955970 @blueorangutan package This is an automated

[GitHub] [cloudstack] blueorangutan commented on issue #3248: [WIP DO NOT MERGE] server: offerings for specified domain(s) and zone(s)

2019-07-02 Thread GitBox
blueorangutan commented on issue #3248: [WIP DO NOT MERGE] server: offerings for specified domain(s) and zone(s) URL: https://github.com/apache/cloudstack/pull/3248#issuecomment-507956270 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. ---

[GitHub] [cloudstack] rhtyd commented on issue #3297: Support copy tags from template/iso image to VM from deploy vm command

2019-07-02 Thread GitBox
rhtyd commented on issue #3297: Support copy tags from template/iso image to VM from deploy vm command URL: https://github.com/apache/cloudstack/pull/3297#issuecomment-507956669 I was under the assumption that tags and details of a template/iso should be copied to a VM. Should this

[GitHub] [cloudstack] rhtyd commented on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV

2019-07-02 Thread GitBox
rhtyd commented on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV URL: https://github.com/apache/cloudstack/pull/3319#issuecomment-507957661 What's the consensus on the PR, is it ready for r

[GitHub] [cloudstack] anuragaw commented on a change in pull request #3152: Refactoring to remove duplicate code.

2019-07-02 Thread GitBox
anuragaw commented on a change in pull request #3152: Refactoring to remove duplicate code. URL: https://github.com/apache/cloudstack/pull/3152#discussion_r299792554 ## File path: api/src/main/java/org/apache/cloudstack/api/command/user/UserCmd.java ## @@ -0,0 +1,29 @@ +/

[GitHub] [cloudstack] rhtyd commented on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV

2019-07-02 Thread GitBox
rhtyd commented on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV URL: https://github.com/apache/cloudstack/pull/3319#issuecomment-507957879 I've added `onhold` label unless we hear from the

[GitHub] [cloudstack] anuragaw edited a comment on issue #3297: Support copy tags from template/iso image to VM from deploy vm command

2019-07-02 Thread GitBox
anuragaw edited a comment on issue #3297: Support copy tags from template/iso image to VM from deploy vm command URL: https://github.com/apache/cloudstack/pull/3297#issuecomment-507958257 @rhtyd In terms of code, does that mean that the flag in deploy VM either defaults to true or we copy

[GitHub] [cloudstack] anuragaw commented on issue #3297: Support copy tags from template/iso image to VM from deploy vm command

2019-07-02 Thread GitBox
anuragaw commented on issue #3297: Support copy tags from template/iso image to VM from deploy vm command URL: https://github.com/apache/cloudstack/pull/3297#issuecomment-507958257 In terms of code, does that mean that the flag in deploy VM either defaults to true or we copy tags irrespect

[GitHub] [cloudstack] rhtyd commented on issue #3336: Sort list of templates, serviceOfferings, diskOfferings etc in the deploy VM wizard

2019-07-02 Thread GitBox
rhtyd commented on issue #3336: Sort list of templates, serviceOfferings, diskOfferings etc in the deploy VM wizard URL: https://github.com/apache/cloudstack/pull/3336#issuecomment-507959386 Ping @anuragaw @shwstppr can you review and test this. Thanks.

[GitHub] [cloudstack] rhtyd commented on issue #3371: [WIP DO NOT MERGE] Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh

2019-07-02 Thread GitBox
rhtyd commented on issue #3371: [WIP DO NOT MERGE] Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-507960205 @svenvogel looks like the refactorings add more regressions. Can you mayb

[GitHub] [cloudstack] ustcweizhou commented on issue #3297: Support copy tags from template/iso image to VM from deploy vm command

2019-07-02 Thread GitBox
ustcweizhou commented on issue #3297: Support copy tags from template/iso image to VM from deploy vm command URL: https://github.com/apache/cloudstack/pull/3297#issuecomment-507960188 code LGTM it is good that the default value is false. -

[GitHub] [cloudstack] rhtyd commented on issue #3378: project id added in test

2019-07-02 Thread GitBox
rhtyd commented on issue #3378: project id added in test URL: https://github.com/apache/cloudstack/pull/3378#issuecomment-507960434 Ping @DaanHoogland This is an automated message from the Apache Git Service. To respond to th

[GitHub] [cloudstack] rhtyd commented on issue #3374: KVM: Enhancements for direct download feature

2019-07-02 Thread GitBox
rhtyd commented on issue #3374: KVM: Enhancements for direct download feature URL: https://github.com/apache/cloudstack/pull/3374#issuecomment-507960633 Ping @nvazquez can you see https://github.com/apache/cloudstack/issues/3047 --

[GitHub] [cloudstack] rhtyd commented on issue #3393: Fix removing SRX port forwarding rules, improve add/remove logic

2019-07-02 Thread GitBox
rhtyd commented on issue #3393: Fix removing SRX port forwarding rules, improve add/remove logic URL: https://github.com/apache/cloudstack/pull/3393#issuecomment-507960853 On hold until @richardlawley confirm changes and testing.

[GitHub] [cloudstack] rhtyd commented on issue #3410: Add Datera storage plugin

2019-07-02 Thread GitBox
rhtyd commented on issue #3410: Add Datera storage plugin URL: https://github.com/apache/cloudstack/pull/3410#issuecomment-507961038 Ping @jcsdatera @swill - if you'd like this to make into 4.13.0.0 please work with me in getting the build/run errors fixed. Thanks.

[GitHub] [cloudstack] rhtyd commented on issue #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure

2019-07-02 Thread GitBox
rhtyd commented on issue #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure URL: https://github.com/apache/cloudstack/pull/3425#issuecomment-507961195 @blueorangutan test This is an automated messa

[GitHub] [cloudstack] blueorangutan commented on issue #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure

2019-07-02 Thread GitBox
blueorangutan commented on issue #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure URL: https://github.com/apache/cloudstack/pull/3425#issuecomment-507961372 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests ---

[GitHub] [cloudstack] rhtyd commented on a change in pull request #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure

2019-07-02 Thread GitBox
rhtyd commented on a change in pull request #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure URL: https://github.com/apache/cloudstack/pull/3425#discussion_r299796886 ## File path: api/src/main/java/com/cloud/resource/ResourceState.java ## @@

[GitHub] [cloudstack] rhtyd commented on a change in pull request #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure

2019-07-02 Thread GitBox
rhtyd commented on a change in pull request #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure URL: https://github.com/apache/cloudstack/pull/3425#discussion_r299797096 ## File path: server/src/main/java/com/cloud/ha/HighAvailabilityManagerImpl.java

  1   2   >