[GitHub] [cloudstack] matheusdaluz opened a new pull request #3389: when destroy the vms, delete the tags from virtual router

2019-06-08 Thread GitBox
matheusdaluz opened a new pull request #3389: when destroy the vms, delete the tags from virtual router URL: https://github.com/apache/cloudstack/pull/3389 ## Description When tags are placed in the vms and after we delerate them, they remain in the virtual router generating problems fo

[GitHub] [cloudstack] rcicm commented on issue #3389: when destroy the vms, delete the tags from virtual router

2019-06-08 Thread GitBox
rcicm commented on issue #3389: when destroy the vms, delete the tags from virtual router URL: https://github.com/apache/cloudstack/pull/3389#issuecomment-500137714 +1 This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] ustcweizhou commented on issue #3389: when destroy the vms, delete the tags from virtual router

2019-06-08 Thread GitBox
ustcweizhou commented on issue #3389: when destroy the vms, delete the tags from virtual router URL: https://github.com/apache/cloudstack/pull/3389#issuecomment-500151880 @matheusdaluz Could you tell us how to verify it ? When I add/delete a tag to a vm, I did not see any change in t

[GitHub] [cloudstack] nvazquez commented on issue #3350: Retrieve diagnostics data rebase

2019-06-08 Thread GitBox
nvazquez commented on issue #3350: Retrieve diagnostics data rebase URL: https://github.com/apache/cloudstack/pull/3350#issuecomment-500157175 @rhtyd the current implementation is using cmd-answer pattern to indicate which files needs to be copied, but using SCP to copy the files using this

[GitHub] [cloudstack] matheusdaluz commented on issue #3389: when destroy the vms, delete the tags from virtual router

2019-06-08 Thread GitBox
matheusdaluz commented on issue #3389: when destroy the vms, delete the tags from virtual router URL: https://github.com/apache/cloudstack/pull/3389#issuecomment-500158483 You should add a tag and after that destroy the vm. T

[GitHub] [cloudstack] matheusdaluz edited a comment on issue #3389: when destroy the vms, delete the tags from virtual router

2019-06-08 Thread GitBox
matheusdaluz edited a comment on issue #3389: when destroy the vms, delete the tags from virtual router URL: https://github.com/apache/cloudstack/pull/3389#issuecomment-500158483 @ustcweizhou You should add a tag and after that destroy the vm. -

[GitHub] [cloudstack] matheusdaluz edited a comment on issue #3389: when destroy the vms, delete the tags from virtual router

2019-06-08 Thread GitBox
matheusdaluz edited a comment on issue #3389: when destroy the vms, delete the tags from virtual router URL: https://github.com/apache/cloudstack/pull/3389#issuecomment-500158483 @ustcweizhou First you ought to create a network and after that attach the vm, next step is create tags to

[GitHub] [cloudstack] matheusdaluz edited a comment on issue #3389: when destroy the vms, delete the tags from virtual router

2019-06-08 Thread GitBox
matheusdaluz edited a comment on issue #3389: when destroy the vms, delete the tags from virtual router URL: https://github.com/apache/cloudstack/pull/3389#issuecomment-500158483 @ustcweizhou First you ought to create a network and after that attach the vm, next step is create tags to

[GitHub] [cloudstack] svenvogel commented on issue #3389: when destroy the vms, delete the tags from virtual router

2019-06-08 Thread GitBox
svenvogel commented on issue #3389: when destroy the vms, delete the tags from virtual router URL: https://github.com/apache/cloudstack/pull/3389#issuecomment-500161550 @matheusdaluz is it for VPC or virtual router? This is a

[GitHub] [cloudstack] ustcweizhou commented on issue #3389: when destroy the vms, delete the tags from virtual router

2019-06-08 Thread GitBox
ustcweizhou commented on issue #3389: when destroy the vms, delete the tags from virtual router URL: https://github.com/apache/cloudstack/pull/3389#issuecomment-500161610 > @ustcweizhou > First you ought to create a network and after that attach the vm, next step is create tags to vm, a

[GitHub] [cloudstack] matheusdaluz commented on issue #3389: when destroy the vms, delete the tags from virtual router

2019-06-08 Thread GitBox
matheusdaluz commented on issue #3389: when destroy the vms, delete the tags from virtual router URL: https://github.com/apache/cloudstack/pull/3389#issuecomment-500161668 @svenvogel virtual router. This is an automated messa

[GitHub] [cloudstack] svenvogel commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh

2019-06-08 Thread GitBox
svenvogel commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-500161775 @ustcweizhou what do you think? for me take the option back as dummy " // not used for

[GitHub] [cloudstack] rafaelweingartner commented on a change in pull request #3389: when destroy the vms, delete the tags from virtual router

2019-06-08 Thread GitBox
rafaelweingartner commented on a change in pull request #3389: when destroy the vms, delete the tags from virtual router URL: https://github.com/apache/cloudstack/pull/3389#discussion_r291819167 ## File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java ## @@ -

[GitHub] [cloudstack] matheusdaluz commented on a change in pull request #3389: when destroy the vms, delete the tags from virtual router

2019-06-08 Thread GitBox
matheusdaluz commented on a change in pull request #3389: when destroy the vms, delete the tags from virtual router URL: https://github.com/apache/cloudstack/pull/3389#discussion_r291819223 ## File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java ## @@ -4601,

[GitHub] [cloudstack] rafaelweingartner commented on a change in pull request #3389: when destroy the vms, delete the tags from virtual router

2019-06-08 Thread GitBox
rafaelweingartner commented on a change in pull request #3389: when destroy the vms, delete the tags from virtual router URL: https://github.com/apache/cloudstack/pull/3389#discussion_r291819297 ## File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java ## @@ -

[GitHub] [cloudstack] matheusdaluz commented on issue #3389: when destroy the vms, delete the tags from virtual router

2019-06-08 Thread GitBox
matheusdaluz commented on issue #3389: when destroy the vms, delete the tags from virtual router URL: https://github.com/apache/cloudstack/pull/3389#issuecomment-500162256 > @matheusdaluz thanks. could you tell me how to see the tags in the virtual router ? in the folder /var/www/ht

[GitHub] [cloudstack] ustcweizhou commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh

2019-06-08 Thread GitBox
ustcweizhou commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-500162259 @svenvogel it looks the issue is not related to "-s", but one of "-n", "-t" and "-f"

[GitHub] [cloudstack] matheusdaluz commented on a change in pull request #3389: when destroy the vms, delete the tags from virtual router

2019-06-08 Thread GitBox
matheusdaluz commented on a change in pull request #3389: when destroy the vms, delete the tags from virtual router URL: https://github.com/apache/cloudstack/pull/3389#discussion_r291819399 ## File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java ## @@ -4601,

[GitHub] [cloudstack] matheusdaluz commented on a change in pull request #3389: when destroy the vms, delete the tags from virtual router

2019-06-08 Thread GitBox
matheusdaluz commented on a change in pull request #3389: when destroy the vms, delete the tags from virtual router URL: https://github.com/apache/cloudstack/pull/3389#discussion_r291823471 ## File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java ## @@ -4601,