[GitHub] [cloudstack] svenvogel commented on issue #3282: Fix slow vm creation when large sf snapshot count

2019-05-08 Thread GitBox
svenvogel commented on issue #3282: Fix slow vm creation when large sf snapshot count URL: https://github.com/apache/cloudstack/pull/3282#issuecomment-490441670 @rhtyd can you merge it? This is an automated message from the A

[GitHub] [cloudstack] anuragaw edited a comment on issue #2823: api: project: tag: User not allowed to tag project created by him

2019-05-08 Thread GitBox
anuragaw edited a comment on issue #2823: api: project: tag: User not allowed to tag project created by him URL: https://github.com/apache/cloudstack/issues/2823#issuecomment-488600704 Permission is denied because when tagging we attempt to check for permissions - which is as follows -

[GitHub] [cloudstack] DaanHoogland commented on issue #3318: Fixed: User not allowed to tag project created by him

2019-05-08 Thread GitBox
DaanHoogland commented on issue #3318: Fixed: User not allowed to tag project created by him URL: https://github.com/apache/cloudstack/pull/3318#issuecomment-490471584 @Spaceman1984 you have a conflict which seems very strange as the location of your change is in exactly the line that gith

[GitHub] [cloudstack] anuragaw commented on issue #3318: Fixed: User not allowed to tag project created by him

2019-05-08 Thread GitBox
anuragaw commented on issue #3318: Fixed: User not allowed to tag project created by him URL: https://github.com/apache/cloudstack/pull/3318#issuecomment-490531226 @Spaceman1984 - you seem to have created a duplicate file TaggedResourceManagerImpl somehow. Could you remove the newly added

[GitHub] [cloudstack] anuragaw commented on a change in pull request #3318: Fixed: User not allowed to tag project created by him

2019-05-08 Thread GitBox
anuragaw commented on a change in pull request #3318: Fixed: User not allowed to tag project created by him URL: https://github.com/apache/cloudstack/pull/3318#discussion_r282046607 ## File path: server/src/com/cloud/tags/TaggedResourceManagerImpl.java ## @@ -215,6 +215,10

[GitHub] [cloudstack] anuragaw removed a comment on issue #3318: Fixed: User not allowed to tag project created by him

2019-05-08 Thread GitBox
anuragaw removed a comment on issue #3318: Fixed: User not allowed to tag project created by him URL: https://github.com/apache/cloudstack/pull/3318#issuecomment-490531226 @Spaceman1984 - you seem to have created a duplicate file TaggedResourceManagerImpl somehow. Could you remove the newl

[GitHub] [cloudstack] skattoju4 opened a new pull request #3319: Use virtio for platform emulator strings starting with Windows*

2019-05-08 Thread GitBox
skattoju4 opened a new pull request #3319: Use virtio for platform emulator strings starting with Windows* URL: https://github.com/apache/cloudstack/pull/3319 ## Description This change addresses #3089. There was an issue where disks were being added with bus type ide when creating wind

[GitHub] [cloudstack] pbankonier commented on issue #3294: Set default service offering over api and ui

2019-05-08 Thread GitBox
pbankonier commented on issue #3294: Set default service offering over api and ui URL: https://github.com/apache/cloudstack/pull/3294#issuecomment-490553133 @ustcweizhou @svenvogel @DaanHoogland The motivation behind this was to make it possible to set a default system offering over the ui

[GitHub] [cloudstack] svenvogel commented on issue #3319: Use virtio for platform emulator strings starting with Windows*

2019-05-08 Thread GitBox
svenvogel commented on issue #3319: Use virtio for platform emulator strings starting with Windows* URL: https://github.com/apache/cloudstack/pull/3319#issuecomment-490583074 @skattoju3 thanks we will test it and come back tomorrow.

[GitHub] [cloudstack] ustcweizhou commented on issue #3319: Use virtio for platform emulator strings starting with Windows*

2019-05-08 Thread GitBox
ustcweizhou commented on issue #3319: Use virtio for platform emulator strings starting with Windows* URL: https://github.com/apache/cloudstack/pull/3319#issuecomment-490663274 @skattoju4 for windows vm, we need to install virtio drivers. for now, we can register template without vir

[GitHub] [cloudstack] svenvogel commented on issue #3319: Use virtio for platform emulator strings starting with Windows*

2019-05-08 Thread GitBox
svenvogel commented on issue #3319: Use virtio for platform emulator strings starting with Windows* URL: https://github.com/apache/cloudstack/pull/3319#issuecomment-490713694 @ustcweizhou Maybe we talk past each other. It should only set the first disk to ide device and all other to